summaryrefslogtreecommitdiff
path: root/comphelper/qa
AgeCommit message (Collapse)Author
2016-02-24convert HighlighterLanguage to scoped enumNoel Grandin
Change-Id: Ibf0871601e52ea4fa49e9622176431943c55abdd
2016-02-24convert TokenTypes to scoped enumNoel Grandin
Change-Id: I17c0a616dd6cf48a22896b6cd6b0df157d1f9a9f
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-25cleanup OInterfaceContainer2 unit testsNoel Grandin
remove unused code and actually hook up the tests in testifcontainer.cxx Change-Id: I9694ebe44f1e8eed3d72373d62424345f899c8e6
2016-01-25loplugin:overrideStephan Bergmann
Change-Id: I9a67ed46a67be521d00ed2368b4820737dcb15e5
2016-01-25loplugin:cstylecastStephan Bergmann
Change-Id: Ie2aeedac1b3fd90d6302be6e5917e99a782d76c7
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-07Fix typosAndrea Gelmini
Change-Id: I90b04b8eda6fc3d530c9db72052720cbe9de0343 Reviewed-on: https://gerrit.libreoffice.org/21197 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-20Seems more natural to pass a homogenous list by initializer_listStephan Bergmann
...than by template parameter pack (even if that requires using ServiceDecl*, as initializer_list cannot take reference types) Change-Id: Ia986201b52d8daedfe925f132ebc79bc2c0ba378
2015-11-05java: make inner classes static where possibleNoel Grandin
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-10-23Remove obsolete version map filesStephan Bergmann
Change-Id: Ic179264fe306bb2bca9797f10e26c0224fb1dd00
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-06tdf#94228 comphelper: replace BOOST_PPDaniel Robertson
Replace BOOST_PP macros in comphelper with variadic templates. The client interface should not change. However, there are a few side effects due to this change. The most important being 1) There is no longer a maximum number of service declarations limmited by default at 12 for unwrapArgs and component_getFactoryHelper. 2) component_getFactoryHelper now terminates early as soon as pRet is not a null pointer. Change-Id: I016fd208d0e80f91d8669fff29d58b6189e946d3 Reviewed-on: https://gerrit.libreoffice.org/18891 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-08-21Remove demonstrated-useless comphelper::compareStephan Bergmann
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21Demonstrate comphelper::compare is uselessStephan Bergmann
Change-Id: I03de2d02f4814bf3425f7278ec91ed1e3b4ce1a0
2015-07-20tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, for comphelper. This also includes extra changes in other modules required accordingly. Change-Id: Id1537f46f1c90f760a0d8987a6dafa0e1da03b8f Reviewed-on: https://gerrit.libreoffice.org/16929 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-01-02Remove unnecessary comphelper::string::getTokenStephan Bergmann
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: remove some comment noiseNoel Grandin
Change-Id: I4d15a0e606f468346bc5d2f43af2e14bcc758e13 Reviewed-on: https://gerrit.libreoffice.org/13405 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-14Some more compareVersionStrings() testsTor Lillqvist
Change-Id: I5b9dc45352afd63dae4c3952d9647e6e3ec98ef4
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-11Add a function to compare version number stringsTor Lillqvist
Change-Id: I88d3d9040f70e84752ade19001a699f60e9e7636
2014-08-20java: remove modifiers implied by the contextNoel Grandin
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20java: remove unnecessary return statementsNoel Grandin
found by PMD Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
2014-08-19java: use 'Short.valueOf' instead of 'new Short'Noel Grandin
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19java: use 'Long.valueOf' instead of 'new Long'Noel Grandin
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-05java: remove commented out codeNoel Grandin
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-05-11fix-includes.pl: comphelperThomas Arnhold
Change-Id: I0b4cd8320881b2b1f7984c86e58915217bcd0d5f
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-02-27Remove visual noise from comphelperAlexander Wilms
Change-Id: I7e5512b43240beee05404cff9d49a87d0217ea89 Reviewed-on: https://gerrit.libreoffice.org/8242 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2013-10-28Disambiguate CPPUNIT_ASSERT_EQUAL argumentsStephan Bergmann
Change-Id: Ib32d59522f33bcd2608401b4f3d3529d9dee5642
2013-10-28Fold SyntaxHighlighter::initialize into ctorStephan Bergmann
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused. Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28Remove unused SimpleTokenizer_Impl::nLine/nColStephan Bergmann
...which are never read; remove thereby unused parameters from functions. Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-28Correctly fix "Terminating NUL" fixStephan Bergmann
1cbe2313edda8a04f0fe233b4a29ef4e2485f557 "Terminating NUL at end of its buffer is not considered part of OUString" was a thinko that cut the last character off the last reported HighlightPortion on a line. Change-Id: Idbe74676e85749cd93854293c6f49c7581414562
2013-10-28Demonstrate that empty comments are handled just fineStephan Bergmann
...see preceding revert of a79cb836b951eb2492e43aadd2ee672b9b67b914 "COMPHELPER: Allow empty comments in SyntaxHighlight." Change-Id: Ib0a8c46c19dd7f0697b95a1c28398073a1183281
2013-10-28Revert "COMPHELPER: Allow empty comments in SyntaxHighlight"Stephan Bergmann
This reverts commit a79cb836b951eb2492e43aadd2ee672b9b67b914, which broke --with-help builds again, as strLine.copy(i->nBegin, i->nEnd-i->nBegin) in BasicCodeTagger::tagParagraph (helpcompiler/source/BasCodeTagger.cxx) depends on the invariant that a HighlightPortion does not extend past the source string. Also, I see no reason for that change, as empty comments are handled just fine already as demonstrated by the following commit... Change-Id: I384bae9c4cf6a38d0a0a2832fa15bde82126cace
2013-10-27COMPHELPER: Allow empty comments in SyntaxHighlightArnaud Versini
Change-Id: I0f3d5673e28e34ed3921c930aca48f3d7574b064 Reviewed-on: https://gerrit.libreoffice.org/6450 Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org> Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2013-10-23Improve testStephan Bergmann
Change-Id: I54e939b7bca883f1c92c957c66ebf47259c92a46
2013-10-23Fix and enable CppunitTest_comphelper_syntaxhighlight_testStephan Bergmann
Change-Id: I2b2aa5f5afdbf58ec3ac2447db370bcb7d1778c0
2013-10-23add inital test for syntaxhighlighterMarkus Mohrhard
Test is partly disabled as we still generate invalid tokens Change-Id: I1a9b03b9bbe2ed7087c6ab7b6d0823ac1d058ba7
2013-05-06Java cleanup, remove unnecessary @SuppressWarnings annotationsNoel Grandin
Change-Id: Ib5df091fc4a6233b526c44ae42dbdbacb0bef7c6
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-01-31RTL_CONSTASCII_(U)STRINGPARAM removed in comphelperChr. Rossmanith
Change-Id: Ib068c06956bc9f04bb7c468375aacd2e6e9db77d
2012-11-30c++ API: use css alias in generated headers, adds global css declThorsten Behrens
This changes all generated API headers (.hpp and .hdl) to use a namespace alias 'css' instead of the pointlessly long com::sun::star Makes the change in cppumaker & associated tools, adds a global namespace alias definition in sal/types.h, and removes a kiloton of local, now pointless-to-harmful versions of that alias from all over the code. Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-10-01fdo#51304: Remove the author of some java source filesAnurag Jain
This patch remove some '@author' for Java souce files, and removes some commented code founded when removing the '@author'. Change-Id: Ic4fcd028a9cdbd85c693d93bcd48e41f36386d22