summaryrefslogtreecommitdiff
path: root/comphelper
AgeCommit message (Collapse)Author
2016-11-01Omit the default comparatorTakeshi Abe
Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0 Reviewed-on: https://gerrit.libreoffice.org/30319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-26coverity#1374269 Uncaught exceptionCaolán McNamara
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-23Fix typosAndrea Gelmini
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-22Typos in commentsJulien Nabet
Change-Id: I6450d3862a67c2a9275a569a8ee3c29262124409 Reviewed-on: https://gerrit.libreoffice.org/30162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-10-21profilesafe: Make sure no recursive saving happensArmin Le Grand
Change-Id: Idd57a948fcaaf23614ca1a92051a50b86e4bb0c5 Reviewed-on: https://gerrit.libreoffice.org/30145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-21profilesafe: Added more specific optionsArmin Le Grand
For Extensions there is the possibility to not only decide enable/disable state for User ones, but also to deinstall user or all extensions, added these options to the dialog and the functionality. Also unified customization name schema to have just one source of strings to avoid errors in the future. Small fix in tryPop_extensionInfo Change-Id: I39acbe9a052ffd4cb78b496f24e5b583136c565a Reviewed-on: https://gerrit.libreoffice.org/30100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-21loplugin:expandablemethodds in include/basic..comphelperNoel Grandin
Change-Id: I1aa9c12e8839325a9fd98530abc89a3d586ff62e Reviewed-on: https://gerrit.libreoffice.org/30120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21coverity#1374089: Unchecked return valueThorsten Behrens
Change-Id: Ied4e80db512000471b5aa215beeef1277121fe12
2016-10-20Blind fix for "error: chosen constructor is explicit in copy-initialization"Stephan Bergmann
...on linux_clang_dbgutil_64 build Change-Id: I00022749ce12df459ce22333593daa2eb6503fd7
2016-10-20Fix odd compilation error with Clang 3.8.0Tor Lillqvist
Fix "default initialization of an object of const type 'const ExtensionInfoEntryVector' (aka 'const vector<(anonymous namespace)::ExtensionInfoEntry>') without a user-provided default constructor". Change-Id: I97013ed4660459a3f4c1b8b5b7cc302ba3ff914d
2016-10-19profilesafe: added xml read/modify to restoreArmin Le Grand
To be able to restore the last saved state of enabled/disabled extensions it is necessary in SafeMode to get and set that states without XExtensionManager, so the configuration xml files have to be accessed. Added this change Change-Id: I00fe5795598427e7c08be0d3dd54bef68d038e24 Reviewed-on: https://gerrit.libreoffice.org/30062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-19coverity#1373663 Untrusted loop boundCaolán McNamara
Change-Id: Iabad14f8fc35656015b98693dd327a41aeaf63c7
2016-10-19profilesafe: Deeper integration with SafeModeArmin Le Grand
Added deeper integration by saving at SaveMode content of user dir completely to a user/SafeMode dir, including the whole stack of pack files. Repair happens in that safe directory, so that the user dir is resetted to default when re-started in SafeMode. All changes (including complete deletion) are played back to the user config at first restart with disabled SafeMode Change-Id: I5114c7d5d04582be62090707bc9b97afa55fc1f1 Reviewed-on: https://gerrit.libreoffice.org/30003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-19replace <<= with assign for <<= with rhs AnyJochen Nitschke
queryAggregation and queryInterface return Any Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a Reviewed-on: https://gerrit.libreoffice.org/29912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-16clang-cl loplugin: comphelperStephan Bergmann
Change-Id: Icde27eeeb21e9049630028e81af10edc1ba8ae04 Reviewed-on: https://gerrit.libreoffice.org/29876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14profilesafe: Adapted to UIArmin Le Grand
Adaptions to UI, added more modes what the user can do in SafeMode. Adapted locations to write pack information and added places where to enter SafeMode. Implemented basically all five possible user choices Change-Id: Ic5324a8f77ab434309e840949c3803e65a75c538 Reviewed-on: https://gerrit.libreoffice.org/29785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-14coverity#1373663 consider backupfilehelper byte twiddling as untaintedCaolán McNamara
Change-Id: I13f7c3df20b3c9f81a9519b4bb84f556a8f4db7e
2016-10-13profilesafe: extended to three modesArmin Le Grand
Saving configuration is now extended to three basic modes, from just saving registrymodifiications to adding user-defined config stuff to saving all information in the user profile, additionally configuration information for Extensions is saved. Added configuration entries for this and tested saving/restoring. Change-Id: I79b09c37617803bf656826f76a7e3db79cda49ac Reviewed-on: https://gerrit.libreoffice.org/29770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-12profilesafe: Multiple adaptionsArmin Le Grand
Added own directory in User config to where the saved content is written and taken from, adapted to also handle ExtensionConfiguration, changed point for creating backups of configuration to doShutdown, create no configuration when a restart is triggered (untested configuration) Change-Id: Id7a96195b765842c31cacf81cc08d2965a205281 Reviewed-on: https://gerrit.libreoffice.org/29729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-12Missing includeStephan Bergmann
Change-Id: I5abde663d639278bcc8374da6b5772b58a9b7a75
2016-10-11profilesafe: Add values for SecureUserConfigfeature/profilesafemodeArmin Le Grand
Added default values for SecureUserConfig values to soffice.ini/rc which enable the mechanism, enable by default and set a maximum of three backups file in packed form. Added more handy flag for easy decision to add compressed/uncompressed. Change-Id: I5a624c09fec4e4278314e13fc5f693ac085d5e61
2016-10-11profilesafe: Added zip deflate/inflateArmin Le Grand
Stack of files can now deflate/inflate using zip library, unfortunately have to use direct due to Deflater/Inflater not being available, had to add linking against zip.lib. Checked compressed and uncompressed creation/usage of backup stack. Also warnings and clang errors corrected. Change-Id: Ieb059baeea323bb48ec5b1cf6b8df09da97cfb93
2016-10-11profilesafe: Collect copies in single *.pack fileArmin Le Grand
Enhanced helper classes for BackupFileHelper to allow writing a stack of rescued last valid configuration files to a single file package. Added configuration values for enabling this and defining the number of entries, added max entry limitation. Using FileSize and CRC32 now to dectect if config file did change. To make this work I added sorting to writing the configuration so that with no change the same configuration file is written. Use std::vector for better mem performance for sorting, defined static const for buffer size of manipulation, prepare inflate/deflate usages. Fixes to setPos, warnings Change-Id: Ib286e2a3f25b0085a1e3ae4f50c9ff1ff3a5dcf5
2016-10-11profilesafe: Enhancements to BackupFileHelperArmin Le Grand
Added helper class to allow easy creation/deployment of backups of a file. It works like a 'stack' of backups, supports easy add/remove/delete of last entry (LIFO). Added some work top allow opening dialogs in DeInit under linux. Change-Id: Idacec97ec2f097af9bd22a8a67b410c7677d17f1
2016-10-11profilesafe: Initial creation of BackupFileHelperArmin Le Grand
Added helper class to allow easy creation/deployment of backups of a file (here: registrymodifications). It works like a 'stack' of backups, supports easy push/pop of backed-up versions. Change-Id: Ie19e1209534f23a3dbd6106a5ca13b24b8fefe4d
2016-10-04comphelper: move setTiledPainting() from SfxViewShellMiklos Vajna
And make it a static one. The primary point of that member function is to prevent invalidations during paint, and since multiple views are allowed, it wasn't extended to filter out invalidations from all views, not just from the current one. (Same goes for other callback types.) Change-Id: I23e6b2c2ff94227f2b72c481148b2d8279ae2905
2016-09-29LOK: conditionally include part number in invalidation payloadMiklos Vajna
Since desktop/ code queues, compresses and only emits callbacks on idle, it's possible that two invalidations are in the queue, and there was a setPart() call between them. In this case it's impossible to tell what part the invalidation was sent for. Fix this by conditionally including the part number in the invalidation payload. It's off by default, a new feature flag is added to request this behavior. gtktiledviewer enables this feature flag by default, though just to show the part number in the debug output. Android doesn't enable it. Change-Id: I73e6def848c0eb61d64e71026002c7a0e750aab4
2016-09-14loplugin:constantparam in chart2..connectivityNoel Grandin
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:dllprivateStephan Bergmann
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-01coverity#1372386 Uncaught exceptionCaolán McNamara
Change-Id: Ic1fd5486e6b26718086d2f062459f11c00f244d2
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-29Adapt loplugin:stringconstant to improved OUStringLiteral1Stephan Bergmann
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-29cid#1371187 Missing move assignment operatorNoel Grandin
Change-Id: Ib0b51a029adcb0b703aa975b6c5fc02a8b21ed63
2016-08-22tdf88205 Adapt uses of css::uno::Sequence to use initializer_list ctorRosen
Change-Id: I7a07552fb7f7c6dc66178be5db249007da49eb40 Reviewed-on: https://gerrit.libreoffice.org/28280 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-18coverity#1371448 Uninitialized pointer fieldCaolán McNamara
Change-Id: Iedfa017dffa4681a9d698108b5dbc7388637c611
2016-08-16new loplugin to check for static OUStringsNoel Grandin
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-10comphelper: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: If042462d8f250dbe2e1be278b7524dab243b08e8 Reviewed-on: https://gerrit.libreoffice.org/28012 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-05Fix certificate validation interactionGiuseppe Castagno
This enables the certificate validation when StillReadWriteInteraction::StillReadWriteInteraction interaction handler is used. Certificate validation is needed for Web/WebDAV files. Change-Id: I38cba9fc8b586953477d7df02acfcc8347603220 Reviewed-on: https://gerrit.libreoffice.org/27914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-01comphelper: fix MSVC 2015 build by removing pointless catchlbenes
In C++11 the destructors are implicitly noexcept. Change-Id: I37e78e39bcc19dfbc81a781a5b353e49f09ae942 Reviewed-on: https://gerrit.libreoffice.org/27708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01tdf#100726: Improve readability of OUString concatenationnadith
this bug fixed in the modules between canvas - cppu Change-Id: I2022b022897dafde20251352376e3facdb9b8d75 Reviewed-on: https://gerrit.libreoffice.org/27663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29comphelper,vcl: let DeInitVCL() join some AsyncEventNotifier threadsMichael Stahl
comphelper::AsyncEventNotifier is an amazing class that dispatches events in separate threads, no doubt implemented during times of exuberant optimism about the tractability of shared-state multi-threading. Unfortunately the authors forgot to think about how all those awesome threads will be joined, so if they are somehow blocked, then it may well happen that the events are dispatched when the main thread is already in DeInitVCL, and the objects required for the dispatching already smell somewhat funny. This happens quite reproducibly when changing dbaccess' ModelMethodGuard to lock the SolarMutex too, then CppunitTest_dbaccess_RowSetClones crashes in DeInitVCL() because one AsyncEventNotifier thread was blocked until then by SolarMutexGuard, and this test never Yields once its document is loaded. Try to fix this by joining the "DocumentEventNotifier" threads from DeInitVCL() itself. Since there's no rtl::WeakReference to go with rtl::Reference, refactor the AsyncEventNotifier and create a new AsyncEventNotifierAutoJoin that has to be used with std::shared_ptr and std::weak_ptr. Change-Id: I50a0749795acb04b0776e543f7125767b697ea35 Reviewed-on: https://gerrit.libreoffice.org/27581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-07-27change from a 2 min dbgutil failure to a 3 minCaolán McNamara
to try and align with the crashtesting timeout Change-Id: Ife3a4a3d63bbb9d9d5b612675e3728900262bf6c
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-18fix buildCaolán McNamara
Change-Id: I90d6826e4544fd39120982f80d41e237a5edbab6
2016-07-18-Werror=enum-compareNoel Grandin
Change-Id: I6bb2c9bcefd9dbb0efd262b1462625a157d11e6f
2016-07-18remove some now unnecessary debug traceNoel Grandin
Change-Id: I15fef941c5a9c9d7627ca22029a95c8e6928ee20
2016-07-18add tagging to ThreadTasks so we don't need more one poolNoel Grandin
If more than one place in the code submits tasks to the shared pool, then waitTillDone() becomes unreliable. Add a tagging mechanism, so different callsites can wait on different sets of tasks. Also try to protect our worker threads against exceptions from the thread tasks code. Change-Id: Idde664ab50008d31a2dd73910bb22f50e62ae22f Reviewed-on: https://gerrit.libreoffice.org/27042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-09Implement XServiceInfo for com.sun.star.comp.MemoryStreamMatúš Kukan
Change-Id: Ie5499d2ac4aac67dc73fdc58958443b8060c4139
generated by cgit (git 2.34.1) at 2024-07-18 13:21:05 +0000