summaryrefslogtreecommitdiff
path: root/comphelper
AgeCommit message (Collapse)Author
2013-11-20Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"Noel Grandin
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295. I mistakenly converted OUString::equalsL calls to OUString::startsWith calls.
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL callsNoel Grandin
Convert code like: if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aByteStr.startsWith("rem")) Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14Move MediaDescriptor from comphelper to unotoolsStephan Bergmann
...so it will be able to use SvtSecurityOptions internally. Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14Make requestAndVerifyDocPassword var with MediaDescriptor a mem fn of latterStephan Bergmann
Change-Id: I645d554c7ce592d93ca0696fa7e6068ce40c9058
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: I972a0b6e73c1302cdd27b6ed88d0d1a3cb598816
2013-11-07fdo#63020: Replace ::comphelper::stl_begin()...Marcos Paulo de Souza
And use some templates inside include/com/sun/star/uno/Sequence.hxx Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47 Reviewed-on: https://gerrit.libreoffice.org/6599 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-28Disambiguate CPPUNIT_ASSERT_EQUAL argumentsStephan Bergmann
Change-Id: Ib32d59522f33bcd2608401b4f3d3529d9dee5642
2013-10-28comphelper: use boost_headers in unit testMichael Stahl
Change-Id: I3858dd3d176757743a39d6a8d9c5328dd5ff34df
2013-10-28Some clean-upStephan Bergmann
Change-Id: I8ef80b7ae952428a62cc1cea8b03219b77a83e99
2013-10-28Remove unnecessary SyntaxHighlighter::Tokenizer statefulnessStephan Bergmann
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it. Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
2013-10-28Fold SyntaxHighlighter::initialize into ctorStephan Bergmann
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused. Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28Move implementation details to syntaxhighlight.cxxStephan Bergmann
(and clean up a little) Change-Id: I6e660708d8ca1509b89b306cd428dc38c8b03f2c
2013-10-28Remove unused SimpleTokenizer_Impl::nLine/nColStephan Bergmann
...which are never read; remove thereby unused parameters from functions. Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-28Correctly fix "Terminating NUL" fixStephan Bergmann
1cbe2313edda8a04f0fe233b4a29ef4e2485f557 "Terminating NUL at end of its buffer is not considered part of OUString" was a thinko that cut the last character off the last reported HighlightPortion on a line. Change-Id: Idbe74676e85749cd93854293c6f49c7581414562
2013-10-28Demonstrate that empty comments are handled just fineStephan Bergmann
...see preceding revert of a79cb836b951eb2492e43aadd2ee672b9b67b914 "COMPHELPER: Allow empty comments in SyntaxHighlight." Change-Id: Ib0a8c46c19dd7f0697b95a1c28398073a1183281
2013-10-28Revert "COMPHELPER: Allow empty comments in SyntaxHighlight"Stephan Bergmann
This reverts commit a79cb836b951eb2492e43aadd2ee672b9b67b914, which broke --with-help builds again, as strLine.copy(i->nBegin, i->nEnd-i->nBegin) in BasicCodeTagger::tagParagraph (helpcompiler/source/BasCodeTagger.cxx) depends on the invariant that a HighlightPortion does not extend past the source string. Also, I see no reason for that change, as empty comments are handled just fine already as demonstrated by the following commit... Change-Id: I384bae9c4cf6a38d0a0a2832fa15bde82126cace
2013-10-27COMPHELPER: Allow empty comments in SyntaxHighlightArnaud Versini
Change-Id: I0f3d5673e28e34ed3921c930aca48f3d7574b064 Reviewed-on: https://gerrit.libreoffice.org/6450 Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org> Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2013-10-23fdo#54938: Replace existsValue for cppu::supportsServiceMarcos Paulo de Souza
As now ::comphelper::existsValue is not used anymore, we're removing this too. Change-Id: I9bd2544a9c378f5a18746255133f5684867e0114 Reviewed-on: https://gerrit.libreoffice.org/6378 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-23fdo#54938: Kill ServiceInfoHelper::supportsService and use cppu's instead.Marcos Paulo de Souza
Change-Id: I1c2d95e4c3fb6242dcb4cdb88cf9733471a3412b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-23Improve testStephan Bergmann
Change-Id: I54e939b7bca883f1c92c957c66ebf47259c92a46
2013-10-23Fix and enable CppunitTest_comphelper_syntaxhighlight_testStephan Bergmann
Change-Id: I2b2aa5f5afdbf58ec3ac2447db370bcb7d1778c0
2013-10-23add inital test for syntaxhighlighterMarkus Mohrhard
Test is partly disabled as we still generate invalid tokens Change-Id: I1a9b03b9bbe2ed7087c6ab7b6d0823ac1d058ba7
2013-10-22Remove unnecessary component_getProcessComponentContext C wrapperStephan Bergmann
Change-Id: I9d9f1a542dbbfc461dd27c32b57e4cad5532fab0
2013-10-22Make violation of "trailing OUString NUL is impl. detail" more obviousStephan Bergmann
Change-Id: I4e91b73dc276f984a4fe324c3a80cb94e8df6ee3
2013-10-22Minor clean-upStephan Bergmann
Change-Id: I48280cf6e12a5219adaa34f57323a93d21c3f554
2013-10-22HighlightPortion's indizes into strings should be sal_Int32Stephan Bergmann
(Had to fix type of some variables holding TextPaM::GetIndex() values from sal_uLong to sal_uInt16 to avoid -Werror,-Wsign-compare failures when comparing those against HightlightPortion's nEnd.) Change-Id: Ia8a0ba682ae28e86e394ee48adff3225eb8de053
2013-10-22Unwind HighlightPortions typedefStephan Bergmann
Change-Id: I0ecc15f9bfd557d0a70a05536906a4984a46463c
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22Terminating NUL at end of its buffer is not considered part of OUStringStephan Bergmann
Change-Id: I3eb11659d1bd45327b66abb567e3ccf132d31915
2013-10-21Remove comphelper::ComponentContextStephan Bergmann
Change-Id: Idc5974e5a2ec68e8f1b2312a88fab15092c82788
2013-10-21fdo#70465: speed up AccessibleEventNotifier::generateId()Michael Stahl
Iterating over all entries of a std::map is rather slow, so add a interval map to manage the free entries. A first attempt to use boost::icl::interval_set for this was abandoned; while the releaseId() function would be just 1 line, GCC 4.8.2 at least is unhappy about boost icl headers for non-obvious reasons: UnpackedTarball/boost/boost/icl/discrete_interval.hpp:45:225: error: default argument for template parameter for class enclosing ‘void boost::icl::boost_concept_check_dummy45(boost_concept_check45*)’ Change-Id: I7b767aefee57df7743dc13a694b6a61abdd536c7
2013-10-21remove pointless EventListeners typedefMichael Stahl
Change-Id: I9cb8ea746c87b394c4c5993de14f692ea018c558
2013-10-21AccessibleEventNotifier: remove implementation details from headerMichael Stahl
Change-Id: Ia422df4066e77bbe3a43a380ba978815fe46dc9c
2013-10-21remove uses of COMPARE_*Caolán McNamara
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
2013-10-17fdo#54938: Adapt svtools and comphelper module ...Marcos Paulo de Souza
to use cppu::supportsService and other pieces. Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-16Unwind useless comphelper::ByteSequence typedefStephan Bergmann
Change-Id: I59317a0d591eac188fa01636031e907357038c29
2013-10-16Straighten the removeFragment code againStephan Bergmann
...what apparently happened is: (1) First, 2c6363eb16f50a8cfd81bc8511554af4f9e06478 "Be less pathetic" replaced MediaDescriptor::impl_normalizeURL with removeFragment. (2) Then, b378e754ae892a044460cfbe33ccc2e51c01f5ca "CMIS: fix file saving issue" (plus follow-up b50d3727cf336bb536efe7bf067f484ddf864e9a "WaE: unused function 'removeFragment'") removed calling removeFragment at all (but re- introduced a now bogus "Parse URL! ..." comment that (1) had removed), which (3) 34f4d2574987b272681b5843e8f5edc374f55fde "CMIS file picker: it really does not like ID Mark" tried to revert again (but kept the bogus comment in), and (4) odd commit 319b160320a045b1a5b302dafbc2220ee1d4d3c3 "CMIS file picker: it really does not like ID Mark" (that looks like a merge conflict resolution gone wrong) erroneously re-introduced MediaDescriptor::impl_normalizeURL that (1) had removed, which caused a -Wunused-variable warning that (5) 706c5a54f662ea58e3b3a64f189eb5120191152a "-Werror,-Wunused-variable" tried to fix, but working under wrong assumptions. The solution is to go effectively back to the code as it was after (1). Change-Id: I62dfa9fa3adbea6b2cb10a509416fe3797c577b9
2013-10-15-Werror,-Wunused-variableStephan Bergmann
...I assume the whole point of 319b160320a045b1a5b302dafbc2220ee1d4d3c3 "CMIS file picker: it really does not like ID Mark" was to actually use the result of impl_normalizeURL. Change-Id: Id94c7785183d96f2a2c3f08caa72af045a1212ba
2013-10-15CMIS file picker: it really does not like ID MarkCao Cuong Ngo
The file picker can't go back folder if we use ID mark in the URL. Conflicts: ucb/source/ucp/cmis/cmis_content.cxx Change-Id: I6985feec71dc23848ee022e0bab9e8515a21ffd2
2013-10-14Probably best to use extern "C" hereTor Lillqvist
Change-Id: I9fac782e29566d3652f9e903ed22abdb6531f883
2013-10-12Bin obsolete CDECL crackTor Lillqvist
Change-Id: I69da428711681d14fd48c198fbce0bb545665b5a
2013-10-12No idea why <wchar.h> would be needed here, and for Unix only evenTor Lillqvist
Change-Id: Ie374a2619d6196172592a14654bb93ec8350c563
2013-10-09Related: fdo#38838 remove UniString::EqualsAsciiCaolán McNamara
Change-Id: I55c85c1c44452c7fb6ac40591aea7177d054affe
2013-10-04require OAccessibleContextHelper to be initialized with SolarMutexMichael Stahl
OAccessibleContextHelper methods are locked by OExternalLockGuard which effectively only locks its ExternalMutex (i.e. SolarMutex); so ensure that all sub-classes actually pass in a SolarMutex by removing the default constructor. (since these classes are in comphelper they can only use the SolarMutex indirectly) This uncovers that AccessibleToolPanelDeckTabBarItem and OAccessibleControlContext did not pass in SolarMutex before. Change-Id: Ib9085eeee6225f7c74b158e72f04b1bf62622071
2013-10-02rhbz#1001768: avoid deadlock in OAccessibleContextHelper::disposing()Michael Stahl
De facto this class is locked by SolarMutex, which is what the OExternalLockGuard actually locks; do not lock m_Mutex because it may cause deadlock. Change-Id: I88b226d73dbef9a5803347b0ac3191bec2ba4515
2013-10-02-Werror,-Wunused-variableStephan Bergmann
Change-Id: Ia04f136a821908591d0701c804518e656aa2083a
2013-10-02-Werror,-Wunused-variableStephan Bergmann
Change-Id: I48fdf4314412fef028ec25c4f6f92891ac35033e
generated by cgit (git 2.34.1) at 2024-06-01 07:09:47 +0000