summaryrefslogtreecommitdiff
path: root/comphelper
AgeCommit message (Collapse)Author
2015-10-18cppcheck:noExplicitConstructorNoel Grandin
Change-Id: I2b68ba9e8caf7971efbba094ef060e72541bdccf Reviewed-on: https://gerrit.libreoffice.org/19426 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-09Hold the SolarMutex while updating properties; thanks to sberg.Michael Meeks
Change-Id: Id9dc4c7e083da2a8d44c7295a8b605de81bca1ef Reviewed-on: https://gerrit.libreoffice.org/19272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-09Move SolarMutex down from tools to comphelper/ to make life easier.Michael Meeks
Change-Id: I7dd21f30daa27e5de2848eb16aee9a610dd629d5 Reviewed-on: https://gerrit.libreoffice.org/19271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-09Create a wrapper to make listening for configmgr changes easy.Michael Meeks
Change-Id: Ib58d04f9e046e604b24e0e338796a7a60aa1d6fd Reviewed-on: https://gerrit.libreoffice.org/19253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-08comphelper: add string::join()Miklos Vajna
If there is a need for it, this could be extended later to work with uno sequences and/or OUStrings as well. Change-Id: Id0af8b1755c8e4b668720563d10a052337e1b2c9
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: Ia3b63df5e8752690e3350f8a13445a096a839952
2015-10-06tdf#94228 comphelper: replace BOOST_PPDaniel Robertson
Replace BOOST_PP macros in comphelper with variadic templates. The client interface should not change. However, there are a few side effects due to this change. The most important being 1) There is no longer a maximum number of service declarations limmited by default at 12 for unwrapArgs and component_getFactoryHelper. 2) component_getFactoryHelper now terminates early as soon as pRet is not a null pointer. Change-Id: I016fd208d0e80f91d8669fff29d58b6189e946d3 Reviewed-on: https://gerrit.libreoffice.org/18891 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: Ifd016962dda31b312070745e7646879186d074e9
2015-10-01remove old standalone Sun bug numbersNoel Grandin
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini
Change-Id: Iaff7e38dd5beac48e1643e369e4240aa736c35ea Reviewed-on: https://gerrit.libreoffice.org/18941 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-24comphelper: replace for_each with range-based forDaniel Robertson
Replace complex uses of ::std::for_each with a range-based for-loop. Change-Id: I57d3d2e830e7700b793e1836777cbe72504c6825 Reviewed-on: https://gerrit.libreoffice.org/18817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-21comphelper: add LibreOfficeKit::set/isViewCallback()Miklos Vajna
Change-Id: Iad0b2ee419327daf478f3ddda2378effe0184067
2015-09-14boost->stdCaolán McNamara
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c Reviewed-on: https://gerrit.libreoffice.org/18564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-11framework: yet another WeakImplHelper<XPropertySetInfo> dupcliateMichael Stahl
There's a very similar comphelper::PropertySetInfo, unfortunately with an additional mnMemberId on its properties, so convert a little... Change-Id: I2a5fc0bb0ff6d680d546192b9d09afee6348f218
2015-09-01comphelper: fix MSVC --enable-mergedlibs build, OFOPXMLHelperMichael Stahl
The OFOPXMLHelper class causes duplicate definition link errors due to its WeakImplHelper base class. It turns out that the OFOPXMLHelper class itself is only used by other exported functions in comphelper itself so just hide the implementation detail. Change-Id: I3ac8c561af703193cc2609e2c799b630a0d43127
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I957be579527123be25abca0b7dcb69295711abf8
2015-08-29o3tl/cow_wrapper: remove boost dependencyDaniel Robertson
Remove boost dependencies from ::o3tl::cow_wrapper, and add the necessary includes to files including checked_delete and noncopyable that do not already include the necessary files. Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686 Reviewed-on: https://gerrit.libreoffice.org/18125 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-21Remove demonstrated-useless comphelper::compareStephan Bergmann
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21Demonstrate comphelper::compare is uselessStephan Bergmann
Change-Id: I03de2d02f4814bf3425f7278ec91ed1e3b4ce1a0
2015-08-19There is no css::uno::Sequence<sal_uInt8> in UNOStephan Bergmann
Change-Id: Ibf5095fea20314180a4e002295c89f570d66d45f
2015-08-19comphelper::isA(Type... -> Type == cppu::UnoType...Stephan Bergmann
Change-Id: I1bfb99b1715a907a03af5a30df6c7a41f91fd2fb
2015-08-19Remove two silly typedefsStephan Bergmann
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19Consolidate isFileUrl checksStephan Bergmann
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-11loplugin: defaultparamsNoel Grandin
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
2015-08-10cppcheck: nullPointerRedundantCheckCaolán McNamara
Change-Id: I5cac2cdb383de5448383434a910eb97061c29071
2015-08-04cui,connectivity: inline some use-once typedefsNoel Grandin
Change-Id: I1b043031014a3e823cd614966984a2ac2be1ac71
2015-07-31comphelper: replace boost::function with std::functionMichael Stahl
Change-Id: I042c97d8472c3afceffba36808687f382571e6c2
2015-07-27comphelper, desktop: fix MSVC mergedlib link failureMichael Stahl
Duplicate symbols are easily avoided by removing duplicate code. Change-Id: I9b598a44156d6ff71b0691e69ab8163b15e2e26f
2015-07-27com::sun::star->css in comphelperNoel Grandin
Change-Id: I4aa0b2d15f2a06cbbbf63a363f403ca6435ffbcd Reviewed-on: https://gerrit.libreoffice.org/17365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-25tdf#92130 fix DoEvents to be recognized as keywordMarek Doležel
Change-Id: I24868acec66a72abbb52b8026ed3a092dbd97632 Reviewed-on: https://gerrit.libreoffice.org/17347 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-23coverity#1312139 random byte is deliberateCaolán McNamara
Change-Id: Iff546476256c87813b01a7db2c8331f926b7e3bd
2015-07-22tdf#82744: fix WebDAV lock/unlock behaviour - part 2Giuseppe Castagno
Changes done to the code in framework, comphelper and unotools, in no particular order - add an interaction handler dedicated to WebDAV The stock interaction handler can be missing depending on the need of the framework performing its tasks, so a dedicated handler is provided, this one is always present. - force opening of a WebDAV file. A WebDAV file sould be open r/o even if explicitly requested to open as r/w. This is a limitation of current WebDAV implementation, not of the standard. This change is needed in order to reopen correctly a file as requested by a 'Edit Mode' GUI command. Change-Id: I5368fa2c0511f1630e6d6139c6a986d33aa19082 Reviewed-on: https://gerrit.libreoffice.org/17182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-20tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, for comphelper. This also includes extra changes in other modules required accordingly. Change-Id: Id1537f46f1c90f760a0d8987a6dafa0e1da03b8f Reviewed-on: https://gerrit.libreoffice.org/16929 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: I928325376b97ddd312af0f0a71187f29be607c6a
2015-07-10add a SAL_RAND_REPEATABLE for repeatable random numsCaolán McNamara
merge the formula and comphelper ones together Change-Id: I2e7e2cdb176afc6982e384fa1e007da5b914e6f0
2015-07-04Fix typosAndrea Gelmini
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc Reviewed-on: https://gerrit.libreoffice.org/16705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29coverity#1308587 Uncaught exceptionCaolán McNamara
Change-Id: I45e699ebf255e7d933a3b5d77717dcd7583d8383
2015-06-29Revert "return and use std::vector from OInterfaceContainerHelper"Noel Grandin
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29return and use std::vector from OInterfaceContainerHelperNoel Grandin
since most of the time we don’t need a heavyweight uno::Sequence. Adds a new method getElementsAsVector(). Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a Reviewed-on: https://gerrit.libreoffice.org/15747 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-24Get rid of comphelper::string::is*Ascii functionsStephan Bergmann
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
2015-06-24Simplify comphelper::string::isdigitAsciiString definitionsStephan Bergmann
Change-Id: I26c889e51287a239ef92a798a6899266837064d9
2015-06-23Drop duplicate #includesTakeshi Abe
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-21Fix typosAndrea Gelmini
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-18Add SwTiledRenderingTest::testGetTextSelection() testcase.Miklos Vajna
Fails without commit 193b907b2bc49b9e48cfab2583e81a24aaa2e666 (SwXTextDocument::getTextSelection: fix missing editeng forward, 2015-06-18). Change-Id: I5fdab128471c12901f930b6b4ab4e2304dd3fe64 Reviewed-on: https://gerrit.libreoffice.org/16359 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>