Age | Commit message (Collapse) | Author |
|
Change-Id: Ie283a4774564f25e0fde8ca35212f92be786d671
Reviewed-on: https://gerrit.libreoffice.org/75785
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...as discussed at
<https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html>
"minutes of ESC call ..."
Change-Id: Ia053da171d59747984546f38e19da808825b4f79
Reviewed-on: https://gerrit.libreoffice.org/63832
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
I seem to have missed quite a few in
commit 9f4d23c15115d64febd6bf01f870cc157badd350
filter out some of the AST in the plugins
This nets me another 14% improvement
Change-Id: I39b980b49ced560f768045dbedd3ddfef29306c1
Reviewed-on: https://gerrit.libreoffice.org/59501
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I26734c13515394162d88351a1cbe2b20abdac865
|
|
...so a dynamic exception specification should be replaced with noexcept(false).
Doesn't look like this omission made any difference when running the rewriter
across the LO code base earlier, though.
Change-Id: Ib0e2b412b65cae7c1a68e875bbddf93f3656cebb
|
|
Change-Id: Ia927ed7d1e7815e59ccb67246da6981c65683168
|
|
Change-Id: Ifa9223fadeeb1fde54afc99874a1b3d855073dce
|
|
Change-Id: I73404287c387a36e224683f75e967d51d911175b
|
|
...only odk/examples/ remains to be clean up
Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
|
|
...as at least MSVC SAL_CALL-annotated functions have an AttributeType wrapped
around the FunctionProtoType.
Change-Id: Ic085e2e3649e6b2fc8ca380047133a8edbe20589
|
|
See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.
* The check for missing @throws documentation is not too specific, it just
checks whether a function with dynamic exception specification has /any/
@throws clause, not necessarily exactly matching the exception types. (Many
of the details in the existing dynamic exception specifications are probably
not very useful, anyway.)
* When adding @throws clauses, I bluntly copied the exception specifications
except for dropping any mentions of std::exception (except in the rare cases
where that was the only exception typed mentioned).
* In many places it might have looked more natural to use trailing Doxygen
comments of the
///< @throws ...
kind, but Clang's getCommentForDecl unfortunately doesn't detect trailing
comments on function decls.
* Also, Clang's getCommentForDecl doesn't look into macros, so some trivial
silly macros were expanded along the way to add comments where necessary.
Change-Id: I1831d72df2d9c801d4b8dd7d708d9cefea039589
|