summaryrefslogtreecommitdiff
path: root/compilerplugins
AgeCommit message (Collapse)Author
2021-08-18loplugin:passstuffbyrefNoel Grandin
Change-Id: I4f01eb3842ef198f02af274f54afb2760c820a4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18loplugin:sequenceloop also check for B2DPolyPolygonNoel Grandin
which has the same problem Change-Id: I98f9924626f26739e91d6a9d21e4276473ea314d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13Help older linkers (Ubuntu 18.04, Fedora 31)Jan-Marek Glogowski
Fixes a regression from commit 429e6e6efbfbc65d36452cbf8b3a25740a1dc8bc ("osl::Mutex->std::mutex in OInputStreamHelper"), which results in failed linking with some older toolchains: /usr/bin/ld.gold: error: workdir/CxxObject/xmlsecurity/source/helper/UriBindingHelper.o: requires dynamic R_X86_64_PC32 reloc against '_ZThn40_N3utl18OInputStreamHelper7acquireEv' which may overflow at runtime; recompile with -fPIC include/com/sun/star/uno/Reference.hxx:240: error: undefined reference to 'non-virtual thunk to utl::OInputStreamHelper::acquire()' collect2: error: ld returned 1 exit status xmlsecurity/Library_xmlsecurity.mk:10: recipe for target 'symbols/instdir/program/libxmlsecurity.so' failed Known problematic setups are my Ubuntu 18.04 build schroot and Caolán's Fedora 31 VM to run Coverity. Change-Id: I40f0734a0cb9131193abf21ba95dc63816b5c1d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-10Use boost::make_sharedStephan Bergmann
Change-Id: I2c842d6198d79dcc3f5c85ab65c8f57357aa2a79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120289 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-10Missing includeStephan Bergmann
(for std::unique_ptr, with recent libstdc++ 12 trunk) Change-Id: I61b7823dd740ea7cdfe0d7403a50ac73b24d1c4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-03Consolidate on C++17 std::scoped_lock instead of std::lock_guardNoel Grandin
as in commit 9376f65a26240441bf9dd6ae1f69886dc9fa60fa Change-Id: I3ad9afd4d113582a214a4a4bc7eea55e38cd6ff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119927 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-29loplugin:unnecessarymethodsNoel Grandin
Change-Id: I1d7a9c2ca91816c9e550cd673e04599f5efcf5ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119668 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-23no need to allocate these static vars on demandNoel Grandin
the constructor can be laid out at compile/link time Change-Id: I377a537e15199ae81394d76ac662576280a25c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-21IsVertical->IsEffectivelyVertical, GetDirectVertical->GetVerticalMike Kaganski
Before commit 653b53287ca09a9ffe3f5ce0242919e719c1086c, editengine objects had a pair IsVertical/SetVertical, which queried and set a boolean flag (and SetVertical also had a second argument to set another flag). The mentioned commit had introduced an inconsistency, changing SetVertical to only set a single flag, but at the same time making IsVertical to return a synthesized result from two values: vertical and rotation. Additionally, GetDirectVertical was introduced to complement SetVertical. In many places, the use of synthetic IsVertical looks suspicious, especially where it is used in combinations with SetVertical. But here I don't change existing logic, and only rename the methods, so that in case someone sees an actual problem, it would be easier to spot the method mismatch. The end result is that now we have a proper getter/setter pair GetVertical/SetVertical, and also IsEffectivelyVertical, named to reflect that it calculates its return value. Change-Id: I38e2b7c5bd7af0787dd7a1c48e1385138dac80b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119315 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-14new loplugin:weakobjectNoel Grandin
find classes with more than one copy of OWeakObject in their inheritance hierarchy, which is dodgy Change-Id: I4e31bd6db03d25d934b736bd6a9c1b665f976ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-12loplugin:unusedmethodsNoel Grandin
Change-Id: I1e17e43bfe4a18034e9c0ff483097fe6ca0e777a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-12loplugin:unusedfieldsNoel Grandin
Change-Id: I487ff0211fc1b894950bedc72cd8444c7da36ace Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118781 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-09Remove redundant duplicate checkStephan Bergmann
Change-Id: I311496e25ac617c6b174b828978a1298231bd433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118686 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-07-09Make loplugin:stringadd slightly more aggressiveStephan Bergmann
...by assuming that all const member functions are side-effect free. (This presumably means that some of the special cases in StringAdd::isSideEffectFree are obsoleted by this more general case, but any such removal is postponed to later clean-up.) (Came across this when idly wondering why 8b7f948d9d79393bc6c1b11d239706666fd5d7de "sc, VmlFormControlExporter: avoid OStringBuffer style" had not been found by the plugin before.) Change-Id: I6bca10df53885b14a590543aabd61f23b3748572 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118675 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-07-05store the SfxItemSet inside SfxSetItem by valueNoel Grandin
rather than on the heap, avoiding an allocation Change-Id: I3f1504f9a2d4178a9ba59e98de182a0ab98cdce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118356 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-02convert AccessibleBrowseBoxObjType to scoped enumNoel Grandin
Change-Id: Iaf764c905d080e4decabd853bd3847b34cb79cdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01loplugin:unusedenumconstants update resultsNoel Grandin
Change-Id: I6153a67cd041f7dbabb650ad0c0d30427a2e558b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118206 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-28split out customcellrenderer codeCaolán McNamara
Change-Id: Ia2803f6eab14ee7aeb697fb039f4e6dbdefa25e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117958 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-25gtk4 dnd into external appsCaolán McNamara
It's always hard to bootstrap dnd because so much of it has to work before any of it works. Typically dnd and cnp are strongly related so getting cnp working first is the way to go before trying dnd. Change-Id: I645f56dc5f8cb0e3a31e0ff8bbaab610366b6312 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117798 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22Clarify no loplugin:overridevirtual with templated base classStephan Bergmann
Change-Id: I4128b43f2a928fa5465991cc92b2d62e54e2cfec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117662 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-22Adapt compilerplugins to llvm::sys::fs::OF_None renameStephan Bergmann
...from F_None, which happened with <https://github.com/llvm/llvm-project/commit/1f67a3cba9b09636c56e2109d8a35ae96dc15782> "[FileSystem] Split up the OpenFlags enumeration" towards LLVM 7, originally leaving the alternative F_None spelling in for compatibility, but which was finally removed now with <https://github.com/llvm/llvm-project/commit/3302af9d4c39642bebe64dd60a3aa162fefc44b2> "Support: Remove F_{None,Text,Append} compatibility synonyms, NFC". Change-Id: Iea1192b5ee351c13ea5d6701887f3aba62133c20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117609 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-19loplugin:finalclassesNoel Grandin
improve the plugin to detect more cases. I only apply the new final changes to classes in /include here. Which reveals that RoadmapWizard::getPageController( TabPage* _pCurrentPage ) will always return nullptr Also needed to sprinkle some SAL_DLLPUBLIC_TEMPLATE around to workaround Visual Studio linking problems. Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-17Adapt o3tl::temporary to C++23 P2266R1Stephan Bergmann
With the recent implemenation of <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1: Simpler implicit move" in Clang 13 trunk as <https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f> "[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build started to fail with > In file included from sal/rtl/random.cxx:25: > include/o3tl/temporary.hxx:21:62: error: non-const lvalue reference to type 'double' cannot bind to a temporary of type 'double' > template <typename T> constexpr T& temporary(T&& x) { return x; } > ^ > sal/rtl/random.cxx:97:37: note: in instantiation of function template specialization 'o3tl::temporary<double>' requested here > return std::modf(random, &o3tl::temporary(double())); > ^ etc. (And fixing that by adding the recommended static_cast then triggered a false loplugin:redundantcast warning.) Change-Id: I222429e9872afdedf77a07014c0a2e9e06c60b50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-17split NotifyingLayout outCaolán McNamara
Change-Id: Ib706331f9e6b3749559a0b78f1a07d442a674829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117369 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-17gtk4: restore double-decker notebooksCaolán McNamara
add a 'NotifyingLayout' to find out when the size of a widget changes now that size-allocate has been removed Change-Id: Iae55b7fafd2fd26c62afaedd777ae40e84fbb964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-16Move enable_if from dummy template parameter to return typeStephan Bergmann
...and drop the no-longer necessary loplugin:implicitboolconversion exclusion (which had been necessary to avoid > [CXX] vcl/source/window/dockingarea.cxx > In file included from vcl/source/window/dockingarea.cxx:26: > In file included from vcl/inc/svdata.hxx:26: > include/o3tl/hash_combine.hxx:14:78: error: implicit conversion (Dependent) from 'bool' to 'std::enable_if_t<(sizeof(N) == 4), bool>' (aka 'typename enable_if<(sizeof(N) == 4), bool>::type') [loplugin:implicitboolconversion] > template <typename T, typename N, std::enable_if_t<(sizeof(N) == 4), bool> = false> > ^~~~~ etc.) Change-Id: If764365213cf29f7dec6fdd6a773dc9894dd15bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117330 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-14Adapt compilerplugins to LLVM 13 APSInt::toString changeStephan Bergmann
<https://github.com/llvm/llvm-project/commit/61cdaf66fe22be2b5942ddee4f46a998b4f3ee29> "[ADT] Remove APInt/APSInt toString() std::string variants". TODO: While most uses of compat::toString should be harmless performance-wise, as they are either in error reporting code or in plugins that are not run by default, some calls like the one in compilerplugins/clang/staticconstfield.cxx might benefit from moving them away from using std::string. Change-Id: Icfac7d6d4a0a4a4edeb5c8bdcdbc13b73e20a5e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117152 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-11loplugin:unusedmethods improve filteringNoel Grandin
Change-Id: I75771dbcecd58259bffdd2ddb0df631205aa8d93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117032 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10Adapt compilerplugins to Clang VK_RValue -> VK_PRValue renameStephan Bergmann
<https://github.com/llvm/llvm-project/commit/aef5d8fdc7d0d348125d5ecf4a13be5888eb1654> "[clang] NFC: Rename rvalue to prvalue" Change-Id: I237e8a491465500e35637f8dae400402bcd9411d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116983 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-04loplugin:virtualdeadNoel Grandin
Change-Id: Ic2e18f9088e7427f0679dab27f0d3acb6f2bb240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116716 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-03-Wunused-but-set-{parameter,variable} in CompilerTest_compilerplugins_clangStephan Bergmann
...new with Clang trunk 13. As a rule of thumb, this change adds explicit cast-to-void silencing in those .cxx that already contained other such silencing casts and adds wholesale #pragma clang diagnostic ignored in all others. Change-Id: I1884496ee1aa81aaf3c8b3533534a4b69b185e9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116660 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-01drop unused Widget::set_secondaryCaolán McNamara
Change-Id: I63e69ca9daa8a452eee28333d8639d1db093e826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31gtk4: enable cut and paste into other applicationsCaolán McNamara
Change-Id: I9924a9af10532254dc368e274e4a20c6706e4239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.Gülşah Köse
SvxBackgroundColorItem is just copied from SvxColorItem. There is nothing special to SvxBackgroundColorItem class. SvxColorItem is a generic item and it's used on many places related with colors. We can use SvxColorItem for background colors too. Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2021-05-31tdf#142467: Update comments with GCC bug IDStephan Bergmann
Change-Id: I71052f8db941733ab4e4b1b36cbf1fcb28eac9d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116420 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-27gtk4: continue to provide Paintable via cairo surfaceCaolán McNamara
instead of squeezing through a GdkTexture and losing hidpi surfaces Change-Id: I1ee75ff804d1d769273e2f80335bfdf528ae8039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27tdf#47065 Add new file open UI options and implement a new threadMatt K
Add new UI options when opening a locked or non-writeable document to allow the user to be notified when such a document becomes editable . If the user selects "Notify", then that document is added to a list of open documents to be checked by a thread every 60 seconds for read/write access and whether lock file is available/obtainable. If access is allowed for a document, then show UI dialog to the user asking to Reload that document. If Reload is selected by the user then that document is reloaded with read/write access. The checking thread is spawned only once no matter how many "Notify" documents there are. The thread is spawned if not already running when a new "Notify" document is opened, and it terminates when all "Notify" documents have been closed or the application terminates. Also update badstatics clang plugin to ignore new global variables introduced. Change-Id: I7555ce6f5df79c2c87216e0129ef3b2883c7d921 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-26tdf#142467 crash on calling 'getInfoHelper' in final classCaolán McNamara
IPropertyArrayHelper & rInfo = getInfoHelper(); crashes when CandleStickChartType is final for unknown reasons. I see this with gcc-11.1.1-1.fc34.x86_64 in 7-1 locally but also in the fedora libreoffice-7.0.6 built with gcc-10 so this isn't a recent problem. #1 0x00007ffff6f4fe91 in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=this@entry=0x5bdd588, nHandle=nHandle@entry=3) at cppuhelper/source/propshlp.cxx:549 #2 0x00007fffad45e9ff in chart::CandleStickChartType::getSupportedMandatoryRoles() (this=0x5bdd520) at chart2/source/model/template/CandleStickChartType.cxx:219 Change-Id: Ia029162587da1fc00df32866863deb186c7e11bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19Adapt loplugin:noexcept to system macro BEGIN_COM_MAP (clang-cl)Stephan Bergmann
...to silence warnings like > In file included from C:/lo-clang/core/extensions/source/activex/SOComWindowPeer.cxx:27: > C:/lo-clang/core/extensions/source/activex/SOComWindowPeer.h(57,1): error: Replace legacy dynamic 'throw ()' exception specification with 'noexcept' [loplugin:noexcept] > BEGIN_COM_MAP(SOComWindowPeer) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1428~1.299/atlmfc/include\atlcom.h(2204,130): note: expanded from macro 'BEGIN_COM_MAP' > static HRESULT WINAPI _Cache(_In_ void* pv, _In_ REFIID iid, _COM_Outptr_result_maybenull_ void** ppvObject, _In_ DWORD_PTR dw) throw()\ > ^~~~~~~ Change-Id: Iee2619e000963a419b757235d86d7f87944ed46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115748 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-18loplugin:unusedfieldsNoel Grandin
Change-Id: Ib574403a7f7f8b11c6263c9c19ec6b65c8374ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-18loplugin:unusedmethodsNoel Grandin
Change-Id: I8191f4a9eb25b12242354813303fb7d30489d2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-18loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I1c6c4741680d5b49c4e1445d0f4ca7a01fd7e192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-17sc_ucalc: move formula tests to their own moduleXisco Fauli
in order to split sc_ucalc monster into smaller modules Now, we can change CppunitTest_sc_ucalc.mk to use the template - Enable testExternalRefUnresolved on Linux/Mac - Remove testFormulaHashAndTag. it was disabled in f4dc8a869ac49f19c20fc5fa606448e9103726bd < the idea behind the test can't work right now > Change-Id: I864341442ccd321c8ef4f7147db4512bcc7a6b21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115595 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-17split OutputDevice from WindowNoel Grandin
as part of a longer-term goal of doing our widget rendering only inside a top-level render- context. I moved all of the OutputDevice-related code that existed in vcl::Window into a new subclass of OutputDevice called WindowOutputDevice. Notes for further work (*) not sure why we are getting an 1x1 surface in SvpSalGraphics::releaseCairoContext, but to fix it I clamp the size there (*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice (*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code? Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-16sc_ucalc: move conditional format tests to their own moduleXisco Fauli
in order to split sc_ucalc monster into smaller modules While at it, remove testCopyPasteSkipEmptyConditionalFormatting it was added already disabled in 5915d38e84c7a7861c169bea18c63824bcfdc470 <add disabled test for conditional formatting with skip empty cells> and it fails if it's enabled Change-Id: I6222849b38ab288b24432dc00698d72f5bcc5c2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115677 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-14Improve loplugin:stringviewStephan Bergmann
Issue the "instead of O[U]String, pass [u16]string_view" diagnostic also for operator call arguments. (The "rather than copy, pass subView()" diagnostic is already part of handleSubExprThatCouldBeView, so no need to repeat it explicitly for operator call arguments.) (And many call sites don't even require an explicit [u16]string_view, esp. with the recent ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 "Optimized OString operator += overloads". Just some test code in sal/qa/ that explicitly tests the O[U]String functionality had to be excluded.) Change-Id: I8d55ba5a7fa16a563f5ffe43d245125c88c793bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115589 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-14sc_ucalc: move shared formula tests to their own moduleXisco Fauli
in order to split sc_ucalc monster into smaller modules Change-Id: I399daeb57dd5fba7077fef6584b0a3772df84d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115559 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-14Improve loplugin:stringview diagnostic outputStephan Bergmann
Say what the O[U]String is constructed from (to make it easier to decide on an optimal rephrase of the whole surrounding expression), and find more cases that could use O[U]StringChar. Change-Id: I64a3851544498c26ca3f46f5df7f593d2fdcb0ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115579 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-12Guard against isCXX11ConstantExpr on dependent expressionStephan Bergmann
> Assertion failed: (!isValueDependent() && "Expression evaluator can't be called on a dependent expression."), function isCXX11ConstantExpr, file ~/llvm/llvm-project/clang/lib/AST/ExprConstant.cpp, line 15540. ...as would have hit with a preliminary version of ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 "Optimized OString operator += overloads" Change-Id: I652063b4eebd076973eaa57219df91cd1fbef312 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-10 12:38:03 +0000