summaryrefslogtreecommitdiff
path: root/compilerplugins
AgeCommit message (Collapse)Author
2017-02-16convert EESpellState to scoped enumNoel Grandin
and drop unused EE_SPELL_NOLANGUAGE enumerator Change-Id: I74a5f89335883a13d77b39f78b7de55bddb1f107
2017-02-16remove unused NONE from ScrollRangeCheck enumNoel Grandin
Change-Id: I9d83cc38a9fa477a61ec7e2ec3d9786318187085
2017-02-16convert resetType to scoped enumNoel Grandin
Change-Id: Ie127b99949546b5303fd105c662b25c62d409941
2017-02-16convert HelpProcessingErrorClass to scoped enumNoel Grandin
and drop unused HELPPROCESSING_INTERNAL_ERROR enumerator Change-Id: I0f2cf063a3f1472e1d52bab5039b1c3158d4865e
2017-02-16remove unused enumerators from SymbolType enumNoel Grandin
Change-Id: I63af4ab93dfd021f88f03fad2c065f5a0e9eeed9
2017-02-16remove unused Exist from oslCheckMode enumNoel Grandin
Change-Id: I1ad187342444c5e92b61578d2a67cce2ae5ac428
2017-02-15convert FuncParamValidity to scoped enumNoel Grandin
and drop unused NONE enumerator Change-Id: Ibc77390efb195a9158ba809ad96aab4dcdbc09cb
2017-02-15convert SylkVersion to scoped enumNoel Grandin
Change-Id: Ib7e02fee748bd55be6d74d60bff3d8ed765ea225
2017-02-15convert DoubledQuoteMode to scoped enumNoel Grandin
and drop unused enumerators Change-Id: I0dc45e2bec1a25357405ca0c0197632ee4806cb0
2017-02-15drop unused PRESOBJ_IMAGENoel Grandin
Change-Id: I8fa011bea423e961a3ebe7cd8687e4bce7c4cd77
2017-02-15drop unused SwChildWindowMailmerge from SfxShellFeature enumNoel Grandin
Change-Id: Ica64d75986877bc0b2fc3bafb092457396fb8e27
2017-02-15convert SmBracketType to scoped enumNoel Grandin
and drop unused enumerators Change-Id: Icda3ff510331f9f0adb97d6dac56edf325d0d1a7
2017-02-15remove unused AccessibilityChanged from SfxHintId enumNoel Grandin
Change-Id: Ic2d413002466e92d38a7a918b3f7e04d3c9eebf2
2017-02-15convert SvxIconChoiceCtrlPositionMode to scoped enumNoel Grandin
and drop unused AutoAdjust enumerator Change-Id: Ie900f89241947cb93a16f0223071846fecfef09c
2017-02-14convert svt::table::TableArea to scoped enumNoel Grandin
and drop unused TableAreaDataArea enumerator Change-Id: I00da558ab899dccbeaa9786c65f7a2831f323b25
2017-02-14convert to EnumerationResult to scoped enumNoel Grandin
and drop unused RUNNING constant Change-Id: I498b8b47e172336775b38c953f867f2adc57603e
2017-02-14convert SvxPrevLineSpace to scoped enumNoel Grandin
Change-Id: I5903169e1d7728a2f1e547efdff82a75e8d7b6a7
2017-02-14remove unused BreakedLine enumerator from SdrMeasureTextVPosNoel Grandin
Change-Id: I28cf3d36c1427b382aea1925d2dd94ace0d2a443 Reviewed-on: https://gerrit.libreoffice.org/34204 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-14convert SvxXMLTableImportContextEnum to scoped enumNoel Grandin
and drop unused stice_unknown enumerator Change-Id: Ia2d363c9e8d9e501bbfb6f9bb5838b109ce8593b Reviewed-on: https://gerrit.libreoffice.org/34201 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-14remove unused BrkAction enumerator from SdrEventKindNoel Grandin
Change-Id: I46c50bbbad5d269b7f15e041db115fa7f37a8168 Reviewed-on: https://gerrit.libreoffice.org/34205 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-13convert ShellModes to scoped enumNoel Grandin
and drop read-only SHELL_MODE_DRAW_CTRL enumerator Change-Id: I2ccaeb492912c876b89ff9b5dccaa99e28a268b7
2017-02-13convert eF_ResT to scoped enumNoel Grandin
and drop read-only FLD_TAGTXT enumerator Change-Id: I718529082ce540c0e3bca37d969917d3b3a67f5e
2017-02-13convert SW_KeyState to scoped enumNoel Grandin
and drop unused InsDel_* enumerators. Also rename to SwKeyState to make it a little shorter and more consistent with other naming. Change-Id: I837ea8d64a0f26426567dcf78750939fc959a4a4
2017-02-11SourceManager::getFilename returns StringRefStephan Bergmann
Change-Id: I77db8565efe2e0d366afc8470308d7801a2a7337
2017-02-10loplugin:dynexcspec: Deallocation functions are implicitly non-throwingStephan Bergmann
...so a dynamic exception specification should be replaced with noexcept(false). Doesn't look like this omission made any difference when running the rewriter across the LO code base earlier, though. Change-Id: Ib0e2b412b65cae7c1a68e875bbddf93f3656cebb
2017-02-10Remove unnecessary blacklists from loplugin:stringconstantStephan Bergmann
Change-Id: I866a421a2b3e8830aaa7096adaef945a2264195e
2017-02-10remove unused enumerator from EncodedWordStateNoel Grandin
Change-Id: I793276d2b13bdb966e18acb8f13b4c7e77516898
2017-02-09restore constant to VerticalOrientationNoel Grandin
Removed in commit f4826959c1a5b0e6d2849d4240668b2087582848 "new loplugin:unusedenumconstants". And add a comment. Change-Id: I63d6f46aa92e31db08e51e47a62104dc7d3d3359 Reviewed-on: https://gerrit.libreoffice.org/34057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09remove ConnectionIdentifierType enumNoel Grandin
since we only use the AsciiCString enumerator. Consequently simplify the GetConnectionIdentifier method Change-Id: I9e1a1318d2f12bfd18edeb8479e0e7171b22d0f1 Reviewed-on: https://gerrit.libreoffice.org/34026 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09Fix SAL_DEBUG_BACKTRACEStephan Bergmann
...after 56d071c10ca8016848f1f059aa3eb197fe928844 "rename SAL_DEBUG_TRACE to SAL_DEBUG_BACKTRACE" (looks like this doesn't get used much...)
2017-02-09loplugin:unusedenumconstants read-only constants in vcl (2)Noel Grandin
Change-Id: Ia3da23e0ef2fa710403745bd11255ed001516da4 Reviewed-on: https://gerrit.libreoffice.org/34020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08loplugin:unusedenumconstants read-only constants in vclNoel Grandin
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2 Reviewed-on: https://gerrit.libreoffice.org/34018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08loplugin:unusedenumconstants read-only constants in writerfilterNoel Grandin
Change-Id: I3cc0d696059b130a8f1f1d8d3b1908d2e84d1a75 Reviewed-on: https://gerrit.libreoffice.org/34017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07convert DEBUG_TIME to scoped enumNoel Grandin
Change-Id: I91b286d8415ebc8c6675aca6ee143850c956c74b Reviewed-on: https://gerrit.libreoffice.org/33986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07drop unused FONT_PROPTYPE_CELL constantNoel Grandin
which makes this enum not necessary anymore Change-Id: I0194634d357569aee502f1e8a7fd95c49e23040c Reviewed-on: https://gerrit.libreoffice.org/33967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07convert GalleryBrowserTravel to scoped enumNoel Grandin
and drop unused GALLERYBROWSERTRAVEL_CURRENT value Change-Id: Id91824cbe024d4b5109ee0755b518164837bc6a6 Reviewed-on: https://gerrit.libreoffice.org/33965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06loplugin:unusedenumconstants in ooxNoel Grandin
Convert FragmentHandler2::MCE_STATE to scoped enum and drop MCE_UNUSED constant Change-Id: Id0b3a81e61d77af5d3837527b008e196835f57cd Reviewed-on: https://gerrit.libreoffice.org/33954 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06loplugin:unusedenumconstants should apparently not be run by defaultStephan Bergmann
Change-Id: I42f479de39b94ca8e9c72a6e92534f602a9fad39
2017-02-06loplugin:unusedenumconstants in connectivity..cuiNoel Grandin
Convert ExpressionFunct to scoped enum and drop FUNC_CONST value. Convert MQueryExpressionBase::node_type to scoped enum and drop Unknown value. Dop PageType::Color value Change-Id: Icb1f5503c230fb91329acc7d9e1da665fa28d95e Reviewed-on: https://gerrit.libreoffice.org/33948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06loplugin:unusedenumconstants in frameworkNoel Grandin
Convert EProtocol to scoped enum and drop E_UNKNOWN_PROTOCOL. Convert ToggleButtonToolbarController::Style to scoped enum and drop STYLE_TOGGLEBUTTON. Convert TargetHelper::ESpecialTarget to scoped enum and drop E_NOT_SPECIAL. Change-Id: I412adacac15192cf6563ce4d5e5b74bfffff4737 Reviewed-on: https://gerrit.libreoffice.org/33949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06remove accidentally committed filesNoel Grandin
Change-Id: Ib41f16f945f6b7a5ba314b13ce8a7b24c35a8edb Reviewed-on: https://gerrit.libreoffice.org/33947 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06loplugin:unusedenumconstants in vclNoel Grandin
- drop TTCR_GLYPHSEQ - drop ImageType::Invalid - give preedit_data_t a default constructor, so my plugin spots that the eState field is being initalised to DontKnow effectively by a memset - document ToolbarIconSize::Small as unused, but can't remove since it might be stored in a user-setting somewhere Change-Id: I94b34bba83a04de16f95e4faec95b4bd29f3c652 Reviewed-on: https://gerrit.libreoffice.org/33887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03compilerplugins: enable loplugin:cppunitassertequals by defaultMiklos Vajna
This forces writing a comparision of two variables in the CPPUNIT_ASSERT_EQUALS(expected, actual) form, rather than CPPUNIT_ASSERT(actual == expected). The benefit is when the test fail, it's more clear what are these two values, rather than just seeing that they are not equal. In the relatively rare case when the types are not streamable, the plugin can be silenced using CPPUNIT_ASSERT(bool(it == foo.end())). But please always first consider making the type streamable instead. See commit 0e1b831b93048c68735f2e2dbdcee587db4862ef (CppunitTest_vcl_complextext: fix loplugin:cppunitassertequals warnings, 2016-12-16) for an example. Change-Id: I564fb0724836b6dbbea9262b53ad646e285a339c
2017-02-03new loplugin unusedenumvaluesNoel Grandin
Change-Id: I03d684fc35238a45a6d99855e5ee6d3a5e33740d
2017-02-02Fix copy/move ctor checkStephan Bergmann
Change-Id: I2993d5809204098e29a7560d666fa1aafb024a89
2017-02-02loplugin:stringconstant, this should be a breakNoel Grandin
after commit dce867e8c4863c969eea3515a988630b74708a43 "loplugin:stringconstant handle calls to constructors with one arg" Change-Id: Ib572d904a95aa96aab3c799f9b7cfb505fcee5e6
2017-02-01More ctor check fixesStephan Bergmann
Change-Id: Ifcce63b975fb7c4ac7e7545e3eadcc6f7f12e466
2017-02-01Fix ctor checkStephan Bergmann
Change-Id: Ie261d5412c510c045b4d93a6bf1a3d4cf4371897
2017-02-01loplugin: use TypeCheck instead of getQualifiedNameAsStringNoel Grandin
since the latter is rather slow Change-Id: Ib73cdb923585580777c2265b561c1808e93b2baa Reviewed-on: https://gerrit.libreoffice.org/33585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>