summaryrefslogtreecommitdiff
path: root/compilerplugins
AgeCommit message (Collapse)Author
2016-11-08loplugin:oncevarNoel Grandin
Change-Id: I44fb6858eeff14fcbd9fdfbbb0aabd1433b6a27d Reviewed-on: https://gerrit.libreoffice.org/30668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04move loplugin:defaultparams to store/Eike Rathke
As per IRC 2016-11-04 12:21 Change-Id: Ic4cc7f67fb31be80a966c652cb30bb859f874a8b
2016-11-04-Werror=unused-functionStephan Bergmann
Change-Id: I33790862cfe40693921d07182ccf4645c3ef28a3
2016-11-04update loplugin:unnnecessaryvirtual to handler destructorsNoel Grandin
and update modules writerfilter..xmloff with the resulting changes Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c Reviewed-on: https://gerrit.libreoffice.org/30530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02loplugin:unusedfieldsNoel Grandin
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01disable this chunk of loplugin code on clang < 3.8Noel Grandin
not worth the spaghetti of making it work across version Change-Id: I0de923b16fb6d58cbad55adc9878ab39bc0c86ae
2016-10-31loplugin:vclwidgets: Adapt iterator hack to libc++Stephan Bergmann
Change-Id: I1e4fbb06578b2b1d6de4b57507693b014d36cd3a
2016-10-31No good reason for dbaccess::OCacheSet::updateRow to be pure?Stephan Bergmann
Most of its virtual member functions are (though insertRow is already a curious exception), even though they are defined, so smells like a copy/paste error rather than deliberate design. And appears to have been the only reason why loplugin:unnecessaryoverride filtered out such overriding of pure base functions. Change-Id: Ib2a40af9cd3cd3dbb26c4147f7d01de4e11f5f6e
2016-10-31fix unnecessaryoverride clang plugin on clang < 3.8Noel Grandin
Change-Id: Id78d694cf7271a6abf94234958ab623cf1cd93a5
2016-10-31update vclwidgets plugin to check local variablesNoel Grandin
Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22 Reviewed-on: https://gerrit.libreoffice.org/30428 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-30Rename ServerFont to FreetypeFontKhaled Hosny
This is what it is actually is, we dropped support for server-side fonts for a long time now. Renamed also a few related classes, but left ServerFontLayout* ones as they will go away soonish. Change-Id: I68a6dad51b6972368b7bf85a0b9c8089cc12740e Reviewed-on: https://gerrit.libreoffice.org/30390 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28Various loplugin warnings in --enable-telepathyStephan Bergmann
Change-Id: I4c437491466c3029f2a9c93fb630c7b5a8d2ff21
2016-10-21The badvectorinit plug-in probably can be retiredTor Lillqvist
Let's hope it only catches false positives now. noelgrandin agrees. Change-Id: Ibd8310c31897aa6835bd6aaf90a49b5cd8f92948
2016-10-20fix bug in expandablemethods pluginNoel Grandin
where using a std::map instead of a std::set meant that it sometimes miscounted the number of callsites Change-Id: I1e2ebcf44fe006827e66620ae4c9bbc813835414
2016-10-19Plugin::isInUnoIncludeFile should not cover WORKDIRStephan Bergmann
...that got in, for no apparent reason, when various, slightly different implementations of isInUnoIncludeFile got consolidated into one. Change-Id: I64a9eb62703d57a0b7b57720ec9f251ffa780691
2016-10-19accidentally left the expandablemethods loplugin activeNoel Grandin
Change-Id: Ifadab184876163195ea3307ec32d2eed4ee00b92
2016-10-19loplugin:expandablemethods in UnoControls..vbahelperNoel Grandin
Change-Id: Iec2c5e13119d97c9ca87e083c0f7cb00227e5231 Reviewed-on: https://gerrit.libreoffice.org/29997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18-Werror=unused-functionStephan Bergmann
Change-Id: I9e0585460d908024f75a1134bc1cd20d12ea3b4e
2016-10-18rename inlineablemethods plugin to expandablemethodsNoel Grandin
and add support for nested functions Change-Id: I63daee5b3047fa1ed5de0e5ddaf998f8b17bc780
2016-10-18loplugins: extract some common functionalityNoel Grandin
Change-Id: If470e1d9b481c9eda0829aa985152baf8fb46d7a
2016-10-18simplify inlineablemethods lopluginNoel Grandin
Change-Id: I72750a14664aa042da232c35cca3373ce367cfb0
2016-10-18some cleanups to the unusedmethods lopluginNoel Grandin
- publicDefinitionSet is unnecessary, the python post-processor does not need it - remove the traversing of templates, clang will do that for us since we have set the shouldVisitTemplateInstantiations() method Change-Id: I0e96dad0b1cc941fe6c4a2e9227e86d8c3f1d85a
2016-10-18new loplugin inlineablemethodsNoel Grandin
look for methods that are: (*) non-virtual (*) only called once (*) only called from inside their own class (*) small i.e. < 40 characters which are candidates for just having their code inlined Change-Id: I0e9e8125d140282cdcdd2a77374059b17b2fcd7d
2016-10-16clang::FileEntry::getName now returns StringRef on Clang masterStephan Bergmann
Change-Id: I94c9676e52a3c60ad70567396a8484e844176c6e
2016-10-14loplugin:mergeclasses merge TextView with ExtTextViewNoel Grandin
Change-Id: If7e11dd8f6b2cb6dc19c6aa3f7e50e2e88861eac Reviewed-on: https://gerrit.libreoffice.org/29828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14loplugin:mergeclasses merge SfxWorkWindow with SfxFrameWorkWin_ImplNoel Grandin
Change-Id: If6cab49904fdb044d85a4fd29f79faa7b52c9959
2016-10-14loplugin:mergeclasses merge SwTextAttrIterator with SwLanguageIteratorNoel Grandin
Change-Id: Iaa9184f6145625c897fa5b919e9bf0c898b41102
2016-10-14loplugin:mergeclasses merge SwComboBox with CaptionComboBoxNoel Grandin
Change-Id: Ieef8f00cb1f6f8fb62ad385d1085e8a63161a710
2016-10-14loplugin:mergeclasses merge SvxListBoxControl with SvxUndoRedoControlNoel Grandin
Change-Id: I5ba9c9d970246d80bb60e27e3b703ec03376c35c
2016-10-14loplugin:mergeclasses merge svx::ISlotInvalidator with svx::FmTextControlShellNoel Grandin
Change-Id: I828ef52bc093d3fa2946f813a2dd09ac6b34e94c
2016-10-14loplugin:mergeclasse merge ScCbWarningBox with ScReplaceWarnBoNoel Grandin
Change-Id: I7b55b036c1992b88b01b51053a3560e9f97986c9
2016-10-13loplugin:mergeclasses ImplEESdrWriter with ImplEscherExSdrNoel Grandin
Change-Id: Iea2241d9fc44b92e18101b3f367a643f03729183
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12typoStephan Bergmann
Change-Id: Iea55eee0e5e777e46bb02435f10bca03e554a15c
2016-10-12improve error message in refcounting pluginNoel Grandin
Change-Id: I02b483c1d696913b33112b9248747f9c3d28dc55
2016-10-11loplugin:constantfunctionNoel Grandin
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10Handle loplugin:fpcomparison false positives by whitelistStephan Bergmann
Change-Id: I58e2beb0695a27922856bd8f8988d9e4508aceb6
2016-10-09loplugin:fpcomparison, macOS reduxStephan Bergmann
Change-Id: Ie41be540209b4af7c0571f7c16bedd0665daff10
2016-10-09loplugin:badstatics: reliably look into std container typesStephan Bergmann
Change-Id: Ifca7325533e3f7d5ce5c59cc6b14d4232d4fc792 Reviewed-on: https://gerrit.libreoffice.org/29614 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-09loplugin:badstaticsStephan Bergmann
ScAddInListener has a member ScAddInDocs* pDocs; // documents where this is used where ScAddInDocs is set<ScDocument*>, and ScDocument has a memmber VclPtr<SfxPrinter> pPrinter; so that's only a chain of (apparently non-owning) pointers. Change-Id: I050218320eb2c588dcfaee80225f4e45a515ed32 Reviewed-on: https://gerrit.libreoffice.org/29613 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-07loplugin:staticmethods: Don't be fooled by decls starting with macrosStephan Bergmann
...like SAL_DLLPRIVATE coming from UNO include files. Change-Id: I9eb64c96b7e9e2a3742a166cedcf635d98fe65a0
2016-10-07loplugin:staticmethods: swStephan Bergmann
Change-Id: I2b06eb926ebc8ab04883da3272ea239a12e09436
2016-10-07loplugin:nullptr: remove duplicate warningsStephan Bergmann
Change-Id: I859d9ac8f7e4134bdac59b39e95eb563d1291e8b
2016-10-06loplugin:fpcomparison: also look into member functionsStephan Bergmann
By accident, the plugin had only looked into non-member functions until now. However, for the vast majority of newly found cases, it is unclear to me whether the relevant code needs fixing or not, so I put all those into a giant whitelist for now. Maybe the plugin's sginal/noise ration just isn't worth it, anyway. Change-Id: I7997a0ebdb4211af208285611656a40ead97d935
2016-10-05merge dbaccess::StorageInputStream with dbaccess::StorageXMLInputStreamNoel Grandin
Change-Id: I05b54b8a2fe4ff0c8b9f89e3d29e864e8665b7b8 Reviewed-on: https://gerrit.libreoffice.org/29519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-04merge sd::FuOutline with sd::FuOutlineTextNoel Grandin
Change-Id: Ie8191ac91175ba51f89809aaa53bc1ffacf42df0 Reviewed-on: https://gerrit.libreoffice.org/29520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-04loplugin:mergeclasses various fixesNoel Grandin
better tracking of templates, ignore more noise in the plugin so the python has less log to process Change-Id: I62874236d362529bd566140ac3fcc65e734fd62c
2016-10-03Fix typosAndrea Gelmini
Change-Id: Ie44267e7c9f92eb1920f05235826abff761251f1 Reviewed-on: https://gerrit.libreoffice.org/29430 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I6aeda978911b25caa45d4e459e581fc743e93d2c Reviewed-on: https://gerrit.libreoffice.org/29442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-25 22:06:10 +0000