Age | Commit message (Collapse) | Author |
|
Stumbled across such redundant visibility re-specifications when looking at the
odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in
cppu/source/cppu/cppu_opt.cxx and used in inline code in
include/com/sun/star/uno/Reference.hxx with only a declaration lacking
CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows.
However, this plugin is probably not worth it being run all the time, so
committing it to compilerplugins/clang/store/.
Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
|
|
...some paths trough clang::Expr::isIntegerConstantExpr (esp. if
non-CPlusPlus11) assert the assumption that the given expr is not
value-dependent, so it appears to be a prereq
Change-Id: Ibc5fe472ea3f91b31c8cb7f06c4b7c7f4d6831a3
|
|
Change-Id: Ie425af19019126b6a15ac03f52e32d186a46db35
|
|
...where SAL_OVERRIDE is not available
Change-Id: I49d447ba90516f4f744c21302607bff97ad3c4d5
|
|
...the worst kind of all
Change-Id: I6b98a324735a79ed9060003b491acce733f74f06
|
|
Change-Id: Iee78bd688ddb3e02deb1a3636d6a604838e97b09
|
|
Change-Id: If3b0f667b379b7973364c93be4b88347e5768223
|
|
Change-Id: I4dc6cc7f461fa11d12bf6fd9700befe4bbdac62c
|
|
Change-Id: I4035318d35d468fa93d4dcfe56f9b0434fd1dfe7
|
|
Change-Id: I7fa18403698530eec379589c76631f0aa367b215
Reviewed-on: https://gerrit.libreoffice.org/12991
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: Ie9d0b07a32cc17705db735ea18f70f28d57badd4
Reviewed-on: https://gerrit.libreoffice.org/12990
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: I1b782bb04b09bee5c3db2261f9390a7b2edf4564
Reviewed-on: https://gerrit.libreoffice.org/12967
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
(Original idea from Kendy)
Look for code that is calling std::find on a sorted container
(set/map/vector) and warn about it - the code should be using
the find method on the container itself, since that is considerably faster.
Change-Id: Ib74e5d3faa836eeb0df16a736d202696626bdfd2
|
|
...and is apparently a leftover from temporary debug output in
e36badb98d0bb5866a297cb51c3e95cdce62d8da "Fix workaround for bug in Clang 3.2
FunctionDecl::isInlined."
Change-Id: I3213981c5d236a7b67083014692566f75a2bcd51
|
|
Change-Id: Ia2b1bc97f3476da7bfbe659e5160cd5c73c01ce5
|
|
Change-Id: I8347010d5607dc2cbb113b33f1cb2cc78ec106d2
|
|
A plugin to warn about and rewrite null pointer constants that are not written
as nullptr (in C++11 code) resp. NULL (in C and C++03 code). It is not
activated for the following reasons:
* At least the call to
pImpl->aFmtNms.insert(pImpl->aFmtNms.begin() + nPos, nullptr);
in svx/source/items/clipfmtitem.cxx would require
<https://svn.boost.org/trac/boost/ticket/10540> "missing std::nullptr_t
support in boost/type_traits/is_pointer.hpp" to be fixed first.
* Additions of code that violate the plugin would probably be frequent, causing
unnecessary grief for those building with plugins enabled.
* It did not find anything interesting, apart from the above Boost bug and the
mildly interesting 1da153b617b80887680be65c1854ef8080c2e1c9 "Consistently use
APP_WRITER as an integer, never as a nullptr."
Anyway,
until make -O -j4 -k check; do make -O -j1 -k check \
COMPILER_PLUGIN_TOOL=nullptr UPDATE_FILES=all; done
sucessfully executed on a recent master and resulted in
6798 files changed, 60919 insertions(+), 60919 deletions(-)
Change-Id: I1260227949868e73fcb63fda13d83e79fde685d7
|
|
Change-Id: If6ee343bb4d4004e7a95fe1c5adc97210fc0abd0
|
|
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
|
|
This gerrit patch was apparently not ready yet for integration.
This reverts commit 44a432e9073b3d39b1bdd34b65cfd91d5541f324.
|
|
First stage of new VCL widget reference checker
Change-Id: I63a2108a26b3c0e0a896d13672b1daa6f8e60b3a
Reviewed-on: https://gerrit.libreoffice.org/10427
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: If9d85236177c819c159d1b836e806fc2b03da45c
|
|
Change-Id: I9b0b6affc60ae030b644fdd13eecfb1aed1f472a
|
|
Change-Id: I214a9745f27c27868b3e74785cf7138fc1db1943
|
|
Change-Id: I15c7f52c542549ad131400c9b5395a06a4777687
|
|
Change-Id: Ibf1d8c74dc8abb8c1fef59c53a8873cc426e2932
|
|
Change-Id: I45b323b326cc56cfc48e0abaa52d51fd86adbf79
|
|
It's boring and a waste of time to have to keep registering in
include/sal/log-areas.dox new log areas that other people have introduced.
We don't really have a uniform policy for logging anyway, so why bother trying
to enforce a such for the log areas? Anybody uses whatever log areas and log
output style and formatting they want in the code they happen to be working
on. And that's fine with me. We were supposed to be the project that avoids
unnecessary process, rules and bureaucracy, right?
Change-Id: I6bddcb56b58edcd885e5dc743c8730878de0036d
|
|
Change-Id: Ic2faece46bebea046eee984a0d53d9cd2892e0c9
|
|
We don't like C-style casts in our nice C++ code
Change-Id: I94e7ec90de9275cd6e20c4146d4f3a74bed93c9d
Reviewed-on: https://gerrit.libreoffice.org/10367
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: Id1ce6c59f705f9c42855995e0ad590c6a3646613
|
|
Change-Id: I0b7be1616a3e4206982f9f925de141ed9d53b96e
|
|
...where prior to r183883 "Implement core issue 903: only integer literals with
value 0 and prvalues of type std::nullptr_t are null pointer constants from
C++11 onwards," Expr::isNullPointerConstant with NPC_NeverValueDependent could
go into an llvm_unreachable case.
Change-Id: I29cf093f18ece4cd83fd759e30f72c2a71f69554
|
|
Change-Id: I00804b2dd63df44478a14a3eaf2fdcd4e4ce5d09
|
|
Broken in commit 1f078fcaddd45bb074e4d0a4933db01f6e8b623e
Change-Id: Ica93c3b9309b2ae4d973ccc34a84b5accac7472c
Reviewed-on: https://gerrit.libreoffice.org/10478
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
|
|
Change-Id: I2746abd05edd00dadfe613c17b9874b1035c3be4
|
|
Change-Id: Ib1f33387c50bcd853140eb2fc46995d23d7f367b
|
|
Change-Id: I63d00cf5ab1dac953fae07ca4eb4d987610551a2
|
|
Change-Id: I78a368ef2899b2462251b45a327fc7b1f31fe764
|
|
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
|
|
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
|
|
Change-Id: I4a6280f47ca3c4a77b4e42fe05d79ded7fc30ef1
|
|
to reduce copy-pasted code
Change-Id: I7728d85dea7d0161998c326d6648ca681a8250d0
|
|
Change-Id: Ic414ad0416e27e223ff702996b796b68d39709b9
|
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
Change-Id: I1bfdd865429cc6fa89ea3b6b4fc132b5d5b57b0d
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
Change-Id: Id46b391c09555c9ec30916fdd93b05455835d81b
|