summaryrefslogtreecommitdiff
path: root/configmgr/qa
AgeCommit message (Collapse)Author
2019-07-17tdf#42949 Fix IWYU warnings in configmgr/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iee703bad69bc3c47dc5960e560187ab1d1d9ff29 Reviewed-on: https://gerrit.libreoffice.org/72023 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-10Remove dead test codeStephan Bergmann
...that has been dead ever since d49bc78f22d7f7403f1f885f15b1d3dd2840cf0d "tdf#46723 - enable configmgr unit tests" Change-Id: Ie7f8e6dc669f66798364f907dab65afdfe4f63c0 Reviewed-on: https://gerrit.libreoffice.org/72104 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-19Some uses of C++17 class template argument deductionStephan Bergmann
Change-Id: I47c469c0fcdff41d83729be9489c946e81ef3686 Reviewed-on: https://gerrit.libreoffice.org/68020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-11Replace OUStringBuffer::appendCopy with append(std::u16string_view)Stephan Bergmann
...which is more general Change-Id: I94f28f8eda887120cf5f143b4549e0339b60e6a7 Reviewed-on: https://gerrit.libreoffice.org/66155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-14create appendCopy method in OUStringBufferNoel Grandin
so we can avoid temporary copies when appending a substring of an OUString to the buffer. I would have preferred to call the method just "append" but that results in ambiguous method errors when the callsite is something like sal_Int32 n; OUStringBuffer s; s.append(n, 10); I'm not sure why Change-Id: I6b5b6641fcb5b26ce2269f89ef06e03c0b6aa76f Reviewed-on: https://gerrit.libreoffice.org/58666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-15use more SAL_N_ELEMENTS part 3Noel Grandin
Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623 Reviewed-on: https://gerrit.libreoffice.org/38789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:cppunitassertequals: configmgrStephan Bergmann
Change-Id: I02d54c1eee815e7c6575a8131d59974089299bdf
2017-03-30data.xcd dead after tdf#46723 - enable configmgr unit testsNoel Grandin
Change-Id: I04fc155f344e15d5bff17cdc42815e7afb14bd38 Reviewed-on: https://gerrit.libreoffice.org/35891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17cleanup double includes and declarationsJochen Nitschke
Change-Id: I770e09f48b1a3e8299f59a8e475ba3c18d436d7b Reviewed-on: https://gerrit.libreoffice.org/35312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-02-09tdf#105447 Move accelerator to first letters in Help menuYousuf Philips
Change-Id: I14088435228a989cb388cb9e205dc7fcd3fbbfa9 Reviewed-on: https://gerrit.libreoffice.org/33646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-03makeAny->Any in canvas..configmgrNoel Grandin
Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e Reviewed-on: https://gerrit.libreoffice.org/33869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-21Kill the AutoPilotPresentations UNO commandGabor Kelemen
The presentation wizard was removed in bb8040595c9b6f0ccde39e6833f27a50abb891d8 but the corresponding UNO command is still available. Change-Id: I54e676672bb53d0283394a0ebffbe9f94f29d9c0 Reviewed-on: https://gerrit.libreoffice.org/30983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-28tdf#95386 Remove remains of .uno:HelperDialogGabor Kelemen
Change-Id: Id131de5bf2b97a35fc67258fe5029fad0b4edf5e Reviewed-on: https://gerrit.libreoffice.org/29352 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-05configmgr: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: I19e197db4158939875fab0d9e51d903aa1671b37 Reviewed-on: https://gerrit.libreoffice.org/27893 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15tdf#61396 Possibility to edit a template not in Template RepositoryAkshay Deep
Menu Sequence: Open Template... Save as Template... ---------------------- Manage Templates Change-Id: I0d0c8ca15d8dc38662e7f84a4f598933c13dd512 Reviewed-on: https://gerrit.libreoffice.org/26179 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-05-31tdf#91781 A round of minor tweaks to Writer's menusYousuf Philips
Change-Id: I0c37f9e0349af0cd9dc41c500543da7532fb9198 Reviewed-on: https://gerrit.libreoffice.org/23976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-05-03Remove Edit -> Plug-in as no longer usedBryan Quigley
This functionality seems to only have been used with NPAPI plugins. They've been previously removed. Per the help text, if it is still used by anything, you can use the context menu instead. MN_READONLY_PLUGINOFF also appeared to be unused, so removed. More code might be removable, but would affect activate on click/visible. Change-Id: I12d5bf54edd3a2f716912179b87e798b47b3cc3d Reviewed-on: https://gerrit.libreoffice.org/24500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-08tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-02tdf#70998 Termchange: Graphic/Picture->Imageakki95
Changed visible terms as required. Change-Id: Id4335629977aa8512c753241d7c2203820716b73 Reviewed-on: https://gerrit.libreoffice.org/21857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-12-30Kill remaining plugin bitsMaxim Monastirsky
Change-Id: Icd99757b48626ef43313e8de42c4e5462f85a958 Reviewed-on: https://gerrit.libreoffice.org/21008 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-12-23loplugin:unusedfields in chart2Noel Grandin
Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
2015-11-06loplugin:stringconstant: elide explicit ctor usage (manually due to macros)Stephan Bergmann
Change-Id: I409ea5a7e4b6a8e2886d5b489b66b217b3be58b6
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: Iab64ec9b325da65b90d79f3c986e97774825f6e2
2015-11-04yyyyyNoel Grandin
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296 Reviewed-on: https://gerrit.libreoffice.org/19704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-09Create a wrapper to make listening for configmgr changes easy.Michael Meeks
Change-Id: Ib58d04f9e046e604b24e0e338796a7a60aa1d6fd Reviewed-on: https://gerrit.libreoffice.org/19253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-02configmgr: remove unused old dmake fileMiklos Vajna
Change-Id: Idbeadeaebf85c9de84d6fafe4d140c77907c0eeb
2015-07-13tdf#92639: Slashes are allowed in set member names, of courseStephan Bergmann
Change-Id: I30944fe9611e83566c891a7d1461ad02979daddd
2015-07-13tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, in configmgr. Change-Id: I0cf82ab487ed879aa385d6065e908e347c0778e8 Reviewed-on: https://gerrit.libreoffice.org/16964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-07Validate names of elements added via the APIStephan Bergmann
Change-Id: I052f8ca6a8788665acb1bf87456f7cc67d64c365
2015-02-12coverity#1269597 Uncaught exceptionCaolán McNamara
and coverity#1269596 Uncaught exception Change-Id: I0466e66cd33dd842296131f73376bc95308254e4
2015-02-11loplugin:unreffunStephan Bergmann
Change-Id: I6cfa63043460a5776873087c62cfbb2753c88f83
2015-02-11tdf#46723 - enable configmgr unit testsRadu Ioan
Known limitation: Disabled testThreads because it fails on writerThreads libreoffice/configmgr/qa/unit/test.cxx:500:(anonymous namespace)::Test::testThreads assertion failed - Expression: success Some exception is catched for some writerThread Change-Id: I5b891bec25599c4536827ffa7ea514b1cdf08b46 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-04line spacing: Change the implementation so that it can be used in toolbars.Jan Holesovsky
Before it was only sidebar-specific, duplicating most the sfx2 framework, and making it impossible to be used from the toolbars. Change-Id: Ibb382633395157602dd806052824e5275503c3e0
2014-10-22Bin unused version.map fileTor Lillqvist
Change-Id: Ic0efcf61e43864d531721474540ec138033bffe6
2014-10-22WaE: overriding virtual function declaration not marked 'override'Tor Lillqvist
CppunitTest_configmgr_unit fails, though, so I did not uncomment it in Module_configmgr.mk. Presumably one would need to look in the old configmgr/qa/unit/makefile.mk to find out how to run it. Change-Id: Id368fd94076f873bfdd34f1829d6a009daa7fa84
2014-10-22WaE: Unreferenced function definitionTor Lillqvist
Change-Id: I3364da59679875c21691fa758578fd871e359956
2014-10-17SID_TOGGLE_MENUBAR (aka slot:6661, .uno:MenuBarVisible) is deadStephan Bergmann
...since introduction of XLayoutManager's private:resource/menubar/menubar in 3fb2acf5b77bff59909f616c44c7de17048b64d7 "INTEGRATION: CWS layoutmanager (1.52.10); FILE MERGED" etc. and final removal of SID_TOGGLE_MENUBAR bits in f605b16e395e8ccc3d1aba7907b0792039016f69 "INTEGRATION: CWS sfxcleanup (1.119.8); FILE MERGED" etc. What still needs fixing are extensions/source/activex/SOActiveX.cxx odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java odk/examples/OLE/activex/SOActiveX.cpp in a similar way as e.g. 0273d3d81d29d5c1f6c387cca633cd99722c100e "INTEGRATION: CWS jl18 (1.6.8); FILE MERGED." Change-Id: I52a43fc7186a4f60929ab6246a2da2e715be7510
2014-08-18remove dead ToolBox RID_HELPBARThomas Arnhold
Change-Id: Ide31f67c346f9a82bf6aa8282caa7cfcee65d9fd
2014-07-21fdo#80536 UI: Menu entry for 'Edit File' -> 'Edit Mode'Joren De Cuyper
In this commit not only a menu entry is created, also the name is changed from 'Edit File' to 'Edit Mode'. Change-Id: Icd7998307cb0337dd2ee95b298452557ab37375b Reviewed-on: https://gerrit.libreoffice.org/10211 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-28fix-includes.pl: configmgrThomas Arnhold
Change-Id: Ica1dc0c8003203ba0ea65a668ea3d86f341ad05d
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-09-10configmgr: cleanup unit test pieces.Michael Meeks
Change-Id: I3d849a1676c638d431a15672c5a7253b70f4e610
2013-09-10fdo#46723 enable configmgr unit testsJelle van der Waa
Change-Id: Id2a10374d207fc079093cdb9a78ac30171251e46
generated by cgit (git 2.34.1) at 2024-12-26 17:39:44 +0000