summaryrefslogtreecommitdiff
path: root/configmgr/source/readonlyaccess.cxx
AgeCommit message (Collapse)Author
2024-05-07loplugin:ostr in configmgrNoel Grandin
Change-Id: If1caaee8e54b5861e1435e900b3ae7bd90ecae5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167237 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2023-06-18Use getXWeak in configmgrMike Kaganski
Change-Id: Ia7d9475cecd2208ccf672f2b35c0c841fed7f4dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150840 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-02osl::Mutex->std::mutex in configmgr::read_only_access::ServiceNoel Grandin
Change-Id: Ia92bb76cedb45d2c28482d34869e239cfdd32ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-23clang-tidy modernize-pass-by-value in configmgrNoel Grandin
Change-Id: If2e69c04e4d72ec6911fb435092275dbfffbf991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-22Revert "simplify locking in configmgr"Noel Grandin
This reverts commit 7f7dad7018c874542e0ab6a0fb0f05f21d112b53. And add some comments to the definition of the lock, to make it purpose obvious. Change-Id: Ib1a0b6345efab0febe9191341ce264c8d6070932 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-22simplify locking in configmgrNoel Grandin
if we are going to have a shared lock, just use the instance of the shared lock instead of taking a shared_ptr to it. Change-Id: I00f74815426fcf971ff8e12734fc4566aa6ad5f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-10Drop 'static_cast<cppu::OWeakObject*>' syntactic noiseMike Kaganski
... where the object is created in-place, and its type is known Change-Id: Ifabfcf2f3ad0d60152f14e8d970c1faa42115288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112256 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-06configmgr: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I8d1419a9f2c0eb4d488b3f60b357f12e8177d7b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15clang-tidy modernize-concat-nested-namespace in codemaker..configmgrNoel Grandin
Change-Id: I48452480fae169e11d60b125bbd0226b6a35a25c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-02Revert "no need to use shared_ptr here"Noel Grandin
This reverts commit 122598af564082786f01b4eafdb9f09f0cffdf5f. Reason for revert: shared_ptr was introduced for fdo#31494, to avoid issues during shutdown Change-Id: I1c3ef4a966b9244da1e504806e917d1918b83803 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86095 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-24no need to use shared_ptr hereNoel Grandin
when we are really just sharing a single global lock object Change-Id: I30d6f4cbd30cb7ee849f20a6c15615a94f67d7d8 Reviewed-on: https://gerrit.libreoffice.org/85768 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): configmgrStephan Bergmann
Change-Id: Ie82faef06ea13d1a0d3007915334822d3f4f94e3 Reviewed-on: https://gerrit.libreoffice.org/76690 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-17tdf#42949 Fix IWYU warnings in configmgr/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iee703bad69bc3c47dc5960e560187ab1d1d9ff29 Reviewed-on: https://gerrit.libreoffice.org/72023 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2015-11-09new loplugin: oncevarNoel Grandin
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-07-13tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, in configmgr. Change-Id: I0cf82ab487ed879aa385d6065e908e347c0778e8 Reviewed-on: https://gerrit.libreoffice.org/16964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-16boost::noncopyable->'= delete'Caolán McNamara
Change-Id: If0f898a1e912fcd2095d8ba88b2b8046596e16ea
2014-05-28fix-includes.pl: configmgrThomas Arnhold
Change-Id: Ica1dc0c8003203ba0ea65a668ea3d86f341ad05d
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-01-08Fix some configmgr XServiceInfoStephan Bergmann
Change-Id: I208f5892f6fb54d53ed4d17ddb189f0a24051a17
2013-11-21Some more adaptions to cppu::supportsServiceStephan Bergmann
Change-Id: I0fa482b3303f339afabf5ed8f3e432b56c6590aa
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2012-12-11rtl:: prefix removal from configmgrRadu Ioan
- removed rtl:: prefix - removed RTL_CONSTASCII_USTRINGPARAM - corrected some misspells Change-Id: I88bb0beec718a7fe38c61220aa61401419f23b42 Reviewed-on: https://gerrit.libreoffice.org/1291 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2012-11-30c++ API: use css alias in generated headers, adds global css declThorsten Behrens
This changes all generated API headers (.hpp and .hdl) to use a namespace alias 'css' instead of the pointlessly long com::sun::star Makes the change in cppumaker & associated tools, adds a global namespace alias definition in sal/types.h, and removes a kiloton of local, now pointless-to-harmful versions of that alias from all over the code. Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-07-25Make comphelper/configuration.hxx work for localized propertiesStephan Bergmann
See aebf5bf22304c73e121b16dc0b51f909c5f34c28 "fdo#52232 ConfigurationSet wrapper unusable for localized properties" for a discussion of the problems with the original design. 1 Redesigned configmgr's localized property access to understand ['*<locale>'] paths that select the best existing value match for the requested <locale>. Adapted ConfigurationWrapper::getLocalizedPropertyValue accordingly. 2 Redesigned ConfigurationChanges to fix the locale at instantiation time. That takes care of ConfigurationWrapper::setLocalizedPropertyValue, ConfigurationWrapper::getGroupReadWrite, and ConfigurationWrapper::getSetReadWrite. (This required an additional constructor parameter for the ReadWriteAccess service, to specify a locale at instantiation time.) 3 Redesigned ReadOnlyAccess to be a service that fixes the locale at instantiation time. That allows to take care of ConfigurationWrapper::getGroupReadOnly and ConfigurationWrapper::getSetReadOnly. Change-Id: I2ae7342b278b6f4222a0189a1deb2a53e204059f
2011-12-13Simplified, type-safe C++ configuration access.Stephan Bergmann
* New offapi com.sun.star.configuration entities to access the complete configuration read-only or read/write... * ...configmgr adapted to support those new services/singletons... * ...new unotools/configuration.hxx is the type-safe C++ plumbing on top of that... * ...officecfg now generates C++ headers to access all the properties and sets given in the .xcs files... * ...and svl's asiancfg.cxx exemplarily makes use of the new officecfg/Office/Common.hxx to access the configuration. * There is still TODOs: For one, see those listed in officecfg/registry/cppheader.xsl. For another, at least a notification mechanism for the new read-only configuration access and the C++ wrapper is missing.