summaryrefslogtreecommitdiff
path: root/configmgr
AgeCommit message (Collapse)Author
2015-03-11V668 no sense in testing the result of new against nullCaolán McNamara
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-02-16incomplete type error under some compilersCaolán McNamara
Change-Id: I87740d4d035bc4e430d566f4672bfd338511d3a8
2015-02-16restore dependenciesCaolán McNamara
Change-Id: I20645122bc80d729093dff8d1a8094c6fbf7d68a
2015-02-16boost::noncopyable->'= delete'Caolán McNamara
Change-Id: If0f898a1e912fcd2095d8ba88b2b8046596e16ea
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-12coverity#1269597 Uncaught exceptionCaolán McNamara
and coverity#1269596 Uncaught exception Change-Id: I0466e66cd33dd842296131f73376bc95308254e4
2015-02-11loplugin:unreffunStephan Bergmann
Change-Id: I6cfa63043460a5776873087c62cfbb2753c88f83
2015-02-11tdf#46723 - enable configmgr unit testsRadu Ioan
Known limitation: Disabled testThreads because it fails on writerThreads libreoffice/configmgr/qa/unit/test.cxx:500:(anonymous namespace)::Test::testThreads assertion failed - Expression: success Some exception is catched for some writerThread Change-Id: I5b891bec25599c4536827ffa7ea514b1cdf08b46 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-02-10cppcheck: assertWithSideEffectCaolán McNamara
Change-Id: I6601e857394d7b460a105e851529350a62d1a2a6
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2014-12-16configmgr: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I7345234957aab62e884c0e884ac0b3b8a21e9cc5
2014-12-05Revert "Log parsing time of each xcd file"Stephan Bergmann
This reverts commit ca85c87bf66d15e689cb09daf5dab5c4467046bc, c57fb9ea459f08c33a4b8c129938411a59a19b77 "Use xmlreader::XmlReader::getUrl" was meant for real.
2014-12-04Log parsing time of each xcd fileTor Lillqvist
Change-Id: I290e2c84b17b9b5063139c6027b72f6cd3a78a99
2014-12-04SAL_INFO how long parseXcsXcuLayer() and parseResLayer() tookTor Lillqvist
Change-Id: I1e71b8a6348301cd5b3fed0ae8b3346ae3e07d8e
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-04line spacing: Change the implementation so that it can be used in toolbars.Jan Holesovsky
Before it was only sidebar-specific, duplicating most the sfx2 framework, and making it impossible to be used from the toolbars. Change-Id: Ibb382633395157602dd806052824e5275503c3e0
2014-10-24Use xmlreader::XmlReader::getUrlStephan Bergmann
Change-Id: Idd59fd1324615e575ed812e0c2a7cdfd84a9aeb2
2014-10-24Beware gb_CppunitTest_use_library_files plus gb_CppunitTest_use_componentStephan Bergmann
...it causes the library's objects to be loaded twice, causing potential trouble with static data. So introduce gb_Cppunit_set_componentfile, processing the library's source component file into an additional workdir/CppuntiTest/ component file referencing the test library. (This required to drop the gb_Helper_abbreviate_dirs bric-a-brac, as it would do $W replacement into file URLs contained in the resulting .component file.) Change-Id: I57847e549817d25cca53a13effd7d408e0c99f9a
2014-10-23Log parsing time of each xcd fileTor Lillqvist
Change-Id: I290e2c84b17b9b5063139c6027b72f6cd3a78a99
2014-10-22Bin unused version.map fileTor Lillqvist
Change-Id: Ic0efcf61e43864d531721474540ec138033bffe6
2014-10-22WaE: overriding virtual function declaration not marked 'override'Tor Lillqvist
CppunitTest_configmgr_unit fails, though, so I did not uncomment it in Module_configmgr.mk. Presumably one would need to look in the old configmgr/qa/unit/makefile.mk to find out how to run it. Change-Id: Id368fd94076f873bfdd34f1829d6a009daa7fa84
2014-10-22WaE: Unreferenced function definitionTor Lillqvist
Change-Id: I3364da59679875c21691fa758578fd871e359956
2014-10-20Revert "fdo#75757: remove inheritance to std::map"Stephan Bergmann
This reverts commit a2deca9d755710bd543fd0caaea0352ac746396d: config_map had been introduced on purpose with bfb978334cea775b8ae5c40ceea050ea0660d80a "configmgr: faster / simpler compare for keys." Change-Id: I3ae0edc4d23977c6537bd2f462f90a702266de6d
2014-10-20fdo#75757: remove inheritance to std::mapDaniel Sikeler
Change-Id: I189d7a1d68eb9022a32e882d68ce8c8dc567c1fd Reviewed-on: https://gerrit.libreoffice.org/12042 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-10-17SID_TOGGLE_MENUBAR (aka slot:6661, .uno:MenuBarVisible) is deadStephan Bergmann
...since introduction of XLayoutManager's private:resource/menubar/menubar in 3fb2acf5b77bff59909f616c44c7de17048b64d7 "INTEGRATION: CWS layoutmanager (1.52.10); FILE MERGED" etc. and final removal of SID_TOGGLE_MENUBAR bits in f605b16e395e8ccc3d1aba7907b0792039016f69 "INTEGRATION: CWS sfxcleanup (1.119.8); FILE MERGED" etc. What still needs fixing are extensions/source/activex/SOActiveX.cxx odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java odk/examples/OLE/activex/SOActiveX.cpp in a similar way as e.g. 0273d3d81d29d5c1f6c387cca633cd99722c100e "INTEGRATION: CWS jl18 (1.6.8); FILE MERGED." Change-Id: I52a43fc7186a4f60929ab6246a2da2e715be7510
2014-10-02coverity#707682 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1230c42c76aee4e9a2a149a27ef11e163753865a
2014-08-18remove dead ToolBox RID_HELPBARThomas Arnhold
Change-Id: Ide31f67c346f9a82bf6aa8282caa7cfcee65d9fd
2014-08-13update_pchThomas Arnhold
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-07-21fdo#80536 UI: Menu entry for 'Edit File' -> 'Edit Mode'Joren De Cuyper
In this commit not only a menu entry is created, also the name is changed from 'Edit File' to 'Edit Mode'. Change-Id: Icd7998307cb0337dd2ee95b298452557ab37375b Reviewed-on: https://gerrit.libreoffice.org/10211 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-08configmgr: fix node cache clearing.Michael Meeks
Change-Id: Idd6c227b8f50446c1d3c48385de6c843faf47466
2014-07-08WaE: Unreachable codeTor Lillqvist
Not sure if the intent is that clearCache() should be called, but the calls have just accidentally been placed after the return statements, or whether the code works correctly and as intended as it is now, i.e. with the unreachable calls to clearCache(). Warning emitted by VS 2013, why don't other compilers warn? Perhaps these functions are never called? Change-Id: I16b0bc1b836753ef5579dadba211cbce4f50cbc3
2014-07-02Make configmgr loplugin:salbool-cleanStephan Bergmann
Change-Id: Ib1f33387c50bcd853140eb2fc46995d23d7f367b
2014-06-30configmgr: faster / simpler compare for keys.Michael Meeks
A surprising amount of time is/was spent comparing keys in the std::map red/black tree traversing nodes. Since we don't need the data truly sorted, instead sort in length buckets. Kills 90k rtl_ustring_compare_withLength calls on startup, around 0.9% of headless start. Change-Id: Ib23aff151ad50d56bbf2ba3e28882cc81898d9ec
2014-06-28configmgr: accelerate getPropertyValue.Michael Meeks
Change-Id: Ie0460c8db6b1e7fcc9bab1f5e9ae1fbd00987994
2014-06-28configmgr: accelerate simple config key fetches.Michael Meeks
Avoid heap allocating UNO object wrappers for the underlying Node structures only to convert to Any and immediately free them agian when we can. Change-Id: Iae4612e9602f872f5d8cca2e516df594c9f1118c
2014-06-28configmgr: implement a single item cache for node lookup.Michael Meeks
Saves 13.5m cycles on a headless start, 1.3%. Change-Id: I73f0dd8a523f84c765a217ee95aea9bcc3db1b5d
2014-06-28configmgr: re-factor findNode and clone into NodeMap.Michael Meeks
Change-Id: Ib170b3cec17402e38bf5555e21f83f44d70bb574
2014-06-28configmgr: hide NodeMap implementation.Michael Meeks
Change-Id: I57c81b5ec7a6541a825e42f9b68e7c5fa98f316f
2014-06-28configmgr: avoid constructing duplicating and freeing Any'sMichael Meeks
Accelerates headless startup by 6.5m cycles or so, 0.6% or so but something. Change-Id: I9edca3d0c1c81d865e8369fee5cf193da7adb97c
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-28update_pchThomas Arnhold
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-28fix-includes.pl: configmgrThomas Arnhold
Change-Id: Ica1dc0c8003203ba0ea65a668ea3d86f341ad05d
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-22update_pch: add configmgrThomas Arnhold
Change-Id: I74f1a032ebce8e4fa13d4afd7f520bbb367b2df5
2014-05-09There is no css::uno::Sequence<bool>Stephan Bergmann
This partially reverts 78b9537b6aca0f998f939988e6e1a56528d28baf "various: sal_Bool->bool." Change-Id: I732b2fb2cca3e66b396a35645f12ae96a40163d5
2014-05-08various: sal_Bool->boolNoel Grandin
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
2014-05-06Avoid using incomplete types with std containersStephan Bergmann
...which is explicitly supported by Boost.Container though, but we cannot use boost::container::map here as Boost.Container is only available since Boost 1.48 and our base is 1.47 still. However, there appears no need for Children to be sorted, and std::unordered_map (and thus boost::unordered_map) requires that pointers to elements are not invalidated by insertions, which we do require. Change-Id: I70ad6f40318d2bafae53ebb67d84c1c89a7d68f6