Age | Commit message (Collapse) | Author |
|
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
|
|
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
|
|
Change-Id: I5e405ec2689000c973cf8ff1f86c1c2d6202eda9
|
|
Change-Id: I8115fb899e4248e6eab1aa9349456103353918e6
|
|
Change-Id: I960aa77ce107c4f02f1e331cda07b75435beed5d
|
|
Change-Id: I3abf410e7235b8dd1d126a3c8705e3ef9722e93b
|
|
Change-Id: I3f9c98d235d1bd5155653c6a56b757393bca2979
|
|
Change-Id: I88796c85447571d446c398439066029c3a200b4b
|
|
Change-Id: I763dc95a393bf296a7f3f5ce2a739f175fd528fb
|
|
...it avoids false warnings about unchecked dynamic_cast results from static
code analyzers, and potentially makes the code a little faster, too. (Most of
these dynamic_casts were kind of a leftover from a very early design that
dispateched on Node type via dynamic_cast instead of a Node::Kind, but which was
much too slow.)
Change-Id: I8db08a1c35783f8ea6c51eed55b11faa2d958807
|
|
This reverts commit 753eeac8a641d70ad0c44bb15fa8949ac991f5d9, which added bogus
if (... != 0)
checks after dynamic_casts that cannot fail, making the code now look as if it
was expected that those casts can fail and the code is prepared to handle it
(which it is not). Silencing the false coverity reports will be addressed in a
follow-up commit.
(That commit unfortunately mixed those changes with mass cosmetic changes.)
|
|
Change-Id: I24b38b63d26bc2d4e1d479754120dfd5b5635737
|
|
Change-Id: Id9c8c3926f64826fd2295e0f75f007ce435f5915
|
|
Change-Id: I208f5892f6fb54d53ed4d17ddb189f0a24051a17
|
|
...for internal loader="com.sun.star.loader.SharedLibrary" components, instead
of exported component_getImplementationEnvironmen (or implicit
CPPU_CURRENT_LANGUAGE_BINDING_NAME). Adapted a few .component files as proof-
of-concept, more to follow.
Change-Id: I82332e0a48e6fc1da245990bb72265fe6e58447e
|
|
because Expert Config is no longer a leaf in option page tree,
it became a standalone window.
Change-Id: Ib82b5eb958073d1afbd9ad2b8493e2670dee591b
|
|
Convert code like
if( !aStr.isEmpty() && aStr[0] == 'x' )
to
if( aStr.startsWith("x") )
Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
|
|
Change-Id: If7019fc334c0f11fae464b65c135d01acfb1a46b
|
|
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: I wonder why I originally
introduced State::locked in addition to State:ignored in the first place, but
can't find a good reason for that now. So the patch looks ok, though it could be
further simplified to completely get rid of State::locked. Will do that in a
follow-up commit.
Change-Id: If07a07b21effbf42918408a0b60b2d18bdc8665c
|
|
Change-Id: If0b413a4fdd93465074548c7ea5451288c1d12aa
|
|
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.
Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
|
|
Change-Id: I0fa482b3303f339afabf5ed8f3e432b56c6590aa
|
|
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
Change-Id: I4c688a4aeedcae56ed6404574bd1bb392d4190cb
Reviewed-on: https://gerrit.libreoffice.org/6311
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I0c7ae8e0393f069259b943e04368e874abdf8386
|
|
to use cppu::supportsService and other pieces.
Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...as there are many cases where the code later wants to obtain this part, and
esp. for the string literal variants it is awkward to calculate the length of
the literal again if this is coded with a following copy() call. Adapt some
code to use this new feature.
(Strictly speaking, the @since tags for the---backwards-compatibly---modified
functions are no longer accurate of course. Also, clean up some sal_Bool and
SAL_THROWS(()) that are unnecesssary cargo-cult here, and where the clean-up
should have no practical compatibility consequences.)
Change-Id: I43e5c578c8c4b44cb47fd08f170b5c69322ad641
|
|
Change-Id: Ib0cac79b86ed60b4df1fc90db15842cc99abc1e9
|
|
Change-Id: I9cc4472b37d24e426a67661806805c11b521dfb1
Reviewed-on: https://gerrit.libreoffice.org/6074
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
...thanks to Andras for pointing me to the problem
Change-Id: I98786e8fe3159426b7e4c8b5345be500be2fc87b
|
|
Change-Id: I672077a2096cc51e7a3668f5873a91299fd00ca1
|
|
Change-Id: I3d849a1676c638d431a15672c5a7253b70f4e610
|
|
Change-Id: Id2a10374d207fc079093cdb9a78ac30171251e46
|
|
...post 5a02076358a547bae8a9b596d9722a7cd2d46c34 "Windows registry configuration
backend."
Change-Id: I4d27c17d4f26254bce175910a76f0076639581e8
|
|
The goal is to manage LibreOffice configuration centrally
in the enterprise. In Windows Server environment using
Group Policies is a common solution for configuration
management. Therefore it is required that LibreOffice can
read configuration data from Windows registry, too.
Windows registry is another configuration layer on the
top of normal xml based configuration.
For example the following registry setting:
[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\LibreOffice\org.openoffice.UserProfile\Data\o]
"Value"="Example Corp."
"Final"=dword:00000001
becomes the following in configuration:
<item oor:path="/org.openoffice.UserProfile/Data">
<prop oor:name="o" oor:finalized="true">
<value>Example Corp.</value>
</prop>
</item>
Change-Id: I2cdd83fc93922bf2806417bfd1b83f85cc926d4c
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
|
|
Change all instances of hardcoded "program", "share" etc subfolder names to
use those from <config_folders.h> instead. In normal builds, the end result
will not change.
Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
|
|
Change-Id: I90854a061d3b51537669365f7a28a0fabe3dac2b
|
|
Change-Id: Ieb5d4a1d669e0472ec08704c618a9d9c1d30b77f
|
|
...now that the original RTL_LOGFILE_TRACEs got replaced.
Change-Id: I0997d6bbb90a22678fdc6398e7786ac36b9d73f4
|
|
Change-Id: I9c2405f92aea75756a0fbac7844ff16319210be3
Reviewed-on: https://gerrit.libreoffice.org/5014
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
If no LanguageTag instance is at hand use the static methods to convert
between BCP 47 string, Locale and MS-LangID instead of creating
temporary instances.
Change-Id: I9597f768078eb81c840e84a5db5617f26bb7dc09
|
|
...the direct-initializations were introduced with
032d5126e41562917b91b8f4826b0be628169968 "cppcheck: fix some uninitMemberVar in
configmgr part," presumably to avoid false positives from static analysis tools.
But the initializations are redundant, as the invariants of the affected classes
imply that the members have meaningful values at their points of use. And the
direct-initializations with arbitrary values make it harder for a maintainer to
understand the relevant invariants, namely to ensure the members must have been
assigned /meaningful/ values by the time they are used. Give a (subtle) clue by
making those into value-initializations.
Change-Id: Iadb25fa08b6d6b12d5bf8a8f04271270b6a7f7cb
|
|
Change-Id: I5ff293b2e06fe5891487616fcfba510e46acebfd
|
|
Change-Id: I9b18f033c46e16cf75cc513d00712c40bfddda14
|
|
Change-Id: Ifab7cef3e883bc10632ac280ca382b2c68bc79e1
Reviewed-on: https://gerrit.libreoffice.org/4317
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
|
|
...which has become necessary since bd60d41176da540b01d7583cfe00637431967f39
"Handle oveflow in O(U)String::toInt() functions" reduces values in the range
(SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied
on getting a correct (unsigned) value for the whole input range ["0" ..
"FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3
"Revert overflow checks in O[U]String::toInt{32,64} again").
Audited all uses of toInt32/64 with non-decimal radix. (There is still a TODO
comment in oox/source/helper/attributelist.cxx, and
stoc/source/typeconv/convert.cxx will still need some love and test code.)
Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
|
|
Change-Id: I108882af13fa97fa094547ec4efb468f988f337d
|