summaryrefslogtreecommitdiff
path: root/connectivity/qa
AgeCommit message (Collapse)Author
2019-08-01mysqlc: Add test for textual blob typesTamas Bunth
Test setting and querying the following data types: TINYTEXT, TEXT, MEDIUMTEXT, LONGTEXT Test them using prepared statements. Change-Id: I43387034ad8c32c3731cde70a22cc8b3dd652b78 Reviewed-on: https://gerrit.libreoffice.org/76747 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-07-29mysqlc: Fix query of cursor position in result setTamas Bunth
Fix queries like "IsAfterLast" in result sets of prepared statements in the mysql driver. Cursor position is stored in the driver, since the mysql C driver does not support the query of the cursor position. The cursor position works the following way: - 0 means the cursor is on "BeforeFirst". In that state calling of getXXX() methods is user error. - 1 means the first row is already fetched. - n means the last fow is fetched, where n is the total number of rows in the result set. - Everything bigger than n is "AfterLast" Change-Id: I131f2042606897019cc0f868dbc4151faf4850ac Reviewed-on: https://gerrit.libreoffice.org/76549 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-07tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN and add some unit tests to ensure the implementation works and the replacements don't introduce some side effects. Change-Id: I4ed50eee53e4dba4d392ed2486186d48f919ce1d Reviewed-on: https://gerrit.libreoffice.org/71712 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-25mysqlc: Allow conversions between different typesTamas Bunth
Change-Id: I54c1f438a755267db0896637c79f915de9113f83 Reviewed-on: https://gerrit.libreoffice.org/71074 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-12tdf#42949 Fix IWYU warnings in include/connectivity/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221 Reviewed-on: https://gerrit.libreoffice.org/68893 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-29mysqlc: fix timestamp query of result setTamas Bunth
Also add test for inserting and reading timestamp values. Change-Id: I2ba997c438f4e33965b0fe0602e58eddeff38b01 Reviewed-on: https://gerrit.libreoffice.org/67066 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-22mysqlc: resultset's previous() on first position..Tamas Bunth
.. should move the cursor backwards to beforeFirst position and return false. Change-Id: Icbb4bed0ea39ea3a0bf375d5616e3ef768fc69d9 Reviewed-on: https://gerrit.libreoffice.org/66729 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-04mysqlc: Fix result set metadata related issueTamas Bunth
In order to allow fetching result of multiple result sets at time same time, all the data is fetched and copied on demand from the mysql result set. The mysql result set (MYSQL_RES) is freed afterwards. That means we need a copy of the meta information as well. Now all the meta data is stored in the driver for each result set, so it does not depend on the MYSQL_RES structure anymore. Also add test case for invoking some meta data queries before and after fetching the result set. Change-Id: Ie8bf993926ebe89cd362ab0b311d1f3d164b84df Reviewed-on: https://gerrit.libreoffice.org/65717 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-12-14mysqlc: Fix obtaining field information in rsTamas Bunth
Result set field information should be stored correctly. It is queried from database on demand and stored locally. Change-Id: Ia62c62e6db32b45640b9fcd5f48c6249aecc41a2 Reviewed-on: https://gerrit.libreoffice.org/64861 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-12-10fix cut and paste error in new example in JdbcLongVarCharTest.javaRene Engelhard
Change-Id: I91e568896b1674e97cdf18eacc21538093765bd9
2018-12-10replace hardcoded jdbc mysql driver URL with env variableRene Engelhard
introduce CONNECTIVITY_TEST_MYSQL_DRIVER_JDBC analogous to CONNECTIVITY_TEST_MYSQL_DRIVER for mysqlc Change-Id: I90b14e7145418248de79aa9d4bf4285fd4f98f9d Reviewed-on: https://gerrit.libreoffice.org/64854 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-12-09mysql_jdbc: test simultaneously opened result setsTamas Bunth
Change-Id: I413fa17ee0fc264526133eca12ee747d40d6ac6a Reviewed-on: https://gerrit.libreoffice.org/64412 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-24mysqlc: next() should move cursor from LastTamas Bunth
XResultSet::next() should move cursor when called while cursor is on the last position. It is not documented, but older versions of the mysqlc extension are implemented that way. The cursor goes to the so called afterlast position. Even so, the next() call on the last position should return false. Change-Id: I0fd145c920077151364a6a8c12e05290496b99c8 Reviewed-on: https://gerrit.libreoffice.org/63895 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-09mysqlc: fix return value of XResultSet::nextTamas Bunth
Change-Id: I59e4803a5d9b01062eb0eaca0bf65d28298bd3e4 Reviewed-on: https://gerrit.libreoffice.org/63121 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-05Fix typo in codeAndrea Gelmini
Change-Id: If1b7b6c157a250baae054d94a5cdf788651bb7bd Reviewed-on: https://gerrit.libreoffice.org/62906 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-05mysqlc: allow multiple open statementsTamas Bunth
Change-Id: I07e57ea7d9e6af1c7543483b1ab54a0b8c5be2d5 Reviewed-on: https://gerrit.libreoffice.org/62640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-10-22Add unit test for mysqlc connectorTamas Bunth
It can be used to test the mysqlc connector whenever there is an external mysql or mariadb server running. The test runs only when CONNECTIVITY_TEST_MYSQL_DRIVER environment variable is set. This variable should contain the URL of the database, including the port number and the host name. The URL should also contain a user name password pair which can be used to connect to the external database. The URL format is the following: [user]/[passwd]@sdbc:mysql:mysqlc:[host]:[port]/[db_name] README is updated and contains detailed information about the test. Change-Id: I1bbc9369ff193a29c06de63a0f6cc975877c8da3 Reviewed-on: https://gerrit.libreoffice.org/62171 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-04-14Revert HSQLDB related unit testsTamas Bunth
Revert changes making HSQLDB related unit tests test Firebird migration. They should still test the HSQLDB driver. It reverts part of 159dd28651788a19848eae56693ad06ed947414d Change-Id: If2b9207e95055418bd1dc1dc6e472335de311d1e Reviewed-on: https://gerrit.libreoffice.org/52873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-04-07dbaccess: Enable hsql migration by defaultTamas Bunth
Also make Firebird driver not experimental anymore. With hsql migration enabled, the hsqldb related unit tests can be reused, because the underlying DBMS is transparent. To achieve that, I added firebird_sdbc component to hsqldb CppunitTest_* files. This commit also contains fixes for upcoming bugs while migrating from hsqldb to firebird, shown by hsqldb related unit tests: - null values: in case of null values, the setNull method should be used instead of nothing. (malformed string otherwise) Remove DBACCESS_HSQL_MIGRATION environment variable, since migration is default from now on. JunitTest_dbaccess_complex was based on HSQLDB. This commit replaces "if exists" hsql specific solution with firebird specific. Also disable test for queries with named parameters. Change-Id: Ieb68f5ad3a11389599c4f268ea4df82a83643b82 Reviewed-on: https://gerrit.libreoffice.org/52008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-11-30Disable check for successful file deletion for nowStephan Bergmann
...as it makes JunitTest_dbaccess_complex fail on Windows. Apparently, those files are held open by soffice for whatever reason. Needs further investigation... Change-Id: Id80b6f58288deaa39fc74fe36886e371968f8d82
2017-11-16Delete test*.odb filesStephan Bergmann
...that are created in java.io.tmpdir (e.g., /tmp on Linux) by connectivity.tools.HsqlDatabase.createDBDocument() during e.g. JunitTest_dbaccess_complex. This revealed that connectivity.tools.AbstractDatabase.delete() (even if it would have been called by the test) would have been non-effective at deleting the file, as the java.io.File constructor used takes a pathname not a file URL as argument, so the call to java.io.File.delete() would not have deleted the relevant file (and returned false, rather). Change-Id: I268e1d1732ac7a0db9ccde7d4ac4f09aa3811e11 Reviewed-on: https://gerrit.libreoffice.org/44801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-23loplugin:includeform: connectivityStephan Bergmann
Change-Id: I06596fac09f0568b8bab2e2e235a2b88bcd3fc7a
2017-07-21migrate to boost::gettextCaolán McNamara
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-03-19TyposJulien Nabet
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c Reviewed-on: https://gerrit.libreoffice.org/35436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-17remove some unused Java codeNoel Grandin
Change-Id: Ia1663256fc0b92c343ea4ba55a821c969077a0aa Reviewed-on: https://gerrit.libreoffice.org/33174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12Prevent use of ORowSetValue with sal_Bool as TINYINTStephan Bergmann
sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of ORowSetValue with sal_Bool instead of bool, apparently intending to treat the value as a boolean, actually treated it as a TINYINT. (See e.g. recent 7b0c57b2faec875c790051d233d1e9abaed2a3bc "some compilers don't like implicit bool-to-ORowSetValue conversion".) Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the m_uInt8 union member can probably go away, too. Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3 Reviewed-on: https://gerrit.libreoffice.org/31909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I8374d6d08f4eb4ae2821e213371c615b92d7e9ab Reviewed-on: https://gerrit.libreoffice.org/29432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-07-29connectivity: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Iad115345c061074da89746de8a9d2af2eb78802c Reviewed-on: https://gerrit.libreoffice.org/27679 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I9a647ba5c867e2152c204e1da98b5139091e51bd
2016-05-30com::sun::star->css in connectivityNoel Grandin
Change-Id: I9489e92dc89a6d83a26ff4f0d9aad26acd28ad9f Reviewed-on: https://gerrit.libreoffice.org/25537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-04these fields can be static constantsNoel Grandin
Change-Id: Id56e219782d7f858cdeb26232c7aabd4f643c9d9 Reviewed-on: https://gerrit.libreoffice.org/21020 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: make inner classes static where possibleNoel Grandin
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-10-16convert "continue" flag to an enumNoel Grandin
Change-Id: I160de1152978f301c514d9107c9e9082bab3cf05
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-04Finalizers must not access UNO objectsStephan Bergmann
If the object being finalized (A) has the last reference to the UNO object (B), and B is actually a proxy for a remote UNO object, then A and B become eligible for finalization in parallel, and the finalizer of B may already have run when the finalizer for A runs. That means that B may already have been removed from the remote bridge, causing an "unknown OID" error from the remote end when the finalizer of A now tries to make a call on B. (We try to assert that close() has actually been called before finalize() calls delete(), but the corresponding exception may be silently swallowed by the JVM finalization machinery.) This caused spurious "URP: queryInterface request message with unknown OID received" failures during JunitTest_dbaccess_unoapi. Change-Id: Ia47c3ef2c22a6adc75b1b8271eb4b3140accebe7
2015-02-08Typos + simple german translationsJulien Nabet
Change-Id: Icc0e9f028b393abb062a880519211be4fcd1d4b3
2015-01-05java: remove more dead codeNoel Grandin
found by looking for unused parameters (in Eclipse) Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05java: remove dead codeNoel Grandin
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: static fields that should not be staticNoel Grandin
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-15java: remove some unused fields and variablesNoel Grandin
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12connectivity: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I10b2ddf9dcc83219fea8eb55783507eed52702e8
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25java: remove some comment noiseNoel Grandin
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12java: convert fields to local variables where possibleNoel Grandin
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-09 19:51:46 +0000