summaryrefslogtreecommitdiff
path: root/connectivity/source/parse
AgeCommit message (Collapse)Author
2018-01-27Modernize a bit connectivity (part2)Julien Nabet
by using for range loops Change-Id: Ibbc4cdaa78c4c9d88487132a2761ac1040b1ecd8 Reviewed-on: https://gerrit.libreoffice.org/48713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-12More loplugin:cstylecast: connectivityStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Idbefb16acae20ab137497e78c9bc5dc5634c07fe
2018-01-04tdf#104986 move named parameters substitution into generic layerLionel Elie Mamane
Previously, drivers were responsible for making the substitution themselves. In practice they all (Firebird, ODBC and JDBC) used the LibreOffice SQL parser to parse the SQL statement and do the substitution. This had a few negative consequences: * The substitition was applied to _all_ SQL commands, including queries having the "execute SQL directly" bit set. Which means that the SQL was _not_ sent to the DBMS exactly as typed by the user. Even if there was no substitution to be made, since the SQL command was always round-tripped through the parser, thus "normalising" it (which is what led to tdf#104986). * "execute SQL directly" queries "magically" behaved slightly differently depending on whether the LibreOffice SQL parser succeeded in parsing them or not. Change-Id: Ieedc643f33467435a139e2565a01e6f398af041f Reviewed-on: https://gerrit.libreoffice.org/47283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-01-02tdf#104986: Add MILLISECOND, WEEKDAY, and YEARDAY tokens for FirebirdTor Lillqvist
Change-Id: I2ba866c408dbf49f1655cc08cc5d0df840eaf01e Reviewed-on: https://gerrit.libreoffice.org/47271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-10-23loplugin:includeform: connectivityStephan Bergmann
Change-Id: I06596fac09f0568b8bab2e2e235a2b88bcd3fc7a
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24loplugin:unusedfields some untouched fieldsNoel Grandin
which lead to a whole bunch of dead code in vcl/.../i18n_status.cxx Change-Id: Id8eeadeb9cbc6107e1a0dac5801ce20b2b9ae6dc Reviewed-on: https://gerrit.libreoffice.org/40355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19loplugin:constparams in connectivityNoel Grandin
Change-Id: I9b81c6227fb3c89a832640058a11444f72019694 Reviewed-on: https://gerrit.libreoffice.org/40155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-13loplugin:oncevar: empty strings: connectivityStephan Bergmann
Change-Id: Icfc67638e2aee9b5025dd40a50a2627d153ada4d
2017-07-05new loplugin unnecessaryparenNoel Grandin
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec Reviewed-on: https://gerrit.libreoffice.org/39549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: connectivityStephan Bergmann
Change-Id: I03127890499dac67816bb43a8c3fb9dd87eefcab
2017-06-27In OSQLParseTreeIterator::traverseCreateColumns, nLen has always been ignoredStephan Bergmann
...ever since the code's introduction with 34506a92ae2f972c9a667e1498d62e73807e8084 "INTEGRATION: CWS mozab04" Change-Id: I845a53077f16cdea6d728b9e6964a55ceea3995d
2017-06-05Improved loplugin:cstylecast to reference types: connectivityStephan Bergmann
Change-Id: I63c747efa2aacf4cb23de6fe9ab02af7abc107f9
2017-05-31simplify OSQLScanner::SQLyyerrorNoel Grandin
...buffer management Change-Id: I649a93ed5bd9bd7d4ac8ec73fc956eb8532eac89 Reviewed-on: https://gerrit.libreoffice.org/38206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert connectivity module away from OSL_ASSERT to assertChris Sherlock
Change-Id: I1f1296836b07df6e147c8be845486ac4acd15abd
2017-04-27tdf#39468 cleanup source code commentsdennisroczek
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in connectivity/ Change-Id: Id32217529e02d3efd070bc226b0078dcab73a602 Reviewed-on: https://gerrit.libreoffice.org/35820 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524 Reviewed-on: https://gerrit.libreoffice.org/34808 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-26loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ib90fb2c3f4d976dce764d4c91af797351317397b
2017-02-17remove unused enumerators from SQLNodeTypeNoel Grandin
Change-Id: I0e8a3c5b63a00befa36c7edfbec0acd60bd3dc03
2017-02-15Drop :: prefix from std in c*/Tor Lillqvist
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155 Reviewed-on: https://gerrit.libreoffice.org/34324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-17no special support for MACOSX PPC in master for a while nowCaolán McNamara
Change-Id: I8d5dc878f41939e55ef8995d1da74548faa4711f
2017-01-09New loplugin:externvar: connectivityStephan Bergmann
Change-Id: I7e62a92ee4b019163de797fd4448170a741879dc
2017-01-09hack to silence -Wunused-functionCaolán McNamara
Change-Id: I585839c05ca3b0336ffbe2c60a2f58c34b0aae78
2017-01-04Fix loplugin warnings in sqlflex.lStephan Bergmann
(Normally hidden by T_LEXFLAGS containing -L in connectivity/Library_dbtools.mk suppressing #line directives; some loplugin:literaltoboolconversion warning would remain in a flex-provided occurrence of ECHO that is apparently not properly prefixed by #line at least with flex 2.6.0.) Change-Id: Id5693d6bd9e5b565dd9820e3cbea8e88e7967dd5
2017-01-04Fix loplugin warnings in sqlbison.yStephan Bergmann
(Normally hidden by T_YACCFLAGS containing -l in connectivity/Library_dbtools.mk suppressing #line directives; some loplugin:cstylecast would remain in bison- provided expansions of $1 etc. variables.) Change-Id: Ic93bea0b2fe0ec5f741c4bc41f25cc72fec0498f
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10loplugin:expandablemethods in comphelper..cppuhelperNoel Grandin
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d Reviewed-on: https://gerrit.libreoffice.org/30717 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:oncevar in cui..connectivityNoel Grandin
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17 Reviewed-on: https://gerrit.libreoffice.org/30653 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-23loplugin:expandablemethodds in include/connectivity..drawinglayerNoel Grandin
Change-Id: Ic58f86422ef8f1e2bb655157850e214fc3a1a9b4 Reviewed-on: https://gerrit.libreoffice.org/30136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-05-30com::sun::star->css in connectivityNoel Grandin
Change-Id: I9489e92dc89a6d83a26ff4f0d9aad26acd28ad9f Reviewed-on: https://gerrit.libreoffice.org/25537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12tweak assert and switch to squeak by NDEBUG and nonNDEBUGCaolán McNamara
Change-Id: I996d69d83acb77e96cb105f65a0243bd5fe80295
2016-05-12fall-through->SAL_FALLTHROUGHCaolán McNamara
Change-Id: I91ed1614162f3b7de13a0fe4ce1af689dce21510
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-04-21clang-tidy modernize-loop-convert in c*Noel Grandin
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I6fada7331ee369c35cbe019db4e730ce56cd1a1f
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I2217920ced336189a94c0a5d1e3ac0ccd3912881
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I18ddafbf3d41f6779fb43e36ba1f1c48b37757a0 Reviewed-on: https://gerrit.libreoffice.org/23671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-28Use const_iterator when possible (connectivity)Julien Nabet
Change-Id: I749e4c3ffa0c89f919459c376edad4804b2b66ca Reviewed-on: https://gerrit.libreoffice.org/23573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-08tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I either replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 statements or i used SAL_INFO(..)s Change-Id: Iefb6b83e86e1767e55600b6e1989ee91207fb220 Reviewed-on: https://gerrit.libreoffice.org/23000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-25convert StandardSQLState to scoped enumNoel Grandin
Change-Id: Ia0a1526140cfed35a73a6fea1a173d2fb5005960
2016-02-25convert SQLNodeType to scoped enumNoel Grandin
Change-Id: I622e55622d38e6017993c8bc52625c85d0f74d74
generated by cgit (git 2.34.1) at 2025-02-09 01:57:28 +0000