summaryrefslogtreecommitdiff
path: root/connectivity/source
AgeCommit message (Collapse)Author
2013-09-04WaE: Unreachable codeTor Lillqvist
Noticed by the MS linker when doing link-time code generation (!). In all cases, a "return" after a call to a function that always throws an exception. To avoid other compilers perhaps warning about missing return of a value, put the "returns" inside ifdefs. Change-Id: I83aa04cb5c3ff8413d3ed4dc85fb57f2a41fd589
2013-09-03Add some comments on foreign key retrieval (firebird-sdbc)Andrzej J.R. Hunt
These two methods don't seem to be used at all within the LO codebase. They are also extremely complicated to implement hence will be left for later implementation -- my part implementation will be put on the wiki firebird page. Change-Id: I72922a4f3c4705fdcc3bbca140d6df64a1e16253
2013-09-03Remove outdated/useless comments. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Iab163debab1513369b75183efdaa3c03f7193a70
2013-09-03ResultSet: add FunctionNotSupportedException, some cleanup. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Iee897766841af980d93aeb73255c82851172601a
2013-09-01Remove some unused code from unusedcode.easyMarcos Paulo de Souza
Change-Id: Ic3e96eebbb914c5b905a8c58532ead9cb01dd41d Reviewed-on: https://gerrit.libreoffice.org/5721 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-31delete more code that was commented outPhilipp Riemer
Change-Id: I8a37b482ca4abb440691b2490e43ecd93a8dbbc5
2013-08-31fix indentationPhilipp Riemer
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I55ff666c357c89ad355a1a5bc0d0347fcc188476
2013-08-31deleted code that was commented outPhilipp Riemer
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I7a67c3768c0d7e36784ee88fc46680037acb244d
2013-08-31fdo#62475 - remove visual noisePhilipp Riemer
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-30Set path and not url for FIREBIRD_[TMP|LOCK]. (firebird-sdbc)Andrzej J.R. Hunt
Otherwise firbird fails to load databases since it can't access a url. Change-Id: I1bebc6fa18c2d1920291dcf5a7300009ede4452a
2013-08-30Improve TIMESTAMP display. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Ief7ec180e3787a3354e2034693052ebf05a30e81
2013-08-30Implement setTimeStamp. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I58907d42ec9e1b4098e2947fdb89b1ab264358a6
2013-08-30Cast pointer before dereferencing. (firebird-sdbc)Andrzej J.R. Hunt
We have a char* pointing to arbitrary data hence we need to cast to the right type, othwerwise we retrieve the first byte only. Change-Id: I6d3d08d15105a506c140044008c5255a8a8e4c39
2013-08-30Implement set[Date|Time]. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Ibf3bc34f316c0a299afc2e015ff4c49ad57099a5
2013-08-30Implement malloc'ing of date/time/timestamp (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I22abb334a337ae2e25188ae43696789d37ecd7d4
2013-08-30Implement set[Date|Time]. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Ia519b2ec9c6be94f6f21bbd2951a295da8079479
2013-08-30Set FIREBIRD_TMP and FIREBIRD_LOCK with sane values. (firebird-sdbc)Andrzej J.R. Hunt
Currently firebird uses /tmp and C://temp/ as default temporary directories, both of which can be incorrect. Instead we now pass the correct temp directories to firebird. Change-Id: I807a47475e76600365e7a2ccfa78d755621dedb7 Reviewed-on: https://gerrit.libreoffice.org/5678 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-29TPropertyValueLessFunctor must actually compare for "<"Stephan Bergmann
Change-Id: I584a410d90531a0f7b784e62f94c39e715713cf1
2013-08-29Implement setTimestamp. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I0c009a99061de787cd250912406a74a75fbc260a
2013-08-29Pass by reference instead of value, fix template parameters. (firebird-sdbc)Andrzej J.R. Hunt
We will also want to pass structs etc. into setValue hence we should pass by reference. Change-Id: Ia8aa02ca14414003c33cd8d070510759091b5ec9
2013-08-28janitorial: more constnessLionel Elie Mamane
Change-Id: Icf4746d70488bec20b4c47fc65fa989cfe90992b
2013-08-28ODBC OResultSet::ensureCacheForColumn initialise *all* new elementsLionel Elie Mamane
e.g. when growing m_aRow from size 3 to size 10 (that is, columnIndex==9), the old code was initialising only position 9 while it we need to initialise all new positions, that is positions 3 to 9. Change-Id: I6a51b816104e33fdd7773b68e254e9bea50110ef
2013-08-28remove risk of infinite recursionLionel Elie Mamane
fillColumn is the only caller of impl_getBookmark, so all necessary setup (in particular ensureCacheForColumn) is already done, and does not need to be done in impl_getBookmark again. Change-Id: Ic78b7dabd7c536abd9ed956baa178d685a63f713
2013-08-28Implement set[Float|Double]. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I70d5ab9bacdeabe6c4edf6f70a9ba283b46c180f
2013-08-28Firebird uses "DOUBLE PRECISION" for doubles. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I99bac2cfde956d2b91dce33fc12ce9044a9c219a
2013-08-28SQL_FLOAT corresponds to DataType::FLOAT.Andrzej J.R. Hunt
Change-Id: Id5e2aab669ba047e9ecb392187aae7c4aa384dda
2013-08-28Use correct type for SQL_FLOAT. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Ic27e886643128edeb5b2d5c81e86681f4dd8d33b
2013-08-28Remove unused code (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I88f47ee442ade499c7f4018ce8b1ffe54b362067
2013-08-28Use template to set integer parameters. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I8a6c9f335574196a50827db7eb44b82f9ea4df16
2013-08-27Implemet setNull. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I9fd53a5e8b5d1dba467fa8064f9f2ea1b93f26df
2013-08-27Implement set[Int|Long]. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I234b8f136b90f56c689553d0df8ec2d473a92225
2013-08-27Implement setShort. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Ia543f34344915c4621ba0c6ce6984dce7ca9e08b
2013-08-27Return change count for Statement:executeUpdate too. (firebird-sdbc)Andrzej J.R. Hunt
This also simplifies Statement, although not using execute_immediate is somewhat less efficient. Change-Id: I4bebe13e5a63cb02e6b2659dec534f0c6feeba52
2013-08-27Implement retrieving change count for executeUpdate. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Ied47f421dc801bb6790bed49b28d3231844e6ee5
2013-08-27release m_aLengthVector even when m_aBindVector is emptyLionel Elie Mamane
Change-Id: Ia3bd53402d436e296005f4f93113cc08daea2421
2013-08-27the place reserved for bookmark in m_aBindVector is never usedLionel Elie Mamane
Change-Id: Iae4850739c329a7b04f8eea75047ab75465e3dea
2013-08-27odbc insert: unbind as soon bindings not necessaryLionel Elie Mamane
SQLFetchScroll uses the bound columns, and writes to them. This has two problems: 1) For non-bookmark columns, this happens in our buffers, and at first sight could be innocuous. However, it allows the driver to disallow us to use SQLGetData on the same columns, which we intend to do... 2) For bookmark column, the "read bookmark from" and "write bookmark to" buffers end up being the same. This unnecessarily exposes us to driver bugs in this corner case. Change-Id: I594d34cf5a64564766f06b49c86f8737961573c0
2013-08-27odbc insert: adjust buffer size *after* it is written toLionel Elie Mamane
the buffer (aBookmark) is written to by SQLBulkOperations or SQLSetPos, not by SQLBindCol, which merely sets up the instruction that the next call should write there. So its finak size is known only *after* the call that makes the write, obviously. Change-Id: I4faaaeffc060433645188f0eda3d9958b087cf6c
2013-08-27fdo#68315 odbc update *reads* a bookmark, not *writes* a bookmarkLionel Elie Mamane
This code was completely inverted. The row update operation *reads* a bookmark (that is, what row to update), not *writes* a bookmark. So we were passing an empty bookmark, and thus the update was failing because we were refering to a non-existent row. Change-Id: I676b1a7727a88e13a3e465bd96cbbaf18dad2fa6
2013-08-26connectivity: firebird::OResultSet: convert to C++98Michael Stahl
Change-Id: I9036539204789d0886a51fcbc3d821012cc9eaee
2013-08-26Quick hack to make driver usable with dbaccess/KeySet. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I6500a7666ad2fc2ffcb29934d6f2b36761867950
2013-08-26Clean up PropertyHelper stuff, set ResultSet properties. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: If2f2041b0f072f36fe56e92b9e54bbb0be8a5860
2013-08-26Actually set m_bIsAfterLast. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: If8558fb53acd1175fa3fd8724a5febca4286abe6
2013-08-23Set Null indicator in input SQLDA as appropriate. (firebird-sdbc)Andrzej J.R. Hunt
If this is incorrectly (or randomly set) then firebird will end up just ignoring any input parameters (previously the case). The documentation claims that -1 is the null indicator, however the inevitably-random values previously provided (from malloc) also caused firebird to treat all input data as null. Change-Id: I79b9704df0a307ec493e74e782551b9b0ff109a2
2013-08-23Improve comment. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Iec5c5a434a371d73bba0345362f991a948d28c6a
2013-08-23Close cursors in PreparedStatement. (firebird-sdbc)Andrzej J.R. Hunt
Trying to reuse a statement that still has an open cursor leads to errors -- in this usage isc_free_statement doesn't actually free the statement but simply closes the db-internal cursor used by that statement previously. Change-Id: Iedbe42bc46e6b6f972b7b19f17a60d5f59bae28c
2013-08-23Use correct sqlda for number of parameters. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Ief966fb9bd9f3344cfe9f3b4c4b37540e00ad063
2013-08-23RefreshRow is unuspported. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: Iec8e72a6236de83a1698e2d6e9dbcb609f0f858f
2013-08-23Remove unsupported XRowLocate/XDeleteRows (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I74bf84c8aae4d4ba6b9a2a9ca497ed0cbc092d35
2013-08-23Remove unsupporte XRowUpdate/XResultSetUpdate. (firebird-sdbc)Andrzej J.R. Hunt
Change-Id: I3b9f8c7199e66f90e1573069996962294793d95e
generated by cgit (git 2.34.1) at 2025-02-06 18:55:40 +0000