summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2022-03-29loplugin:unusedfieldsNoel Grandin
Change-Id: Iaf3a0a42e94994eab25f5e9ef8c111362e86fb02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132262 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-25loplugin:unusedmethodsNoel Grandin
Change-Id: I42cd6d52bd6c0759fa0a8b1b91bbf1af7eb70ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-25tdf#132924 - Firebird findColumn: return column alias if specifiedAndreas Heinisch
The function findColumn in a Basic macro should also find aliases for columns specified in an SQL query using a Firebird database. Change-Id: I96adb2564da1e18cee58f1c6803526d8ff4deabb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131990 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-03-22Move BSTR wrapper to systools, and fix some wrong BSTR usesMike Kaganski
BSTR is documented [1] to be prefixed by a 32-bit integer specifying its length *in bytes* (not characters), so passing wchar_t* as BSTR is wrong, and the length member of rtl_uString can't substitute the proper BSTR length, since rtl_uString::length specifies length in characters. Any code taking BSTR and using SysStringLen to get its length would only get half of the passed OUString data. In dbaccess/source/ui/dlg/adodatalinks.cxx, the abovementioned error was implemented. OTOH, OLEVariant::getByteSequence() in connectivity/source/drivers/ado/Aolevariant.cxx passed BSTR from tagVARIANT to ctor of OLEString, which resulted in the BSTR being freed in both dtors of OLEString and OLEVariant (the latter calls VariantClear, which itself clears string when vtfield is VT_BSTR). [1] https://docs.microsoft.com/en-us/previous-versions/windows/desktop/automat/bstr Change-Id: Iedbd62b20133644258af3660616add7b63cac258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131950 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-22Simplify CoCreateInstance / CoGetClassObject with COMReferenceMike Kaganski
Change-Id: Ieb1035410c3c6c4b40ea779e829a940460d19b5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131922 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-17Remove old mysql_jdbc/mysqlc in drivers.xcuJulien Nabet
and retrieve 2 missing items from it into mysqlc part Change-Id: I7494ca420e89f267659c06ef5f519790d47b3508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131681 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-16tdf#147997: MySQL/MariaDB for dialog for direct connectionJulien Nabet
Expand a bit rebranding to JDBC part and other locations Change-Id: Ia48972996b3eb3be0341d7d93a0ba1dc69fe0057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131632 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-15loplugin:trivialdestructor (macOS)Stephan Bergmann
Change-Id: I4f379f9f5c848e8fb01b05591d8a80a45719b43b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131578 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-13Remove forgotten remnant test codeJulien Nabet
Change-Id: Iffa86449fc2e4946821afea07e22deb355c7fbf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131507 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-03-12tdf#147309: Recreating a view with same name and in the same session fails (FB)Julien Nabet
Since HSQLDB already worked, just do the same. Change-Id: I44929cf36179cc3cdff6e61f05899c9a913c78b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131442 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-04cid#1500701 silence Dereference after null checkCaolán McNamara
Change-Id: Iccd159c81011863cd664a2903dd14006bdc3b8a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130988 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28cid#1500397 silence Resource leakCaolán McNamara
this reverts commit 1142dc2398de2e2be0e057ecb432ad9c8895313a Date: Sun Feb 27 14:14:18 2022 +0100 cid#1500397: Resource leak with an alternative that hopefully silences coverity and helps show better what is going on Change-Id: Ifb117d65789e80e66419911dbb6b327bdf7ed948 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-27cid#1500397: Resource leakJulien Nabet
Change-Id: I765df1eef9ccf447cdd0a80497c1ca6f22bb9e42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130625 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-26cid#1500433 Using a moved objectCaolán McNamara
Change-Id: I150cd0f021aeb1aefe411f19dfcac111ac35b295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-25tdf#145759 30.6001 -> monthDaysWithoutJanFebHossein
30.6001 shows month days without Jan and Feb. According to the below link, it is calcuated as (365-31-28)/10 = 30.6 but because of a floating point bug, it was used as 30.6001 as a workaround. "30.6001, 25 year old hack?" https://www.hpmuseum.org/cgi-sys/cgiwrap/hpmuseum/archv011.cgi?read=31650 The value 30.6 is used as i18nutil::monthDaysWithoutJanFeb here instead of 30.6001. The new value is ~30.60000038 which is > 30.6, so the calculations should be correct. In order to make sure, a unit test is added, and part of the values are checked against the values calculated by this website: Julian Day and Civil Date Calculator https://core2.gsfc.nasa.gov/time/julian.html Change-Id: I8cc7e046514dc3de652a1c37399e351cb2b614dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125813 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-02-22Fix a ODatabaseMetaDataResultSet type in evoab2Julien Nabet
Change-Id: I974b1ce90d87fb8591eb7d788f884402111b5a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130396 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-22Fix some ODatabaseMetaDataResultSet types in FirebirdJulien Nabet
Change-Id: I12e579d04b81057d3513dab3459c035b1ae9df42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130393 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-22Add XWeak constructor and operator= to uno::WeakReferenceNoel Grandin
which is faster since we can skip the UNO_QUERY. Change-Id: Id95ad9f3568213e974bd13659d92d4ea94dbfbd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-21cid#1500693 Resource leakJulien Nabet
Change-Id: Ic560c2079be0b04ce382350390e03e0ec2d8abcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130303 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify sequence of Property in connectivity/jdbcJulien Nabet
Change-Id: I703a3adc7203045288e982c4155dfc19a01e414a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130137 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify sequence of Property in connectivity/firebirdJulien Nabet
Change-Id: Ie45d5418e474cfeb2ac3ac62edbaa1e5bd688d9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130136 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify sequence of Property in connectivity/adoJulien Nabet
Change-Id: I1b1e183b053d98139ca5b45f3642d252252da14a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130142 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify sequence of Property in connectivity/macabJulien Nabet
Change-Id: Id0ed3ab3d66dfb8b76030fad7cd0b2bc3ea010fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130139 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify sequence of Property in connectivity/mysqlcJulien Nabet
Change-Id: Ib4e1c47262c42db92226be5f84742799c3a1cbb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130138 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify even more sequence of Property in connectivity/odbcJulien Nabet
Change-Id: I8dd75cf5c41aa879efe740f48bcb305901742804 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130135 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify sequence of Property in connectivity/odbcJulien Nabet
Change-Id: Iaa2b908d63899c2e1141602b26d6da6b064f63e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130119 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-17Revert "ODBC: fix signatures of Bulk, SpecialColumns et NativeSQL"Julien Nabet
This reverts partly commit 8942956e05f2208ffb666a2118f5db092c30ce6a. Reason, Lionel indicates: In general UnixODBC has to deal with more portability to more platforms, so I would tend to more follow their signatures than the ones of Microsoft, that has to deal with only Windows OS on less CPU ABIs. Change-Id: I8b8924d35aa86ac23a8191baa8584463941eddc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130084 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2022-02-17ODBC: fix signatures of Bulk, SpecialColumns et NativeSQLJulien Nabet
I compared with https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/odbc-api-reference?view=sql-server-ver15 Change-Id: Iac38c2305fbf3ace502f9e75802510f76a6bd700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130055 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-15tdf#145759 Using M_PI from cmath instead of magic constants.pragat-pandya
Replace the instances of Pi's value as magic number by M_PI Use M_PI_2 and 2_M_PI instead of calculating these values in code. Use basegfx functions to convert angle units. Change-Id: I6cca7cc93704a70ccf3a0571a56a789bc9df51ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129479 Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com> Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2022-02-08Drop some methods returning just a string and only used onceJulien Nabet
Change-Id: Idccc6edea7dabc79135d49ffe69c1a13f2990b76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129684 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-02-08cid#1497933 suppress Macro compares unsigned to 0Caolán McNamara
Change-Id: I7f06f889f2bd687028c00d79bdcf9e2edacc5c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-07fix big-endian hsql to firebird migrationCaolán McNamara
Change-Id: I047d2366ad80eca701924cb0f66b6b1bcfdcac5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-06We know the length hereMike Kaganski
Change-Id: I630b7fbda7c9ebf578e74260a0d67eea32e9e429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129549 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-05tdf#138691: avoid buffer overflowMike Kaganski
Change-Id: Ib5eaf6c658e1185c1e3eec7ce34f0ce54d6ce771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129441 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-01Mysql/MariaDB: remove useless include+using and unused vars in mysqlc_driverJulien Nabet
BUNDLE_MARIADB seems to be useless since 2018 with: 7430dfe2a4a3b13ffa248bf14a3a2ca87993f48d: loplugin:unusedmethods Change-Id: I75c9954f096e28c715f95073962241cafb787a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129173 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-30Mysql/MariaDB: remove useless include+using + unused vars in mysqlc_connectionJulien Nabet
+ replace one time used define MYSQLC_URI_PREFIX Change-Id: Ia2ad5b2883f5f417bdbdcc7b39055bd5454c10f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129174 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-27tdf#126960, tdf#131330: FB make views editable+refresh auto after creationJulien Nabet
Change-Id: I78783056659a26cc8139d74eefc225de1a11ca7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129011 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-27Mysql/MariaDB: remove obsolete comment in viewsJulien Nabet
Obsolete after eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45 Mysql/MariaDB: after creating a view then refresh, make it appear as a view For this, I took example on hsqldb part this time (instead of Firebird which is uncomplete). Also, deleting a brand new created table works now. Of course, there are still pb with schema containing special characters like "`" In fact, the description of the previous commit was wrong since renaming a view still shows the table icon instead of view icon. You must reopen the file so the icon is ok. Change-Id: I2d27107db672e02af74e34a692309844ac310004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129035 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-25Mysql/MariaDB: after creating a view then refresh, make it appear as a viewJulien Nabet
For this, I took example on hsqldb part this time (instead of Firebird which is uncomplete). Also, deleting a brand new created table works now. Of course, there are still pb with schema containing special characters like "`" Change-Id: I4849f412ed5b3c2f35fbb4caaf06577828cc255a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128943 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-23Mysql/MariaDB: Fix slight bug in Tables::createObject:Julien Nabet
unescape scatalog before converting it in aCatalog In Views, remove connectivity::mysqlc::Views::disposing which seems more cargo cult Remove useless XConnection.hpp in tables (how come I didn't spot it in cleaning process?) Change-Id: I28863dcd93baae923877dbd431b6807226c0a548 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128799 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-22Mysql/MariaDB: Clean mysqlc_keys + remove usingJulien Nabet
Change-Id: Idd7d0ce4ffd18fec95102c41372c83fb7df11168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128757 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-22Mysql/MariaDB: Clean mysqlc_catalog + remove usingJulien Nabet
Change-Id: Ia9cd6dc9a6389ea1764a85c5f35a65f7d6ac40a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128755 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-22Mysql/MariaDB: Clean mysqlc_column + remove usingJulien Nabet
Change-Id: I10e3cc1fb2b66d7bebbaa33d7eb0b2099658e3af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128759 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-22Mysql/MariaDB: Clean mysqlc_views + remove usingJulien Nabet
Change-Id: I11e1284f9e7589cf4770d723e36c91a84b9b36b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128761 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-22Mysql/MariaDB: Clean mysqlc_view + remove usingJulien Nabet
Change-Id: I6fcb2f2c4346e6293a1e40e6f143ef6e8a68ee8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128760 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-22Mysql/MariaDB: Clean mysqlc_table + remove usingJulien Nabet
Change-Id: Iae0c8d4f12644bee15f78311b86d367f179a4fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128754 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-22Mysql/MariaDB: Clean mysqlc_columns + remove usingJulien Nabet
Change-Id: I6d29d594ed423efa25f063fd3107718b0f8b5b18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128758 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-22Mysql/MariaDB: Clean mysqlc_indexes + remove usingJulien Nabet
Change-Id: I893dc2d858a90b45b92b2866129527567bdb45e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128756 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-21Mysql/MariaDB: Clean mysqlc_tables + remove usingJulien Nabet
So it allows to make the variable types far more explicit. It may help to differentiate the global mechanism from the specific mechanism Change-Id: I655824b97dbef5eab610d3b1535307b108245f53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128699 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-20Mysql/MariaDB: allow View renamingJulien Nabet
Strange bug the renamed view appears like a table but when closing and reopening the file, the view is indeed there as a view (and not as a table) and renamed Change-Id: I0f26fca66ffb0785ece6223df623845c5e015c93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128707 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-03-23 18:10:13 +0000