summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2016-09-23TDE fix some clang plugin based warningsJan-Marek Glogowski
Change-Id: I3b44038e8a889e4c13126fd8d721e53e71ea9ec6
2016-09-22loplugin:unusedmethods unused returnsNoel Grandin
Change-Id: I4da3374e31d3c7407b401d66275da7f56ae83d30 Reviewed-on: https://gerrit.libreoffice.org/29178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Remove NumberFormatCodeWrapperMaarten Bosmans
This class only adds a level of indirection, without any useful functionality. Change-Id: I806e1b9241caf025c62c12c93aad3101daac874a Reviewed-on: https://gerrit.libreoffice.org/29134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20Remove obsolete workaround for SUNPRO 5 compilerStephan Bergmann
...copy/pasted into three more places Change-Id: I6661244d0248af509cd867fc3e8c451551068a78
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15convert LogLevel constants to scoped enumJochen Nitschke
rename some variables to distinguish them from type name use enumarray for log level strings remove unused DATA member Change-Id: Id3c38b82e679b3aede5ce790735443e769d5f236 Reviewed-on: https://gerrit.libreoffice.org/28920 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15connectivity: firebird: loplugin:nullptrMichael Stahl
Change-Id: Ia711be1238de87ac5b52b02de077b70220369e4b
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-14loplugin:overrideStephan Bergmann
Change-Id: I0cd2007c9169fe480e28e684cfe1bd8b24da7123
2016-09-14loplugin:constantparam in chart2..connectivityNoel Grandin
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-01coverity#1372406 Uncaught exceptionCaolán McNamara
Change-Id: I24fe9cb3aa9002d4b94b6f934e39aff243c1e09d
2016-09-01coverity#1372402 Uncaught exceptionCaolán McNamara
Change-Id: I63743ccdeca1be66da5622bd286f08daebdd74ff
2016-09-01coverity#1372398 Uncaught exceptionCaolán McNamara
Change-Id: Icf6c0f8071a3ea2de81073dfcabc64fae6aeee9c
2016-09-01coverity#1372392 Uncaught exceptionCaolán McNamara
Change-Id: Ic8bb4748b0752796fcb76c1816441bb22b896809
2016-09-01coverity#1372390 Uncaught exceptionCaolán McNamara
Change-Id: I4bb01b0bb9865986d9da8ed294a46fa7a4488458
2016-09-01coverity#1372389 Uncaught exceptionCaolán McNamara
Change-Id: Ic788073adcaefb3de2bff7e249f17a64fad48b19
2016-09-01coverity#1372388 Uncaught exceptionCaolán McNamara
Change-Id: I55c4e2ad1f3384c4e8b0a6cc88b83fa96cf2dede
2016-09-01coverity#1372387 Uncaught exceptionCaolán McNamara
Change-Id: I563e7987d00a68373c05dc4f1f3d62cd3e52de70
2016-09-01coverity#1372383 Uncaught exceptionCaolán McNamara
Change-Id: Idfdd846d8439be91b059d53dab6591d202576fae
2016-08-30declare default dtor as virtualCaolán McNamara
Change-Id: Ic77dbe3ffb2d2856d437158914b877b913296e0e
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (connectivity)Stephan Bergmann
Change-Id: I1c9e33d3f4306199320e60cf0eb2970e687576ef
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-28Resolves: tdf#81883 dispose OCalcConnection's doc before shutdownCaolán McNamara
if noone else does it, then ensure the doc is disposed before XDesktop it torn down Change-Id: I3136802a40c9cfb43039307dc65949d3264b6f2b Reviewed-on: https://gerrit.libreoffice.org/28428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25DocHolder->DocHolderCaolán McNamara
Change-Id: I8eddff0791a7887e1aee0515e73d40c54b97a0ae
2016-08-25cid#1371320 Missing move assignment operatorNoel Grandin
Change-Id: I34da999f516abedd65135f67e7479706e64e7b20 Reviewed-on: https://gerrit.libreoffice.org/28376 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25Improve exception constructionStephan Bergmann
Change-Id: I2c1d28bb7c841f594fe2fdaf5f34fcdd730d8ee2
2016-08-25cid#1371770 Uncaught exceptionStephan Bergmann
Change-Id: I147e98d0eef2568c78ea95aee9fa68656f2e8e75
2016-08-21coverity#1371621 Uncaught exceptionCaolán McNamara
Change-Id: I82e500ce3b6022f7783f645bbcd4e957588f7bae
2016-08-21coverity#1371622 Uninitialized scalar fieldCaolán McNamara
Change-Id: Id1408665b01889eabe449047f2d8f62229aeeb16
2016-08-19Some clang-tidy misc-move-constructor-initStephan Bergmann
...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
2016-08-18tdf#72987 GSoC Use Firebird backup formatWastack
Store embedded database files as an archive (.fbk) file. The firebird database file is extracted when opening an odb file, and archived for each saving. Change-Id: I6c985f89a0fb01b2294f728b4581053521ca0c88 Reviewed-on: https://gerrit.libreoffice.org/28045 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-18tdf#69949 GSoC Firebird implement autoincrementWastack
Change-Id: I6fe08b575f01b986f0a3c96b341f254279427b68 Reviewed-on: https://gerrit.libreoffice.org/28062 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-17tdf#91324 correct firebird date formatWastack
Store date inside the embedded firebird database as: Years as the years since 1900. Months from 0 to 11. Change-Id: Ic6269a183261c4c482f91f0d3871b42c54d4b99f Reviewed-on: https://gerrit.libreoffice.org/28173 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-17tdf#73073 GSoC Firebird Set autoCommit trueWastack
Use autoCommit for embedded Firebird database. Change-Id: I5633960b8e3d4e6ee8f9b4f29406c7208a059521 Reviewed-on: https://gerrit.libreoffice.org/28047 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-17GSoC Upgrade firebird to 3.0Wastack
Embedded firebird is now version 3.0. Supports MSVC 14.0. Instead of fbembed, there are now two libraries: fbclient and Engine12. fbclient is linked as fbembed before, Engine12 is loaded at runtime from fbclient. fb now needs system libtommath, which is supplied as a new ExternalProject of LO. Change-Id: I132939bdee745795b22f675e4265e9590079c45f Reviewed-on: https://gerrit.libreoffice.org/27642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-17loplugin:unusedenumconstants in basctl..editengNoel Grandin
Change-Id: I49a23a197969d58a3a2d6b2be1fbe4a647c7fa08
2016-08-16loplugin:stringstaticStephan Bergmann
Change-Id: Ia5d7ca7864dbef1489294783438b9d718159614b
2016-08-16new loplugin to check for static OUStringsNoel Grandin
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11tdf#91324 GSoC adapt struct tm correctly for dateWastack
Change-Id: Id0413d735eeeb506b6e706c5d31e7bf989ab5e41 Reviewed-on: https://gerrit.libreoffice.org/27592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-07Revert "tdf#67302 Resolving tablesSupplier name clash for postgresql"Lionel Elie Mamane
As explained in https://bugs.documentfoundation.org/67302 this is the right thing to do in that directory, but cannot be comitted in isolation. All callers of that function in all of LibreOffice need to be adapted to the new syntax of the returned value (that is that the value is now properly escaped). This needs to be done at the same time in all drivers and all places that call this API (+documented in the release notes). This reverts commit d43f4390e006716ca538ad92d09bd012179efd66. Change-Id: I8f33fd68ec09d67dd6d38ae50d8ae156f11c5357 Reviewed-on: https://gerrit.libreoffice.org/26593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-08-05loplugin:countusersofdefaultparams in chart2..desktopNoel Grandin
Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee Reviewed-on: https://gerrit.libreoffice.org/27896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01tdf#100726: Improve readability of OUString concatenationnadith
this bug fixed in the modules between canvas - cppu Change-Id: I2022b022897dafde20251352376e3facdb9b8d75 Reviewed-on: https://gerrit.libreoffice.org/27663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29connectivity: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Iad115345c061074da89746de8a9d2af2eb78802c Reviewed-on: https://gerrit.libreoffice.org/27679 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-22Fix typosAndrea Gelmini
Thanks to Carlo Bertoldi for the german translation. Change-Id: I76f554e757318aed4e28b5a05fae0ba15bd46afb Reviewed-on: https://gerrit.libreoffice.org/27355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-07-15loplugin:redundantcastStephan Bergmann
Change-Id: I2d963eb8395b8eca776032d32d72f5ec85891c70
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-09 23:01:55 +0000