summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2016-03-03loplugin:unuseddefaultparams in connectivityNoel Grandin
Change-Id: I03cc69a924913713a0da819899ce259305b88016
2016-03-02loplugin:unuseddefaultparam in cuiNoel Grandin
Change-Id: I445b96a2ed4364616b2cb6a23efe36afb3f862f7
2016-03-01coverity#1352212 Unchecked return valueCaolán McNamara
Change-Id: I75a6853a6708585201dbc4722e7a19cd568a48f7
2016-02-25convert StandardSQLState to scoped enumNoel Grandin
Change-Id: Ia0a1526140cfed35a73a6fea1a173d2fb5005960
2016-02-25convert SQLNodeType to scoped enumNoel Grandin
Change-Id: I622e55622d38e6017993c8bc52625c85d0f74d74
2016-02-25convert TraversalParts to scoped enumNoel Grandin
Change-Id: I34797d6ccdf8b9c75004c129056f3a09f169e1b4
2016-02-25convert OSQLStatementType to scoped enumNoel Grandin
Change-Id: I2df117cf0f405e88899e7ccab380156284720449
2016-02-25convert ParameterClassification to scoped enumNoel Grandin
Change-Id: Iab3d2db50acc1f70b352dd0fd5f1270693a8e991
2016-02-25convert FilterComponent to scoped enumNoel Grandin
and simplify the overly-general logic in FilterManager Change-Id: I2cbd9db6a53894cd13713a5cc0d1807cec456848
2016-02-25convert EComposeRule to scoped enumNoel Grandin
Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9
2016-02-25convert SQLExceptionInfo::TYPE to scoped enumNoel Grandin
Change-Id: I2f21a742bc649fc42f89aebac2691c6054cd20d8
2016-02-25convert InternationalKeyCode to scoped enumNoel Grandin
Change-Id: I2eba99ebb86003f1f5ddefafb4cd191b29853819
2016-02-25convert ErrorCode to scoped enumNoel Grandin
Change-Id: I37d2dd0b84fce229b548bbe941cfdd1169170af9
2016-02-25The XJavaVM.getJavaVM return value can always be extracted to sal_Int64Stephan Bergmann
(avoids warning with MSVC 2015) Change-Id: I9b3c5bc26a1e3df88a03e5fb295eb6a8fb63f824
2016-02-23Guard against globally shared UNO ref accessed from wrong UNO envStephan Bergmann
connectivity/source/drivers/jdbc/jdbc.component has environment="@CPPU_ENV@:affine" to place the com.sun.star.comp.sdbc.JDBCDriver implementation into an affine UNOenvironment. The com.sun.star.sdbcx.comp.hsqldb.Driver implementation (in the normal C++ UNO environment), in ODriverDelegator::connect (connectivity/source/drivers/hsqldb/HDriver.cxx), calls StorageContainer::registerStorage to store an XStorage in a global map, then calls the JDBCDriver (i.e., thread enters the affine environment), which calls via (non-UNO) JNI into hsqldb.jar code, which in turn calls via (non-UNO) JNI into Java_com_sun_star_sdbcx_comp_hsqldb_StorageFileAccess_isStreamElement (connectivity/source/drivers/hsqldb/StorageFileAccess.cxx), which uses StorageContainer::getRegisteredStorage to obtain the XStorage and use it. But that XStorage is the original C++ object, not a proxy that witnesses the mapping between the normal C++ and the affine UNO environment. (And the thread is still in the affine environment, after having passed through the Java stack frames via non-UNO JNI.) That does not necessarily cause any problems immediately (so apparently went unnoticed for quite a while), but when the XStorage-implementation in turn wants to obtain the SimpleLogRing singleton, it would now trigger the std::abort();//TODO in cppuhelper/source/servicemanager.cxx (where the invocation-by-constructor case hasn't yet been implemented for differing environments), when that singleton is changed to use the constructor feature in <https://gerrit.libreoffice.org/#/c/22020/> "tdf#74608: Constructor function for SimpleLogRing singleton." So just do any necessary mapping every time an XStorage stored in the static StorageContainer is accessed. Change-Id: I91a62fd7e1cec29026f70a2c3acdfe051885c0fa
2016-02-23Replace nested pairs with structStephan Bergmann
Change-Id: I95513accce789110fa987b9bf9ca94762fbeb646
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-22Remove TRACE_ALLOC/FREE debugging codeStephan Bergmann
...which started to cause -Werror,-Wunused-variable on Mac OS X after db8067145f0126402be39042934e11228a1b42e9 "loplugin:write only fields" Change-Id: I0cb11e969e8e3835ddd5a33b8e0330135c63a8f6
2016-02-22loplugin:write only fieldsNoel Grandin
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-22WaE vs2015: casting from int32 to pointer to to odbc idiosyncraciesNorbert Thiebaud
Change-Id: I94f2435aee76b03d4b14b009fdeca06a14f22909 Reviewed-on: https://gerrit.libreoffice.org/22599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-18coverity#1352441 silence Resource leakCaolán McNamara
Change-Id: Ib7d771098d640e17a9503d2d780051e916fa6bb3
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-11mork: Clean up unused includesDavid Ostrovsky
Change-Id: Ideff092f49bd84ce829f3ae142de7ff2d32391ab Reviewed-on: https://gerrit.libreoffice.org/22128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09sequence->vector in postgresqlNoel Grandin
Change-Id: I57bf8f4404df9f73d9a52c651c9f27784f10c937
2016-02-09tdf#88462 convert manual XInterface implementationskerem
Change-Id: I00561b7a6de6265cfdea0e3a92f404fac86982f6 Reviewed-on: https://gerrit.libreoffice.org/22213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09sequence->vector in ParameterManagerNoel Grandin
Change-Id: Ifbd3f7f3baf91aa21c085d3be1f67cba0a9068d3 Reviewed-on: https://gerrit.libreoffice.org/22182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05tdf#74608: Ctor function for mork component implementationDavid Ostrovsky
Change-Id: I706e65777c3f7ec1af255d93ffa31925e75fb2b7 Reviewed-on: https://gerrit.libreoffice.org/22123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-04mork: Remove unused source fileDavid Ostrovsky
Change-Id: I0b8c1692c2b04bbbb5486517b2e8de6957ab4b79 Reviewed-on: https://gerrit.libreoffice.org/22104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-04mork: SAL_DELETED_FUNCTION->'= delete'David Ostrovsky
Change-Id: I71e2000920e606e5d550ed5451722cbb80f3dc82
2016-02-04mork: boost::noncopyable->'= delete'David Ostrovsky
Change-Id: Ibe5e44af2348150fef0fa3d3e579ca2893fc6b1c Reviewed-on: https://gerrit.libreoffice.org/22095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-03connectivity: replace boost::bind with lambdaMichael Stahl
Change-Id: I5a68b743221a3519701e4e3778562ae626783e0f
2016-02-02boost::hash->std::hashNoel Grandin
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-25more Windows build fixesNoel Grandin
after my OInterfaceContainer2 change Change-Id: Idab05e4496028d9418b1eb881f62ce33498e008b
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-22GCC PCH says -Werror=unused-macros BOOST_SPIRIT_DEBUGMichael Stahl
... so try to blacklist that boost::spirit header, it is fortunately included only in one cxx file per library anyway. Change-Id: I95752540d33b2b20d7a185c05c4d4d15e660d956
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e Reviewed-on: https://gerrit.libreoffice.org/21603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-13connectivity: suppress MSVC 2013 --enable-lto warning C4702Michael Stahl
Change-Id: I55b27c655de221c10bac6f868a59b0dbd6cd8d32
2016-01-13-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: Ide514da5b4413974e50beeb4f41881294475303c
2016-01-12connectivity: remove MSVC 2012 specific hackMichael Stahl
Change-Id: I78a25118d68ab7ad1db5240910f0974ba1e8381f
2016-01-11loplugin:defaultparamsStephan Bergmann
Change-Id: I60c66ae8944cb4cfe82bfb762d9739446362b61b
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-07Some cleanup for sal_uIntPtr usageJohannes Hauf
Change-Id: Ia9779e6477d8848588f3543d09ea6b4477f594a2 Reviewed-on: https://gerrit.libreoffice.org/21022 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05Revert "WIP tdf#72987 Use firebird backup format for .odb no need for ↵Lionel Elie Mamane
rebuild indexes" This reverts commit f961fef03906fc059a4a0c008799f68fc22727c1. This can be done only *after* the firebird driver switches to the backup format. Change-Id: I71874ab6d4b4da9648e08d037786a56f9421751d Reviewed-on: https://gerrit.libreoffice.org/21113 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
generated by cgit (git 2.34.1) at 2025-02-10 15:32:17 +0000