summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2018-03-05Rename OCharsetMap::find overload to findIanaNameStephan Bergmann
Change-Id: Id3fe81b41b92d6ad4e3f7127331d859a7b3c7f54 Reviewed-on: https://gerrit.libreoffice.org/50779 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-05tdf#116171: Tunnel arbitrary rtl_TextEncoding from sc to sdbc:dbase connectionStephan Bergmann
...including those that have no corresponding textual IANA character set name representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some DBase files. In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection it was sent as an empty string CharSet property, which the receiving OConnection::construct translated back to else m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW; so the net effect remains the same for that special case. Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4 Reviewed-on: https://gerrit.libreoffice.org/50772 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-28Translate German comments and debug stringsJohnny_M
Change-Id: Ie2da785cb674e21f042caa5e6d461e3489036003 Reviewed-on: https://gerrit.libreoffice.org/50467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-16connectitivty: can use o3tl::make_unique<> hereMiklos Vajna
Change-Id: Ia01bf2866e3f688dfab64c5fd72e787e4409fb75 Reviewed-on: https://gerrit.libreoffice.org/49830 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-12cppcheck useInitializationListJochen Nitschke
unique_ptr don't need explicit nullptr initialization, same goes for VclPtr in ImpEditEngine. Change-Id: Id8f3163c2719bee6ee2724cae98449d564be5535 Reviewed-on: https://gerrit.libreoffice.org/49559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in OTableNoel Grandin
use rtl::Reference here since these are reference counted data structures, and we hand out references to me via our API Change-Id: I8f69dde2db08519cb3d9de20b4ad54462e3ecc98 Reviewed-on: https://gerrit.libreoffice.org/49180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in OStatement_BaseNoel Grandin
Change-Id: I41bc59c7ff7d711e0fc877e843625fa54c96b6bc Reviewed-on: https://gerrit.libreoffice.org/49183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in OSQLParseNodeNoel Grandin
Change-Id: Ibad6e4b32b19a925de621b9dea7070d3930f05ef Reviewed-on: https://gerrit.libreoffice.org/49182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05loplugin:useuniqueptr in OConnectionNoel Grandin
Change-Id: I0f1069eefc6d0afa8aa852af76099e79c63cbed9 Reviewed-on: https://gerrit.libreoffice.org/49181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02remove connectivity OSubComponentNoel Grandin
push the logic that is still necessary down into the subclasses Change-Id: I99424f0b3c654c5652991a4140b17ceb02224e50 Reviewed-on: https://gerrit.libreoffice.org/49087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01connectivity: remove dead codeChris Sherlock
Change-Id: Ia968179d90978dc6c737effce5447efda60c1f66 Reviewed-on: https://gerrit.libreoffice.org/47490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-31connectivity: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I22553d7cbbae7cfaac3f39a17db54dfe06e2e5bc Reviewed-on: https://gerrit.libreoffice.org/48989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-30coverity#1421119 Dereference after null checkCaolán McNamara
Change-Id: Ic5002a25ed51fe72e1f36f365707101632d786e1 Reviewed-on: https://gerrit.libreoffice.org/48905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-29Fix typosAndrea Gelmini
Change-Id: Iedd82d035454c940d76a94c7e910c81827c1389c Reviewed-on: https://gerrit.libreoffice.org/48828 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-29sw: prefix members of SwExtUserField, SwFileNameField and SwFileNameFieldTypeMiklos Vajna
Change-Id: I0722417149c9fbcd2aee3491c841c036a5677c8d Reviewed-on: https://gerrit.libreoffice.org/48807 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-29loplugin:useuniqueptr in OCatalogNoel Grandin
Change-Id: Ie06456ac8971494f64711cd70fd2b32a4dce719d Reviewed-on: https://gerrit.libreoffice.org/48740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-27Modernize a bit connectivity (part2)Julien Nabet
by using for range loops Change-Id: Ibbc4cdaa78c4c9d88487132a2761ac1040b1ecd8 Reviewed-on: https://gerrit.libreoffice.org/48713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-27Add HSQLDB schema importTamas Bunth
It can be enabled by initializing the DBACCESS_HSQL_MIGRATION variable. Create new library "dbahsql" which is responsible for migrating the embedded hsql database to any database covered by sdbc. The hsqldb schema is stored in a file named "script" in form of SQL statements. The SQL statements used by DBMS's differ mostly by the defined types. Because of that, only the create statements need to be parsed, alter statements will work (with a little luck) without actually modifying it. User / security settings which can occur in the script file (e.g. GRANT statements) are dropped. Statements starting with SET are also dropped (they are hsql specific stuff) Change-Id: I6a22942e8a9a76765f80e50f0ad68f4d72e1ff9d Reviewed-on: https://gerrit.libreoffice.org/48260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-01-26Modernize a bit connectivity (part1)Julien Nabet
by using for range loops + use returned iterator by erase call in ZConnectionPool Change-Id: I97b14b24ebddefea909bc17cb3463f840fde38a0 Reviewed-on: https://gerrit.libreoffice.org/48634 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-26Update comment to reflect the right typeJens Carl
Follow up from commit 4cdb7fa375ba1894deb412853214f01f95bd3f05, where it was missed. Change-Id: Icfc123b0e238705f175fda6308ecc40569d3a31a Reviewed-on: https://gerrit.libreoffice.org/48643 Reviewed-by: Jens Carl <j.carl43@gmx.de> Tested-by: Jens Carl <j.carl43@gmx.de>
2018-01-25Change property value to get CellContentType in connectivity/Jens Carl
Follow up from commit cceaece18a42405190941865908636522e0ee4cb. Change-Id: I29df5403204279b038095156c85638877d2dc9ff Reviewed-on: https://gerrit.libreoffice.org/48465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-25loplugin:unused-returns in basegfx..cppcanvasNoel Grandin
Change-Id: I32dc8c92871c8349651d2f4204a332d387e6e1b2 Reviewed-on: https://gerrit.libreoffice.org/48428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24Fix some IWYU warningsMiklos Vajna
Change-Id: I4b6e799c1afc2a762a3729ee89f3226c59a6eef8 Reviewed-on: https://gerrit.libreoffice.org/48462 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22remove some sal_Bool remnantsNoel Grandin
Change-Id: I0a9637aca523a73fbdbbd22f9ad735d6d1ba6898 Reviewed-on: https://gerrit.libreoffice.org/48273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-20loplugin:emptyif (macOS)Stephan Bergmann
Change-Id: I0abd0ace30f172d0991be697e6f78edd50ddeaaa Reviewed-on: https://gerrit.libreoffice.org/48214 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-20More loplugin:cstylecast on macOSStephan Bergmann
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Iff4877e8a42804c952c48c13332caf0a83c92870 Reviewed-on: https://gerrit.libreoffice.org/48216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19loplugin:unnecessaryparen (macOS)Stephan Bergmann
Change-Id: Ie4ae8459c0afbeac0cad1b8a30dad02535d558dd Reviewed-on: https://gerrit.libreoffice.org/48190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19new loplugin:emptyifNoel Grandin
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19SAL_W32 is just an alias for _WIN32Stephan Bergmann
...so consistently use the latter instead of the former Change-Id: I144d5e7c472632f93b2258461510346bc85892d9 Reviewed-on: https://gerrit.libreoffice.org/48135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-17Fix typosAndrea Gelmini
Change-Id: I18ce04cbaa79c827a52e2441e98ee2e3377b5877 Reviewed-on: https://gerrit.libreoffice.org/48077 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-17loplugin:unnecessaryparen extend to delete statementsNoel Grandin
Change-Id: Ic4383ea948876a26f791f0e5b0110cef978a26e1 Reviewed-on: https://gerrit.libreoffice.org/48027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-16Fix typosAndrea Gelmini
Change-Id: Ia976371bf52eb1216d8abe728d80bbb87a3c38a2 Reviewed-on: https://gerrit.libreoffice.org/47858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-15More loplugin:cstylecast: connectivityStephan Bergmann
Change-Id: Id7cbe6a119b944813bc7638b08e59d4705607ece
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-14Fix typosAndrea Gelmini
Change-Id: Icc5fc590a6a90e30afa5f61028d4dd0279fbe120 Reviewed-on: https://gerrit.libreoffice.org/47861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-12More loplugin:cstylecast: connectivityStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Idbefb16acae20ab137497e78c9bc5dc5634c07fe
2018-01-11loplugin:redundantcast: connectivityStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: I43a148a0d192f85bbad95696c7c3c3e717c5b00a
2018-01-11connectivity: various small cleanups in the Writer driverMiklos Vajna
Change-Id: I91735c3e92262fd37966c53f973d5eee1522cd61 Reviewed-on: https://gerrit.libreoffice.org/47741 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-11(related:tdf#114939) connectivity: use real SHA1Michael Stahl
It looks like OConnectionWrapper::createUniqueId() doesn't really care what particular hash is used, it just wants to create something unique, so don't use the 'special' StarOffice SHA1 here. Change-Id: I817be900ecc9c6d686f21cce4a46f9eadd244b71
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-07fixup tdf#104986 move named parameters substitution into generic layerLionel Elie Mamane
remove now unused class member Change-Id: I30ffcf60833580a5f0029fa4efef80507d7918df Reviewed-on: https://gerrit.libreoffice.org/47524 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-07tdf#114495 ODBC: clear row status buffer *before* we throw away the statementJulien Nabet
Change-Id: I898e9d0e3e2cf1ed41489231d1cd761171bfcea4 Reviewed-on: https://gerrit.libreoffice.org/47514 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-01-06Revert "tdf#114495: fix crash in odbc resultset dtr"Julien Nabet
This reverts commit 89e354eff9d99d05461e2892fb1af56d186b8653. Change-Id: I73435ba76d7d7ca7ebf91eeced470fb792786c92 Reviewed-on: https://gerrit.libreoffice.org/47513 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-06tdf#114495: fix crash in odbc resultset dtrJulien Nabet
See bt https://bugs.documentfoundation.org/attachment.cgi?id=138913 Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=12d5e57dcac22c288ef23075b82e3e3e87929912 Change-Id: Ic079b87370207a1e51d747e250caea2bfcbc8c17 Reviewed-on: https://gerrit.libreoffice.org/47496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-04tdf#104986 move named parameters substitution into generic layerLionel Elie Mamane
Previously, drivers were responsible for making the substitution themselves. In practice they all (Firebird, ODBC and JDBC) used the LibreOffice SQL parser to parse the SQL statement and do the substitution. This had a few negative consequences: * The substitition was applied to _all_ SQL commands, including queries having the "execute SQL directly" bit set. Which means that the SQL was _not_ sent to the DBMS exactly as typed by the user. Even if there was no substitution to be made, since the SQL command was always round-tripped through the parser, thus "normalising" it (which is what led to tdf#104986). * "execute SQL directly" queries "magically" behaved slightly differently depending on whether the LibreOffice SQL parser succeeded in parsing them or not. Change-Id: Ieedc643f33467435a139e2565a01e6f398af041f Reviewed-on: https://gerrit.libreoffice.org/47283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-01-04firebird-sdbc: check parameter index before setting in all casesLionel Elie Mamane
Change-Id: I291b0436a7cfde07879436a753329b52ff0c1049 Reviewed-on: https://gerrit.libreoffice.org/47284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02tdf#104986: Add MILLISECOND, WEEKDAY, and YEARDAY tokens for FirebirdTor Lillqvist
Change-Id: I2ba866c408dbf49f1655cc08cc5d0df840eaf01e Reviewed-on: https://gerrit.libreoffice.org/47271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-01-02tdf#71007: Pass also fractional seconds to/from FirebirdTor Lillqvist
We know that ISC_TIME is simply in units of seconds/ISC_TIME_SECONDS_PRECISION. Change-Id: I2896f53c2d32a773c535e19f55dd1314abd18ec9 Reviewed-on: https://gerrit.libreoffice.org/47266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-16 04:22:59 +0000