summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2015-11-02tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-11-02loplugin:stringconstantNoel Grandin
Change-Id: I736e0d63ed891aee1582844aff25b9bdacab8db9
2015-10-30fix OSX buildNoel Grandin
after my commit cb4fa1d1e2e61b686442a9d26220c0f1a6e1d4e7 "use uno::Reference::set method instead of assignment" Change-Id: Iecbcd2ffd521913a63374a56c5179065cca42f09
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30cppcheck: unreadVariableCaolán McNamara
Change-Id: I109e5f36a524e2996d00bf81e873776d0d738011
2015-10-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27Reduce scope of #include <tools/stream.hxx>Matteo Casalin
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-27loplugin:unusedmethodsNoel Grandin
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-25Remove Seamonkey based address book driverDavid Ostrovsky
Seamonkey based address book driver is based on pre-compiled libraries and is only used on Windows 32 bit. Remove it in favor of mork driver. Given that Seamonkey based mozab driver also provides Outlook and Outlook Express address book integration, that Windows-32-bit--only feature is lost for now. If necessary, support for that feature could be rewritten from scratch, in a way that would also work for Windows 64 bit. Change-Id: Ie1c125e692598bda999767c328c9e2262a2b82af Reviewed-on: https://gerrit.libreoffice.org/19560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-21refactor out some com::sun::star typedefsNoel Grandin
which mostly serve to make the code harder to read Change-Id: Ia2a83fee9f850ab6f0bea6305ce8600d6b785fe8
2015-10-21loplugin:badvectorinitStephan Bergmann
Change-Id: I3fa3e83e67b5ba017bbd2a33edaf41207e5fe96f
2015-10-20new loplugin: badvectorinitNoel Grandin
look for places calling the 1-argument vector fill constructor and then immediately called push_back, which is generally a sign that its leaving empty slots. Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517 Reviewed-on: https://gerrit.libreoffice.org/17525 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: I7e232e92cc9d058f93eff9f7249e37ed3a9cd9ac
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: I8e40cf9166aa65c81cb6b4ed17506ec5b9d725e3
2015-10-18tdf#72205 a VARCHAR and a LONGVARCHAR should compare equalLionel Elie Mamane
Change-Id: Id20ceb22bb04570c9c52df4d8233a7afa8ba0168 Reviewed-on: https://gerrit.libreoffice.org/19436 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-10-18janitorial: indentLionel Elie Mamane
Change-Id: I26030811a5da551482b0cc2a18c302160ada6cd6 Reviewed-on: https://gerrit.libreoffice.org/19435 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-10-16convert "continue" flag to an enumNoel Grandin
Change-Id: I160de1152978f301c514d9107c9e9082bab3cf05
2015-10-15cid#1327023 to cid#1327077 SIC: Inner class could be made staticNoel Grandin
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-13remove some useless commentsNoel Grandin
found with git grep '// /' Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13connectivity: drop unused headersDouglas Mencken
add to MacabRecord.hxx only what's really needed Change-Id: I7b11fb6f403957009ac590714b9972e2989d7aff Reviewed-on: https://gerrit.libreoffice.org/19332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-13TDE: fix build of the address book driver, 2ndJan-Marek Glogowski
The tdeab1 also needs boost headers. Not sure why my compile survived the first time (ccache?), after removin the boost headers from the makefile. Change-Id: I2b1f88f17eef549cb3effd2267d15ba97627f2b1
2015-10-12TDE: fix build of the address book driverJan-Marek Glogowski
From the compile failures, it apparently uses boost headers. Change-Id: I952847187f53e6c00ed39020c4922d427dca9189
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12tdf#65108 "" instead of <> written in include lineFeyza Yavuz
Underwent the same process under the connectivity/source/drivers/firebird/ Change-Id: Id64b1f52a2f19cb91590bebe80a2f6aea70cc9ee Reviewed-on: https://gerrit.libreoffice.org/19137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-06clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: Ie1416bdd0740efa78e1ebdba9d50536f1768b046
2015-10-06clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I4c73594326f4c20f25433dea2112115ad1a12299
2015-10-06clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I40017006cdf8b8454d487b4b78bebb6350476390
2015-10-06clang-analyzer-deadcode.DeadStoresStephan Bergmann
nLen was unused ever since 5e1b6f684538df8e38f8d60619a2ae2e792edf47 "first version" Change-Id: I110ccf9156c4d0c4b47b0fba928d388ba7e06387
2015-10-06loplugin:unusedmethodsNoel Grandin
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-01coverity#1209375 Unchecked dynamic_castCaolán McNamara
Change-Id: Ib6ac44878c6f485326c16fd0224b220e86a4dc6a
2015-09-30Fix typosAndrea Gelmini
Change-Id: I13c3dc33722f139582f27412d5d336264d3d15a3 Reviewed-on: https://gerrit.libreoffice.org/18942 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 tdf#94559: second step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in chart2, connectivity, editeng, extensions, filter, forms, framework, idl Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99 Reviewed-on: https://gerrit.libreoffice.org/18920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30Fix typosAndrea Gelmini
Change-Id: Iaff7e38dd5beac48e1643e369e4240aa736c35ea Reviewed-on: https://gerrit.libreoffice.org/18941 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-23CppCheck : reduce variables scopeMichaël Lefèvre
Change-Id: Ief402017b693a4337f330fb07bb7a6dc6e749f72 Reviewed-on: https://gerrit.libreoffice.org/18753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14boost->stdCaolán McNamara
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09 Reviewed-on: https://gerrit.libreoffice.org/18568 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-13cppcheck: unreadVariableCaolán McNamara
Change-Id: Ia611c9a1119af65688031d16ff322f1bde43297b
2015-09-12tdf#92794: '$' should be replaced in error dialog of addressbookJulien Nabet
Change-Id: Ic57611be96f160037fbff2e9452f9206083c80e4 Reviewed-on: https://gerrit.libreoffice.org/18324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-09Get rid of connectivity's diagnose_ex.hStephan Bergmann
...that rather trivially wrapped some osl/diagnose.h functionality Change-Id: I4105708488114a9c87aa415affb997a783241248
2015-09-09Get rid of OSL_UNUSEDStephan Bergmann
In many cases it was originally used to silence warnings about variables used only in OSL_ENSURE etc., but that's no longer necessary since OSL_ENSURE is based on SAL_WARN etc. In some other cases it was apparently used as a speculative debugging aid, to have a value assigned to a variable to be easily able to view the value in a debugger. And in some cases it was used with (otherwise ignored) return values of (typically SQL-related) function calls, but it is probably better to eventually find and fix all the problematic ones among such calls via function declarations annotated SAL_WARN_UNUSED_RESULT. Change-Id: Ib925b38da70073b546fdcd00fa8524dc302accbf
2015-09-08clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since OResultSet::fillNeededData got introduced in 8687beec5dfc08b28accc7779e0f7762cd947f12 "INTEGRATION: CWS insight01" (and the return value of the N3SQLPutData call in the first case block had always been ignored completely, not even unnecessarily assigned to nRet as in these later two case blocks) Change-Id: I1d2005e7c91749510b23f86ac792bd11ae564608
2015-09-08clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since b309e422c631ce6ce729552cc8053478f9539dfd "#95348# type usage changed" introduced the local nMaxLen and passed that instead of _nMaxLen into the two ODBC3SQLFunctionId::BindCol calls Change-Id: Ifb561106c87b6e424ccc9d350752b19b3648c7c8
2015-09-08clang-analyzer-deadcode.DeadStoresStephan Bergmann
...at least since 4695f7d361641ea4dcd927a7b4aab86e0c971d5b "#82018# check for double column names" removed the commented-out code that would have used it (and which had been commented out ever since the code got introduced) Change-Id: I11e9cafb53894ce7cb7ffc031f2d6b047bd3258d
2015-09-03remove KDE3 support, --enable-kde and --enable-kdeabMichael Stahl
With the new RHEL6-era baseline TDF can finally ship KDE4 support. Change-Id: I227278b576a3ed2f2aaa751d41b469ca92dc78b3 Reviewed-on: https://gerrit.libreoffice.org/18267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-03warning: nonterminal usesless in grammarStephan Bergmann
...ever since its use got removed in 17e1d9f46d7957b7ec54943122ddd5fbace19ab8 "INTEGRATION: CWS oj4" Change-Id: I6494e11bb162d4c4bb880a6c4f9ece01331975dd
2015-09-03tdf#88462 connectivity convert manual XInterfaceDaniel Robertson
Convert postgresql driver ReflectionBase manual XInterface implementation to use ::cppu::WeakComponentImplHelper. Change-Id: I738bd7df33de9c0fe0e3242eb5a4fab6a8dcb3f0 Reviewed-on: https://gerrit.libreoffice.org/18207 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-03warning: nonterminal usesless in grammarStephan Bergmann
Change-Id: I97f3fb5cf62a68460157b2302a84d56a1417d376
generated by cgit (git 2.34.1) at 2024-08-16 13:13:47 +0000