Age | Commit message (Collapse) | Author |
|
Change-Id: Ic48aee378d0a89466c49de85baa96a3bea127d2f
Reviewed-on: https://gerrit.libreoffice.org/55771
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit c179e8a7ea273a48713192c3ba7dfea313149cd8)
Reviewed-on: https://gerrit.libreoffice.org/55780
Tested-by: Jenkins
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
(cherry picked from commit 4de33eb2b5a802e8eda36c5806913efeead68441)
|
|
Change-Id: I51db43c1a3b6d3c93a04a3419238ea286cab987e
Reviewed-on: https://gerrit.libreoffice.org/52577
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 1ddb065adcd0c2f5666e86bdf841d818ab7a215e)
|
|
It can be enabled by initializing the DBACCESS_HSQL_MIGRATION variable.
Create new library "dbahsql" which is responsible for migrating the
embedded hsql database to any database covered by sdbc.
The hsqldb schema is stored in a file named "script" in form of SQL
statements. The SQL statements used by DBMS's differ mostly by the
defined types. Because of that, only the create statements need to be
parsed, alter statements will work (with a little luck) without actually
modifying it.
User / security settings which can occur in the script file (e.g. GRANT
statements) are dropped. Statements starting with SET are also dropped
(they are hsql specific stuff)
Change-Id: I6a22942e8a9a76765f80e50f0ad68f4d72e1ff9d
Reviewed-on: https://gerrit.libreoffice.org/48260
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 95bece38ac5c943657ad959cad148c84a91d45a4)
|
|
Change-Id: I2ba866c408dbf49f1655cc08cc5d0df840eaf01e
Reviewed-on: https://gerrit.libreoffice.org/47271
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 72ff62a13af402d19e6e53b809b29033a985c04a)
|
|
We know that ISC_TIME is simply in units of
seconds/ISC_TIME_SECONDS_PRECISION.
Change-Id: I2896f53c2d32a773c535e19f55dd1314abd18ec9
Reviewed-on: https://gerrit.libreoffice.org/47266
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit e0a22d47d281f61f51ead6d2831cd53c15036ffe)
|
|
Implement it as a user-defined Blob subtype.
Change-Id: Ia369b6858e7d9191f34032445c1003931273e926
Reviewed-on: https://gerrit.libreoffice.org/47098
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 0217031a98508731f15df9d361a6e5b584db5716)
|
|
Change-Id: I435524d1852a6691b382b93c9b6d2a7705938cd7
Reviewed-on: https://gerrit.libreoffice.org/47130
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 64d4f117447d990ed3215b0dd619e07de26ce417)
|
|
Create a more effective implementation of XClob::length() and
XClob::getSubString() methods, where string is read segment-by-segment
instead of reading the whole underlying blob. That way it is possible to
handle big texts which would not fit into memory.
Also allow reading Clob data from a resultset with getString() and
writing it in a prepared statement with setString().
Implement XPreparedStatement::setClob(). Also implement a private
version of setClob() for creating a clob from OUString:
Allow the creation of a clob column with GUI by adding a new type in
ODataBaseMetaData::getTypeInfo().
Change-Id: Ibcbbdd80e8eed5e2a3fe55b0fa196401f1bcbcdf
Reviewed-on: https://gerrit.libreoffice.org/47093
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit f80b51ae441e3483a2e9b77a30b932d4e8fba192)
|
|
Change-Id: I9a1b3aa9bde855577078fe0db2e31a9c160031d7
Reviewed-on: https://gerrit.libreoffice.org/47092
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit e7a80ddb91c44711296aa996bf00242edbfba32d)
|
|
There is no explicit binary type in Firebird. It can be accomplished
using the CHAR type with a special character set, which tells the
database that it is binary data and there is no collation. (called
OCTETS).
Because of that, we also need the character set to decide the exact
column type.
And also refactor some parts of the driver:
- Create class to determine internal type from firebird type, subtype,
scale and character set.
- Use internal type (DataType::XXX) in XDatabaseMetaData::getTypeInfo()
indirectly. (We want to return a Firebird type for each internal type,
not in the opposite direction.
Change-Id: Ica56a84d89253e11936e7012086fe1d9f61a65f0
Reviewed-on: https://gerrit.libreoffice.org/47091
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit bf662904c4b60e93c6b86e06288d41996eed12a2)
|
|
Change-Id: I398bf195a8cfebe081fd3034d6c539b02aaf6d73
Reviewed-on: https://gerrit.libreoffice.org/46148
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 8abda0217dcdfc45fc0f7e74a37d048c5fda395f)
|
|
..but suppress error of closing closed cursor
Change-Id: I58f96f02f3f600a089bde361ed3e46a03a4902d4
Reviewed-on: https://gerrit.libreoffice.org/46141
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 032a3e3713af3e308229bd8e1ada17d6d24072f3)
|
|
Change-Id: I8cb4eaebd71d8b06523230954da15d73325ac94b
Reviewed-on: https://gerrit.libreoffice.org/46130
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 907423a6ec5c2170dbf2ca445c0a1285e9a6adfc)
|
|
A cursor need only be closed in this manner if it was previously
opened and associated with stmt_handle by isc_dsql_set_cursor_name()
See Interbase API Guide: isc_dsql_free_statement
Reviewed-on: https://gerrit.libreoffice.org/46132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 9585521c28b74dec36522a6501ca670b8e14c7ca)
Change-Id: Iadb0dcf83ee58b6196112c44d922528a3f56f7ea
|
|
Change-Id: I471197a9c60ca28b93be0974956e5e1d90f843ca
Reviewed-on: https://gerrit.libreoffice.org/46125
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 9ccc1f59446bc4a16b6d090a3b556e184eb5f159)
|
|
...including those that have no corresponding textual IANA character set name
representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some
DBase files.
In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection
it was sent as an empty string CharSet property, which the receiving
OConnection::construct translated back to
else
m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW;
so the net effect remains the same for that special case.
Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4
Reviewed-on: https://gerrit.libreoffice.org/50772
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 5ad62544bce42396faaae2bc79c7517af6ff085b)
Reviewed-on: https://gerrit.libreoffice.org/50780
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Merge of:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=9585521c28b74dec36522a6501ca670b8e14c7ca
+
https://cgit.freedesktop.org/libreoffice/core/commit/?id=032a3e3713af3e308229bd8e1ada17d6d24072f3
Change-Id: Iadb0dcf83ee58b6196112c44d922528a3f56f7ea
Reviewed-on: https://gerrit.libreoffice.org/46132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/47543
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I898e9d0e3e2cf1ed41489231d1cd761171bfcea4
Reviewed-on: https://gerrit.libreoffice.org/47514
(cherry picked from commit 964cc98794941dbf7dccce526c4fa88c16b3a26c)
Reviewed-on: https://gerrit.libreoffice.org/47525
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
It's the length of the OUString that we just made from the
OUStringBuffer that we want.
Fixes a problem where the code would try to execute an erronoeus SQL
statement like:
')EATE TABLE "Tasks" ("Notes" VARCHAR(32765),"TaskID" INTEGER,"EndDate" DATE,"StartDate" DATE,"Description" VARCHAR(65000),'
Too lazy to file a bug for this, the error should be obvious by just
reading the code.
Change-Id: I473cd8a7a9791700ca8b6467a84f4bad5dee4d55
Reviewed-on: https://gerrit.libreoffice.org/47230
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit d48edd1e854e0df012b61f833d83efcd19fbe99b)
Reviewed-on: https://gerrit.libreoffice.org/47231
|
|
There's no TINYINT or equivalent so let's do the same as setShort
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit f31ccd18f1b142f8c851e7e219f8bc18b157bc52)
Change-Id: Ia1154ee068b02f40e7efa21571036d8b49844859
Reviewed-on: https://gerrit.libreoffice.org/47237
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
...as it makes JunitTest_dbaccess_complex fail on Windows. Apparently, those
files are held open by soffice for whatever reason. Needs further
investigation...
Change-Id: Id80b6f58288deaa39fc74fe36886e371968f8d82
Reviewed-on: https://gerrit.libreoffice.org/45596
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Remove a duplicated and commented T3SQLNativeSql definition.
Patch by: me
(cherry picked from commit 72c9a57b915e080b4bd27800f30232624172b1c3)
Change-Id: I2730ede794f750181075b253f62951d47ec82ddc
Reviewed-on: https://gerrit.libreoffice.org/45176
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...which revealed that lcl_CFType.cf should rather be of type CFTypeID (i.e.,
unsigned long), and required some adaption of for loops to cope with the type
differences between old sal_Int32 length vars and new std::vector::size calls.
Change-Id: Ic87acbb8b4255627fa976d3615bb319237aa4deb
Reviewed-on: https://gerrit.libreoffice.org/45154
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12
Reviewed-on: https://gerrit.libreoffice.org/45075
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0
Reviewed-on: https://gerrit.libreoffice.org/44944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d
Reviewed-on: https://gerrit.libreoffice.org/44875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
OTools::ThrowException uses SQLGetDiagRec to get error message. It's not
the caller's responsibility to define the encoding of resulting string.
Also, using the default setting of RTL_TEXTENCODING_MS_1252 turns
returned localized strings into garbage.
To allow correct conversion into Unicode string, let's use current
thread encoding, and drop the input encoding parameter.
Change-Id: Idb02e3ebb4fc407ce5e658fb2137ea2aa3bc127d
Reviewed-on: https://gerrit.libreoffice.org/44877
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
...that are created in java.io.tmpdir (e.g., /tmp on Linux) by
connectivity.tools.HsqlDatabase.createDBDocument() during e.g.
JunitTest_dbaccess_complex.
This revealed that connectivity.tools.AbstractDatabase.delete() (even if it
would have been called by the test) would have been non-effective at deleting
the file, as the java.io.File constructor used takes a pathname not a file URL
as argument, so the call to java.io.File.delete() would not have deleted the
relevant file (and returned false, rather).
Change-Id: I268e1d1732ac7a0db9ccde7d4ac4f09aa3811e11
Reviewed-on: https://gerrit.libreoffice.org/44801
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: If4da1df3f7889d2b579fcde4fec5ac3c82026555
Reviewed-on: https://gerrit.libreoffice.org/44627
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I49387d2b6ec1893bf721e3289f2f620a4ce71fb3
Reviewed-on: https://gerrit.libreoffice.org/44668
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91
Reviewed-on: https://gerrit.libreoffice.org/44654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
|
|
Change-Id: Idcc6b1734599eec5d9eefbefb8849dc050b6a9d6
Reviewed-on: https://gerrit.libreoffice.org/44522
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: Ib15931e415990b56367fe3e1c7cf3f22cc4826d5
Reviewed-on: https://gerrit.libreoffice.org/44529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I0cd075efad83c0a8d6f05c91201a9aa86649590b
Reviewed-on: https://gerrit.libreoffice.org/44386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...to connectivity/source/inc/ado/, as it is included from include files there,
which only happens to work because of -I$(dir $(3)) in
gb_CObject__command_pattern (in solenv/gbuild/platform/com_MSC_class.mk) and the
fact that those include files in connectivity/source/inc/ado/ are in turn only
included from .cxx files in connectivity/source/drivers/ado/.
Change-Id: I0bbecaeeaac1f94fa86355e391d2826f3e29c440
Reviewed-on: https://gerrit.libreoffice.org/44230
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia13d0931bbdf642fe04119ea1112788fb143eba8
Reviewed-on: https://gerrit.libreoffice.org/44110
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I27b865cbb79c9ed9c1b5af9f0666450778ae8335
|
|
Change-Id: Ib87a1dae55f926baffe1cf436fedeab59508d253
|
|
Change-Id: I06596fac09f0568b8bab2e2e235a2b88bcd3fc7a
|
|
no need to explicitly specify it anymore
Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...instead of implicitly next to the including file, in preparation of
loplugin:includeform
Change-Id: I4272c5e24eb887a36a6f3c296def375956f56499
|
|
... living in an ASCII world?
Change-Id: I82912924420766734573a10b2e110fef6fcadd1c
Reviewed-on: https://gerrit.libreoffice.org/43343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Quite certainly the decimal separator wasn't to be obtained twice
and used as group separator the second time..
Change-Id: I8fb1a066f7f33f377fc98f917aeadad74c41205b
Reviewed-on: https://gerrit.libreoffice.org/43342
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Fow now just don't crash on them, instead give empty result for those
cells.
Change-Id: I9edd231b00fa00af95408a550484da74c98275da
Reviewed-on: https://gerrit.libreoffice.org/43319
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Since the buffer pointed to by SQL_ATTR_FETCH_BOOKMARK_PTR is not free()/delete()ed by the destructor of OResultSet, this is not the right place to unregister it.
This reverts commit b76a087f73cdf3d1a8bcc56b1ed7a5959ca0f1bd.
Change-Id: I78e162c0ced1a15decc4a0f464c99f68fcac7ce5
Reviewed-on: https://gerrit.libreoffice.org/43270
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
|
|
Change-Id: I75141d99744bf3133b6c64aec9a56db13f836d0c
Reviewed-on: https://gerrit.libreoffice.org/43264
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
As discussed here:
https://bugs.documentfoundation.org/show_bug.cgi?id=112947#c9
and
https://bugs.documentfoundation.org/show_bug.cgi?id=112947#c10
Change-Id: I4376c090c4da3f25487d404ed8c0e00ca51ca204
Reviewed-on: https://gerrit.libreoffice.org/43241
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
suggested by Nick Gorham
Change-Id: I3579caf5192df6e460dea3a5b3728196d75a65f4
Reviewed-on: https://gerrit.libreoffice.org/43234
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
instead of manual ref counting
Change-Id: I210d4a2cd6487bd2d7d81a53106b484fe411ca9b
Reviewed-on: https://gerrit.libreoffice.org/43203
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|