summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2019-03-13connectivity Writer driver: use auto when initializing with new to avoid ...Miklos Vajna
... duplicating the type name Change-Id: I12b2302c4316b3ec1f22df366100c3b2a4d87454 Reviewed-on: https://gerrit.libreoffice.org/69173 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-13tdf#121092: synchronize defaults for drivers settingsMike Kaganski
See commit f33eb08a2b74e5de033af9b5f5283b220ac58ded for details TODO: reimplement defaults to be taken from the Drivers.xcu, not from ODatabaseModelImpl::getDefaultDataSourceSettings. TODO: always write settings, even if they are equal to defaults (unless they are schema defaults) - that will allow to change a default, and not break existing configurations. Change-Id: Ic0fa9a03bf801aeca3e6373eb7019f5ad7e8eb46 Reviewed-on: https://gerrit.libreoffice.org/69076 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-13Removed duplicated includeAndrea Gelmini
Change-Id: Iea9ca5fed98f1040dd697324f9818d0014f5f79f Reviewed-on: https://gerrit.libreoffice.org/69149 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-12tdf#42949 Fix IWYU warnings in include/connectivity/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221 Reviewed-on: https://gerrit.libreoffice.org/68893 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-11Related: tdf#123975 I think this needs to be initially unsetCaolán McNamara
i.e. https://help.libreoffice.org/Common/Special_Settings#Supports_primary_keys "This tri-state check box by default is set to the undetermined state" otherwise the fix for tdf#123975 has no effect this change initially in... commit 3208fcb3a36d75d6290d9c548430682f153b09db Date: Thu Sep 13 22:57:58 2018 +0200 tdf#119743: add Features entries in Properties block Drivers.xcu Change-Id: Ic08fb1330985b90eec10662d50462f4ec127b9f9 Reviewed-on: https://gerrit.libreoffice.org/69042 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11tdf#121092: save AppendTableAliasName to ODBMike Kaganski
This property corresponds to AppendTableAliasInSelect in Features sections. Also the default value in Drivers.xcu for ODBC made consistent with that in ODatabaseModelImpl::getDefaultDataSourceSettings. Change-Id: I95335e0808b9b8021189c2c75826c2d792a10566 Reviewed-on: https://gerrit.libreoffice.org/69028 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-10tdf#121092: save GenerateASBeforeCorrelationName to ODBMike Kaganski
As mentioned in connectivity/registry/README, the property should be named differently in Features and Properties sections. Also the default value set in ODbAdminDialog::createItemSet should be synchronized with the other defaults, because otherwise, in case when the value is absent in the set (when it is default), this value is used in the dialog... sigh, we have too much places where relevant defaults are generated and need to be in sync. TODO: this should be reimplemented to take all defaults from the xcu. Change-Id: Ia61ab2e585107ede9c977cf563cb30e45d624bed Reviewed-on: https://gerrit.libreoffice.org/69002 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-10Fix typoAndrea Gelmini
Change-Id: Id92be196bd4a6a061ef7985d8a07ab0be4523a0f Reviewed-on: https://gerrit.libreoffice.org/68986 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-10tdf#39593 use existing clearConnectionPools() methodArkadiy Illarionov
Change-Id: I318508531b3f52da2d699e6d35c7cda72d4de115 Reviewed-on: https://gerrit.libreoffice.org/68981 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-10tdf#121092: synchronize defaults for ODBC settingsJulien Nabet
The defaults for EnableSQL92Check, PreferDosLikeLineEnds, RespectDriverResultSetType in connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu made consistent with respective defaults in ODatabaseModelImpl::getDefaultDataSourceSettings When inconsistent, the settings don't ever get written to the ODB's content.xml (likely they are filtered out as default at different levels). This change allows the non-default to be written. Since the defaults in ODatabaseModelImpl::getDefaultDataSourceSettings are there at least since 2006 (commit 0eb026293c88d422d701d1a06735d9cce5457ca9), so that in any existing ODB the settings are absent if they are equal to those defaults, they are not changed. Change-Id: I220336fae666554c1bc23c1915152515fefd18ce Reviewed-on: https://gerrit.libreoffice.org/68979 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-09Simplify containers iterations in connectivityArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I1f7c1ea19cdc8d450b7ed88a663ba9ccb3249304 Reviewed-on: https://gerrit.libreoffice.org/68974 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07log nice exception messages whereever possibleNoel Grandin
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06loplugin:unnecessaryparen improve member expressionNoel Grandin
Change-Id: I304621018cb1e2a47e478e86df4229bcf2176741 Reviewed-on: https://gerrit.libreoffice.org/68757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04simplify UNO getTypes methodsNoel Grandin
Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550 Reviewed-on: https://gerrit.libreoffice.org/68659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-01Fix typoAndrea Gelmini
Change-Id: I7940a112baa985e66668d847f13a271553ad5b4b Reviewed-on: https://gerrit.libreoffice.org/68523 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-27Untabify .l files (to silence loplugin:indentation warnings)Stephan Bergmann
Change-Id: I8368c8a1d52f6c55a8cea952b2b02345e41c1e5c Reviewed-on: https://gerrit.libreoffice.org/68448 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27Add missing modelines to .l filesStephan Bergmann
...and change connectivity/source/parse/sqlflex.l license header from using (unusual, anyway) // comments to using /* */ comment, so that it can go before Flex's opening %{ Change-Id: I371890e937cc5055405c17226dd87ba1694688aa Reviewed-on: https://gerrit.libreoffice.org/68433 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-26loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: I94689e4eed290b4505d2caba2d9802ef7fb6cffd Reviewed-on: https://gerrit.libreoffice.org/68378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-25loplugin:unusedfields in connectivityNoel Grandin
Change-Id: I72b6c34151815bef0f99f81ef67529b52fd33150 Reviewed-on: https://gerrit.libreoffice.org/68277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-21loplugin:indentation (macOS)Stephan Bergmann
* Some .m/.mm files that still contained tabs instead of spaces have been cleaned up with Emacs' untabify (and apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions): apple_remote/source/GlobalKeyboardDevice.m apple_remote/source/HIDRemoteControlDevice.m apple_remote/source/KeyspanFrontRowControl.m apple_remote/source/RemoteControl.m vcl/osx/a11yrolehelper.mm * Some of the changes predate 0626e66d761de18f62e4d00d427903032da9d517 "Avoid loplugin:indentation after preproc conditional inclusion lines" and would likely have no longer been flagged since. Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f Reviewed-on: https://gerrit.libreoffice.org/68090 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-19Some uses of C++17 class template argument deductionStephan Bergmann
Change-Id: I47c469c0fcdff41d83729be9489c946e81ef3686 Reviewed-on: https://gerrit.libreoffice.org/68020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-10Make LDAP support optionalAndrew Udvare
Change-Id: Ifbd3903494a81e7b155bf6468f6ca2c50b3370a4 Reviewed-on: https://gerrit.libreoffice.org/65958 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-08loplugin:indentation in connectivityNoel Grandin
Change-Id: I6619fcdd84a23aae975dcaa7315c7f229c63c4f1 Reviewed-on: https://gerrit.libreoffice.org/67535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-06store originating exception when re-throwingNoel Grandin
Change-Id: I26959d3604a581f1528e575239970ab364c7fd50 Reviewed-on: https://gerrit.libreoffice.org/67413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-04tdf#122129 Firebird: fix concurrency issueTamas Bunth
Allow only one isc_dsql_prepare at a time. Change-Id: I3d5974057272cd47697aeb7be54579d0c1a662a0 Reviewed-on: https://gerrit.libreoffice.org/67231 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-30Fix type of MySqlFieldInfo::mysql_type to avoid -Wc++11-narrowing (clang-cl)Stephan Bergmann
...at > connectivity/source/drivers/mysqlc/mysqlc_resultsetmetadata.cxx(45,13): error: non-constant-expression cannot be narrowed from type 'enum enum_field_types' to 'unsigned int' in initializer list [-Wc++11-narrowing] > fields[i].type, // mysql_type > ^~~~~~~~~~~~~~ Change-Id: I3439ca06b9dd6efb24931203f7c7842e430f034c Reviewed-on: https://gerrit.libreoffice.org/67141 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-29mysqlc: fix timestamp query of result setTamas Bunth
Also add test for inserting and reading timestamp values. Change-Id: I2ba997c438f4e33965b0fe0602e58eddeff38b01 Reviewed-on: https://gerrit.libreoffice.org/67066 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-29tdf#106463 set new firebird connections as autocommit by defaultLionel Elie Mamane
as per SDBC specifications Change-Id: I132a8e565468bcacf0fa5ee0dfb62bf0dd717e24 Reviewed-on: https://gerrit.libreoffice.org/67015 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-01-25loplugin:unusedmethodsNoel Grandin
Change-Id: Ifb0c479e9d1aed1cd90d78ed23902fc05db556d6 Reviewed-on: https://gerrit.libreoffice.org/66862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24Fix typoAndrea Gelmini
Change-Id: I8c6ec56681449c295b25890f94acfabcf77df4ec Reviewed-on: https://gerrit.libreoffice.org/66764 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-24loplugin:constparams in connectivity..cuiNoel Grandin
Change-Id: Ia2ae97498a9aad8638c4b77ce20143eeec616751 Reviewed-on: https://gerrit.libreoffice.org/66792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-22mysqlc: resultset's previous() on first position..Tamas Bunth
.. should move the cursor backwards to beforeFirst position and return false. Change-Id: Icbb4bed0ea39ea3a0bf375d5616e3ef768fc69d9 Reviewed-on: https://gerrit.libreoffice.org/66729 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-22mysqlc: fetch data exactly when it's neededTamas Bunth
It fixes the issue that one could not call getXXX on a result set on which next() method was never called before. Change-Id: I972bb9d475d192a14ba1534dcbdac81c20f211d0 Reviewed-on: https://gerrit.libreoffice.org/66404 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-21Forgot to adapt one of the format stringsStephan Bergmann
...in 113536e974d7ebbbc484b0ef40406f9b4d14e511 "Avoid -Werror=format-{overflow,truncation}=" Change-Id: Ie26abed8c5694a3b26777771737ded2b3b484935
2019-01-21Avoid -Werror=format-{overflow,truncation}=Stephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized, by making the buffers large enough for the (hypothetical) largest values of the various date/time components Change-Id: I82e9b08fa099546b2d6f29c702e1440df9e6c6e0 Reviewed-on: https://gerrit.libreoffice.org/66618 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21Fix typoAndrea Gelmini
Change-Id: I14fba5feb45ee2f8de5f017b6da95bd1fe4908f8 Reviewed-on: https://gerrit.libreoffice.org/66660 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-18o3tl::make_unique -> std::make_unique in chart2...cuiGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I2ba0b9b44971166bd79527b52745f3c40dc14387 Reviewed-on: https://gerrit.libreoffice.org/66490 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18Fix typoAndrea Gelmini
Change-Id: I80e83c04f3001fefad6cbdffc19ce8e05272dc88 Reviewed-on: https://gerrit.libreoffice.org/66562 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-18Base/Mysqlc: fix schemas retrievingJulien Nabet
Change-Id: Ib0bd600aed3c3394890a199d105aff17cd547200 Reviewed-on: https://gerrit.libreoffice.org/66554 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2019-01-17tdf#122516: fix timestamp in MariaDb/mysqlJulien Nabet
Change-Id: I9740e265c7f4c607bf871c5f12df149355ce6a61 Reviewed-on: https://gerrit.libreoffice.org/66495 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2019-01-16New loplugin:emptyStephan Bergmann
Change-Id: I8729db064573ac21dfe6b203c5ae244d79ecc4fe Reviewed-on: https://gerrit.libreoffice.org/66430 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-16Fix typoAndrea Gelmini
Change-Id: Ice8631e3a72f7ec0df571419f7766aa343a0191b Reviewed-on: https://gerrit.libreoffice.org/66414 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-12tdf#122437 mysqlc: Fix foreign key referencesTamas Bunth
Comparing mysqlc terminology (INFORMATION_SCHEMA) with the description of the XDatabaseMetadata interface: - columns with name "REFERENCED_*" (INF_SCHEMA) should be used for primary key attributes (sdbc terminology). - columns without any prefix (INF_SCHEMA) should be used for primary key attributes (sdbc) Change-Id: Id9780fd86834441485da927f85b9446c40951fcf Reviewed-on: https://gerrit.libreoffice.org/66213 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-12tdf#122437 mysqlc: consider "types" parameter in..Tamas Bunth
..method XDatabaseMetadata::getTables() so it will return only those types which are needed. This solves the problem that no tables appear in "Relations.." window. Change-Id: Ia02537c78917583f574ad788098c65a9acd43078 Reviewed-on: https://gerrit.libreoffice.org/66212 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-12 22:10:33 +0000