summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2017-11-18silence some coverity warningsCaolán McNamara
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d Reviewed-on: https://gerrit.libreoffice.org/44875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-18Assume thread encoding for ODBC status stringMike Kaganski
OTools::ThrowException uses SQLGetDiagRec to get error message. It's not the caller's responsibility to define the encoding of resulting string. Also, using the default setting of RTL_TEXTENCODING_MS_1252 turns returned localized strings into garbage. To allow correct conversion into Unicode string, let's use current thread encoding, and drop the input encoding parameter. Change-Id: Idb02e3ebb4fc407ce5e658fb2137ea2aa3bc127d Reviewed-on: https://gerrit.libreoffice.org/44877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-16Delete test*.odb filesStephan Bergmann
...that are created in java.io.tmpdir (e.g., /tmp on Linux) by connectivity.tools.HsqlDatabase.createDBDocument() during e.g. JunitTest_dbaccess_complex. This revealed that connectivity.tools.AbstractDatabase.delete() (even if it would have been called by the test) would have been non-effective at deleting the file, as the java.io.File constructor used takes a pathname not a file URL as argument, so the call to java.io.File.delete() would not have deleted the relevant file (and returned false, rather). Change-Id: I268e1d1732ac7a0db9ccde7d4ac4f09aa3811e11 Reviewed-on: https://gerrit.libreoffice.org/44801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-14Translate German debug stringsJohnny_M
Change-Id: If4da1df3f7889d2b579fcde4fec5ac3c82026555 Reviewed-on: https://gerrit.libreoffice.org/44627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-13survive building dbaccess+connectivity with --disable-dynamic-loadingCaolán McNamara
Change-Id: I49387d2b6ec1893bf721e3289f2f620a4ce71fb3 Reviewed-on: https://gerrit.libreoffice.org/44668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-13Fix typosAndrea Gelmini
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-09connectivity: fix loplugin:datamembershadow warning in the Calc driverMiklos Vajna
Change-Id: Idcc6b1734599eec5d9eefbefb8849dc050b6a9d6 Reviewed-on: https://gerrit.libreoffice.org/44522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-09loplugin:unusedvariable add some more std:: typesNoel Grandin
Change-Id: Ib15931e415990b56367fe3e1c7cf3f22cc4826d5 Reviewed-on: https://gerrit.libreoffice.org/44529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-07loplugin:finalclasses in connectivityNoel Grandin
Change-Id: I0cd075efad83c0a8d6f05c91201a9aa86649590b Reviewed-on: https://gerrit.libreoffice.org/44386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03Move ado_{pre,post}_sys_include.hStephan Bergmann
...to connectivity/source/inc/ado/, as it is included from include files there, which only happens to work because of -I$(dir $(3)) in gb_CObject__command_pattern (in solenv/gbuild/platform/com_MSC_class.mk) and the fact that those include files in connectivity/source/inc/ado/ are in turn only included from .cxx files in connectivity/source/drivers/ado/. Change-Id: I0bbecaeeaac1f94fa86355e391d2826f3e29c440 Reviewed-on: https://gerrit.libreoffice.org/44230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-01loplugin:constantparam in connectivityNoel Grandin
Change-Id: Ia13d0931bbdf642fe04119ea1112788fb143eba8 Reviewed-on: https://gerrit.libreoffice.org/44110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27loplugin:includeform: connectivity (Windows)Stephan Bergmann
Change-Id: I27b865cbb79c9ed9c1b5af9f0666450778ae8335
2017-10-24loplugin:includeform: connectivity (macOS)Stephan Bergmann
Change-Id: Ib87a1dae55f926baffe1cf436fedeab59508d253
2017-10-23loplugin:includeform: connectivityStephan Bergmann
Change-Id: I06596fac09f0568b8bab2e2e235a2b88bcd3fc7a
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-16Make include files found through -Iconnectivity/source/incStephan Bergmann
...instead of implicitly next to the including file, in preparation of loplugin:includeform Change-Id: I4272c5e24eb887a36a6f3c296def375956f56499
2017-10-13Do not cast sal_Unicode separator to sal_CharEike Rathke
... living in an ASCII world? Change-Id: I82912924420766734573a10b2e110fef6fcadd1c Reviewed-on: https://gerrit.libreoffice.org/43343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-13Correct copypasta decimal separator as group separatorEike Rathke
Quite certainly the decimal separator wasn't to be obtained twice and used as group separator the second time.. Change-Id: I8fb1a066f7f33f377fc98f917aeadad74c41205b Reviewed-on: https://gerrit.libreoffice.org/43342 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-11connectivity writer driver: survive merged cellsMiklos Vajna
Fow now just don't crash on them, instead give empty result for those cells. Change-Id: I9edd231b00fa00af95408a550484da74c98275da Reviewed-on: https://gerrit.libreoffice.org/43319 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-09Revert "Related tdf#112947: another fix about odbc"Lionel Elie Mamane
Since the buffer pointed to by SQL_ATTR_FETCH_BOOKMARK_PTR is not free()/delete()ed by the destructor of OResultSet, this is not the right place to unregister it. This reverts commit b76a087f73cdf3d1a8bcc56b1ed7a5959ca0f1bd. Change-Id: I78e162c0ced1a15decc4a0f464c99f68fcac7ce5 Reviewed-on: https://gerrit.libreoffice.org/43270 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-10-08Remove extra line added by mistakeJulien Nabet
Change-Id: I75141d99744bf3133b6c64aec9a56db13f836d0c Reviewed-on: https://gerrit.libreoffice.org/43264 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-08Related tdf#112947: another fix about odbcJulien Nabet
As discussed here: https://bugs.documentfoundation.org/show_bug.cgi?id=112947#c9 and https://bugs.documentfoundation.org/show_bug.cgi?id=112947#c10 Change-Id: I4376c090c4da3f25487d404ed8c0e00ca51ca204 Reviewed-on: https://gerrit.libreoffice.org/43241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-08tdf#112947: fix write to free'd memory (odbc)Julien Nabet
suggested by Nick Gorham Change-Id: I3579caf5192df6e460dea3a5b3728196d75a65f4 Reviewed-on: https://gerrit.libreoffice.org/43234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-06use more rtl::Reference in connectivityNoel Grandin
instead of manual ref counting Change-Id: I210d4a2cd6487bd2d7d81a53106b484fe411ca9b Reviewed-on: https://gerrit.libreoffice.org/43203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-04Revert "check for unnecessary DLLPUBLIC annotations"Stephan Bergmann
This reverts commit a599eeab786ecbe1b5b6509e3c792e5c1ba31248, plus follow-up fa4431449d0306e8179f53a2a69c549800bd24bd "Avoid bogus loplugin:dllmacro 'unnecessary *DLLPUBLIC declaration ...'". See (abandoned) <https://gerrit.libreoffice.org/#/c/42983/> "loplugin:dllmacro: Handle implicit member functions" how this would have needed to be extended to give consistent results across Linux and macOS, but then would have started to remove DLLPUBLIC from entities that apparently need to at least have default type visibility on macOS and started to make tests fail.
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-01throw more useful uno::Exception'sNoel Grandin
if we're going to throw the base class of the exception hierarchy, we can at least put a useful message in there to make the source a little bit easier to locate. Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566 Reviewed-on: https://gerrit.libreoffice.org/42968 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-30Use SAL_W/SAL_U instead of reinterpret_cast btwn wchar_t* and sal_Unicode*Mike Kaganski
This is type-safe, and allows to catch cases where a source type is changed for some reason, but reinterpret_cast masks that Change-Id: Ib64b6fa2e22d94a6bba890f0ccc3e20325c6f0a1 Reviewed-on: https://gerrit.libreoffice.org/42961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-29check for unnecessary DLLPUBLIC annotationsNoel Grandin
on classes which are fully defined in a header file Rename the dllprivate plugin to dllmacro and add the functionality there. Change-Id: I4581d551c46a8f61213d95973f323359d08278d8
2017-09-25Fix typosAndrea Gelmini
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-24tdf#96505 Get rid of cargo cult "long" integer literals66kesara99
Remove unnecessary "Long" literals in multiple locations Change-Id: Icc44546f10fed841683053eee01b788274e0add1 Reviewed-on: https://gerrit.libreoffice.org/42683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-21More naming errors. There are no "Descriptions" in the SDBCX module,Damjan Jovanovic
there are only "Descriptors". Patch by: me (cherry picked from commit ccc4532f9ed95f4460941e2762ae3250d37805f5) Change-Id: Ifd4f34c7b1ba64b449222dc864a38df80f4c6727 Reviewed-on: https://gerrit.libreoffice.org/42535 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21loplugin:flatten in connectivity..desktopNoel Grandin
Change-Id: Iff59d3049ba40b4338ef8eec67d08a96b0834d2b Reviewed-on: https://gerrit.libreoffice.org/42578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21Fix a typo in the XServiceInfo implementationDamjan Jovanovic
for main/connectivity/source/sdbcx/VIndexColumn.cxx. It's implementation/service names are com.sun.star.sdbcx.VIndexColumn and com.sun.star.sdbcx.IndexColumn, not com.sun.star.sdbcx.VIndex and com.sun.star.sdbcx.Index. Patch by: me (cherry picked from commit d2f0e14de2a52180ed84c0402e47a0de16589203) Change-Id: Ie8a8bead7f7b5dd2c655603a7355bc0b2678ef7e Reviewed-on: https://gerrit.libreoffice.org/42534 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20unused m_nFetchSize in OResultSetNoel Grandin
since initial commit 77e4adbe4759f21f6cf095d954391a9ddbbec2cf Date: Mon Sep 17 22:50:49 2012 +0200 mork driver implementation Change-Id: I226c4065a5ab4404cc9e99eb3e026d153d1ccf08
2017-09-19Looks like we can just as well use ADORecordset hereStephan Bergmann
...instead of _ADORecordset, to make this consistent with the reset of the ADO driver code. (Appears the former is a #define for the latter.) Change-Id: I0b2d89e4483cf7f441df2cf2ceef7bfd37866cf9
2017-09-18Some more WIN32_LEAN_AND_MEANMike Kaganski
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874 Reviewed-on: https://gerrit.libreoffice.org/42419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-11connectivity DatabaseMetaData: pull out OComponent from OCalc/WriterMiklos Vajna
Only getURL() and getTables() is custom, the rest can be shared. Change-Id: I9d282a30f722bce0c05b37c7d005c84193e01b7c Reviewed-on: https://gerrit.libreoffice.org/42152 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-06loplugin:unnecessaryparenJan-Marek Glogowski
Change-Id: I1e80b1b62157f78fe3c0964773c8a0e29a901710
2017-09-04loplugin:unnecessaryparen in connectivityNoel Grandin
Change-Id: Iee4b0caa2eb7ad6d335f55adc19e7ed78b34335c
2017-09-01Remove unused m_aBatchVector membersStephan Bergmann
Change-Id: I7b7ff3295fa5eb87d113b48dcff0cf3c0b12b4ff Reviewed-on: https://gerrit.libreoffice.org/41780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-31Replace some lists by vectors (+rename vars)Julien Nabet
Change-Id: Iad4e3cc13f7908840ef45a04ea4b551d3b0fc487 Reviewed-on: https://gerrit.libreoffice.org/41771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-31Use vector and replace m_aBatchList by m_aBatchVectorJulien Nabet
Change-Id: I7c2c529eb78679f9733374bf0785773684c728c4 Reviewed-on: https://gerrit.libreoffice.org/41770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-31Replace list by vector for getResourceStringWithSubstitutionJulien Nabet
Change-Id: I0b09a575971286ecc4d3bbc40926b949e9ab28c0 Reviewed-on: https://gerrit.libreoffice.org/41768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-31loplugin:constparams: connectivity (clang-cl)Stephan Bergmann
Change-Id: I6dc7939f42aa1d1d62f8c71f5a5529becdffa704
2017-08-31loplugin:constparams: connectivity (macOS)Stephan Bergmann
Change-Id: I2d14eeea20d2622e06c7c34a1fa7e84439b3d224
2017-08-29remove some unused macro definitionsNoel Grandin
Change-Id: I253e5108161b932e3dc588b656e550bb9dc022b0 Reviewed-on: https://gerrit.libreoffice.org/41672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-12 18:43:26 +0000