Age | Commit message (Collapse) | Author |
|
it's a workaround, but given the conflicting requirements of
MSVC not liking duplicate symbols, but the unit test needing to
link the objects directly to access internal symbols, there is
not much else we can do.
Change-Id: I9bdcc5f2b6ab0712cc3317033c4fbae4791cbb6b
Reviewed-on: https://gerrit.libreoffice.org/12387
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
|
|
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
|
|
(Original idea from Kendy)
Look for code that is calling std::find on a sorted container
(set/map/vector) and warn about it - the code should be using
the find method on the container itself, since that is considerably faster.
Change-Id: Ib74e5d3faa836eeb0df16a736d202696626bdfd2
|
|
Change-Id: Iae4c439de43fba471916463da8939709bbd068e5
|
|
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
|
|
Change-Id: I3d198d60524224e22d7f609ddde1ed8c3c319da9
|
|
Change-Id: If89d6613394220fa4ca1da9b5b8820d9dbc205c7
|
|
Change-Id: I2dde714f847f6df4d9b4ede744bef089a3715d7a
|
|
Change-Id: I7200fe17c66cd904f0fc243bf8e33d6c24079729
|
|
Change-Id: Iee569c32569339ec2eeb6ef038e5bdc83e541a8f
|
|
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
and
coverity#1158394 Uncaught exception
Change-Id: I73430678c658202475e0073c3c9bde0a072c1ee9
|
|
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I66499283f4218662146c380f605bb20b8a2ff49a
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I3b1b78127d7d4080a23c0ac9f7d37706197de62c
|
|
Change-Id: If3963e0ae2c6477eb074e89f411c22a82d339634
|
|
Change-Id: Ie3b66520ab0c859272a4b0291f6c907e7fce61e5
|
|
Change-Id: I1e957afe1dc35571128fac4432b54e8ae35aa9ab
|
|
Change-Id: I3923a6a83bfc0a35f5a5af86cfd0e5308cfda24c
|
|
Change-Id: Ia056948df45ade616dd4c434a4c9d319d48d97f2
|
|
Change-Id: I9182ad75a5b49d5aa9d58cecc690b06220f13272
|
|
Change-Id: I4ebfee76cb17562a47d4c2e868539fc70ead530e
|
|
Change-Id: I7f390151c232d0a96d50b16c0c76aacea569653e
|
|
Change-Id: I8b39addd8d4b9f7d68d0f7a317d1dff7388aba93
|
|
Change-Id: Iff1ada702f57fba9ba979bc158412b0321921672
|
|
Change-Id: I8dda8f4621f265208c713c9edcfe725f1c9c5998
Reviewed-on: https://gerrit.libreoffice.org/12001
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I0f1beadc90eae9750b53062df2512f7c886fd267
|
|
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
|
|
Dispose the dbaccess document, and recursively delete the temp directory
in Connection::dispose().
Change-Id: Id283289e44b8ca09b88da19920da7f27b551aa7e
|
|
ODatabaseMetaData and OResultSetMetaData apparently have life-times
independent of their creating object, so they need to own the
Connection too.
Change-Id: Idee28a96e318ca4b3d804084d609737a7fc75862
|
|
bin/refcount_leak.py was very helpful here.
Change-Id: I61dc57408cf1533f733c08b701884851ec6afb8d
|
|
Change-Id: I74e1a02602fd5d86790e3c0e71d6a8649fa0aa05
|
|
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
|
|
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
|
|
Change-Id: I5b2903cf2928e19be203d80243c2ac2e75be28cb
|
|
Change-Id: Id33384cee3444924e7e8de7d496f117f120b1876
|
|
and
coverity#706330 Uncaught exception
Change-Id: I105e37c88654cf47b50fe6b260b8994622305dab
|
|
and
coverity#706317 Uncaught exception
Change-Id: Idd01f4ba68b1ce6590d6c7b79bcff9593f0766ea
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
Change-Id: I980e55ab3942c93447573c0af7b7486dfc0a0e10
|
|
Change-Id: I582bc15b8065c9262c0933f1afa0bda6e1f5d94e
|
|
Change-Id: I847cea7329a0c9cf370406afe8a7511f58c89901
|
|
Change-Id: I3a84a212abfcf0668b7040c8fa537ad62aaf5224
|
|
Change-Id: I922ce18051eefb4507cc84870ce18ae0a49f4608
|
|
Change-Id: Ic72750fcea93edf3457ccea4a357e9d2929a646c
Reviewed-on: https://gerrit.libreoffice.org/11941
Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>
|
|
Change-Id: I0306b8431641d841027b30dfe1c03ecad5df6867
|