summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2015-10-01coverity#1209375 Unchecked dynamic_castCaolán McNamara
Change-Id: Ib6ac44878c6f485326c16fd0224b220e86a4dc6a
2015-09-30Fix typosAndrea Gelmini
Change-Id: I13c3dc33722f139582f27412d5d336264d3d15a3 Reviewed-on: https://gerrit.libreoffice.org/18942 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 tdf#94559: second step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in chart2, connectivity, editeng, extensions, filter, forms, framework, idl Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99 Reviewed-on: https://gerrit.libreoffice.org/18920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30Fix typosAndrea Gelmini
Change-Id: Iaff7e38dd5beac48e1643e369e4240aa736c35ea Reviewed-on: https://gerrit.libreoffice.org/18941 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-23CppCheck : reduce variables scopeMichaël Lefèvre
Change-Id: Ief402017b693a4337f330fb07bb7a6dc6e749f72 Reviewed-on: https://gerrit.libreoffice.org/18753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14boost->stdCaolán McNamara
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09 Reviewed-on: https://gerrit.libreoffice.org/18568 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-13cppcheck: unreadVariableCaolán McNamara
Change-Id: Ia611c9a1119af65688031d16ff322f1bde43297b
2015-09-12tdf#92794: '$' should be replaced in error dialog of addressbookJulien Nabet
Change-Id: Ic57611be96f160037fbff2e9452f9206083c80e4 Reviewed-on: https://gerrit.libreoffice.org/18324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-09Get rid of connectivity's diagnose_ex.hStephan Bergmann
...that rather trivially wrapped some osl/diagnose.h functionality Change-Id: I4105708488114a9c87aa415affb997a783241248
2015-09-09Get rid of OSL_UNUSEDStephan Bergmann
In many cases it was originally used to silence warnings about variables used only in OSL_ENSURE etc., but that's no longer necessary since OSL_ENSURE is based on SAL_WARN etc. In some other cases it was apparently used as a speculative debugging aid, to have a value assigned to a variable to be easily able to view the value in a debugger. And in some cases it was used with (otherwise ignored) return values of (typically SQL-related) function calls, but it is probably better to eventually find and fix all the problematic ones among such calls via function declarations annotated SAL_WARN_UNUSED_RESULT. Change-Id: Ib925b38da70073b546fdcd00fa8524dc302accbf
2015-09-08clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since OResultSet::fillNeededData got introduced in 8687beec5dfc08b28accc7779e0f7762cd947f12 "INTEGRATION: CWS insight01" (and the return value of the N3SQLPutData call in the first case block had always been ignored completely, not even unnecessarily assigned to nRet as in these later two case blocks) Change-Id: I1d2005e7c91749510b23f86ac792bd11ae564608
2015-09-08clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since b309e422c631ce6ce729552cc8053478f9539dfd "#95348# type usage changed" introduced the local nMaxLen and passed that instead of _nMaxLen into the two ODBC3SQLFunctionId::BindCol calls Change-Id: Ifb561106c87b6e424ccc9d350752b19b3648c7c8
2015-09-08clang-analyzer-deadcode.DeadStoresStephan Bergmann
...at least since 4695f7d361641ea4dcd927a7b4aab86e0c971d5b "#82018# check for double column names" removed the commented-out code that would have used it (and which had been commented out ever since the code got introduced) Change-Id: I11e9cafb53894ce7cb7ffc031f2d6b047bd3258d
2015-09-03remove KDE3 support, --enable-kde and --enable-kdeabMichael Stahl
With the new RHEL6-era baseline TDF can finally ship KDE4 support. Change-Id: I227278b576a3ed2f2aaa751d41b469ca92dc78b3 Reviewed-on: https://gerrit.libreoffice.org/18267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-03warning: nonterminal usesless in grammarStephan Bergmann
...ever since its use got removed in 17e1d9f46d7957b7ec54943122ddd5fbace19ab8 "INTEGRATION: CWS oj4" Change-Id: I6494e11bb162d4c4bb880a6c4f9ece01331975dd
2015-09-03tdf#88462 connectivity convert manual XInterfaceDaniel Robertson
Convert postgresql driver ReflectionBase manual XInterface implementation to use ::cppu::WeakComponentImplHelper. Change-Id: I738bd7df33de9c0fe0e3242eb5a4fab6a8dcb3f0 Reviewed-on: https://gerrit.libreoffice.org/18207 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-03warning: nonterminal usesless in grammarStephan Bergmann
Change-Id: I97f3fb5cf62a68460157b2302a84d56a1417d376
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I358fe0f3dc11939269f58b345489621b0ad25797
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I68b02ad101c4c2165b4618ed5d97cbffc2c43d2d
2015-08-27Clean up sEmptyStephan Bergmann
Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93
2015-08-19comphelper: remove unnecessary include <stack>Michael Stahl
Change-Id: I39295d69dd8a48f0f40275830cb6fda4ca0b69f3
2015-08-19Clean up remaining utl::LocalFileHelper::Convert...Stephan Bergmann
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040 "ConvertURLToSystemPath->getSystemPathFromFileURL" and 28f3464a571a23a2c16bd0980e9021b95d011511 "ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those Convert... functionality with direct calls to the corresponding osl::FileBase functions. Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-17o3tl: rename compat_functional headerThorsten Behrens
After the cleanup, the stuff there really stands on its own (and the remaining usage of select1st/2nd is more descriptive than lambdas). Change-Id: I0aba131d5dc550189f8130d167dc94167e404540 Reviewed-on: https://gerrit.libreoffice.org/17806 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: Id0a933d3507bc0f8145afa04effadf8475c8e210
2015-08-11tdf#92459 remove o3tl/compat_functional.hxxDaniel Robertson
Replace all uses of deprecated features from the o3tl included in compat_functional.hxx with lambda expressions in connectivity and reportdesign. The patch should not cause any side effects. The change is largely cosmetic. Change-Id: I2042b91bf0fa2b47cce9ea11c97fa4ca6734c5e2 Reviewed-on: https://gerrit.libreoffice.org/17588 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11loplugin: defaultparamsNoel Grandin
Change-Id: I906912f29448bfc72e8139546aa09525c959867f
2015-08-05OSL_ENSURE always makes the condition visible to the compiler nowStephan Bergmann
Change-Id: Ifc2f4592fdd4cfebdefc0c4b94656ffc06ddf879
2015-08-05loplugin:unusedmethodsNoel Grandin
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04cui,connectivity: inline some use-once typedefsNoel Grandin
Change-Id: I1b043031014a3e823cd614966984a2ac2be1ac71
2015-08-03tdf#91112: pass by const reference to lambdasJorenz Paragas
Since the function returned by o3tl::compose1 had its parameter passed by const reference, the same should be done for the lambda expressions that replace o3tl::compose1. I overlooked this detail in my previous commits. Change-Id: I0db5eec4e74d4835e786742ee6de3805215f377f Reviewed-on: https://gerrit.libreoffice.org/17465 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-29tdf#91112 replace o3tl::unary_compose with lambdas in connectivityJorenz Paragas
The replaced code used o3tl::unary_compose directly instead of the helper function o3tl::compose1. Change-Id: Idb5cae2e2a2dae5f8bdc572f475ebb76171fd853 Reviewed-on: https://gerrit.libreoffice.org/17249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-28remove unused UStringDescription structNoel Grandin
Change-Id: Ib92e64e9a8d14f755edc8866979aa6196d0b61f3
2015-07-27remove some unused definesNoel Grandin
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188 Reviewed-on: https://gerrit.libreoffice.org/17332 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-26tdf#92792: Register mork driver on windows 64bit and make it workDavid Ostrovsky
Mork service wasn't registred on windows as it was generally excluded on this platform not matter what architecture was used. Pofile discovery was broken, as XP_WIN wasn't define and the code fall back to use UNIX directories for profile discovery on windows that obviously cannot work. Change-Id: I823378a1a094a2172ba2cb3bf9bdacedb27b36a2 Reviewed-on: https://gerrit.libreoffice.org/17349 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2015-07-21coverity#1312084 Unchecked return valueCaolán McNamara
Change-Id: I4b4b263f4448c4d3b83cea57635624b31f757576
2015-07-20cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ib9373a5a75eea998a86156ff742e7950369ddc88
2015-07-17error C2065: ´bFound´ : undeclared identifierCaolán McNamara
Change-Id: Ibf72f77458d837849fe20361ca751dce2989830c
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17fix evoab2 buildCaolán McNamara
Change-Id: I944494af60b9805d53a2f1c507b9eb99fd935e9c
2015-07-17tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, for connectivity. Change-Id: I3645a2855e903848936520ac854fc1039fc456e8 Reviewed-on: https://gerrit.libreoffice.org/16971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: Idb1aa3801ab09022f68aea512df1ddd64348a5b0
2015-07-15loplugin:unusedmethods connectivityNoel Grandin
Change-Id: Ie9f3daa49b02dddc7b56d1f5fb58a229f53d4513 Reviewed-on: https://gerrit.libreoffice.org/17043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13tdf#91112 replace o3tl::compose1 with lambdas in connectivityJorenz Paragas
Change-Id: I8f61471e08fe7f620d76bdcd72eb7f5c35931388 Reviewed-on: https://gerrit.libreoffice.org/16940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-10Fix an opposite conditionTakeshi Abe
... slipped in at 54013188b24a1a02491a2853f731461253065424. Change-Id: Ib18b2f12d4ad97b9ec5dd771d5f13b35e0274e33 Reviewed-on: https://gerrit.libreoffice.org/16932 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-10cleanup some unnecessary direct usage of the OString/OUString C API.Noel Grandin
Change-Id: I6edee95aae1c169ce70063562a0c1b287e0c4735 Reviewed-on: https://gerrit.libreoffice.org/16861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-08Fix typosAndrea Gelmini
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-05aDBFColumn.db_typ is input controlledCaolán McNamara
so we can't guarantee that it is valid ascii Change-Id: Icdc6162db4405df729e548a836de5662255088ed
2015-07-03Fix typosAndrea Gelmini
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875 Reviewed-on: https://gerrit.libreoffice.org/16706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-13 17:17:53 +0000