summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2020-07-30fix leak in Mork::OResultSetNoel Grandin
Change-Id: I2e915762aca653acb7f9e1b322459f83297a997f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99786 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29Remove some unused includesMiklos Vajna
Change-Id: I9af7e2fa0a450ebe396c0f049831a20100dbdc9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99659 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-23connectivity/odbc: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I7cc971c7a99950a05804ae73f132c68e0c5a0625 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-23connectivity/ado: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I27bfc55d401fb1a9b9c33309f4b1f00ec13a92fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-20Fix typoAndrea Gelmini
Change-Id: I337a1da87aaacc82240622de4bd0090f87c72298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98999 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-18compact namespace: connectivityNoel Grandin
Change-Id: I4f7999672ba15d9f453ded9accb3991b8150c32d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98905 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-16loplugin:unusedmethodsNoel Grandin
Change-Id: Ibc1ec64cba8eb083aaff28848a42337cc597ea19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14connectivity/dbpool2: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ib621b48f9c542a8cdeea6d7627770784abbd44fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98689 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14connectivity/firebird: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ibac6bae417b664f9132ddc7d6dd539a85da28674 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98686 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14connectivity/hsqldb: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I80d9c854640073038d1a4d79997111912d924f69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14connectivity/jdbc: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Id268f9780400e5d0940f378cd8ee91f86662bf55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14connectivity/macab: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I418417284ede616ed36d213b378260e321913cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98674 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14connectivity/evoab: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I30f1fdca220e64e087a1de2f8a6ab1f2e7ba8a45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98687 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14connectivity/dbtools: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I281475b9fe5eff0d462f575e8434b9511b292e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98688 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-13connectivity/mozab: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I93b5ae48ec3580b1feb20fa1cf7897a0f2ed8fb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98668 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-13connectivity/postgresql: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I88e3706d799941fae7ed74e0f5de1cde827c0487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98665 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-13connectivity/mysql: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ifbfe7fe0aa54cd250efe4a55e9e648a74fd4dc04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-13tdf#42949 Fix IWYU warnings in include/[a-r]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I7f5c35474b671facbda85a9538462dd4291add91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97655 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-12update pchesCaolán McNamara
Change-Id: I75602277a5a26b012a12f2c4f4b7ff5bb663b0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11connectivity: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Id678e4c51459429dd3953c0e54558d2c36e85eee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98562 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-10replace usage of blacklist with excludelist for IWYUThorsten Behrens
Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 Change-Id: I2f22d455d2a936a85750eaab1fda215ebb6d9d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98182 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-10replace usage of blacklist with denylistThorsten Behrens
.. and a few cases of instead doing blacklist->excludelist where that made more sense. Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Canvas::DeviceBlacklist -> DeviceDenylist [API CHANGE] officecfg::Office::Canvas::BlacklistCurrentDevice -> DenylistCurrentDevice [API CHANGE] officecfg::Office::Common::Misc::OpenCLBlackList -> OpenCLDenyList Change-Id: Ia35e25496bf0cc0692d5de4cb66bfc232d3a869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98180 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: connectivityStephan Bergmann
Change-Id: I959a520f240faab062ecd4f6e2658d9fc9ce709f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97545 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: connectivityStephan Bergmann
Change-Id: I50676f940abb36091e175d7469806e8ccc6ba7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97195 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-24use more std::container::insert instead of std::copyNoel Grandin
which is both more compact code, and more efficient, since the insert method can do smarter resizing Change-Id: I17f226660f87cdf002edccc29b4af8fd59a25f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-22Consolidate unique_ptr deleters calling freeStephan Bergmann
Change-Id: I57a977dbb521270a466d464df8c31c364179ec20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96854 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-17connectivity: fix mysql testMichael Stahl
* rename the gbuild target according to conventions * fix -Werror=unused-but-set-variable * disable assert in testMultipleResultsets() that fails presumably since commit 86c86719782243275b65f1f7f2cfdcc0e56c8cd4 * document how to set up mariadb for dummies like me in README Change-Id: I7f92b80fef90b47e69e4e9a7a02187882a4cab06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96537 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-05Use o3tl::safeCoInitializeEx/safeCoUninitializeReinit (ado)Julien Nabet
Change-Id: I8eaa5c0f91a5e78888f6a2edea13fa5d2227fb9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95598 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-06-05tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctornienzu
Change-Id: Ic61c1d5829b510a71b8d444f29ffed36ee540ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94717 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-03Improve COM library management in ADOJulien Nabet
Change-Id: I99a1c61068fec743847181b43f3d9278c85e95e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95174 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-03Upcoming loplugin:elidestringvar: connectivityStephan Bergmann
Change-Id: I406486e13b822c34cd2329cc3828dd0567be30e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95385 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-28Make loplugin:simplifypointertobool handle parenthesized expressionsStephan Bergmann
...as discussed as an open TODO in the commit message of fe6cce01c88d045a1fcf09acf049c34c22299b02 "Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptr". The necessary changes across the code base have been done fully automatically with the rewriting plugin on Linux. (All those changes apparently involve uses of macro arguments wrapped in parentheses in the macro body, but always in conditionally-converted-to-bool contexts. In other contexts, such automatic rewriting would add the "bool" to the macro body, which would be wrong in general, but we apparently get away with that sloppy coding for now.) The parenExprs_ stack that fe6cce01c88d045a1fcf09acf049c34c22299b02 had introduced to treat such (then-undetected, it had turned out) parenthesized cases now turns out to not be needed after all. Change-Id: I2021f61c2e2805be7e18b38edf8744d186cac3cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95010 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-27Remove some unused includesMiklos Vajna
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-24inline some use-once typedefsNoel Grandin
Change-Id: Idddba2f3fd05265b08dbc88edb6152d34a166052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-22Prefer CoInitializeEx instead of CoInitializeJulien Nabet
As https://docs.microsoft.com/fr-fr/windows/win32/api/objbase/nf-objbase-coinitialize?redirectedfrom=MSDN advised. Moreover, it'll make concurrency model explicit Change-Id: I247a49248bf45beb64a7985a7c0d078ee48efe2d Change-Id: I6e755fd516d9fb2dd2a9df0c66d9afd6070447ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94669 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-18use for-range on Sequence in cli_ure..connectivityNoel Grandin
Change-Id: Ic5254e402d153a13c29928b59738cbe1603d0139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-15mysqlc: fix default transaction levelJulien Nabet
According to https://dev.mysql.com/doc/refman/8.0/en/innodb-transaction-isolation-levels.html it's REPEATABLE READ Change-Id: I7e9b0209528158908d8529f11e09554e372401a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93898 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-05-14unixODBC changed soname to .2 so reflect it (connectivity)Julien Nabet
Synchronize with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3f5584526fd4e8290dac033e1cf3d64acd25d893 author Tomáš Chvátal <tchvatal@suse.com> 2017-01-05 16:06:10 +0100 committer Lionel Elie Mamane <lionel@mamane.lu> 2017-01-13 10:17:13 +0000 commit 3f5584526fd4e8290dac033e1cf3d64acd25d893 (patch) tree 055eaf148ed60da5182e6033d7a74a387765f886 parent afe64b6f0ab839955690f07929268a3d389279bf (diff) unixODBC changed soname to .2 so reflect it we dlopen this library and thus we should be able to find it with any soname, so far .1 and .2 seem to be used. Also now the load order on linux is: .so.2 -> .so.1 -> .so Change-Id: I1b7a54992ee9a654d77d0ef443087178c99cffe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94199 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-05-13Removed duplicated includeAndrea Gelmini
Change-Id: I4919b787160dad755f13658f26cbe1fd3fd0fad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94138 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-13use std::optional for this error fieldNoel Grandin
otherwise when I add source/line to the uno::Exception in an upcoming change, the message becomes non-empty, and hasErrors() return true. I note that we throw SQLException in lots of places without a message, so it is possible that this change will cause us to notice errors we previously missed. Change-Id: Idf7c5b5143e20c992d8d7550043aa2ed875c78b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-11tdf#126468: MySQL/MariaDB and Firebird don't require order field in select partJulien Nabet
Change-Id: I75f050dd6f38fefe83d24a4886610d421f72826e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93937 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-10tdf#132814: fix put autovalue to Yes in gui for Mysql/MariaDBJulien Nabet
See part of bt: https://bugs.documentfoundation.org/show_bug.cgi?id=132814#c3 Like this since at least: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8 author Tamas Bunth <tamas.bunth@collabora.co.uk> 2018-10-08 11:04:48 +0200 committer Tamás Bunth <btomi96@gmail.com> 2018-10-14 22:16:05 +0200 commit b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8 (patch) tree f1ab6e9fec3c66f0a3285b3ffffcbae38dc7185d parent ba6723431afa843232fadf44e12ddab44e85c9f0 (diff) Revert removal of mysql jdbc connector And also make some minor fixes so it cooperates with the new mysqlc library. Change-Id: Id328c8378be1555fb5934c738def7fcd62f7a14b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93915 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-10mysql-sdbc: better separate what resultset provides what interfaceLionel Elie Mamane
PreparedStatement should not provide XStatement (!!) since MySQL does not support multiple results for prepared statements, PreparedStatement should not expose a XMultipleResults interface Move those out of the common base to Statement itself. Change-Id: Ice7478089441e1def6fd65ff117eb31d04ec46ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93864 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-10mysql-sdbc: do not lie about supporting XPreparedBatchExecutionLionel Elie Mamane
Change-Id: I85220307566f04640965f048ee0b5c5c4e552bdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93863 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-10tdf#112423: mysql-sdbc: implement XMultipleResultsLionel Elie Mamane
Thanks to Julien Nabet for the pointers to MySQL's multiple results API documentation: https://dev.mysql.com/doc/refman/8.0/en/c-api-multiple-queries.html Change-Id: Ia6e7f52752ad895210cc415f71bb48d678f3f0ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93686 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09Typo: aSerachMapping->aSearchMapping (connectivity/ado)Julien Nabet
Change-Id: I3415c8cecb1cae709de714c99303bd21b495cba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93870 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-09mysql-sdbc: statement::execute do not handle parametersLionel Elie Mamane
this is not a PreparedStatement, it is not allowed to have parameters Change-Id: I15cd493b89824e4e68eff5a59ac255bf05db0190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93853 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09mysql-sdbc: statement: do not pointlessly keep pointer to resultLionel Elie Mamane
in m_pMysqlResult since it is never actually used after being assigned, except in the code block that assigned it. Change-Id: Ic4341321b18b2c92eb93e59dd3b9e3035c69f293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93852 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09mysql-sdbc: statement: rename disposeResultset to closeResultsetLionel Elie Mamane
it does not actually dispose teh ResulteSet, it only lets go of the reference. Change it to actually close the ResultSet. Change-Id: Iee51738274468f5c00e026304915ba44139a9fab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93851 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
generated by cgit (git 2.34.1) at 2024-06-21 09:14:32 +0000