summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2017-07-04loplugin:unusedfieldsNoel Grandin
Change-Id: I6bf3de7ba6e6bff2fd607156a0dcdd554887e491 Reviewed-on: https://gerrit.libreoffice.org/39475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:casttovoidStephan Bergmann
...cases that were initially missed due to the broken containsProcessingConditionalInclusion() Change-Id: Ib7d801ab5173ee590ef35a9e075d3ce4d4aa06da
2017-07-03use begin()/end() when working with SequenceNoel Grandin
Change-Id: Icf9da6a24d72c073338f6fbb513d7250b3898015 Reviewed-on: https://gerrit.libreoffice.org/39469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:oncevar (clang-cl): connectivityStephan Bergmann
Change-Id: I76dcc99c29302b49a1d66fa22db8b28714421a98
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-02loplugin:casttovoid: connectivityStephan Bergmann
Change-Id: I03127890499dac67816bb43a8c3fb9dd87eefcab
2017-07-02Typo: isCaseSensitveExtension->isCaseSensitiveExtensionJulien Nabet
Change-Id: Ifcd0a93fc8f3e95f7e0e8d518b5d6fbb5ab0a514 Reviewed-on: https://gerrit.libreoffice.org/39448 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-07-02tdf#108789 and others: overhaul DBase files encoding handlingLionel Elie Mamane
- Calc: make the complete "what encoding to use" decision before calling the connectivity driver, so that the driver has no ambiguity about whether it should override our setting or not. To this end, factorise the part of the driver that reads the encoding from the file header into dbtools. - Calc: don't ask for encoding when the file's header give the encoding. - don't confuse CP850 (the default) and "don't know", including: * don't ignore CP850 user setting * don't overwrite user setting with CP850 Thanks to Julien Nabet for the extensive collaboration on this. Change-Id: Id80b7c505858b88f717b0ce6bd890527909e5fd1
2017-06-30loplugin:oncevarStephan Bergmann
Change-Id: Id19ffb1d4817a882bc3f8f73c3ead932c5a92aeb
2017-06-29loplugin:oncevarStephan Bergmann
Change-Id: I5ee54b458b85581cf49ab39a7b1dc0cae6abed00
2017-06-29improve refcounting lopluginNoel Grandin
to find ref-counted classes being managed via other smart pointer classes. Hopefully prevent needing fixes like 642ae256ea5b8083ba0b3c097ca8ea52304b9cdb "ChangedUIEventListener is refcounted, mustn't be helt by unique_ptr" Change-Id: I6b0c5f8f87ce3546a8a1104ce1000470c09459bd Reviewed-on: https://gerrit.libreoffice.org/39378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-28In DatabaseMetaData::getIndexInfo, isPrimary has always been ignoredStephan Bergmann
...ever since the code's introduction with e28033fdfad9750ebe96885b9514adee629acf88 "Apply sdbc-postgresql.diff" Change-Id: Ia0a1581c0284d96c73367ac6ea52fb0bab8e3c88 Reviewed-on: https://gerrit.libreoffice.org/39310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-28connectivity: Fix memory leak at finding non-empty fileTakeshi Abe
Change-Id: I7134dc4efb9a659727474a788dce19fcb8ea2da7 Reviewed-on: https://gerrit.libreoffice.org/39338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-27In OSQLParseTreeIterator::traverseCreateColumns, nLen has always been ignoredStephan Bergmann
...ever since the code's introduction with 34506a92ae2f972c9a667e1498d62e73807e8084 "INTEGRATION: CWS mozab04" Change-Id: I845a53077f16cdea6d728b9e6964a55ceea3995d
2017-06-26s/catched/caughtNoel Grandin
Change-Id: I7ea6977a9749e86f8058b78cdb91cd2c62da8264 Reviewed-on: https://gerrit.libreoffice.org/39164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23simplify some string handling in tracing callsNoel Grandin
Change-Id: I0fb76562429e691400a02216019c7f96791cf9b3 Reviewed-on: https://gerrit.libreoffice.org/39159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-20create comphelper::RefCountedMutexNoel Grandin
and merge the two existing implementations of the idea - SotMutexHolder from package and RefCountedMutex from connectivity Change-Id: I87f09f359ac798cf934381a2c75225dab71dd43e Reviewed-on: https://gerrit.libreoffice.org/38972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-20loplugin:oncevar in codemaker..connectivityNoel Grandin
Change-Id: Ia479d9d3d459a699dfc5c1148d01c35e8bc973bd Reviewed-on: https://gerrit.libreoffice.org/39000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-15use more SAL_N_ELEMENTS part 3Noel Grandin
Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623 Reviewed-on: https://gerrit.libreoffice.org/38789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-14dBASE: put back an array for trailerJulien Nabet
since except language code, the other information aren't used but keep the details in comment Change-Id: Ibb5bf22e88bd3a5f9c7603ad018cada8add8b2ce Reviewed-on: https://gerrit.libreoffice.org/38799 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-14loplugin:redundantcase (clang-cl)Stephan Bergmann
Change-Id: I8d31de92528461afbe25ec059093c1c21eb9ef72
2017-06-13dBASE: remove wrong m_ prefix introduced in a recent commitJulien Nabet
Change-Id: I9f05facd98d60604256b15c4b35871f7d0a825f9 Reviewed-on: https://gerrit.libreoffice.org/38755 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-13dBASE: typo + remove useless comment from previous commitJulien Nabet
Change-Id: Icb16bc4eaf06bd1abc41d5c4109e66c914fb9e71 Reviewed-on: https://gerrit.libreoffice.org/38754 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-13dBASE: header refactoringJulien Nabet
use sources from: https://www.clicketyclick.dk/databases/xbase/format/dbf.html http://www.dbase.com/KnowledgeBase/int/db7_file_fmt.htm + translate vars Also, a condition was wrong about language driver Change-Id: I58c41776f927c51bc4eec951d747b9e2a59733d1 Reviewed-on: https://gerrit.libreoffice.org/38751 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-13remove TDE integration (vclplug, address book, config backend)Michael Stahl
It has ~no users, can't even be built on modern Linuxes, and it annoys folks who want to refactor VCL. Per ESC decision from 2017-06-08, remove --enable-tde and --enable-tdeab. Change-Id: I51ce4786f29f8fcac2e2bb2a654c41fbfbbd8afd Reviewed-on: https://gerrit.libreoffice.org/38718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-13use local statics for getUnoTunnelImplementationIdJochen Nitschke
replace uses of double checked locking pattern and rtl::Static Change-Id: I479d9d94f652b4fb4c67388405823a5f4e2b6ed4 Reviewed-on: https://gerrit.libreoffice.org/38690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12tdf#55631: DBASE import (take 2)Julien Nabet
if we can't read head db_frei part, let's also put by default m_eEncoding = RTL_TEXTENCODING_IBM_850; Change-Id: I97601ba4c782dcfc280e975cc4498ea68407dd48 Reviewed-on: https://gerrit.libreoffice.org/38659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
2017-06-12Fix typosAndrea Gelmini
Change-Id: Ib2ba32d48d3df16b0b20deea84416fe15a2d7176 Reviewed-on: https://gerrit.libreoffice.org/38650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-11Fix typosAndrea Gelmini
enviroment -> environment Change-Id: I08b95367fbd45f7f785121df33533c0ee7ee331f Reviewed-on: https://gerrit.libreoffice.org/38649 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-10DBase, encodings mixedJulien Nabet
See https://bz.apache.org/ooo/show_bug.cgi?id=18728#c7 101 - 866 MS-DOS, Russian 102 - 865 MS-DOS, Nordic taken as reference by Muthu Subramanian who also added some other encodings with https://cgit.freedesktop.org/libreoffice/core/commit/?id=b00c4ec0967f8712d721b31ccb2dd0778c9e973b Also https://msdn.microsoft.com/en-us/library/aa975345%28v=vs.71%29.aspx 865 Nordic MS-DOS x66 866 Russian MS-DOS x65 Change-Id: Iea494bed07d8050fd60e24ffea153ce911c27c8c Reviewed-on: https://gerrit.libreoffice.org/38618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-05Improved loplugin:cstylecast to reference types: connectivityStephan Bergmann
Change-Id: I63c747efa2aacf4cb23de6fe9ab02af7abc107f9
2017-06-03android: Update configure.ac for NDK r14b versionbrainbreaker
This commits updates the NDK version warning in confiure.ac for NDK r14b as it is now tested for building Android. Also, Modify code in JStatement.cxx to suppress the warning of ignoring return value which turns into error with --enable-werror argument. Change-Id: I40b264c2f39788948dbf947073de63c3347184f9 Reviewed-on: https://gerrit.libreoffice.org/38359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-02Cleaning in table.cxx of firebirdJulien Nabet
- Replace nNullabble by nNullable - Replace wrong var name sNewTableName by sNewColName Change-Id: Ib10de7057c0d131f8504e8387721a05bd9e4434f Reviewed-on: https://gerrit.libreoffice.org/38251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-05-31simplify OSQLScanner::SQLyyerrorNoel Grandin
...buffer management Change-Id: I649a93ed5bd9bd7d4ac8ec73fc956eb8532eac89 Reviewed-on: https://gerrit.libreoffice.org/38206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30remove duplicate 'using namespace'Jochen Nitschke
Change-Id: I7f8828f677cfb588135ff75c03ffb75895773440 Reviewed-on: https://gerrit.libreoffice.org/38201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30fix convertName2SQLNameNoel Grandin
after my commit 47bbe217607374ccd3a76f1ef6d82e43efd31ba1 "untwist the logic in convertName2SQLName" Change-Id: I3d365a24c538d8ecade2b6fe32fa739d8f4bd211
2017-05-30untwist the logic in convertName2SQLNameNoel Grandin
Change-Id: Ib3cfa3a8a2bdc691e3f6db25672a37c8ede1ffd5 Reviewed-on: https://gerrit.libreoffice.org/38180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30teach redundantcast plugin about functional castsNoel Grandin
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-25Related tdf#108068: Use new name of column when it's been changedJulien Nabet
First fix simple case, the rename of a column which is not a primary key Change-Id: Ia0de8e531021cbec0409408008c541c25a4bcd85 Reviewed-on: https://gerrit.libreoffice.org/38014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-05-19loplugin:stringcopy: connectivityStephan Bergmann
Change-Id: I2309a6b943323e42df8bb2b4c971c1388539ead4
2017-05-19loplugin:unusedfieldsNoel Grandin
make it a little smarter in dealing with fields that are smart pointers Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11 Reviewed-on: https://gerrit.libreoffice.org/37751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15Translate German comments and debug strings (leftovers in dirs a... to c...)Johnny_M
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "a" to "c". Change-Id: I3b0152ee78ad80a29d714cbd98bf888f31be4763 Reviewed-on: https://gerrit.libreoffice.org/37573 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-15remove some unnecessary lockingNoel Grandin
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c Reviewed-on: https://gerrit.libreoffice.org/37602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09Fix typosAndrea Gelmini
Change-Id: Ie0f67456e5c7d9b7b26b27b4d633881236ceeadb Reviewed-on: https://gerrit.libreoffice.org/37361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-09dump exception message on exceptionCaolán McNamara
Change-Id: I30d942e9e8b240be9033b41142831b018bdfc49f