summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2017-03-03Remove bogus source code commentsdennisroczek
Change-Id: I616ca3483d926c8e4155512ef5138e3f7978ece3 Reviewed-on: https://gerrit.libreoffice.org/34842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-26loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ib90fb2c3f4d976dce764d4c91af797351317397b
2017-02-26CleanupJulien Nabet
Following 26843cea83292632b4ed92dfd1b3da9a46c12995 (from 2008!) Change-Id: I09713a6c39994d98dfb82c1ee4cc90b7711e7317 Reviewed-on: https://gerrit.libreoffice.org/34655 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-21Fix typos/translations, following 04644956e53dAndrea Gelmini
No automatic tools Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428 Reviewed-on: https://gerrit.libreoffice.org/30874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21loplugin:subtlezeroinit: connectivityStephan Bergmann
Change-Id: I4091b05ecc2f8c2daca94870f2fec9e5c928c07f
2017-02-19warn->info on icedove/seamonkey profilesCaolán McNamara
Change-Id: I25fe8a433670effbbfd5c530587602697e4f6cf4
2017-02-19Firebird: css::sdbcx::Driver is implementedJulien Nabet
in Driver.cxx around line 253 and declared as such in FirebirdDriver::getSupportedServiceNames_Static Change-Id: I3ca6f144f019ba41af02e2f3ac63395015f7f812 Reviewed-on: https://gerrit.libreoffice.org/34427 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-02-17remove unused NONE from TAscendingOrder enumNoel Grandin
Change-Id: I31c793df40b2a687b4a6c84854f34aba72ac0494
2017-02-17remove unused enumerators from SQLNodeTypeNoel Grandin
Change-Id: I0e8a3c5b63a00befa36c7edfbec0acd60bd3dc03
2017-02-17remove unused enumerators from StandardSQLStateNoel Grandin
Change-Id: Id17c6c0cc41496f494117e781878b15ba2bc0518
2017-02-15Drop :: prefix from std in c*/Tor Lillqvist
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155 Reviewed-on: https://gerrit.libreoffice.org/34324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann
Change-Id: I3bfa7b8896c9eb191047edf469749bb7f0128dfd Reviewed-on: https://gerrit.libreoffice.org/34270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-14BOOST_SPIRIT_SINGLE_GRAMMAR_INSTANCE has been defined forever in these filesTor Lillqvist
Change-Id: I0afa1b404192f44540aa318e748452e0328fac6b
2017-02-12Various typos about propertyJulien Nabet
Change-Id: I7585a1346fb19a886240db8dd393554efee862cc Reviewed-on: https://gerrit.libreoffice.org/34174 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-10Remove MinGW supportStephan Bergmann
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10convert SearchParam::SearchType to scoped enumNoel Grandin
and drop unused SRCH_LEVDIST enumerator Change-Id: Ic5118757060656562e04dd7da24a3f143abec3fb Reviewed-on: https://gerrit.libreoffice.org/34065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08rtl_str_shortenedCompare_WithLength -> OString::startsWithStephan Bergmann
Change-Id: I3eabdeba10d8d1064f00b817b04f03aad8a6b352
2017-02-07connectivity: Remove leftover OEvaluateSetTakeshi Abe
Change-Id: Ia8ecabb426c969a02174b399a479dfb337b36a79 Reviewed-on: https://gerrit.libreoffice.org/33983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06loplugin:unusedenumconstants in connectivity..cuiNoel Grandin
Convert ExpressionFunct to scoped enum and drop FUNC_CONST value. Convert MQueryExpressionBase::node_type to scoped enum and drop Unknown value. Dop PageType::Color value Change-Id: Icb1f5503c230fb91329acc7d9e1da665fa28d95e Reviewed-on: https://gerrit.libreoffice.org/33948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02Too dumb to sortStephan Bergmann
Change-Id: I0ba613bff040d07554dc41783aea332d0a597b3c
2017-02-02unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01Missing includesStephan Bergmann
Change-Id: I287f166291a905c9f4d166bf07c09de93184bf87
2017-02-01loplugin:useuniqueptrStephan Bergmann
Change-Id: Iffab8e3d8ecaad835d5f0cce68ede4eaea1547a4
2017-02-01loplugin:stringconstantStephan Bergmann
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-02-01loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I53699ef386dad99b38559defe985057492a5df76
2017-02-01-Wunused-macrosJochen Nitschke
Change-Id: I2d3b6f22deee0f2b9ec39592b89e0e4742659593 Reviewed-on: https://gerrit.libreoffice.org/33782 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30ditch fixed length bufferCaolán McNamara
Change-Id: I06bbe4ee92ebeb7d1bc305d5a7da9ee9a4fa0cb8 Reviewed-on: https://gerrit.libreoffice.org/33706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-30tdf#105101 check scale to determine subtypeTamás Bunth
For computed decimal/numeric values firebird's subtype remains 0. In this case we check for the scale of column. If it is not 0 (negative), than imply numeric. Change-Id: Ie5a023d165852fe402b3b4cac817b0bbef58e7cd Reviewed-on: https://gerrit.libreoffice.org/33660 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-01-30tdf#105142 set default charset to UTF8Tamás Bunth
Change-Id: I47dd18a141949f94903297f6e011e7956587b400 Reviewed-on: https://gerrit.libreoffice.org/33663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-23loplugin: unnecessary destructor: comphelper..desktopNoel Grandin
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23loplugin:useuniqueptrStephan Bergmann
Change-Id: Ia0c8c3bb8319b5719bf63a3408d404d9adc681cc
2017-01-23use rtl::Reference in OResultSetNoel Grandin
instead of manual acquire/release Change-Id: I8baa2e7ac64445ea69d4b62566a89b6e42307e51
2017-01-20loplugin:dynexcspec (macOS), connectivityStephan Bergmann
Change-Id: Ic8cd364cd27f7f7669ac8d5553fc3974b5f8c992
2017-01-20loplugin:dynexcspec (clang-cl), connectivityStephan Bergmann
Change-Id: Ia49a11d4f707764640ea497d877d1699183ca56e
2017-01-19New loplugin:dynexcspec: Add @throws documentation, connectivityStephan Bergmann
Change-Id: Id8711eaeac65efaa228b60d5786169016bfb61a3
2017-01-17no special support for MACOSX PPC in master for a while nowCaolán McNamara
Change-Id: I8d5dc878f41939e55ef8995d1da74548faa4711f
2017-01-17remove some unused Java codeNoel Grandin
Change-Id: Ia1663256fc0b92c343ea4ba55a821c969077a0aa Reviewed-on: https://gerrit.libreoffice.org/33174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17new loplugin: useuniqueptr: connectivityNoel Grandin
Change-Id: I016f6a62814f1e93373dc70f59893fa38361464b Reviewed-on: https://gerrit.libreoffice.org/33149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14coverity#1371289 avoid the need for an assignmentCaolán McNamara
Change-Id: I7f9b8d21652c79642f9a2f916ad0609c8abd430b
2017-01-14loplugin:refcountingStephan Bergmann
Change-Id: Ied9ecabb3cb6b5d629ec72db164df452d8ca114a
2017-01-14tdf#70433 tdf#104734 implement sdbc XClobTamás Bunth
And use it in getClob, so LO can display clob values like the return value of the built-in List function. Change-Id: I395016e945dbeb2c6bb3737b6345d40ff9f48089 Reviewed-on: https://gerrit.libreoffice.org/32938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-01-13coverity#1371289 avoid the need for an assignmentCaolán McNamara
Change-Id: Ia0efc427d9996eb8414821d07f7e760fb1b35246
2017-01-13jdbc clob character stream: return 1 when returning a single odd byteLionel Elie Mamane
if at that point nBytesToRead is 0, it may be that it was 1, but we have read one byte from the buffer (m_buf). So in this case, return 1, not 0 (which would signal EOF). Change-Id: I229e53f1c38c80f709df244a3509caccd69c8ecf Reviewed-on: https://gerrit.libreoffice.org/33029 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-11XBlob::getBytes expects 1-indexed positionTamás Bunth
There was also a wrong relation. Now blob resets its position. Change-Id: I41caf7cdfa261cafa5b9e66c9523c7f15225bfd8 Reviewed-on: https://gerrit.libreoffice.org/32937 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann
Change-Id: Ibbcb8b6dfaf1c979db2e7930c4f6c8475d693ac8