summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: static fields that should not be staticNoel Grandin
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-18connectivity: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I9ca72364cd57fd2da0c6f5f704a3fe494c0a1df5
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-16java: remove OOoRunnerLightNoel Grandin
and just use OOoRunner, there is no point in having a stripped down jar, the cost of firing up the Java VM completely dwarfs any benefit of having a smaller jar. Change-Id: Ibcc3c5bd6e9b9c918041142dd32db0ea5dddc25b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-12-15java: remove some unused fields and variablesNoel Grandin
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12connectivity: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I10b2ddf9dcc83219fea8eb55783507eed52702e8
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-09fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: Ib35eb591534c3f23adc3cb7b7fa9696dc5cbeabf Reviewed-on: https://gerrit.libreoffice.org/13383 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-12-08callcatcher: update unused codeCaolán McNamara
Change-Id: I3cd65d112339fa9c67ed462fe39acbbef91d4d8d
2014-12-05loplugin:cstylecast, involving pointer to incomplete typeStephan Bergmann
Change-Id: I614bd8433a105a2855e0efa039f4a9986197435f
2014-12-05loplugin:cstylecast, involving pointer to incomplete typeStephan Bergmann
Change-Id: I4b291f0d40fd8622094a706f8241c8917e4f0cf3
2014-12-05loplugin:cstylecast, involving pointer to incomplete typeStephan Bergmann
Change-Id: Ib3127eb72ca72f55ce6082ebcb05fceb80608c47
2014-12-04connectivity (Linux): loplugin:cstylecastStephan Bergmann
Change-Id: If2a3306360ea3db4476b09774e4f93c2c0dc4027
2014-12-04connectivity (Mac): loplugin:cstylecastStephan Bergmann
Change-Id: Icb680130bf5123029fa3880c8f9865a2b71facfd
2014-12-01fdo#86852 correctly recognise NULL values in query parameter values dialogLionel Elie Mamane
Change-Id: I3c0cf976e0a9fbafe6eee768799a2f48c2ee0ea9
2014-12-01Resolves: fdo#80938 fix SQL view to be editableCaolán McNamara
regression from commit d60392fb5b387175dbd2e575848993c02c56922f Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Mar 6 12:05:24 2014 +0000 coverity#706316 help out coverity re tortured logic Change-Id: I2ee7bd3b7421ae46878d1b565ef14dd7b0bbd10e
2014-11-25java: remove some comment noiseNoel Grandin
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-24unotools: Internalize ucblockbytes.hxx headerMatúš Kukan
Change-Id: I1a9b795eda832673a83a426c8bf10d5bb9c28581
2014-11-20further fix mozab build after header cleanupChristian Lohmaier
Change-Id: I7e3c79d854a08c94aa699d86994704b9360b69bf
2014-11-20connectivity: fix the mozab buildMichael Stahl
Change-Id: I299c856814e09a93a71f8acf8745a0590e2ecc72
2014-11-18Build fix on Windows.Kohei Yoshida
Change-Id: I5e4c29ce5a1f427c5642a253f985b42938912075
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17Build fix on WindowsKohei Yoshida
Change-Id: I5c24856bfe48646bc0e9cd00f0849a5db12dfef2
2014-11-17Missing includeStephan Bergmann
Change-Id: I1dbf7a73ec60115f11d3a5455de2871041cd1605
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14coverity#1158396 Uncaught exceptionCaolán McNamara
Change-Id: I6752a534bca8f81627cdd616ac0f2268824299e0
2014-11-14coverity#1242888 Unused valueCaolán McNamara
Change-Id: Idf2709382dc431b6e34c2993d04c41aa8a3786ab
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-13fix connectivity unit test for --enable-mergedlibsNoel Grandin
it's a workaround, but given the conflicting requirements of MSVC not liking duplicate symbols, but the unit test needing to link the objects directly to access internal symbols, there is not much else we can do. Change-Id: I9bdcc5f2b6ab0712cc3317033c4fbae4791cbb6b Reviewed-on: https://gerrit.libreoffice.org/12387 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05new loplugin: use more efficient find() methodsNoel Grandin
(Original idea from Kendy) Look for code that is calling std::find on a sorted container (set/map/vector) and warn about it - the code should be using the find method on the container itself, since that is considerably faster. Change-Id: Ib74e5d3faa836eeb0df16a736d202696626bdfd2
2014-11-05-Werror,-Wpointer-bool-conversionStephan Bergmann
Change-Id: Iae4c439de43fba471916463da8939709bbd068e5
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04coverity#706375 uncaught exceptionDavid Tardon
Change-Id: I3d198d60524224e22d7f609ddde1ed8c3c319da9
2014-11-04coverity#706366 uncaught exceptionDavid Tardon
Change-Id: If89d6613394220fa4ca1da9b5b8820d9dbc205c7
2014-11-04coverity#706363 uncaught exceptionDavid Tardon
Change-Id: I2dde714f847f6df4d9b4ede744bef089a3715d7a
2014-11-04coverity#706362 uncaught exceptionDavid Tardon
Change-Id: I7200fe17c66cd904f0fc243bf8e33d6c24079729
2014-11-04coverity#706361 uncaught exceptionDavid Tardon
Change-Id: Iee569c32569339ec2eeb6ef038e5bdc83e541a8f
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31coverity#1158395 Uncaught exceptionCaolán McNamara
and coverity#1158394 Uncaught exception Change-Id: I73430678c658202475e0073c3c9bde0a072c1ee9
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#735298 Unchecked return valueCaolán McNamara
Change-Id: I66499283f4218662146c380f605bb20b8a2ff49a
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28Resolves: fdo#85081 terminate if can't load kde addressbookCaolán McNamara
Change-Id: I3b1b78127d7d4080a23c0ac9f7d37706197de62c
2014-10-28coverity#706303 Uncaught exceptionCaolán McNamara
Change-Id: If3963e0ae2c6477eb074e89f411c22a82d339634
generated by cgit (git 2.34.1) at 2024-08-10 22:23:50 +0000