summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-18Typo: kjnow->knowJulien Nabet
Change-Id: Ib30aa4e8f430131f5f073169d694e53a3bcd6960
2014-06-18Typo: perharps->perhapsJulien Nabet
Change-Id: Ibc1580d04d896a953edc15fb6cc9381914230e32
2014-06-18Use rtl::Reference to make code clearer & exception-safeLionel Elie Mamane
Change-Id: I8cfdf792541b351a19e16f95d4e6f7127e3d33b2
2014-06-18fdo#80084 file driver PreparedStatement: close previous ResultSet on reexecLionel Elie Mamane
This partially reverts commit d87c2c59c9c1d5f5825f355c9eb941fdf95b42f6 "sdbc file driver (Prepared)Statement: created ResultSet owned by *caller*" From that commit, we keep the part about not reusing the same ResultSet on reexecution (client code may have disposed it or closed it), but we revert the part about not closing / disposing the previous ResultSet on reexecution. Change-Id: I4946207f9740484b2f5fbc3575a5708fe39f357c
2014-06-18rtl::Reference fits just fine hereStephan Bergmann
Change-Id: Ib48999c7fe532b2a8bf5222ef27d8d4929937e3b
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-15Resolves: fdo#80025 Crash with Thunderbird/Icedove address bookJulien Nabet
There's no property USEBOOKMARKS for mork/moz (regression from 0fadbdbbdbd55cf60f9a202f1cf7b1d60517078c) Change-Id: If81f063fad2d702c9d8b0bb4147757655cb016cf
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: I7f22aa5576ca3c62fa363971f4fa5992b7711563
2014-06-13coverity#706304 Uncaught exceptionCaolán McNamara
also coverity#706301 Change-Id: Ie6eba530c9a2f822226fbd1b1a6aa49deaf99659
2014-06-11Related fdo#79714 OSX-crash opening query or table in embedded Firebird ODBJulien Nabet
See https://bugs.freedesktop.org/attachment.cgi?id=100839 and other comments Change-Id: I1187b171caf54997f5e8850ade4a3fb35ad9ec29
2014-06-10coverity#1213468 Uncaught exceptionCaolán McNamara
Change-Id: I451b13be6b72925e4cfa0e66c5690eca22c54dad
2014-06-06fixincludeguards: fix include guardsThomas Arnhold
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b Reviewed-on: https://gerrit.libreoffice.org/9629 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-05coverity#1158175 Missing break in switch, assuming its intentionalCaolán McNamara
Change-Id: Ia0f1951f1e3edcd858a37ea091550feb2b9fd451
2014-06-05connectivity: remove SAL_THROW macroNoel Grandin
Change-Id: Id3bbb7a0d39a41b7106303f42d55ba4968235b63
2014-06-04update_pch: add a bunch of pch filesThomas Arnhold
connectivity: 3m52s -> 2m47s cppcanvas: 28s -> 13s cppuhelper: 20s -> 14s dbaccess: 2m38s -> 2m01s hwpfilter: 16s -> 13s sot: 21s -> 16s Change-Id: I49286bfe6be73dd1b861be632b95e17a99e82f8a
2014-06-04connectivity: fix includesThomas Arnhold
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
2014-06-04coverity#736759 Dereference before null checkCaolán McNamara
Change-Id: Ia36e192d32c46a5c1129eca050b2863ec1213bb4
2014-06-04Missing gb_CppunitTest_use_vclStephan Bergmann
Change-Id: If3d2dbe70fc3448ca6ab8ef8af62f5b571888c86
2014-06-04DeInitVCL at end of testsStephan Bergmann
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-01Resolves: fdo#79493 Refresh Tables option fails with FirebirdJulien Nabet
Comparing with hsqldb part, sdbcx::OCollection link wasn't present in Tables constructor Also include Catalog.hxx to be able to call "refreshTables" method Change-Id: I1d8f2b0b361f8fd90f3065c07b3224894a3700d6
2014-05-31fdo#73352 firebird don't claim to support interfaces one doesn'tLionel Elie Mamane
and then throw an exception when the interface is used Change-Id: Id5e2c852323d49f51ab55cf46ab54223cf8ccf03 Reviewed-on: https://gerrit.libreoffice.org/9590 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-30Replace "compareToAscii" by !=Julien Nabet
See http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-td4110680.html Change-Id: I1ed37671e6c248ada7a972dba00e0fe98b565e75
2014-05-30Fix memory leakStephan Bergmann
Change-Id: I64a74ea23d9a2410ebff0c42c54601fd0b0190f0
2014-05-30Fix memory leakStephan Bergmann
Change-Id: I30ab0dcf47d236c8ebda3a2d1da0aaa4f0cd7477
2014-05-30Fix memory leakStephan Bergmann
Change-Id: Ia9176826b89b947408230bf65db26a83f269c845
2014-05-30Fix memory leakStephan Bergmann
Change-Id: I70522657f968ed4f84e9447dd999d8be746fc973
2014-05-30Fix memory leakStephan Bergmann
Change-Id: I0e5c3af0504f3090a5db7692c6bfb1d33b3aa81f
2014-05-30Fix leaks in test codeStephan Bergmann
Change-Id: I435fcfd6d10875565b543ea76fa8bfbf52e5f5d0
2014-05-30fdo#68849: Add header guards to all include filesJens Carl
Added header guards to files in directories avmedia/, basegfx/, chart2/, and connectivity/ Change-Id: I94ec438ec918ccef1c518edfd9ab4944e9e2961b Reviewed-on: https://gerrit.libreoffice.org/9555 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-29Update comment to reality... many properties now, not one.Lionel Elie Mamane
Change-Id: Icc81d3067969d1d61182865d36ecabec4e7f85b7 Reviewed-on: https://gerrit.libreoffice.org/9551 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-29To avoid some confusion for people like me :)Julien Nabet
Thank you Lionel and Tor! (see http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-td4110680.html) Change-Id: Ibbe68b8b3d12e4dfacf7f66bb3adbc2fd831d1a5
2014-05-29use OUString::startsWith()Noel Grandin
Change-Id: I0fc77b50792e48be175ab7cc151509e097676849
2014-05-29remove more unnecesary OUString constructor useNoel Grandin
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29remove unnecessary NULL parameter passed to UNO ExceptionNoel Grandin
.. now that we have a default value for that parameter Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-26coverity#982631 Missing break in switchCaolán McNamara
Change-Id: I1c21dfb48f4ecdcc3c599d69fe76bde006a85313
2014-05-24coverity#983622 Uncaught exceptionCaolán McNamara
Change-Id: I3b63a42444a116afe7d88e2f806b17a709651e34
2014-05-23coverity#1103737 Uncaught exceptionCaolán McNamara
Change-Id: I53aab00dfad0310a7846fdf7185c50036329343c
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-22Fix previous commitJulien Nabet
Change-Id: I629b5f6e57c5d8368bafc544c1c23785ee209a1e
2014-05-22Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19Julien Nabet
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22cppcheck: Exception should be caught by referenceThomas Arnhold
Change-Id: Ib92122311186da16fbef9441560bb7a013072e76
2014-05-22remove unnecessary use of OUString constructorNoel Grandin
Change-Id: I7769625289d8bf47fe5905dfb91d3bce9e0f5c85
2014-05-21fix spellingNoel Grandin
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-17remove wrongly added IsBookmarkable propertyLionel Elie Mamane
Change-Id: I7bde1200dbe9da76e062f2783cc223a07084c6fd
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-16Use SQL_DEFAULT_TXN_ISOLATION to get getDefaultTransactionIsolationJulien Nabet
Change-Id: I7f4785088151490ae1d55d2bb78bce28357d5c45 Reviewed-on: https://gerrit.libreoffice.org/8863 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-15Related: #i124896# remove obsoleted pq_allocator.hxxCaolán McNamara
Change-Id: I8a2b54c97f20e581b9703bf33dbba537c2f603c2
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
generated by cgit (git 2.34.1) at 2024-08-05 02:12:13 +0000