summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09include/jvmfwk/*.h -> .hxx (only ever included from C++ code)Stephan Bergmann
Change-Id: Ia912e937d5a48afb6f8f5345b20bb7bd517fc4f1
2016-03-09loplugin:constantparam in connectivityNoel Grandin
Change-Id: I5e71b3de15e043066cd4177dd42b231527eb71e4
2016-03-08tdf#75280 Replace sal_uIntPtr to better types in /connectivityJaskaran
Many other occurences of outdated sal_uIntPtr still remain.This commit does not fully fix the issue. Change-Id: I744a4399a12cefb48e948c20c2d0dec833116b81 Reviewed-on: https://gerrit.libreoffice.org/23034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-08tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I either replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 statements or i used SAL_INFO(..)s Change-Id: Iefb6b83e86e1767e55600b6e1989ee91207fb220 Reviewed-on: https://gerrit.libreoffice.org/23000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-07loplugin:defaultparamsStephan Bergmann
Change-Id: Ibc922d84aeaba4e2dbfac3a23f253db76408db45
2016-03-07tdf#97499 Remove some Default arguments in unordered containerJaskaran
Change-Id: Ic008e244b8ae1888fa45379371f5525ee77f6087 Reviewed-on: https://gerrit.libreoffice.org/22887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07loplugin:unuseddefaultparamsNoel Grandin
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07improve defaultparams lopluginNoel Grandin
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in variousNoel Grandin
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04pgsql-sdbc: put local code and constants in anonymous namespaceLionel Elie Mamane
Change-Id: Iaccda39ddf651f6b2ef326c9b3903670c25bcdde
2016-03-04pgsql-sdbc: factorise common codeLionel Elie Mamane
Change-Id: Iea185bc216e92baee9f97157b8ac13a9a64f99b5
2016-03-04tdf#92538 pgsql-sdbc make a reasonable sorting of typesLionel Elie Mamane
Change-Id: I74283234834b5057857620ed2466068e88628585
2016-03-04pgsql-sdbc: "text" dataype is *LONG*VARCHARLionel Elie Mamane
Change-Id: Idd01299ef4592b43e573c3b0996d4822664c6bcf
2016-03-04fixup startsWith vs == in string comparisonsLionel Elie Mamane
probably left-over from OUString transition Change-Id: I29f8f34ad44828608aa16b0b0a0759e887e280af
2016-03-04-Werror,-WshadowStephan Bergmann
Change-Id: I944d7bd40a297dac97b954196a0e8e286f0ba712
2016-03-04fixup tdf#92538Lionel Elie Mamane
Change-Id: I57650fe955a31f433d611d9e74a0762d349bed64
2016-03-04fixup tdf#92538Lionel Elie Mamane
Change-Id: I62fbead59ac83147da6da984f89b64b1d7e4f90d
2016-03-03tdf#92538 use proper schema name for type namesLionel Elie Mamane
Change-Id: I7e428e4530765925bd35c7f4fcde7f95ceb12243
2016-03-03loplugin:unuseddefaultparams in include/filterNoel Grandin
Change-Id: I893b50835717d449e495e00e9b33de0b60467a6e
2016-03-03loplugin:unuseddefaultparams in connectivityNoel Grandin
Change-Id: I03cc69a924913713a0da819899ce259305b88016
2016-03-02loplugin:unuseddefaultparam in cuiNoel Grandin
Change-Id: I445b96a2ed4364616b2cb6a23efe36afb3f862f7
2016-03-01coverity#1352212 Unchecked return valueCaolán McNamara
Change-Id: I75a6853a6708585201dbc4722e7a19cd568a48f7
2016-02-25convert StandardSQLState to scoped enumNoel Grandin
Change-Id: Ia0a1526140cfed35a73a6fea1a173d2fb5005960
2016-02-25convert SQLNodeType to scoped enumNoel Grandin
Change-Id: I622e55622d38e6017993c8bc52625c85d0f74d74
2016-02-25convert TraversalParts to scoped enumNoel Grandin
Change-Id: I34797d6ccdf8b9c75004c129056f3a09f169e1b4
2016-02-25convert OSQLStatementType to scoped enumNoel Grandin
Change-Id: I2df117cf0f405e88899e7ccab380156284720449
2016-02-25convert ParameterClassification to scoped enumNoel Grandin
Change-Id: Iab3d2db50acc1f70b352dd0fd5f1270693a8e991
2016-02-25convert FilterComponent to scoped enumNoel Grandin
and simplify the overly-general logic in FilterManager Change-Id: I2cbd9db6a53894cd13713a5cc0d1807cec456848
2016-02-25convert EComposeRule to scoped enumNoel Grandin
Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9
2016-02-25convert SQLExceptionInfo::TYPE to scoped enumNoel Grandin
Change-Id: I2f21a742bc649fc42f89aebac2691c6054cd20d8
2016-02-25convert InternationalKeyCode to scoped enumNoel Grandin
Change-Id: I2eba99ebb86003f1f5ddefafb4cd191b29853819
2016-02-25convert ErrorCode to scoped enumNoel Grandin
Change-Id: I37d2dd0b84fce229b548bbe941cfdd1169170af9
2016-02-25The XJavaVM.getJavaVM return value can always be extracted to sal_Int64Stephan Bergmann
(avoids warning with MSVC 2015) Change-Id: I9b3c5bc26a1e3df88a03e5fb295eb6a8fb63f824
2016-02-23Guard against globally shared UNO ref accessed from wrong UNO envStephan Bergmann
connectivity/source/drivers/jdbc/jdbc.component has environment="@CPPU_ENV@:affine" to place the com.sun.star.comp.sdbc.JDBCDriver implementation into an affine UNOenvironment. The com.sun.star.sdbcx.comp.hsqldb.Driver implementation (in the normal C++ UNO environment), in ODriverDelegator::connect (connectivity/source/drivers/hsqldb/HDriver.cxx), calls StorageContainer::registerStorage to store an XStorage in a global map, then calls the JDBCDriver (i.e., thread enters the affine environment), which calls via (non-UNO) JNI into hsqldb.jar code, which in turn calls via (non-UNO) JNI into Java_com_sun_star_sdbcx_comp_hsqldb_StorageFileAccess_isStreamElement (connectivity/source/drivers/hsqldb/StorageFileAccess.cxx), which uses StorageContainer::getRegisteredStorage to obtain the XStorage and use it. But that XStorage is the original C++ object, not a proxy that witnesses the mapping between the normal C++ and the affine UNO environment. (And the thread is still in the affine environment, after having passed through the Java stack frames via non-UNO JNI.) That does not necessarily cause any problems immediately (so apparently went unnoticed for quite a while), but when the XStorage-implementation in turn wants to obtain the SimpleLogRing singleton, it would now trigger the std::abort();//TODO in cppuhelper/source/servicemanager.cxx (where the invocation-by-constructor case hasn't yet been implemented for differing environments), when that singleton is changed to use the constructor feature in <https://gerrit.libreoffice.org/#/c/22020/> "tdf#74608: Constructor function for SimpleLogRing singleton." So just do any necessary mapping every time an XStorage stored in the static StorageContainer is accessed. Change-Id: I91a62fd7e1cec29026f70a2c3acdfe051885c0fa
2016-02-23Replace nested pairs with structStephan Bergmann
Change-Id: I95513accce789110fa987b9bf9ca94762fbeb646
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-22Remove TRACE_ALLOC/FREE debugging codeStephan Bergmann
...which started to cause -Werror,-Wunused-variable on Mac OS X after db8067145f0126402be39042934e11228a1b42e9 "loplugin:write only fields" Change-Id: I0cb11e969e8e3835ddd5a33b8e0330135c63a8f6
2016-02-22loplugin:write only fieldsNoel Grandin
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-22WaE vs2015: casting from int32 to pointer to to odbc idiosyncraciesNorbert Thiebaud
Change-Id: I94f2435aee76b03d4b14b009fdeca06a14f22909 Reviewed-on: https://gerrit.libreoffice.org/22599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-18coverity#1352441 silence Resource leakCaolán McNamara
Change-Id: Ib7d771098d640e17a9503d2d780051e916fa6bb3
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-11mork: Clean up unused includesDavid Ostrovsky
Change-Id: Ideff092f49bd84ce829f3ae142de7ff2d32391ab Reviewed-on: https://gerrit.libreoffice.org/22128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09sequence->vector in postgresqlNoel Grandin
Change-Id: I57bf8f4404df9f73d9a52c651c9f27784f10c937
2016-02-09tdf#88462 convert manual XInterface implementationskerem
Change-Id: I00561b7a6de6265cfdea0e3a92f404fac86982f6 Reviewed-on: https://gerrit.libreoffice.org/22213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09sequence->vector in ParameterManagerNoel Grandin
Change-Id: Ifbd3f7f3baf91aa21c085d3be1f67cba0a9068d3 Reviewed-on: https://gerrit.libreoffice.org/22182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-15 18:59:13 +0000