Age | Commit message (Collapse) | Author |
|
Change-Id: I07b1d90258647453e498b574bc38c78872041c2d
|
|
from
sal_Int32 nIndex = sSystemPath.lastIndexOf('.');
so
OUString sConnPartURL = sSystemPath.copy( 0, ::std::max< sal_Int32 >( nIndex, sSystemPath.getLength() )
is equivalent to
OUString sConnPartURL = sSystemPath.copy( 0, sSystemPath.getLength() )
which is
OUString sConnPartURL = sSystemPath;
so drop sConnPartURL and replace with sSystemPath
Change-Id: I3fc8e88a4b3e474c3dccd08cf356e4663503ae02
|
|
Change-Id: I2c83c87d15f5fdc766a8464a8389e22120eabc52
|
|
Change-Id: Iacf60c456912f2e38c7a082e48c45164e79c1097
|
|
Change-Id: I8384920bc55dafb2cc6581fe82f38d4e2659cc3d
|
|
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
|
|
Convert code like:
OUStringBuffer sVal(OUString("0x"));
to:
OUStringBuffer sVal("0x");
Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
|
|
Convert code like
aStrBuffer.append(OUString(" AS "));
to
aStrBuffer.append(" AS ");
Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
|
|
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
|
|
Convert code like
aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp");
to
aFilename = OUString::number(nFilePostfixCount) + ".bmp";
Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
|
|
Change-Id: I42427beeae06f607e60aeeb7142714fd1f5d740d
|
|
...for internal loader="com.sun.star.loader.SharedLibrary" components, instead
of exported component_getImplementationEnvironmen (or implicit
CPPU_CURRENT_LANGUAGE_BINDING_NAME). Adapted a few .component files as proof-
of-concept, more to follow.
Change-Id: I82332e0a48e6fc1da245990bb72265fe6e58447e
|
|
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
|
|
Change-Id: Icd0f4ecee7d3d633f7a41e479729688829b4cf9d
|
|
Change-Id: Ief475a1bf6e65b4786e8ee9c025b204f143a30e0
|
|
!pSchemaPat->isEmpty() checked twice where line before we test if aPKQ is empty
so it seemed quite logical to test aPKO here
Change-Id: I79d7ec89f7ae67520492bbd4121a4a86918f2fbf
|
|
dd0990db74a4a5c3a129a7ff0ed2a739cd74a381 "fdo#72463 RowSet: on execute when not
dirty, rebuild cache" had temporarily introduced a bug that caused m_pParseTree
to be null here during JunitTest_dbaccess_unoapi, but Lionel states that it
cannot legitimately be null, even though the computation of m_bIsCount in the
ctor takes potentially null m_pParseTree into account.
Change-Id: If95f076a4c80f80cd58bba83521633fe8bb71f5d
|
|
That is the only choice that makes sense, since the
(Prepared)Statement could die (go out of scope) before the ResultSet.
User code could do that, if it does not "need" the (Prepared)Statement
anymore. Also, it is only natural for user code to dispose a ResultSet
that it does not need anymore.
So we need to create a fresh ResultSet each time.
The "luck" here is that the sdbc file driver does not implement
the XMultipleResults interface; things get more hairy then.
Change-Id: Ibf2cb5e5b7ca90432a289c185a6b4fe32d1ba565
|
|
Change-Id: Ia6799c852eb95d496fbc8dcfdabde62dffc263a6
Reviewed-on: https://gerrit.libreoffice.org/7066
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Except for our external api where the Oriya is stuck (and similar for
the vba implementation)
Change-Id: I8288c930567385eea49a4c303727b13ef8b8a89f
|
|
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.
Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
|
|
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
|
|
Change-Id: Ie9666b1c8878dd26593629b4b64d74b7448f98c1
|
|
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
|
|
Change-Id: I3ab3777a65fd68f8cbaf17a8e2a989dc4ad7b1cc
|
|
Change-Id: Ie5036134f03a0e9bfdfcb28190444b5d2ddcc323
|
|
Change-Id: I59f3fba9d4602cddfef1bd6862cbcfb9eec133ae
|
|
Change-Id: Ifbda934a89087fcc1c031978d3e5b5783722b328
|
|
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
|
|
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
|
|
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
|
|
Change-Id: Ic8914484c23c586036280bdf12a3fef3128d03ff
|
|
To test whether the range [a,b( is *before* e,
compare e to b, not to a.
This makes a difference when a==b, which happens for row 0 (header)
when there is no header.
Change-Id: I629b71936f82a468febe0360909264dd80304437
|
|
Change-Id: I39465b1b22a537de95db9f65b04ecf4bce667d0c
|
|
Change-Id: Ifd1829843886b8c58669fd4ccf04bc35bf4a0e10
|
|
Change-Id: Ic876603e5860b987280b73726fd79a071a9c833c
|
|
Change-Id: I1ab32794a10f78f305de8057af5885d7719f87a3
|
|
"connectivity: use 'application/x-dbase' for DBase files," as it breaks
JunitTest_dbaccess_unoapi. This apparently needs changes to more places.
Change-Id: I39ce794254324881818951fdb500ff04347b603a
|
|
... which is what we already use in calc.desktop; also
"application/dbaes" is not registered at IANA.
Change-Id: Ic2031a53e6620d10874df8882448497564962114
|
|
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.
Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
|
|
Convert code like this:
if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
if (aStr == "rem")
which compiles down to the same code.
Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
|
|
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.
I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
|
|
* Windows XP SP2 is 0x0502, see
http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
this is done module wide now. So the overall behavior
is as before. This seems to be the best compromise for
now.
* We need at least SP2 because of the bluetooth stuff
used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
project specific precompiled header files.
* All local definitions of WINVER are removed, because
the global WINVER setting makes them obsolete now.
To the relation of the three macros:
Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.
WINVER and NTDDI_VERSION can be set idenpendently each
for itself.
Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
|
|
Convert code like:
defaultValue.matchAsciiL( RTL_CONSTASCII_STRINGPARAM( "nextval(" ) );
to:
defaultValue.startsWith( "nextval(" );
Change-Id: I77bdcbf46bec6ded3c16a8248634b1424a1eb4f0
|
|
Convert code like:
if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
if (aByteStr.startsWith("rem"))
Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
|
|
Convert code like:
OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
OString aKeyName("NDX");
which compiles down to the same code
Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
|
|
Convert code like:
aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
aOStringBuf.append( " is missing )" );
which compiles down to the same code.
Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
|
|
Convert code like:
aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
aStrBuf.append( "ln(x)" );
which compiles down to the same code.
Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
|
|
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
|
|
Simplify code like:
aStr.equalsAsciiL( "%", 1 )
to
aStr.startsWith( "%" )
Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
|