summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2016-07-08loplugin:redundantcast: redundant static_casts in connectivityStephan Bergmann
Change-Id: I2428e27f04b9f967c21ea0dd29eff6ee63167ec3
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I9a647ba5c867e2152c204e1da98b5139091e51bd
2016-07-04tdf#43157 clean up OSL_ASSERT in connectivityJochen Nitschke
replace with compile time checks Change-Id: I9f3dd3b44fe0aa953feaa34a1bc0ccbdc3600899 Reviewed-on: https://gerrit.libreoffice.org/26801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04remove comphelper::string::removeNoel Grandin
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-27clang-analyzer-deadcode.DeadStoresStephan Bergmann
regression introduced by e1af7f0c438bc242e4562aa0286c99787b5ad544 "clang-tidy modernize-loop-convert in c*" Change-Id: I2f1fcb324f9bf7e97a8a514f41ac1208f1f1ca74
2016-06-23loplugin:unusedvariablecheckStephan Bergmann
Change-Id: Ia9c5ea707990d03dd4042c2e0a791976cc1b5f74
2016-06-23tdf#67302 Resolving tablesSupplier name clash for postgresqlPrashant
Change-Id: Ic9bedc678699e136c09a51575f1d27131c5ffd29 Reviewed-on: https://gerrit.libreoffice.org/25069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-21connecitivty: [loplugin:nullptr]Michael Stahl
Change-Id: Ic717e1d119e1a5b8a87caca263322d9e58fe6c68
2016-06-10o3tl::tryGet on a temporary is dangerousStephan Bergmann
...so rename to o3tl::tryAccess to make it more obvious that the returned proxy points into the internals of the given Any, and forbid calling o3tl::tryAccess on a temporary Change-Id: Ia412c6b2b06693811b9b7f0076a08bbf97142df9
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09remove some manual ref-counting in connectivityNoel Grandin
Change-Id: I0d00b4566c13817b296f237e993f4ce63ef0c664 Reviewed-on: https://gerrit.libreoffice.org/26053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06Normalize on using @throws instead of @raise[s]Stephan Bergmann
...as the former is used almost exclusively Change-Id: I38ff11cd0d5125534550df99dd427666011c3b7b
2016-06-06connectivity: -Werror=unused-variableMichael Stahl
Change-Id: Idaef923205a5f21d7c4c84cc74d3a369107f7325
2016-06-06loplugin:sallogareasStephan Bergmann
Change-Id: I32a1b278643ab54dd16966d0e41f3cee0bafb024
2016-06-06connectivity: DBase: fix some obvious endian issuesMichael Stahl
These calls to SvStream::Read/Write operate on structs that contain 32-bit integers. Change-Id: I2d45128ad482013cd9ef1fca0dd259dfc09c904f
2016-06-06Use o3tl/any.hxx in connectivityStephan Bergmann
Change-Id: I5c0d84b20b9146c4fc65bfdc0e9c65a05c93d71c
2016-06-06tdf#89329: use unique_ptr for pImpl in TColumnHelperXisco Fauli
Change-Id: I4a7594cb2a9424fddbd79e2b5d77431bf329eec9 Reviewed-on: https://gerrit.libreoffice.org/25903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03loplugin:refcountingStephan Bergmann
Change-Id: I97a2d4538e0667fe7220a94589a4296c02d882a2
2016-06-02don't detach from database if we are not attachedLionel Elie Mamane
this leads to a cascade of uncaught/unexpected exception and thus abort in debug build Change-Id: If417d2fd2037379e3006f98bc046713729ea4648
2016-05-30com::sun::star->css in connectivityNoel Grandin
Change-Id: I9489e92dc89a6d83a26ff4f0d9aad26acd28ad9f Reviewed-on: https://gerrit.libreoffice.org/25537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30loplugin:unusedmethodsNoel Grandin
Change-Id: I08e9bb65b2530148b80c67f01d51e594fc698acb Reviewed-on: https://gerrit.libreoffice.org/25543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26loplugin:unusedreturntypesNoel Grandin
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Revert "remove some manual ref-counting"Noel Grandin
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert T_DRIVERTYPE to scoped enumNoel Grandin
Change-Id: I87cfefbd35df5a8db8bac72f937a5906071b7568 Reviewed-on: https://gerrit.libreoffice.org/25356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert OKeyType to scoped enumNoel Grandin
Change-Id: Ic604991cdc0bf3e6dc5604a4a2b33f62b92f0915 Reviewed-on: https://gerrit.libreoffice.org/25355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22convert TAscendingOrder to scoped enumNoel Grandin
Change-Id: Idd88c08df47c4175702cea0e0a36c6b3e031469f Reviewed-on: https://gerrit.libreoffice.org/25212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17Make CSV line parsers consistent with CSV field parsers.Damjan Jovanovic
Our CSV field parsing algorithms treats fields starting with a quote (immediately at the beginning of the row, or after the field delimiter) as quoted. A quoted field ends at the corresponding closing quote, and any remaining text between the closing quote and the next field delimeter or end of line is appended to the text already extracted from the field, but not processed further. Any quotes in this extra text are taken verbatim - they do not quote anything. Our CSV line parsers were big hacks - they essentially read and concatenate lines until an even number of quote characters is found, and then feed this through the CSV field parsers. This patch rewrites the line parsers to work exactly how the field parsers work. Text such as: "another" ",something else is now correctly parsed by both Calc and Base as: [another "],[something else] instead of breaking all further parsing. Patch by: me (cherry picked from commit 60e93b8b5b6bc4220d66e95cd234a37f3c8f8fd7) Change-Id: Iced60fad9371e17a2e5640cd7169804b18cf5103 Reviewed-on: https://gerrit.libreoffice.org/24999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-12tweak assert and switch to squeak by NDEBUG and nonNDEBUGCaolán McNamara
Change-Id: I996d69d83acb77e96cb105f65a0243bd5fe80295
2016-05-12fall-through->SAL_FALLTHROUGHCaolán McNamara
Change-Id: I91ed1614162f3b7de13a0fe4ce1af689dce21510
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-06connectivity: replace boost::remove_reference with std::remove_referenceMichael Stahl
Change-Id: I7c11fcdaf8065fa86d224ad2fab88b0bcb907255
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04Fix Windows-only code, part 8Stephan Bergmann
Change-Id: I875c4f4382221baaaedcdfe9513ed75706e8517b
2016-05-04Fix Windows-only code, part 7Stephan Bergmann
Change-Id: Idf118bee77b55004897ae085e124b9cec2ba4237
2016-05-04Fix Windows-only code, part 6Stephan Bergmann
Change-Id: Ib9a311dd199db81b0be46a7c32c49a10e1b866e7
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03NULL -> nullptrStephan Bergmann
Change-Id: I7e4e36fbff89cb45c01a11dc70c4e6f17fe3bc38
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25-Werror=maybe-uninitializedStephan Bergmann
Change-Id: Iafa3712d3b600e11b687e7ec5a4ea5a14e87a48b
generated by cgit (git 2.34.1) at 2025-01-29 18:34:24 +0000