summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17Make CSV line parsers consistent with CSV field parsers.Damjan Jovanovic
Our CSV field parsing algorithms treats fields starting with a quote (immediately at the beginning of the row, or after the field delimiter) as quoted. A quoted field ends at the corresponding closing quote, and any remaining text between the closing quote and the next field delimeter or end of line is appended to the text already extracted from the field, but not processed further. Any quotes in this extra text are taken verbatim - they do not quote anything. Our CSV line parsers were big hacks - they essentially read and concatenate lines until an even number of quote characters is found, and then feed this through the CSV field parsers. This patch rewrites the line parsers to work exactly how the field parsers work. Text such as: "another" ",something else is now correctly parsed by both Calc and Base as: [another "],[something else] instead of breaking all further parsing. Patch by: me (cherry picked from commit 60e93b8b5b6bc4220d66e95cd234a37f3c8f8fd7) Change-Id: Iced60fad9371e17a2e5640cd7169804b18cf5103 Reviewed-on: https://gerrit.libreoffice.org/24999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-12tweak assert and switch to squeak by NDEBUG and nonNDEBUGCaolán McNamara
Change-Id: I996d69d83acb77e96cb105f65a0243bd5fe80295
2016-05-12fall-through->SAL_FALLTHROUGHCaolán McNamara
Change-Id: I91ed1614162f3b7de13a0fe4ce1af689dce21510
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-06connectivity: replace boost::remove_reference with std::remove_referenceMichael Stahl
Change-Id: I7c11fcdaf8065fa86d224ad2fab88b0bcb907255
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04Fix Windows-only code, part 8Stephan Bergmann
Change-Id: I875c4f4382221baaaedcdfe9513ed75706e8517b
2016-05-04Fix Windows-only code, part 7Stephan Bergmann
Change-Id: Idf118bee77b55004897ae085e124b9cec2ba4237
2016-05-04Fix Windows-only code, part 6Stephan Bergmann
Change-Id: Ib9a311dd199db81b0be46a7c32c49a10e1b866e7
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03NULL -> nullptrStephan Bergmann
Change-Id: I7e4e36fbff89cb45c01a11dc70c4e6f17fe3bc38
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25-Werror=maybe-uninitializedStephan Bergmann
Change-Id: Iafa3712d3b600e11b687e7ec5a4ea5a14e87a48b
2016-04-25Cannot extract Any to sal_uInt32Stephan Bergmann
...which has the same underlying type as sal_Bool Change-Id: If0548d2830b5924dec06e487c83a468fe8567c87
2016-04-25fix Windows buildNoel Grandin
Change-Id: I35b0d9a1ed6b4929217e75a03132f53844acd5b9
2016-04-25simplify OPropertyMap initNoel Grandin
Change-Id: I4ac86aea7ea391c1c708308b12670005e5eb7d6f
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I4654278f9a718042efde46755ee25e62494e3fb6
2016-04-22loplugin:salboolStephan Bergmann
Change-Id: Ibcae25d2476de37842e4a0e670b5951f431195a2
2016-04-21clang-tidy modernize-loop-convert in c*Noel Grandin
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I6fada7331ee369c35cbe019db4e730ce56cd1a1f
2016-04-18follow-up for clean-up declarations and includesJochen Nitschke
small change for commit 150ac9cf05ed9da6a2af5bc3f820280fd853e519 use forward declaration instead of include Change-Id: Ida9742b49233dc2bd2731e816dd6dc4d5705bb07 Reviewed-on: https://gerrit.libreoffice.org/24222 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18cppcheck: silence known condition warning in connectivityJochen Nitschke
Change-Id: Ic1e1b2f7aeb6d4c0a2f59f298df125c12a75b081 Reviewed-on: https://gerrit.libreoffice.org/24197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ie10757b8026e0bdf8be40f41bb04bb02334241f3
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15loplugin:passstuffbyrefStephan Bergmann
Change-Id: I5c2883dab8045e70467c6d09a75dcb423eecf702
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#97853 connectivity: fix inverted conditionMichael Stahl
Also in 2 places IS_TYPE was converted to dynamic_cast instead of a typeid check; use typeid there too, just for consistency. (regression from ac9671f94800b647f82b12e718968311a025e87e) Change-Id: I0df47a845eff660c791304c22c97704589ab999f
2016-04-13loplugin:passstuffbyref in connectivityNoel Grandin
Change-Id: I751977ecc1b532f72dd5673767471cb0a2cdbd06
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in connectivityNoel Grandin
Change-Id: Ie84eeac24f22c5e3d3a4f63728a73023d626ccc0
2016-04-11No need to wrap SAL_INFO in OSL_DEBUG_LEVEL > 0Stephan Bergmann
Change-Id: Ibb62a7fd5975ca891333f78a6f3c7c50329aa073
2016-04-11Replace OUtoCStr macroJulien Nabet
+ use SAL_INFO instead of OSL_TRACE for the impacted lines and surroundings Change-Id: Icf12f51d68af15527ec7baf79a2d60608d849c97 Reviewed-on: https://gerrit.libreoffice.org/23975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-08tdf#94306 replace boost::noncopyable in c...Jochen Nitschke
comphelper, connectivity and cppcanvas. Replace with C++11 delete copy-constructur and copy-assignment. Removed unused boost/noncopyable.hpp includes from some source files in cppcanvas. Change-Id: I90780820e21fbfd291ac10c266e7d16616e3a81b Reviewed-on: https://gerrit.libreoffice.org/23905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I2217920ced336189a94c0a5d1e3ac0ccd3912881
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #2tymyjan
Change-Id: I2e77c3b33ae3b8a49a7890cac77be566391972f2 Reviewed-on: https://gerrit.libreoffice.org/23751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I18ddafbf3d41f6779fb43e36ba1f1c48b37757a0 Reviewed-on: https://gerrit.libreoffice.org/23671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-28Use const_iterator when possible (connectivity)Julien Nabet
Change-Id: I749e4c3ffa0c89f919459c376edad4804b2b66ca Reviewed-on: https://gerrit.libreoffice.org/23573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-26tdf#90561: Add AS keyword in Query-designer for hsqldbJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=90561#c8 for more details Change-Id: Id812b68a9482e152ca60ea20bf3026e219a0ab8c Reviewed-on: https://gerrit.libreoffice.org/23515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-23loplugin:constantparam in connectivityNoel Grandin
Change-Id: Idfc7d9709a917ce2ebbc06119a906daf4cee8d48
generated by cgit (git 2.34.1) at 2025-02-11 10:15:36 +0000