Age | Commit message (Collapse) | Author |
|
This reverts partly commit 8942956e05f2208ffb666a2118f5db092c30ce6a.
Reason, Lionel indicates:
In general UnixODBC has to deal with more portability to more platforms,
so I would tend to more follow their signatures than the ones of Microsoft, that has to deal with only Windows OS on less CPU ABIs.
Change-Id: I8b8924d35aa86ac23a8191baa8584463941eddc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130084
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Tested-by: Jenkins
|
|
I compared with https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/odbc-api-reference?view=sql-server-ver15
Change-Id: Iac38c2305fbf3ace502f9e75802510f76a6bd700
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130055
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Replace the instances of Pi's value as magic number by M_PI
Use M_PI_2 and 2_M_PI instead of calculating these values in code.
Use basegfx functions to convert angle units.
Change-Id: I6cca7cc93704a70ccf3a0571a56a789bc9df51ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129479
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
|
|
Change-Id: Idccc6edea7dabc79135d49ffe69c1a13f2990b76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129684
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: I7f06f889f2bd687028c00d79bdcf9e2edacc5c82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129601
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I047d2366ad80eca701924cb0f66b6b1bcfdcac5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129597
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I630b7fbda7c9ebf578e74260a0d67eea32e9e429
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129549
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ib5eaf6c658e1185c1e3eec7ce34f0ce54d6ce771
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129441
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
BUNDLE_MARIADB seems to be useless since 2018 with:
7430dfe2a4a3b13ffa248bf14a3a2ca87993f48d: loplugin:unusedmethods
Change-Id: I75c9954f096e28c715f95073962241cafb787a69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129173
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
+ replace one time used define MYSQLC_URI_PREFIX
Change-Id: Ia2ad5b2883f5f417bdbdcc7b39055bd5454c10f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129174
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I78783056659a26cc8139d74eefc225de1a11ca7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129011
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Obsolete after eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45
Mysql/MariaDB: after creating a view then refresh, make it appear as a view
For this, I took example on hsqldb part this time (instead of Firebird which is uncomplete).
Also, deleting a brand new created table works now.
Of course, there are still pb with schema containing special characters like "`"
In fact, the description of the previous commit was wrong since renaming a view
still shows the table icon instead of view icon.
You must reopen the file so the icon is ok.
Change-Id: I2d27107db672e02af74e34a692309844ac310004
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129035
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
For this, I took example on hsqldb part this time (instead of Firebird which is uncomplete).
Also, deleting a brand new created table works now.
Of course, there are still pb with schema containing special characters like "`"
Change-Id: I4849f412ed5b3c2f35fbb4caaf06577828cc255a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128943
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
unescape scatalog before converting it in aCatalog
In Views, remove connectivity::mysqlc::Views::disposing which seems more cargo cult
Remove useless XConnection.hpp in tables (how come I didn't spot it in cleaning process?)
Change-Id: I28863dcd93baae923877dbd431b6807226c0a548
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128799
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Idd7d0ce4ffd18fec95102c41372c83fb7df11168
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128757
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ia9cd6dc9a6389ea1764a85c5f35a65f7d6ac40a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128755
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I10e3cc1fb2b66d7bebbaa33d7eb0b2099658e3af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128759
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I11e1284f9e7589cf4770d723e36c91a84b9b36b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128761
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I6fcb2f2c4346e6293a1e40e6f143ef6e8a68ee8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128760
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Iae0c8d4f12644bee15f78311b86d367f179a4fbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128754
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I6d29d594ed423efa25f063fd3107718b0f8b5b18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128758
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I893dc2d858a90b45b92b2866129527567bdb45e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128756
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
So it allows to make the variable types far more explicit.
It may help to differentiate the global mechanism from the specific mechanism
Change-Id: I655824b97dbef5eab610d3b1535307b108245f53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128699
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Strange bug the renamed view appears like a table but when closing and reopening the file,
the view is indeed there as a view (and not as a table) and renamed
Change-Id: I0f26fca66ffb0785ece6223df623845c5e015c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128707
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
In "Tables::appendObject":
- Simplify code by relying on :dbtools::createSqlCreateTableStatement
- Call "createObject" with "sComposedName" instead of awkward "sSchema + "." + rName"
and since "createObject" decomposes its parameter with ::dbtools::qualifiedNameComponents
we can also get rid of the ugly "CONCAT(TABLE_SCHEMA, '.', TABLE_NAME)" and just use "TABLE_NAME"
In ODatabaseMetaData::getTables, we must remove "`" since it seems incompatible with LIKE
(or missed how to make it compatible)
Also remove useless Keys::dropObject.
It seems we can rely on general mechanism since adding/removing primary key works
and so remove m_pTable which also become useless
bonus: avoid "using namespace dbtools" in mysqlc_views.cxx for 2 uses only
Change-Id: Ic24ec84c61dea7d419fc3a05ded6545bf20455bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128579
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I58cb94376e8cf7f06cd825ee7019fb5e9726fc9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128516
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
The hack worked by accident as long as the internal index
constants didn't change. Which was the case with
commit f7d0c6b42a0a5ec98876006cd5048589219be741
CommitDate: Thu Sep 23 20:28:42 2021 +0200
Sort ZF_STANDARD_NEWEXTENDED_DATE_... into ZF_STANDARD_DATE category
convertDateString()
Standard + 36 == old ZF_STANDARD_DATE + 6 => DATE_SYS_DDMMYYYY
unchanged
convertDateTimeString()
Standard + 51 == old ZF_STANDARD_DATETIME + 1 => DATETIME_SYS_DDMMYYYY_HHMMSS
became wrong nothing (no format assigned, empty DATE slot)
convertTimeString()
Standard + 41 == old ZF_STANDARD_TIME + 1 => TIME_HHMMSS
became wrong ZF_STANDARD_DATE_SYS_DMMMMYYYY (DATE_SYS_DMMMMYYYY)
So time 08:00 double 0.33333... was converted to string
"30 December 1899" which then numeric was 0.
Change-Id: I642e0a977d4e167f78537d20624e86721e518c54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128507
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Delete View works (and the list is updated)
Modifying View works
But, there are at least 2 things to fix:
- adding a view still works but the list isn't updated without manual refresh)
- renaming view doesn't work (a popup error message appear)
Change-Id: I48ffb322910ca64d51a161424f265de387bdd7ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128483
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
It's more to have something clean.
Indeed there wasn't impact on Firebird since the table name is surrounded by quotes,
eg: DROP TABLE"TableTest"
Change-Id: Iad525ccb912347798c6780fd1a5bac12ee85333f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128488
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
by just letting general mechanism deal with it
Change-Id: Iac70137c94419b719266f31222205d651d18b43b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128468
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ia17a396a8d55e38ac8ad42fab90c50bfaf96809e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128459
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8f2983c1d08026ad0cbe796f73e0ff44f917de17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128458
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I4b021847cfe855061b862006fbdc4ac36797ee09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128455
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I7df464107e692817ef80d887a4addea618d6cc72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128356
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I0af49eef735f5191f956f9ef9ae8e39c1eb7651a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128375
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
aTableNames is not changed till we hold a reference to that name.
Change-Id: I8a06b5bead101cba4e3293f6c29a849e7a9d0f6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128396
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
See tdf#42949 for motivation
Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
This allows to build a complete static LibreOffice on Linux,
except for linked externals. Since LO's static build implies
disabled dynamic loading, one must select one VCL backend to
be compiled in.
See the (large) comment in solenv/gbuild/static.mk trying to
explain, why this implementation was chosen (spoiler: seems
there is no other way) and what is actually implemented.
This will collect all libraries, statics and externals of
executables. If the executable uses components, it will get
linked to all static components. While it works with any
Executable, it just makes sense for soffice.bin, because the
static component map sucks every dependency in, bloating most
other binaries.
In theory on could generate the dependencies based on the list
of used components (see gb_CppunitTest_use_components), then
generate a specific static constructor map, directly include it
in the exe's cxx code and then link the minimal dependencies.
The static LO should build on Linux with:
--enable-customtarget-components
--disable-dynamic-loading
Tested VCL plugin config is:
--disable-gtk3
--disable-gen
--enable-qt5
The partial build support is split into a 2nd patch.
Change-Id: Iafc95752fae9e88095f54a21f1e30a4f080815e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126790
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Change-Id: I9447d7220faeb7a8147e649f0cca57ae15d3e9aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128301
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
+ sort objects in Library_mysqlc.mk
Change-Id: Ide8ea46424b034c109670ee5514b0afebfa376aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128176
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Flush() turns into a sync() on the device, which is pretty slow.
Most of the time all we actually want to do is to flush the internal
buffers from the SvStream.
So expose the FlushBuffer method and use that where possible.
And also means we don't need the mbDontFlushOnClose flag on SvStream
any more.
Change-Id: Ibe089b88b325f0fdc565200a97ce72cd26b7fcfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128214
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Let's do like MYSQL JDBC where no system schemas appear and let's remove:
- information_schema
- performance_schema
- mysql
Remove all the crufts about information_schema then.
Also, Mysql 5.1 has been released in 2008 and 5.0 beta was in 2005 (no production date indicated in Wikipedia for 5.0)
So we can consider there's no need in 2022 to test if Mysql > 49999
Change-Id: I49715bb5aa21681b687bab0e75603e4bd0c422de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128062
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=177292
Noticing:
warn:legacy.osl:7697:7697:connectivity/source/drivers/mysqlc/mysqlc_general.cxx:188: mysqlToOOOType: unhandled case, falling back to VARCHAR
I found REGEXP_REPLACE returned a MYSQL_TYPE_LONG_BLOB and some locations should be taught about it.
Also, let's also deal with MYSQL_TYPE_TINY_BLOB and MYSQL_TYPE_MEDIUM_BLOB
Change-Id: Ib7fd6ef747ce1b1851c788d2bb5a1d4ec673aee1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127919
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Tested-by: Jenkins
|
|
Thank you Krzysztof Hałasa for the patch!
Change-Id: Ib7532a716b7e0fa73f309e0a4f9af9e663e0d3df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127673
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Jenkins
|
|
See https://bugs.documentfoundation.org/show_bug.cgi?id=146471#c1
for full explanations
Change-Id: Ie75669cf951429654ff8e6c28508b9fee2ee03bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127715
Tested-by: Jenkins
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I6731ad4c49066b197ffc5b4e5d2c482bd7ca169e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127615
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Problematic SQL here:
SELECT * FROM "Table1" WHERE "Name" = :name OR :name IS NULL
Firebird considers there are 2 parameters.
When providing an empty string, no pb, OPreparedStatement::setNull is called which is ok for both parameters
When providing a non empty string, we go to OPreparedStatement::setString. For first param no pb
but for second param, sql type is SQL_NULL so it must be taken into account
See https://www.firebirdsql.org/file/documentation/html/en/refdocs/fblangref25/firebird-25-language-reference.html#fblangref25-datatypes-special-sqlnull
for full details
Change-Id: I80dff259d85957e8547c098e4c48b642cce26804
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127593
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Tested-by: Jenkins
|
|
Fix this assertion:
0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
1 0x00007fcc7f2b2536 in __GI_abort () at abort.c:79
2 0x00007fcc7f2b241f in __assert_fail_base
(fmt=0x7fcc7f418998 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fcc614a5de7 "false", file=0x7fcc614b3542 "/home/julien/lo/libreoffice/connectivity/source/drivers/firebird/Util.cxx", line=346, function=<optimized out>) at assert.c:92
3 0x00007fcc7f2c1212 in __GI___assert_fail
(assertion=0x7fcc614a5de7 "false", file=0x7fcc614b3542 "/home/julien/lo/libreoffice/connectivity/source/drivers/firebird/Util.cxx", line=346, function=0x7fcc614b3865 "void connectivity::firebird::mallocSQLVAR(XSQLDA *)") at assert.c:101
4 0x00007fcc6149c715 in connectivity::firebird::mallocSQLVAR(XSQLDA*) (pSqlda=0x5bca950) at connectivity/source/drivers/firebird/Util.cxx:346
5 0x00007fcc61470722 in connectivity::firebird::OPreparedStatement::ensurePrepared() (this=0x5bc6a10) at connectivity/source/drivers/firebird/PreparedStatement.cxx:110
6 0x00007fcc614714df in connectivity::firebird::OPreparedStatement::getMetaData() (this=0x5bc6a10) at connectivity/source/drivers/firebird/PreparedStatement.cxx:147
7 0x00007fcc6147165d in non-virtual thunk to connectivity::firebird::OPreparedStatement::getMetaData() () at connectivity/source/drivers/firebird/PreparedStatement.cxx:154
8 0x00007fcc66694776 in dbaccess::OPreparedStatement::getMetaData() (this=0x5bc6cc0) at dbaccess/source/core/api/preparedstatement.cxx:178
9 0x00007fcc6669480d in non-virtual thunk to dbaccess::OPreparedStatement::getMetaData() () at dbaccess/source/core/api/preparedstatement.cxx:179
10 0x00007fcc667711bd in dbaccess::OSingleSelectQueryComposer::getColumns() (this=0x5bb99f0) at dbaccess/source/core/api/SingleSelectQueryComposer.cxx:824
Change-Id: I285c9bcd0b1fd059994d339ae4d419dec516f220
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127551
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I1e71a35c2ce6bc7ef3081054e51494411d9a29ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127491
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Some unused functions and variables and many missing
HAVE_FEATURE_NSS warnings, because the native-code.py
stubs were missing the config_crypto.h header.
Change-Id: I88ff7d8f96e7382027a21f205db982fd797bd6af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127392
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|