summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2015-06-15fix buildNoel Grandin
after commit 8066c73940a30e97d8634655ea39d73fa8cf3c20 "cppcheck: noExplicitConstructor" Change-Id: I2caf2f5d0679e46cee5637d3090dd5a7bee5d25b
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I2b5fba9cdd950349a8e8d22bbd7bb6e17f008920
2015-06-15cppcheck:redundantConditionNoel Grandin
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-12so m_aEvaluateIter is unusedCaolán McNamara
Change-Id: Ie26303d737954f2d3af58e3cc6217aeadcb67cc0
2015-06-12so m_pEvaluationKeySet is always NULLCaolán McNamara
Change-Id: I79e92b63aa2efc9c3da595c8e857666a2d727900
2015-06-12m_pEvaluationKeySet is always NULLCaolán McNamara
Change-Id: Ibe24fc199753dd7a840d57532a20d901c216b910
2015-06-12and aEvaluateSetList is always emptyCaolán McNamara
Change-Id: Ia39db9248a05db525cba364445942ac438725d39
2015-06-12coverity#1306211 Logically dead codeCaolán McNamara
results from the chain of... commit 81b954718f0cdac6873927e869b3e41f863562e7 Author: Noel Grandin <noel@peralex.com> Date: Tue Jun 9 08:55:13 2015 +0200 loplugin:unnecessaryvirtuals Improve the plugin a little. Create a python script to process the output. Run it again. commit a7cfc17991ce528eb5ceb80cfab82bfe76a73609 Author: Caolán McNamara <caolanm@redhat.com> Date: Sat Apr 4 21:09:58 2015 +0100 and no user of OFILEOperandAttr left now either commit c614370677d4b0605c061d5380072c4bae50cb6a Author: Caolán McNamara <caolanm@redhat.com> Date: Sat Apr 4 21:08:41 2015 +0100 no user of OFILEAnalyzer anymore Change-Id: I9eb5b10d4c1f8b4d0876a0c172bbe01acaa0bb72
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11convert 'it.begin() == it.end()' to 'it.empty()'Noel Grandin
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145 Reviewed-on: https://gerrit.libreoffice.org/16212 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-09loplugin:unnecessaryvirtualsNoel Grandin
Improve the plugin a little. Create a python script to process the output. Run it again. Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
2015-06-08cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ie2ae923ad4c1a66e779711de6ff05328ef144dac
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I8c3f4d39629bbfee91402bddfe27b4d104c524c0
2015-06-08loplugin:staticmethodsStephan Bergmann
Change-Id: I22af41840410ee78aee739e0dec49bb43cda874b
2015-06-08Revert "loplugin:staticmethods"Jan Holesovsky
This reverts commit 81d82b78a107f2e6c14d6fbdf0d97c8e6cc8b0bd.
2015-06-08loplugin:staticmethodsStephan Bergmann
Change-Id: I22af41840410ee78aee739e0dec49bb43cda874b
2015-06-04Finalizers must not access UNO objectsStephan Bergmann
If the object being finalized (A) has the last reference to the UNO object (B), and B is actually a proxy for a remote UNO object, then A and B become eligible for finalization in parallel, and the finalizer of B may already have run when the finalizer for A runs. That means that B may already have been removed from the remote bridge, causing an "unknown OID" error from the remote end when the finalizer of A now tries to make a call on B. (We try to assert that close() has actually been called before finalize() calls delete(), but the corresponding exception may be silently swallowed by the JVM finalization machinery.) This caused spurious "URP: queryInterface request message with unknown OID received" failures during JunitTest_dbaccess_unoapi. Change-Id: Ia47c3ef2c22a6adc75b1b8271eb4b3140accebe7
2015-06-02loplugin:loopvartoosmallStephan Bergmann
Change-Id: I63917d68b05d6e2f1248bcf88e27952df201d2c5
2015-06-02Use range-based forStephan Bergmann
Change-Id: Ie10317f3ffcaa8032417584cb056007c5f67ea91
2015-06-02loplugin:loopvartoosmallStephan Bergmann
Change-Id: Id5501599969fab5c6944a31b1fb629a3fc5f85b2
2015-06-02hsqldb flush: protect against weak ref having expiredLionel Elie Mamane
Change-Id: I5967271c1c154ab4cf5555d30d3812183ea2a6b7
2015-06-02more debugging informationLionel Elie Mamane
Change-Id: I9bb95b80e0e85573a09b8ad7233c6543fccae032
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: I9852610322540a87305b775a1f4c90fb81f728e9
2015-06-01add libebook-1.2.so.16 in EApi.cxxRene Engelhard
Change-Id: I3f361a3d6d90b3449e0bf417fd39d756ad98cae6
2015-05-30HSQLDB connection flush: safer handling when createStatement or execute failsLionel Elie Mamane
Change-Id: I32f3014bbf32c4a4a990bea03ee565c9b4c0164d
2015-05-29loplugin:redundantcast: const_cast to same typeStephan Bergmann
Change-Id: Ic4e5afab0e948392a0f2e4bdeab84afffa3e647f
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29convert ODBC3SQL constants to scoped enumNoel Grandin
Change-Id: I61d2b76a32be23d238b1f50a6a76975d64d1878c
2015-05-29loplugin:unnecessarysuperclass, merge IWarningsContainer..Noel Grandin
..into WarningsContainer Change-Id: I682528a4eb1b1298faf12b2d498db65f94800cd5 Reviewed-on: https://gerrit.libreoffice.org/15905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-28Fix memory leakDavid Ostrovsky
The same was done in mork driver [1] and mork driver was derived from mozab driver. [1] 317306710d8f7c16bd6b9edc1e0af7e0e757cbac Change-Id: I64bc85819810707511a3cebd43802066cd94a727
2015-05-26add libebook-1.2.so.15 in EApi.cxxRene Engelhard
Change-Id: I7676f1f69bd563dede965a1a5fc6b1f714f11aab
2015-05-17Remove include stdio (part1)Julien Nabet
Change-Id: I364aedbd8870c2bbd3440f144143c503dd7ff2c1 Reviewed-on: https://gerrit.libreoffice.org/15767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-15tdf#62475: partial handmade fixesAndrea Gelmini
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann
Change-Id: I74bf1042cc5a2c4027023f1fa32248a50f5d2274
2015-05-11loplugin:staticmethodsStephan Bergmann
Change-Id: I1730694d8856ed009b8bf02a71657ca933bc6101
2015-05-10cppcheck: uselessAssignmentPtrArgCaolán McNamara
Change-Id: Ie7844af5ab7ead6383e60933588f66c5871f3282
2015-05-08...or rather, like thisStephan Bergmann
Change-Id: I87b547b76f6e214730757bec375b1d7b3d5d8f41
2015-05-08loplugin:implicitboolconversionStephan Bergmann
Change-Id: Iec38fdf8c165d1121e74f7221b49ca49f808ac03
2015-05-08jdbc character stream: don't mix up bytes and charactersLionel Elie Mamane
Change-Id: I59352edd887982faa792b02adbb55c3f67f1d78d
2015-05-08loplugin:staticmethodsStephan Bergmann
Change-Id: Ic93e560641f1ec1c5fc316ed126617c6d99ab5b5
2015-05-08callcatcher: update unused codeCaolán McNamara
Change-Id: I8563922204d3ec93bf138cbd1aaba620c0215bf7
2015-05-08I very much assume this wants to call java.io.Reader.readyStephan Bergmann
...seeing that there is no java.io.Reader.available. (And then, there's no good way to map from java.io.Reader.ready's boolean value to css.io.XInputStream.available's long value, so conservatively map true to 1.) But I have no idea how to trigger this code. Change-Id: I18d12e0d968141410a1b56e700ed544edceda97c
2015-05-08Fix Boolean value operationsStephan Bergmann
(css.sdbc.ColumnValue.NULLABLE happens to be 1, so the odd comparison is harmless and redundant.) Change-Id: I6b64cc083e72198c71e4e38ec4347f79af924621
2015-05-08jboolean-related clean-upStephan Bergmann
Change-Id: Iecd03d0343b9b7c3a8b23b5a1e9654148b94d44c
2015-05-04drop useless temp debugging stringsCaolán McNamara
Change-Id: I41c7053296c634c0fed5b31f2e080c3eaf59bbba
2015-04-29rhbz#1213173: connectivity: Calc driver: prevent document being disposedMichael Stahl
... by adding a XCloseListener that vetoes any attempt to close it. The Calc document can be opened by the user in the UI and closed again. Change-Id: Ied427b67274d925c911e516c0a50a4c0b2b18db9