summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31coverity#1158395 Uncaught exceptionCaolán McNamara
and coverity#1158394 Uncaught exception Change-Id: I73430678c658202475e0073c3c9bde0a072c1ee9
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#735298 Unchecked return valueCaolán McNamara
Change-Id: I66499283f4218662146c380f605bb20b8a2ff49a
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28Resolves: fdo#85081 terminate if can't load kde addressbookCaolán McNamara
Change-Id: I3b1b78127d7d4080a23c0ac9f7d37706197de62c
2014-10-28coverity#706303 Uncaught exceptionCaolán McNamara
Change-Id: If3963e0ae2c6477eb074e89f411c22a82d339634
2014-10-27coverity#706321 Uncaught exceptionCaolán McNamara
Change-Id: Ie3b66520ab0c859272a4b0291f6c907e7fce61e5
2014-10-27coverity#1249674 Missing break in switchCaolán McNamara
Change-Id: I1e957afe1dc35571128fac4432b54e8ae35aa9ab
2014-10-27cid#1249675 Uncaught exceptionNoel Grandin
Change-Id: I3923a6a83bfc0a35f5a5af86cfd0e5308cfda24c
2014-10-25coverity#706329 Uncaught exceptionCaolán McNamara
Change-Id: Ia056948df45ade616dd4c434a4c9d319d48d97f2
2014-10-25coverity#706328 Uncaught exceptionCaolán McNamara
Change-Id: I9182ad75a5b49d5aa9d58cecc690b06220f13272
2014-10-25coverity#706322 Uncaught exceptionCaolán McNamara
Change-Id: I4ebfee76cb17562a47d4c2e868539fc70ead530e
2014-10-25coverity#706319 Uncaught exceptionCaolán McNamara
Change-Id: I7f390151c232d0a96d50b16c0c76aacea569653e
2014-10-25coverity#706317 Uncaught exceptionCaolán McNamara
Change-Id: I8b39addd8d4b9f7d68d0f7a317d1dff7388aba93
2014-10-25coverity#1202804 Explicit null dereferencedCaolán McNamara
Change-Id: Iff1ada702f57fba9ba979bc158412b0321921672
2014-10-25java: prevent overflow by using 'long int' arithmetic in multiplicationRobert Antoni Buj i Gelonch
Change-Id: I8dda8f4621f265208c713c9edcfe725f1c9c5998 Reviewed-on: https://gerrit.libreoffice.org/12001 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-24coverity#736109 Nesting level does not match indentationCaolán McNamara
Change-Id: I0f1beadc90eae9750b53062df2512f7c886fd267
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-21connectivity: firebird: fix temp directory leakMichael Stahl
Dispose the dbaccess document, and recursively delete the temp directory in Connection::dispose(). Change-Id: Id283289e44b8ca09b88da19920da7f27b551aa7e
2014-10-21connectivity: firebird: use Reference for Connection where appropriateMichael Stahl
ODatabaseMetaData and OResultSetMetaData apparently have life-times independent of their creating object, so they need to own the Connection too. Change-Id: Idee28a96e318ca4b3d804084d609737a7fc75862
2014-10-21connectivity: firebird: fix Connection leak in OStatementCommonBaseMichael Stahl
bin/refcount_leak.py was very helpful here. Change-Id: I61dc57408cf1533f733c08b701884851ec6afb8d
2014-10-17cid#1247650 Uninitialized scalar fieldNoel Grandin
Change-Id: I74e1a02602fd5d86790e3c0e71d6a8649fa0aa05
2014-10-17java: final fields that can be staticNoel Grandin
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16java: close ResultSet after useNoel Grandin
Change-Id: I5b2903cf2928e19be203d80243c2ac2e75be28cb
2014-10-16remove unnecessary catch blockNoel Grandin
Change-Id: Id33384cee3444924e7e8de7d496f117f120b1876
2014-10-15coverity#706322 Uncaught exceptionCaolán McNamara
and coverity#706330 Uncaught exception Change-Id: I105e37c88654cf47b50fe6b260b8994622305dab
2014-10-15coverity#706318 Uncaught exceptionCaolán McNamara
and coverity#706317 Uncaught exception Change-Id: Idd01f4ba68b1ce6590d6c7b79bcff9593f0766ea
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-14coverity#706320 Uncaught exceptionCaolán McNamara
Change-Id: I980e55ab3942c93447573c0af7b7486dfc0a0e10
2014-10-14coverity#706319 Uncaught exceptionCaolán McNamara
Change-Id: I582bc15b8065c9262c0933f1afa0bda6e1f5d94e
2014-10-14coverity#706332 Uncaught exceptionCaolán McNamara
Change-Id: I847cea7329a0c9cf370406afe8a7511f58c89901
2014-10-14coverity#706327 Uncaught exceptionCaolán McNamara
Change-Id: I3a84a212abfcf0668b7040c8fa537ad62aaf5224
2014-10-14coverity#706326 Uncaught exceptionCaolán McNamara
Change-Id: I922ce18051eefb4507cc84870ce18ae0a49f4608
2014-10-14connectivity: the value of Math.asin(0.0) is zeroRobert Antoni Buj i Gelonch
Change-Id: Ic72750fcea93edf3457ccea4a357e9d2929a646c Reviewed-on: https://gerrit.libreoffice.org/11941 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-13coverity#1158396 Uncaught exceptionCaolán McNamara
Change-Id: I0306b8431641d841027b30dfe1c03ecad5df6867
2014-10-12coverity#706331 Uncaught exceptionCaolán McNamara
Change-Id: I48e11a07924418721d45fcac55bd5aeb68f115a3
2014-10-11coverity#735605 Division or modulo by zeroCaolán McNamara
Change-Id: Ic3680ae833ed325ff4afe96fdca02f784ccd7d71
2014-10-11connectivity: Iterate over each Entry in a Map & Enhanced for-loopsRobert Antoni Buj i Gelonch
Change-Id: Id4a340584fc727058f6e37c1f0d3c5887e931417 Reviewed-on: https://gerrit.libreoffice.org/11917 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11connectivity: firebird: recursively delete temp directoriesMichael Stahl
TempFile itself will only remove empty directories. Change-Id: Ibaf986856bde172de40686ae363821b19add8106
2014-10-10coverity#706302 Uncaught exceptionCaolán McNamara
Change-Id: I082b7682124053948733efc2dbe5df6196acaa5f
2014-10-10add copy constructor for ONDXPagePtr classNoel Grandin
which I forgot in commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb "remove SvRefBase::QueryDelete" Change-Id: Ib52b9cb58451abd62f75d7376b069bf6aef550b2
2014-10-09fdo#84073: change ODBC/JDBC escapes to lowercaseJulien Nabet
Change-Id: I19ce3acb9575fbef8273bbd84cb4dc322e101ac8
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09remove SvRefBase::QueryDeleteNoel Grandin
Move it's functionality into the only place that needs it, in the dbase driver. Removes an extra virtual call from a widely used class. The dbase driver seems to be using to perform some kind of whacky object recycling, so it's not like we want this functionality to be used somewhere else. Change-Id: I41018f71e0b0a79fdd3d527536f0ac95c788e614 Reviewed-on: https://gerrit.libreoffice.org/11786 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-07connectivity: try to fix build after f641fd15Michael Stahl
Change-Id: I6a8534044eb0c245ef8aa80c52cd1a37ba8fa5a5
2014-10-06Revert "ADO driver: don't override a virtual method just to call the one of ↵Lionel Elie Mamane
the parent" This reverts commit 220deb0a0ed7b3efa14088acdab0520709309105.
2014-10-06Revert "ADO: don't override a virtual method to call the one of the parent"Lionel Elie Mamane
This reverts commit fa8f2fdf45c168a25dd955ebd24780b4863d6cde. Change-Id: I252e29648fb59a15379ba2f3b63d6914a7fc3a93
2014-10-06ADO: don't override a virtual method just to call the one of the parentLionel Elie Mamane
Change-Id: Ibae309ffbb7b2500c9113a95ca3fc508de378976