summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: connectivityStephan Bergmann
Change-Id: I959a520f240faab062ecd4f6e2658d9fc9ce709f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97545 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: connectivityStephan Bergmann
Change-Id: I50676f940abb36091e175d7469806e8ccc6ba7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97195 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-24use more std::container::insert instead of std::copyNoel Grandin
which is both more compact code, and more efficient, since the insert method can do smarter resizing Change-Id: I17f226660f87cdf002edccc29b4af8fd59a25f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-22Consolidate unique_ptr deleters calling freeStephan Bergmann
Change-Id: I57a977dbb521270a466d464df8c31c364179ec20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96854 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-17connectivity: fix mysql testMichael Stahl
* rename the gbuild target according to conventions * fix -Werror=unused-but-set-variable * disable assert in testMultipleResultsets() that fails presumably since commit 86c86719782243275b65f1f7f2cfdcc0e56c8cd4 * document how to set up mariadb for dummies like me in README Change-Id: I7f92b80fef90b47e69e4e9a7a02187882a4cab06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96537 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-05Use o3tl::safeCoInitializeEx/safeCoUninitializeReinit (ado)Julien Nabet
Change-Id: I8eaa5c0f91a5e78888f6a2edea13fa5d2227fb9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95598 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-06-05tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctornienzu
Change-Id: Ic61c1d5829b510a71b8d444f29ffed36ee540ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94717 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-03Improve COM library management in ADOJulien Nabet
Change-Id: I99a1c61068fec743847181b43f3d9278c85e95e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95174 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-03Upcoming loplugin:elidestringvar: connectivityStephan Bergmann
Change-Id: I406486e13b822c34cd2329cc3828dd0567be30e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95385 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-28Make loplugin:simplifypointertobool handle parenthesized expressionsStephan Bergmann
...as discussed as an open TODO in the commit message of fe6cce01c88d045a1fcf09acf049c34c22299b02 "Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptr". The necessary changes across the code base have been done fully automatically with the rewriting plugin on Linux. (All those changes apparently involve uses of macro arguments wrapped in parentheses in the macro body, but always in conditionally-converted-to-bool contexts. In other contexts, such automatic rewriting would add the "bool" to the macro body, which would be wrong in general, but we apparently get away with that sloppy coding for now.) The parenExprs_ stack that fe6cce01c88d045a1fcf09acf049c34c22299b02 had introduced to treat such (then-undetected, it had turned out) parenthesized cases now turns out to not be needed after all. Change-Id: I2021f61c2e2805be7e18b38edf8744d186cac3cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95010 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-27Remove some unused includesMiklos Vajna
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-24inline some use-once typedefsNoel Grandin
Change-Id: Idddba2f3fd05265b08dbc88edb6152d34a166052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-22Prefer CoInitializeEx instead of CoInitializeJulien Nabet
As https://docs.microsoft.com/fr-fr/windows/win32/api/objbase/nf-objbase-coinitialize?redirectedfrom=MSDN advised. Moreover, it'll make concurrency model explicit Change-Id: I247a49248bf45beb64a7985a7c0d078ee48efe2d Change-Id: I6e755fd516d9fb2dd2a9df0c66d9afd6070447ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94669 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-18use for-range on Sequence in cli_ure..connectivityNoel Grandin
Change-Id: Ic5254e402d153a13c29928b59738cbe1603d0139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-15mysqlc: fix default transaction levelJulien Nabet
According to https://dev.mysql.com/doc/refman/8.0/en/innodb-transaction-isolation-levels.html it's REPEATABLE READ Change-Id: I7e9b0209528158908d8529f11e09554e372401a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93898 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-05-14unixODBC changed soname to .2 so reflect it (connectivity)Julien Nabet
Synchronize with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3f5584526fd4e8290dac033e1cf3d64acd25d893 author Tomáš Chvátal <tchvatal@suse.com> 2017-01-05 16:06:10 +0100 committer Lionel Elie Mamane <lionel@mamane.lu> 2017-01-13 10:17:13 +0000 commit 3f5584526fd4e8290dac033e1cf3d64acd25d893 (patch) tree 055eaf148ed60da5182e6033d7a74a387765f886 parent afe64b6f0ab839955690f07929268a3d389279bf (diff) unixODBC changed soname to .2 so reflect it we dlopen this library and thus we should be able to find it with any soname, so far .1 and .2 seem to be used. Also now the load order on linux is: .so.2 -> .so.1 -> .so Change-Id: I1b7a54992ee9a654d77d0ef443087178c99cffe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94199 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-05-13Removed duplicated includeAndrea Gelmini
Change-Id: I4919b787160dad755f13658f26cbe1fd3fd0fad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94138 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-13use std::optional for this error fieldNoel Grandin
otherwise when I add source/line to the uno::Exception in an upcoming change, the message becomes non-empty, and hasErrors() return true. I note that we throw SQLException in lots of places without a message, so it is possible that this change will cause us to notice errors we previously missed. Change-Id: Idf7c5b5143e20c992d8d7550043aa2ed875c78b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-11tdf#126468: MySQL/MariaDB and Firebird don't require order field in select partJulien Nabet
Change-Id: I75f050dd6f38fefe83d24a4886610d421f72826e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93937 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-10tdf#132814: fix put autovalue to Yes in gui for Mysql/MariaDBJulien Nabet
See part of bt: https://bugs.documentfoundation.org/show_bug.cgi?id=132814#c3 Like this since at least: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8 author Tamas Bunth <tamas.bunth@collabora.co.uk> 2018-10-08 11:04:48 +0200 committer Tamás Bunth <btomi96@gmail.com> 2018-10-14 22:16:05 +0200 commit b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8 (patch) tree f1ab6e9fec3c66f0a3285b3ffffcbae38dc7185d parent ba6723431afa843232fadf44e12ddab44e85c9f0 (diff) Revert removal of mysql jdbc connector And also make some minor fixes so it cooperates with the new mysqlc library. Change-Id: Id328c8378be1555fb5934c738def7fcd62f7a14b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93915 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-10mysql-sdbc: better separate what resultset provides what interfaceLionel Elie Mamane
PreparedStatement should not provide XStatement (!!) since MySQL does not support multiple results for prepared statements, PreparedStatement should not expose a XMultipleResults interface Move those out of the common base to Statement itself. Change-Id: Ice7478089441e1def6fd65ff117eb31d04ec46ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93864 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-10mysql-sdbc: do not lie about supporting XPreparedBatchExecutionLionel Elie Mamane
Change-Id: I85220307566f04640965f048ee0b5c5c4e552bdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93863 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-10tdf#112423: mysql-sdbc: implement XMultipleResultsLionel Elie Mamane
Thanks to Julien Nabet for the pointers to MySQL's multiple results API documentation: https://dev.mysql.com/doc/refman/8.0/en/c-api-multiple-queries.html Change-Id: Ia6e7f52752ad895210cc415f71bb48d678f3f0ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93686 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09Typo: aSerachMapping->aSearchMapping (connectivity/ado)Julien Nabet
Change-Id: I3415c8cecb1cae709de714c99303bd21b495cba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93870 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-09mysql-sdbc: statement::execute do not handle parametersLionel Elie Mamane
this is not a PreparedStatement, it is not allowed to have parameters Change-Id: I15cd493b89824e4e68eff5a59ac255bf05db0190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93853 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09mysql-sdbc: statement: do not pointlessly keep pointer to resultLionel Elie Mamane
in m_pMysqlResult since it is never actually used after being assigned, except in the code block that assigned it. Change-Id: Ic4341321b18b2c92eb93e59dd3b9e3035c69f293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93852 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09mysql-sdbc: statement: rename disposeResultset to closeResultsetLionel Elie Mamane
it does not actually dispose teh ResulteSet, it only lets go of the reference. Change it to actually close the ResultSet. Change-Id: Iee51738274468f5c00e026304915ba44139a9fab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93851 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09mysql-sdbc: resultset: do not keep m_pResult after freeing itLionel Elie Mamane
and replace m_bResultFetched by (m_pResult == nullptr) Change-Id: I81dc9f1be9a72813a8a31c214ea6f8c43a1e37d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93850 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09mysql-sdbc: do not lie about supporting XBatchExecutionLionel Elie Mamane
Change-Id: I414c5b43fe942203207b57bd23bfae79f1c3cbf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93849 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09mysql-sdbc: fill SQLSTATE field of SQLException when throwing itLionel Elie Mamane
Change-Id: I0970fcfeb0ca92e6401b6f71ca4f54202fc27598 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93848 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09Avoid ODBC warning when testing connectionJulien Nabet
When clicking test connection for ODBC, there's this warning on console warn:legacy.osl:11208:1336:connectivity/source/drivers/odbc/OConnection.cxx:68: Failure from SQLDisconnect Some debug by adding a call to OTools::ThrowException indicates that SQLGetDiagRec returns 08003 08003 Connection not open (DM) The connection specified in the argument ConnectionHandle was not open. (see https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/sqldisconnect-function?view=sql-server-ver15) It's due to the fact that "N3SQLDisconnect( m_aConnectionHandle )" has already been called during void OConnection::disposing() Avoid the warning by testing m_bClosed Change-Id: Ie992da3582ab4d61cde35ada3f10f6a3d51d8be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08compact namespace in canvas..cuiNoel Grandin
Change-Id: I7bd0c2a55b936896fcfe7e1a374871008a18618f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08tdf#122461 SQL identifiers (names) can contain newlinesLionel Elie Mamane
Change-Id: Ic58e6b65e146b2e0d9cb656aa5fa06cfe955d11d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93690 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-05tdf#122408 make StatementComposer apply HAVING clauseLionel Elie Mamane
Change-Id: I381c918e8cac2800367bc586f8c230d46bcd71e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93448 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-04-28Fix typosAndrea Gelmini
Change-Id: I50a80014addf5fb6a3974139249f45f6a2e67d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92939 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-26update pchesCaolán McNamara
Change-Id: I83a61da7dda6c72552eecd377f1c3744c92a797e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26tdf#132385: sql parser: don't drop clauses from window specificationJulien Nabet
bison rule window_specification: '(' window_specification_details ')' { $$ = SQL_NEW_RULE; $$->append(newNode("(", SQLNodeType::Punctuation)); $$->append($2); $$->append(newNode(")", SQLNodeType::Punctuation)); } ; makes it look like rule "window_specification_details" is a single node, but in reality it is a sequence of four nodes: window_specification_details: opt_existing_window_name opt_window_partition_clause opt_order_by_clause opt_window_frame_clause ; The result is that only the "opt_existing_window_name" clause was being put in the parse tree, and the other three were simply discarded. Since that will forever be a trap, and this is the only place where window_specification_details is used, we inline it into window_specification and remove it. Change-Id: I568904355174d2bc36155bde1d4dd09f57759cd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92894 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-04-25Typo: *Comparsion* -> *Comparison* in dbaccess/connectivityJulien Nabet
Change-Id: I9dfe37b290dbb83b1dfb2f92669ae254898ee72e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-22uiobject.hxx only needs forward declaresCaolán McNamara
and update pches accordingly Change-Id: I411712532fd85961bffe6678416fcdc1d9c7f53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-18loplugin:flatten connectivityNoel Grandin
Change-Id: Ic1d9eb84b64ebde99e15704a10b27f21447df4d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-14loplugin:buriedassign in c*Noel Grandin
Change-Id: Id14fed7e5c0f588ad3c927f12251432d12c1a7c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-30tdf#131712: fix crash on table with non null float field (mysql native)Julien Nabet
See bt with infinite loop here: http://bugs.documentfoundation.org/attachment.cgi?id=159161 Change-Id: Iaa4e998c640c414dec60a72d5977f8d6a6a8433f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91379 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-03-20MSVC hack to avoid multiply defined symbolsStephan Bergmann
...as reported (at least with clang-cl and --disable-pch) now, apparently after e5230535877e30c3b874495e8794faa3a42d8017 "simplify ORefVector code": > [build LNK] Library/filelo.dll > idbtools.lib(dbtoolslo.dll) : error LNK2005: "public: long const & __cdecl std::vector<long,class std::allocator<long> >::operator[](unsigned __int64)const " (??A?$vector@JV?$allocator@J@std@@@std@@QEBAAEBJ_K@Z) already defined in fanalyzer.o > idbtools.lib(dbtoolslo.dll) : error LNK2005: "public: unsigned __int64 __cdecl std::vector<long,class std::allocator<long> >::size(void)const " (?size@?$vector@JV?$allocator@J@std@@@std@@QEBA_KXZ) already defined in fanalyzer.o > Creating library C:/lo-clang/core/workdir/LinkTarget/Library/ifile.lib and object C:/lo-clang/core/workdir/LinkTarget/Library/ifile.exp > C:\lo-clang\core\instdir\program\filelo.dll : fatal error LNK1169: one or more multiply defined symbols found (The fix strategy is the same as in e.g. 177f5c2e505b7978fc232a891577a448e49b290d "Proper fix for multiply defined SfxEnumItem<sal_uInt16> with MSVC".) Change-Id: Ie30fb21471e5cbe492486e3f0b76d50f67686253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90803 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-18avoid clang's unreachable code warningLuboš Luňák
Change-Id: I1a3aa4f560fbc2d41872a634a599226c592ddc18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90715 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-18simplify ORefVector codeNoel Grandin
by making it extend std::vector - it wants to be a ref-counted vector, so let it be, and we can simplify the usage sites Change-Id: I93ff6ee1522da965e16223dca171401d36fd67b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90664 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-15Firebird: TODO already fixed (SYSTEM TABLES filtered)Julien Nabet
TODO added with: commit ec365165ba7f332df479422174899808e1ff4152 Author: Andrzej J.R. Hunt <andrzej@ahunt.org> Date: Mon Aug 12 17:15:46 2013 +0100 Implement refreshTables. (firebird-sdbc) then fixed with: commit c73286f83c64b5216ee430c72a412a2903eee16b Author: Andrzej J.R. Hunt <andrzej@ahunt.org> Date: Wed Aug 14 09:30:52 2013 +0100 Use table type in getTables. (firebird-sdbc) + commit 0506b35c50eddb010097b1359295da2ba6fd3ee1 Author: Andrzej J.R. Hunt <andrzej@ahunt.org> Date: Wed Aug 14 08:49:54 2013 +0100 Avoid selecting system tables for viewing. (firebird-sdbc) Change-Id: I1882f92a63d23a7cfad4a0e1930b57eec0365e9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90540 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-15Firebird: IndexType is OTHER not CLUSTEREDJulien Nabet
Wikipedia indicates: 'Firebird makes all indices of the database behave like well-tuned "clustered indexes" used by other architectures.' but it's not "CLUSTERED", neither "STATISTIC" nor "HASHED" (the other specific types from offapi/com/sun/star/sdbc/IndexType.idl) According to https://www.ibphoenix.com/resources/documents/design/doc_18, it seems another type => OTHER Change-Id: I3eefe9bd025e1cfeaefb75091f7ed03e8642dfea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90537 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-14Firebird: fix TODO use xClob instead of xBlob for REMARKSJulien Nabet
TODO added with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e6ae90b0723ed0cbf8c9c7dab65d235d0b78431a author Andrzej J.R. Hunt <andrzej@ahunt.org> 2013-08-10 12:58:32 +0100 committer Andrzej J.R. Hunt <andrzej@ahunt.org> 2013-08-11 16:05:11 +0100 commit e6ae90b0723ed0cbf8c9c7dab65d235d0b78431a (patch) tree b61ed29963dea3d6fd1c276ab6cc05a143e2058b parent d12ddee812480595745b656113475468bddc4b1a (diff) Reduce verbosity of getTables. (firebird-sdbc) Change-Id: I14c46ab9d36bf40791004941684308011af81b61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90494 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-01-26 07:38:32 +0000