summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:oncevar in cui..connectivityNoel Grandin
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17 Reviewed-on: https://gerrit.libreoffice.org/30653 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02KAB loplugin:unnecessaryoverrideJan-Marek Glogowski
Change-Id: I62e6f2488554df663e0ae6c72b6af9e2ec9976a1
2016-10-28loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I70ba8d3b03c56a597785f109f0cb687bd936bc64
2016-10-28coverity#1371275 Missing move assignment operatorCaolán McNamara
Change-Id: I6c47c797d2654506bdc95c35b2558ce812f4070d
2016-10-27Remove bogus comments about ~IPropertyArrayHelper not being virtualStephan Bergmann
...which isn't true at least ever since b525a3115f54576017a576ff842dede5e2e3545d "initial import", but got copy/pasted all over the place Change-Id: I47d3d8a594aef3ac3736d7176ae964a118821014
2016-10-26coverity#1374287 Uncaught exceptionCaolán McNamara
Change-Id: Ieed911b33fe4a5358855b3960b9d4c77c66ceff9
2016-10-26coverity#1374285 Uncaught exceptionCaolán McNamara
Change-Id: I0a3790607fe7db6a8b8093a67e4dbf3548c800bb
2016-10-26coverity#1374283 Uncaught exceptionCaolán McNamara
Change-Id: I658a12da4d30f360f207ca06dcf3650ba18cc7a2
2016-10-26tdf#103373 create and connect with default userWastack
For an embedded Firebird database resolve authentification with a default username and password (hardcoded) instead of trusted authentification. Change-Id: I54ee04898a8b2bedc9a24001c64173400769f416 Reviewed-on: https://gerrit.libreoffice.org/30160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-10-23loplugin:expandablemethodds in include/connectivity..drawinglayerNoel Grandin
Change-Id: Ic58f86422ef8f1e2bb655157850e214fc3a1a9b4 Reviewed-on: https://gerrit.libreoffice.org/30136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-17loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Id90a0a3334f4551b926a240b2e06a34337188c07
2016-10-16clang-cl loplugin: connectivityStephan Bergmann
Change-Id: I025cf2ad63f08bb58d54983982d7a116fac0ffea Reviewed-on: https://gerrit.libreoffice.org/29874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctornadith
Change-Id: I4abcff5e1bf050bd4e4cf0695f196c418d8229ef Reviewed-on: https://gerrit.libreoffice.org/29778 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctornadith
Change-Id: Ibfb981a58e61c72f3a292dd8e72895b98502d640 Reviewed-on: https://gerrit.libreoffice.org/29787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorAsela Dasanayaka
Fix a bug on connectivity/source/drivers/ado/AResultSet.cxx Change-Id: I164732100ff3bdc4e73f80e2495610cb53581b0d Reviewed-on: https://gerrit.libreoffice.org/29758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12ADO: return correct css::sdbcx::CompareBookmark valuesStephan Bergmann
css.sdbcx.XRowLocate's compareBookmarks is documented to return values from the css.sdbcx.ConpareBookmark constants group, which has LESS = -1, EQUAL = 0, GREATER = 1, NOT_EQUAL = 2, NOT_COMPARABLE = 3. So in case of equality return EQUAL (0) instead of sal_True (1). And, in the MS SDK's adoint.h, the CompareEnum enum os defined with enumeators adCompareLessThan = 0, adCompareEqual = 1, adCompareGreaterThan = 2, adCompareNotEqual = 3, adCOmpareNotComparable = 4, so mapping from the latter to the former needs to do -1, not +1. Change-Id: I6643da31f326e38153e4ebab9e680b33a6854918 Reviewed-on: https://gerrit.libreoffice.org/29735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-12loplugin:unnecessaryoverride in connectivity/cuiNoel Grandin
Change-Id: I5ec4eb2f74036e42851333e3d669dbea58c2490a Reviewed-on: https://gerrit.libreoffice.org/29687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11Replace OLEVariant operators with proper functions, for clarityStephan Bergmann
* Rename the original getDate (returning double) to getDateAsDouble, to make room for the new getDate (returning css::uno::Date). * Assume the difference between the original 'operator String' (first checking for VT_BSTR, then for isNull()) and getString (first checking for isNull(), only then calling 'operator String') was accidental rather than by design. Change-Id: I6261bdad5c328d6b10e83f2d1664a6c78ec1fed4 Reviewed-on: https://gerrit.libreoffice.org/29705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-11Replace OLEString operators with proper functions, for clarityStephan Bergmann
Change-Id: I1fa309d034e1ec94f38d07ede07e691f1484a4f5 Reviewed-on: https://gerrit.libreoffice.org/29697 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I8374d6d08f4eb4ae2821e213371c615b92d7e9ab Reviewed-on: https://gerrit.libreoffice.org/29432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23TDE fix some clang plugin based warningsJan-Marek Glogowski
Change-Id: I3b44038e8a889e4c13126fd8d721e53e71ea9ec6
2016-09-22loplugin:unusedmethods unused returnsNoel Grandin
Change-Id: I4da3374e31d3c7407b401d66275da7f56ae83d30 Reviewed-on: https://gerrit.libreoffice.org/29178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Remove NumberFormatCodeWrapperMaarten Bosmans
This class only adds a level of indirection, without any useful functionality. Change-Id: I806e1b9241caf025c62c12c93aad3101daac874a Reviewed-on: https://gerrit.libreoffice.org/29134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20Remove obsolete workaround for SUNPRO 5 compilerStephan Bergmann
...copy/pasted into three more places Change-Id: I6661244d0248af509cd867fc3e8c451551068a78
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15convert LogLevel constants to scoped enumJochen Nitschke
rename some variables to distinguish them from type name use enumarray for log level strings remove unused DATA member Change-Id: Id3c38b82e679b3aede5ce790735443e769d5f236 Reviewed-on: https://gerrit.libreoffice.org/28920 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15connectivity: firebird: loplugin:nullptrMichael Stahl
Change-Id: Ia711be1238de87ac5b52b02de077b70220369e4b
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-14loplugin:overrideStephan Bergmann
Change-Id: I0cd2007c9169fe480e28e684cfe1bd8b24da7123
2016-09-14loplugin:constantparam in chart2..connectivityNoel Grandin
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-01coverity#1372406 Uncaught exceptionCaolán McNamara
Change-Id: I24fe9cb3aa9002d4b94b6f934e39aff243c1e09d
2016-09-01coverity#1372402 Uncaught exceptionCaolán McNamara
Change-Id: I63743ccdeca1be66da5622bd286f08daebdd74ff
2016-09-01coverity#1372398 Uncaught exceptionCaolán McNamara
Change-Id: Icf6c0f8071a3ea2de81073dfcabc64fae6aeee9c
2016-09-01coverity#1372392 Uncaught exceptionCaolán McNamara
Change-Id: Ic8bb4748b0752796fcb76c1816441bb22b896809
2016-09-01coverity#1372390 Uncaught exceptionCaolán McNamara
Change-Id: I4bb01b0bb9865986d9da8ed294a46fa7a4488458
2016-09-01coverity#1372389 Uncaught exceptionCaolán McNamara
Change-Id: Ic788073adcaefb3de2bff7e249f17a64fad48b19
2016-09-01coverity#1372388 Uncaught exceptionCaolán McNamara
Change-Id: I55c4e2ad1f3384c4e8b0a6cc88b83fa96cf2dede
2016-09-01coverity#1372387 Uncaught exceptionCaolán McNamara
Change-Id: I563e7987d00a68373c05dc4f1f3d62cd3e52de70
2016-09-01coverity#1372383 Uncaught exceptionCaolán McNamara
Change-Id: Idfdd846d8439be91b059d53dab6591d202576fae
2016-08-30declare default dtor as virtualCaolán McNamara
Change-Id: Ic77dbe3ffb2d2856d437158914b877b913296e0e
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (connectivity)Stephan Bergmann
Change-Id: I1c9e33d3f4306199320e60cf0eb2970e687576ef
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-28Resolves: tdf#81883 dispose OCalcConnection's doc before shutdownCaolán McNamara
if noone else does it, then ensure the doc is disposed before XDesktop it torn down Change-Id: I3136802a40c9cfb43039307dc65949d3264b6f2b Reviewed-on: https://gerrit.libreoffice.org/28428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25DocHolder->DocHolderCaolán McNamara
Change-Id: I8eddff0791a7887e1aee0515e73d40c54b97a0ae
generated by cgit (git 2.34.1) at 2025-01-10 13:20:59 +0000