summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2016-11-16new loplugin finalprotectedNoel Grandin
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15fix build of kde3 addressbookCaolán McNamara
Change-Id: I109f6ff9ca35792d3337bac2a6612ba12d2272fd
2016-11-15fix buildNoel Grandin
after commit 0d051730156f633150fa9e3107fe97cf7be6d8f9 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Nov 15 09:13:33 2016 +0200 loplugin:constantparam Change-Id: Ia3e761168043e5a8d22793689e9f224a85a6b7ca
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14Make ~OCode an anchor again for vtable and RTTI emissionStephan Bergmann
...had been lost with dd5fa4cea7b0c6912754e6887a678a050d4a7610 "declare default dtor as virtual" Change-Id: I30acd02c293a5ecc99f5bf4f6b1f6358ae392e93
2016-11-14coverity#1371279 Missing move assignment operatorCaolán McNamara
Change-Id: Ic1c1017184bff54360b0ea3b6f57e53d61cbe1d5
2016-11-12coverity#1394295 Unchecked return valueCaolán McNamara
Change-Id: Ie4edbe91ab4f9b9910fc895e47ea8b9fdfc00b7e
2016-11-12coverity#1371239 Missing move assignment operatorCaolán McNamara
but if _MSC_VER need >= 2015 Change-Id: I730319702ddc589c4fc1d72b20fd200eacfa53e4 Reviewed-on: https://gerrit.libreoffice.org/30785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-12Related tdf#70433: Use subtype to distinguish BLOB/CLOB for FirebirdJulien Nabet
See http://www.firebirdfaq.org/faq48/ Change-Id: If233919daeb02b67d0b3bc42547fbd3030864c37 Reviewed-on: https://gerrit.libreoffice.org/30789 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-11tdf#71251: VARCHAR max length is 32765 for FirebirdJulien Nabet
At least for Firebird 2.5 (see http://www.firebirdsql.org/en/firebird-technical-specifications/) Let's put the same for CHAR Change-Id: I4ab232689093b0418a7c1a9751685f41f2dabbf7 Reviewed-on: https://gerrit.libreoffice.org/30783 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-11Revert "coverity#1371239 Missing move assignment operator"Caolán McNamara
This reverts commit 8909cbeb315e257fbe06dad6caee5db18879b916.
2016-11-11coverity#1371239 Missing move assignment operatorCaolán McNamara
Change-Id: Ie5cddac8b4b0c8eefee82a14c845982600df0455
2016-11-10loplugin:staticmethodsStephan Bergmann
Change-Id: Id7d7bb572466bcc803ac424cd8ddb64205a1c273
2016-11-10loplugin:stringconstantStephan Bergmann
Change-Id: I0eb2b9986840b1bd5bc892da23c56205047bc120
2016-11-10loplugin:cstylecastStephan Bergmann
Change-Id: I6ec274c6c546f60c23fe639002d751f0a9f11d33
2016-11-10WiP tdf#74172 use DECIMAL and NUMERIC data typesWastack
Change-Id: I917cdf6e8d3ebfa7c9e4a52ca61adc5b8707ecfc Reviewed-on: https://gerrit.libreoffice.org/30447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-10loplugin:expandablemethods in comphelper..cppuhelperNoel Grandin
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d Reviewed-on: https://gerrit.libreoffice.org/30717 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:oncevar in cui..connectivityNoel Grandin
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17 Reviewed-on: https://gerrit.libreoffice.org/30653 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02KAB loplugin:unnecessaryoverrideJan-Marek Glogowski
Change-Id: I62e6f2488554df663e0ae6c72b6af9e2ec9976a1
2016-10-28loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I70ba8d3b03c56a597785f109f0cb687bd936bc64
2016-10-28coverity#1371275 Missing move assignment operatorCaolán McNamara
Change-Id: I6c47c797d2654506bdc95c35b2558ce812f4070d
2016-10-27Remove bogus comments about ~IPropertyArrayHelper not being virtualStephan Bergmann
...which isn't true at least ever since b525a3115f54576017a576ff842dede5e2e3545d "initial import", but got copy/pasted all over the place Change-Id: I47d3d8a594aef3ac3736d7176ae964a118821014
2016-10-26coverity#1374287 Uncaught exceptionCaolán McNamara
Change-Id: Ieed911b33fe4a5358855b3960b9d4c77c66ceff9
2016-10-26coverity#1374285 Uncaught exceptionCaolán McNamara
Change-Id: I0a3790607fe7db6a8b8093a67e4dbf3548c800bb
2016-10-26coverity#1374283 Uncaught exceptionCaolán McNamara
Change-Id: I658a12da4d30f360f207ca06dcf3650ba18cc7a2
2016-10-26tdf#103373 create and connect with default userWastack
For an embedded Firebird database resolve authentification with a default username and password (hardcoded) instead of trusted authentification. Change-Id: I54ee04898a8b2bedc9a24001c64173400769f416 Reviewed-on: https://gerrit.libreoffice.org/30160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-10-23loplugin:expandablemethodds in include/connectivity..drawinglayerNoel Grandin
Change-Id: Ic58f86422ef8f1e2bb655157850e214fc3a1a9b4 Reviewed-on: https://gerrit.libreoffice.org/30136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-17loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Id90a0a3334f4551b926a240b2e06a34337188c07
2016-10-16clang-cl loplugin: connectivityStephan Bergmann
Change-Id: I025cf2ad63f08bb58d54983982d7a116fac0ffea Reviewed-on: https://gerrit.libreoffice.org/29874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctornadith
Change-Id: I4abcff5e1bf050bd4e4cf0695f196c418d8229ef Reviewed-on: https://gerrit.libreoffice.org/29778 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctornadith
Change-Id: Ibfb981a58e61c72f3a292dd8e72895b98502d640 Reviewed-on: https://gerrit.libreoffice.org/29787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorAsela Dasanayaka
Fix a bug on connectivity/source/drivers/ado/AResultSet.cxx Change-Id: I164732100ff3bdc4e73f80e2495610cb53581b0d Reviewed-on: https://gerrit.libreoffice.org/29758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12ADO: return correct css::sdbcx::CompareBookmark valuesStephan Bergmann
css.sdbcx.XRowLocate's compareBookmarks is documented to return values from the css.sdbcx.ConpareBookmark constants group, which has LESS = -1, EQUAL = 0, GREATER = 1, NOT_EQUAL = 2, NOT_COMPARABLE = 3. So in case of equality return EQUAL (0) instead of sal_True (1). And, in the MS SDK's adoint.h, the CompareEnum enum os defined with enumeators adCompareLessThan = 0, adCompareEqual = 1, adCompareGreaterThan = 2, adCompareNotEqual = 3, adCOmpareNotComparable = 4, so mapping from the latter to the former needs to do -1, not +1. Change-Id: I6643da31f326e38153e4ebab9e680b33a6854918 Reviewed-on: https://gerrit.libreoffice.org/29735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-12loplugin:unnecessaryoverride in connectivity/cuiNoel Grandin
Change-Id: I5ec4eb2f74036e42851333e3d669dbea58c2490a Reviewed-on: https://gerrit.libreoffice.org/29687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11Replace OLEVariant operators with proper functions, for clarityStephan Bergmann
* Rename the original getDate (returning double) to getDateAsDouble, to make room for the new getDate (returning css::uno::Date). * Assume the difference between the original 'operator String' (first checking for VT_BSTR, then for isNull()) and getString (first checking for isNull(), only then calling 'operator String') was accidental rather than by design. Change-Id: I6261bdad5c328d6b10e83f2d1664a6c78ec1fed4 Reviewed-on: https://gerrit.libreoffice.org/29705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-11Replace OLEString operators with proper functions, for clarityStephan Bergmann
Change-Id: I1fa309d034e1ec94f38d07ede07e691f1484a4f5 Reviewed-on: https://gerrit.libreoffice.org/29697 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I8374d6d08f4eb4ae2821e213371c615b92d7e9ab Reviewed-on: https://gerrit.libreoffice.org/29432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23TDE fix some clang plugin based warningsJan-Marek Glogowski
Change-Id: I3b44038e8a889e4c13126fd8d721e53e71ea9ec6
2016-09-22loplugin:unusedmethods unused returnsNoel Grandin
Change-Id: I4da3374e31d3c7407b401d66275da7f56ae83d30 Reviewed-on: https://gerrit.libreoffice.org/29178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Remove NumberFormatCodeWrapperMaarten Bosmans
This class only adds a level of indirection, without any useful functionality. Change-Id: I806e1b9241caf025c62c12c93aad3101daac874a Reviewed-on: https://gerrit.libreoffice.org/29134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20Remove obsolete workaround for SUNPRO 5 compilerStephan Bergmann
...copy/pasted into three more places Change-Id: I6661244d0248af509cd867fc3e8c451551068a78
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15convert LogLevel constants to scoped enumJochen Nitschke
rename some variables to distinguish them from type name use enumarray for log level strings remove unused DATA member Change-Id: Id3c38b82e679b3aede5ce790735443e769d5f236 Reviewed-on: https://gerrit.libreoffice.org/28920 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15connectivity: firebird: loplugin:nullptrMichael Stahl
Change-Id: Ia711be1238de87ac5b52b02de077b70220369e4b
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-14loplugin:overrideStephan Bergmann
Change-Id: I0cd2007c9169fe480e28e684cfe1bd8b24da7123
generated by cgit (git 2.34.1) at 2025-01-02 20:12:00 +0000