summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2019-06-11Fix typoAndrea Gelmini
Change-Id: I2ad6228e21dd51be90a289cc438cf640d453d8d7 Reviewed-on: https://gerrit.libreoffice.org/73788 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-10Use hasElements to check Sequence emptiness in chart2..connectivityArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: I41824e8a4ef38d6a35a0ac4421cffcbcd17308e1 Reviewed-on: https://gerrit.libreoffice.org/71802 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-03mysqlc: Add support for mysql type INT24Tamas Bunth
Which is mapped to sal_Int32. Change-Id: Ibf12e92a20034440fa990ed0c6f1196f4ca3f40f Reviewed-on: https://gerrit.libreoffice.org/73217 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-06-01tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: Iccc7e079d9f8778060bbebba3f8e9204fc351d8e Reviewed-on: https://gerrit.libreoffice.org/73289 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-31connectivity: fix memory leaks caused by OConnection::acquire()Michael Stahl
Followup to 58f121ef2e680697e10453add43bab9b771d153a; OConnection must not be held by rtl::Reference as that creates a cycle. (regression from 497e40ad03c27837978551ba15491c3fb2a0bf53) Change-Id: Ibd56d335e3e2631c5a57ea435f1035e89868a5a6 Reviewed-on: https://gerrit.libreoffice.org/73155 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-29tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: Ib5459a365231514efa0e8a33a880857378cd239e Reviewed-on: https://gerrit.libreoffice.org/73121 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22New loplugin:dataStephan Bergmann
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22tdf#122538: add index appendix for hsqldbJulien Nabet
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=3208fcb3a36d75d6290d9c548430682f153b09db Change-Id: I8f85f0a5838df87671ecb9bdb5751b7ec43c09ea Reviewed-on: https://gerrit.libreoffice.org/72701 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-05-14tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: Icf6a0b81aca489b25520c9f6837d1b482179cad5 Reviewed-on: https://gerrit.libreoffice.org/72155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-12regenerate PCH headersLuboš Luňák
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09Clean up makefile (remove some cargo-cult copied stuff)Jens Carl
Change-Id: Iafbb69a405a3c9ee8d0ae7dbe8a24a75d237519d Reviewed-on: https://gerrit.libreoffice.org/71924 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-07tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN and add some unit tests to ensure the implementation works and the replacements don't introduce some side effects. Change-Id: I4ed50eee53e4dba4d392ed2486186d48f919ce1d Reviewed-on: https://gerrit.libreoffice.org/71712 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-01Fix typoAndrea Gelmini
Change-Id: I20e6de52e8244ef118973671cd25fb9fc6f3e22f Reviewed-on: https://gerrit.libreoffice.org/71632 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-30implement std::hash for css::uno::Reference and rtl::ReferenceNoel Grandin
The declaration in BarChart.cxx is particularly suspicious, because it was using a < for the KeyEqual template parameter. Been there since: commit b2c3233e5f267b5d244d722a94424a3b224b3314 Date: Thu Dec 21 20:08:33 2017 +0900 chart2: suspend/resume setting rects dirty for 3D shapes comphelper::OInterfaceCompare is no longer necessary Change-Id: I8278c4a3d9113a18570ca237cd05d553ec8f3975 Reviewed-on: https://gerrit.libreoffice.org/71537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-30Fix typoAndrea Gelmini
Change-Id: Ie0193edb4e729c4469c15bc5940dbc8005caf28b Reviewed-on: https://gerrit.libreoffice.org/71561 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-30Fix typoAndrea Gelmini
Change-Id: I0af0c7c750018a9766dc0b3af4a6c114a7b27144 Reviewed-on: https://gerrit.libreoffice.org/71560 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-29Fix typoAndrea Gelmini
Change-Id: I881b23341ee1fc8d1ff3443e8ab52f51e07c3646 Reviewed-on: https://gerrit.libreoffice.org/71499 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-25Resolves: rhbz#1702810 Prepare for upcoming libebook soname version bumpMilan Crha
as noted here: https://mail.gnome.org/archives/desktop-devel-list/2019-April/msg00016.html wrt: https://gitlab.gnome.org/GNOME/evolution-data-server/issues/33 Change-Id: I88f900b3adf12de545b1d2d16da67eae22fde748 Reviewed-on: https://gerrit.libreoffice.org/71281 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-25Cut down on -pthread/-lpthread proliferationStephan Bergmann
Building against libstdc++ effectively always requires -pthread anyway (as various standard C++ headers require it, see the comment added to solenv/gbuild/platform/unxgcc.mk), so many explicit uses of -pthread/-lpthread can be removed. Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests that libc++ indeed doesn't need -pthread as libstdc++ does. The remaining uses of -pthread/-lpthread are mostly in configure.ac for the various BSDs (which somebody else might want to clean up now), and related to external projects. I tried to be careful to remove -pthread/-lpthread from makefiles only when C++ object files are involved (so -pthread will now be included on the link command line by default). Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1 Reviewed-on: https://gerrit.libreoffice.org/71291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-25mysqlc: Allow conversions between different typesTamas Bunth
Change-Id: I54c1f438a755267db0896637c79f915de9113f83 Reviewed-on: https://gerrit.libreoffice.org/71074 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-24Avoid calling java.lang.Class.newInstance()Stephan Bergmann
For one, it is deprecated since Java 9, and for another it causes a NullPointerException when called from the JNI Invocation API (i.e., without a Java caller frame) at least with some Java 12. (Found when doing a test build with Java 12 and JAVA_SOURCE/TARGET_VER explicitly configured as 7 with d365f36331874f94bbd9832fbd19ace90fafefec "Allow to pass JAVA_SOURCE/TARGET_VER into configure".) I have entered information about the NullPointerException at <https://bugreport.java.com/bugreport/start_form.do>, but haven't heard back yet, so duplicate that information here: Issue Type: > Bug Component: > Core Libraries Operating System: > Linux 64-bit Java Release: > 12 Synopsis: > Calling java.lang.Class.newInstance from JNI Invocation API causes NullPointerEx Description: > I can reproduce this with the OpenJDK 12 RPMs on Fedora 30, but from looking at <https://hg.openjdk.java.net/jdk/jdk12/file/06222165c35f/src/java.base/share/classes/java/lang/Class.java> it looks plausible that it is a common issue that Reflection.getCallerClass() returns null when java.lang.Class.newInstance is called from the JNI Invocation API, and that null is propagated to jdk.internal.reflect.Reflection.verifyMemberAccess as parameter currentClass, which dereferences it at <https://hg.openjdk.java.net/jdk/jdk12/file/06222165c35f/src/java.base/share/classes/jdk/internal/reflect/Reflection.java#l130>. > This is known to have been working with older OpenJDK (at least 1.8). Steps to Reproduce: > Compile the provided test.cc with `g++ -I/usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc30.x86_64/include -I/usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc30.x86_64/include/linux /usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc30.x86_64/lib/server/libjvm.so test.cc` and run it with `LD_LIBRARY_PATH=/usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc30.x86_64/lib/server ./a.out`. Expected Result: > exit 0 Actual Result: > Exception in thread "main" java.lang.NullPointerException > at java.base/jdk.internal.reflect.Reflection.verifyMemberAccess(Reflection.java:130) > at java.base/java.lang.reflect.AccessibleObject.slowVerifyAccess(AccessibleObject.java:673) > at java.base/java.lang.reflect.AccessibleObject.verifyAccess(AccessibleObject.java:666) > at java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:638) > at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:490) > at java.base/java.lang.reflect.ReflectAccess.newInstance(ReflectAccess.java:166) > at java.base/jdk.internal.reflect.ReflectionFactory.newInstance(ReflectionFactory.java:404) > at java.base/java.lang.Class.newInstance(Class.java:590) > Aborted Source code for an executable test case: > #include <cstdlib> > > #include "jni.h" > > void handleError(JNIEnv * env) { > if (env->ExceptionCheck()) { > env->ExceptionDescribe(); > std::abort(); > } > } > > int main() { > JavaVM * vm; > JNIEnv * env; > JavaVMInitArgs args{JNI_VERSION_1_2, 0, nullptr, true}; > if (JNI_CreateJavaVM(&vm, reinterpret_cast<void **>(&env), &args) != JNI_OK) { > std::abort(); > } > auto const c1 = env->FindClass("java/lang/Class"); > handleError(env); > auto const id = env->GetMethodID(c1, "newInstance", "()Ljava/lang/Object;"); > handleError(env); > auto const c2 = env->FindClass("java/lang/Object"); > handleError(env); > env->CallObjectMethod(c2, id); > handleError(env); > } Workaround: > Call via JNI the suggested replacement of clazz.getDeclaredConstructor().newInstance() instead of the deprecated java.lang.Class.newInstance(). Change-Id: I85ff7102a18b98561f188e609873753546bc050d Reviewed-on: https://gerrit.libreoffice.org/71240 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-24Fix typosAndrea Gelmini
Change-Id: I9cc5e13681b047fe772704b42796e210ad070601 Reviewed-on: https://gerrit.libreoffice.org/71148 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-22Fix typoAndrea Gelmini
Change-Id: I8080b857566a4f066a388114b36458d575d43f1a Reviewed-on: https://gerrit.libreoffice.org/71057 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-21Fix typoAndrea Gelmini
Change-Id: If8b06f8879712ade0bfaaf807c37222bb06bd279 Reviewed-on: https://gerrit.libreoffice.org/71025 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-21Fix typoAndrea Gelmini
Change-Id: I17877a9b45ad288b715cc2bf8def06532e679e4f Reviewed-on: https://gerrit.libreoffice.org/71026 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-20Fix typoAndrea Gelmini
Change-Id: Id8422102f776f438e00b40a2ee0ae0b96e4f552a Reviewed-on: https://gerrit.libreoffice.org/70997 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20Fix typoAndrea Gelmini
Change-Id: I6a22d7b302bd8ef8e06d93f73a13929625a444f7 Reviewed-on: https://gerrit.libreoffice.org/70996 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini
Change-Id: I30282339753722d242684b35407577352bbbf771 Reviewed-on: https://gerrit.libreoffice.org/70967 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini
Change-Id: Ica38eedeb2733095a1e6d987ad57064cb9be99bd Reviewed-on: https://gerrit.libreoffice.org/70973 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini
Change-Id: I84ef63b6c82175132b376122253d3b262a065944 Reviewed-on: https://gerrit.libreoffice.org/70976 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Fix typoAndrea Gelmini
Change-Id: I1021d7cfc2b27924e3a30d0f0d6a936e2bec99f9 Reviewed-on: https://gerrit.libreoffice.org/70907 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Fix typoAndrea Gelmini
Change-Id: Ief0343a128ae45ee62f7965a6ea77b2dcbd0ae49 Reviewed-on: https://gerrit.libreoffice.org/70911 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-17Restrict lambda capture listStephan Bergmann
Change-Id: I72ac69f9cbea34f69d828f55468fb630ca8290fe Reviewed-on: https://gerrit.libreoffice.org/70885 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-17Fix use of variable before its lifetime beginsStephan Bergmann
This has been broken with 48314f25241e014a634dd5371543b90137ffd2bc "improve function-local statics in basic..cui" (and has been found with a new plugin to be commited). Change-Id: I518360e3273af9db4a8560a89bc8a789410c8033 Reviewed-on: https://gerrit.libreoffice.org/70875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-17Fix typoAndrea Gelmini
Change-Id: Ic29460926173ed37c60d8626872dda15cc1f76ec Reviewed-on: https://gerrit.libreoffice.org/70851 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-17Fix typoAndrea Gelmini
Change-Id: I678ddb576f6cfeadf2418781675023def545c2c8 Reviewed-on: https://gerrit.libreoffice.org/70850 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-17Fix typoAndrea Gelmini
Change-Id: I6307b00dfc1dad4cc0b22bfd6d142d54a1c96c92 Reviewed-on: https://gerrit.libreoffice.org/70852 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-15improve loplugin simplifyconstructNoel Grandin
to find stuff like OUString s = OUString("xxx") Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04 Reviewed-on: https://gerrit.libreoffice.org/70697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-14Fix typoAndrea Gelmini
Change-Id: Idaf6df71470d2a838ac793bb992f979a51b1c581 Reviewed-on: https://gerrit.libreoffice.org/70739 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-13loplugin:sequentialassign in codemaker..connectivityNoel Grandin
Change-Id: I9776431ebce95a88ae42715aaba2ddc28fb52471 Reviewed-on: https://gerrit.libreoffice.org/70642 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-11Fix typosAndrea Gelmini
Change-Id: I1c3fccac03b5cc8acdd1d25dc5536f5874ff26ad Reviewed-on: https://gerrit.libreoffice.org/70575 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-10clang-tidy: Silence warnings from WIP unhandled-self-assignment checkTamás Zolnai
Where it can be done by removing useless / duplicate code. For XFListStyle I removed the copy operator entirely, because it was bugous and it seems not to be used anyway. Change-Id: Iba0eb0d5c45b42f0e78be466c617acdc1216eb22 Reviewed-on: https://gerrit.libreoffice.org/70482 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-09Removed executable permission on sourceAndrea Gelmini
Change-Id: I2e41d3d80a4c3c75b923a90507b7b9b1ed3669c3 Reviewed-on: https://gerrit.libreoffice.org/70438 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-08tdf#112689: replace OUStringBuffer with OUString in one fileJason Burns
Change-Id: I7fc32ad2bcbff4cd8bedea9bed49a0f4748ebe0f Reviewed-on: https://gerrit.libreoffice.org/70392 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-06Fix typoAndrea Gelmini
Change-Id: I2d5b20bdc5c87edce37930b5acced910fe1aec70 Reviewed-on: https://gerrit.libreoffice.org/70332 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-29Fix typoAndrea Gelmini
Change-Id: I334a253dcbf6aef8b182e249605b625b89347450 Reviewed-on: https://gerrit.libreoffice.org/69908 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-27Remove unused using declarations in directories [a-d]*Gabor Kelemen
Found with: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: I50f6dfa881ac4e752668e762ade0943aaf28ab96 Reviewed-on: https://gerrit.libreoffice.org/69601 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-16 06:25:01 +0000