summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)Author
2013-03-25Remove a couple of unused private fieldsTor Lillqvist
Change-Id: Ia28d6befe63453ced7c623e76abc7a0ec7d6cbeb
2013-03-25Fix warning: unused variable 'aMutex' [loplugin]Tor Lillqvist
Change-Id: I1dc2d18f285bbd7fc4316a7a194a21769b11d545
2013-03-25Fix warning: unused variable 'sColumnName' [loplugin]Tor Lillqvist
Change-Id: I3b4267f9782bc7bc71247523c8fd5940bc8cef38
2013-03-25Introduce HAVE_GCC_PRAGMA_DIAGNOSTIC_{MODIFY,SCOPE}Stephan Bergmann
...replacing hard-coded GCC version checks. Those checks that guard #pragma GCC diagnostic ignored "-Wnon-virtual-dtor" appear relevant only for GCC itself, not Clang (which used to fail the old guards because it typically announces itself with a rather low __GNUC__/__GNUC_MINOR__ version), see 6e67c03dc0225fc66343546b14e902b9d238b1a3 "Enable -Wnon-virtual-dtor for GCC 4.6" Change-Id: I6bfa4d5caa6192e7a203ce829682bf6bb8d61a1b
2013-03-23coverity#704216 Logically dead codeJulien Nabet
Change-Id: I83af7c87576c185b4884a2a6ceaea5274efa7c37
2013-03-22String::AppendAscii cleanupRicardo Montania
Change-Id: I3c1ff291488b7747e143982aa7ea95169175c2c2 Reviewed-on: https://gerrit.libreoffice.org/2914 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-21Fix single core builds when TDE integration is enabledTimothy Pearson
Change-Id: I3a28d843e567db2a905125424615cba0bd28c7b4 Reviewed-on: https://gerrit.libreoffice.org/2882 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-20no need for include guard valueThomas Arnhold
Change-Id: Ib12b2c975d90cf842381916f3eb98dad3b4b3b4d
2013-03-20Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)Stephan Bergmann
...which is a confusing overload with unexpectedly different semantics from the one-parameter form. In preparation of marking it as deprecated. Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
2013-03-20use #if instead of #ifdef for testing config_xxx.hxx macrosLuboš Luňák
http://lists.freedesktop.org/archives/libreoffice/2013-March/047769.html Change-Id: I81ed4500878ff3193e028410a1f0205e28d17fc3
2013-03-20simplify OUString assignmentsChr. Rossmanith
Change-Id: Ieffd80aa84c9a041785bb81b3a904a32d00cb2bb Reviewed-on: https://gerrit.libreoffice.org/2863 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-20fdo#46808, Convert a bunch of comphelper::ComponentContext stuffNoel Grandin
.. to Reference<XComponentContext> mostly in the dbaccess module, but it also affected some other modules. Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-19coverity#704590 Explicit null dereferencedJulien Nabet
Change-Id: I787a39959a1558fe4f284bc1941194a841e2d600 Reviewed-on: https://gerrit.libreoffice.org/2860 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-03-19removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarationsThomas Arnhold
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b Reviewed-on: https://gerrit.libreoffice.org/2835 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19Simplify equalsIgnoreAsciiCaseAscii[L] callsStephan Bergmann
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold
Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19Fix single core build when TDE integration is enabledTimothy Pearson
Change-Id: I15d537a8ea7d3a42c9a1924dd81e83ba9b4aa421 Reviewed-on: https://gerrit.libreoffice.org/2830 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-18avoid Wundef in cases where the usage seems otherwise okLuboš Luňák
Change-Id: Iabccc31c59cec32235661f5225f45bb13f76a68f
2013-03-18coverity#705135 Missing break in switchJulien Nabet
Change-Id: Ie610b3b10b5d83b772ad96e455d59360368086a4 Reviewed-on: https://gerrit.libreoffice.org/2779 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-18fix makeAny callsChristian Lohmaier
checks failed on Mac/PPC - setValue expects sal_Bool, not plain bool for bool there's assignment operator. Similar for unsigned short - there's dedicated operator to assign sal_uInt16 - no need to cast to signed sal_Int23 that then fails to convert properly. Change-Id: I6c67a3741cf2d7910fc543c9c71db1c6e816bea6 Reviewed-on: https://gerrit.libreoffice.org/2805 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-15Revert "cleanup sqlflex and sqlbison options"Kohei Yoshida
This reverts commit b659d7c33fcacdbbef86557e78f071abf94bead2. That commit appears to have broken the build on Linux. Reverting it fixes it. Change-Id: I70d62c04e9fb284ed2c360c0976d0cbeafc2ddc2
2013-03-15cleanup sqlflex and sqlbison optionsPeter Foley
Change-Id: I3f01636ef861828fdbe87e4057b6dc293ca63576
2013-03-14remove legacy build.pl prj/build.lst files.Michael Meeks
2013-03-12update pch headersLuboš Luňák
Change-Id: Ibb368e6a806666a73bf6bf1a097d14bc6e75b24d
2013-03-12janitorial: readabilityLionel Elie Mamane
Change-Id: Iaab09826d79b0fbcd3104d33d1f159767a09921a
2013-03-11fix my previous commit (compareToAscii)Thomas Arnhold
Change-Id: I06885691c1fb3cfa0824f2ac1307ae4d9f3c9d40
2013-03-11use startsWith() instead of compareToAscii()Thomas Arnhold
brain damage... Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-11fdo#61726: rename report-builder package to org.libreoffice.reportDavid Ostrovsky
To prevent future clashes with uno name space rename the com.sun.star.report package to org.libreoffice.report. Bump the version to 1.2.4. Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f Reviewed-on: https://gerrit.libreoffice.org/2578 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-08fdo#60691 add modelines to *.src and *.hrc filesBorim
use solenv/bin/add-modulelines script for the task and remove all UTF bom from *.src and *.hrc files svx/source/dialog/hdft.src Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08evoab2: Follow API changes in EDS 3.8Mathias Hasselmann
EDS 3.8 deprecates e_book_client_new() and replaces it with various e_book_client_connect() functions. This patch follows the change and enables direct read access for the addressbook. That means instead of receiving contacts via the D-Bus session bus, the connectivity driver now directly accesses the underlaying SQLite data base (for reading). This patch also shuffles code in EApiInit() slightly to avoid excessive if/else nesting. Change-Id: If41fb92eed2ea26bbf2d3125a9ba2250f142c5a2
2013-03-08evoab2: Move get_e_source_registry() to EApi.cxxMathias Hasselmann
get_e_source_registry() was declared in EApi.hxx, but defined in NDatabaseMetaData.cxx. This doesn't seem right, the header file and the purpose of the function indicate that it belongs into EApi.cxx. Change-Id: Iea3f11a901398aa3f467b96fbe8778c403887bcb
2013-03-08evoab2: Avoid G_N_ELEMENTS when loading symbolsMathias Hasselmann
With G_N_ELEMENTS() the array name has to be twice, which can cause hard to spot typos in code derived from copy-and-paste, as we have here in the module loader. C++ can avoid the duplication by using the proper templates. Change-Id: I485e28a92e74b7e24f4a59cced6e5635f3a53a38
2013-03-08make use of startsWith()Thomas Arnhold
Change-Id: Ie70097de550ddd1cddc6714f8f86f9723cb36679 Reviewed-on: https://gerrit.libreoffice.org/2599 Tested-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-06fdo#60148 Clean up warnings from the Clang compiler pluginnccuong
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671 loplugin: clean warnings: unused variables, incorrect indentation and log area. Reviewed-on: https://gerrit.libreoffice.org/2544 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-03-05doubled usingThomas Arnhold
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-04make lto workPeter Foley
Change-Id: Iab6892368c6ba6bb5b83132cdcd6aa959c3b0e1f
2013-03-04sal_Bool to boolTakeshi Abe
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04doubled namespacesThomas Arnhold
Change-Id: I0f6a34a459c1492a69afa3ef6bcbaa8ed7639a22
2013-03-04doubled namespaceThomas Arnhold
Change-Id: I756f4a98b1eedcbe7674e9afd9b06816141688b9
2013-03-04remove unused and commented out codeThomas Arnhold
This code gets never called. Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-04coverity: merge traverse{OR,AND}Criteria into traverseSearchConditionLionel Elie Mamane
Meaning, these two functions have the same behaviour, they produce the same output (and side-effects) when called on the same input. traverseORCriteria handles only the actual "foo OR bar" case, and hands off all other cases to traverseANDCriteria. But, lo and behold, traverseANDCriteria also handles the "foo OR bar" case, in the same manner! Change-Id: I10410e88ce48852b60d1d688fe2865923de9d80b
2013-03-03Related to fdo#60724: correct spellingThomas Arnhold
Using the autocorrect list of LibreOffice extras/source/autotext/lang/en-US/acor/DocumentList.xml Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657 Script: http://pastebin.ca/2327716
2013-03-03loplugin: improve indentationThomas Arnhold
Change-Id: If0ddaa8fd7cfaf4df8589422cb50ce37f1be2ad1
2013-03-03fdo#60724: fix paramater -> parameter misspelling found by lintianVojta Koukal
Change-Id: I6c09767211817533494df34744a265cf28a76105
2013-03-03loplugin: unused variables and commented codeThomas Arnhold
Change-Id: I01f1f1d112767b576d7cfc6e25fe95385de2c0cf
2013-03-03coverity#736112: make clear that this is not part of the ifMarkus Mohrhard
Change-Id: I442d7e363f7594d1fae5e2afdde71ff6670b1962
2013-03-03coverity#736111: make clear that this is not part of the ifMarkus Mohrhard
Change-Id: Iab61e80a7fa8f01d826ac90e184d09d0e2358b40
2013-03-03coverity#736110: make clear that this is not part of the ifMarkus Mohrhard
Change-Id: I709672e9e2789213c85878d2bd0194ad5bc34060