Age | Commit message (Collapse) | Author |
|
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
|
|
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
|
|
Change-Id: I961e6a9e227962096b57569a8b8160841cacd950
|
|
rSt >> pPtr[3] >> pPtr[2] >> pPtr[1] >> pPtr[0] results in error:
no match for 'operator>>' in 'rSt >> *(pPtr + 3u)'
Change-Id: I1820bac8c72f7633ab01a17bf5d073b988e1b58c
Reviewed-on: https://gerrit.libreoffice.org/8207
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I2e472aa0279d0763762d3c660207cd74da512626
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
|
|
Change-Id: Id7c6db5c6cbefef427d9c2cc4bd210811b5a7991
|
|
in favour of ReadXXX methods.
Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3
Reviewed-on: https://gerrit.libreoffice.org/7915
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
as preparation for converting the SvStream::operator>> methods on
primitive types
Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I4520eea08e43ccd657c1db03b258ef84612da971
Reviewed-on: https://gerrit.libreoffice.org/7726
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: Id4dfa3d4676b50a86fd6044d501de15b122bb7f1
|
|
Change-Id: Ibe8600f8ad38859cd79d52528f970d99f0b8f536
|
|
Change-Id: Ie2de4680e07e26416fc52d4c22b5bececb190cc1
|
|
we can use -1 as the failure return code as return value is always checked and
isolated from the rest of the code.
Change-Id: I87a743de82d681a7e4eabc61a576c4e50f1279a8
|
|
Change-Id: I5b369703333332598353d9817f0253bbe5fc3601
|
|
Otherwise (i.e. with non-vertical lines) the width will be incorrect,
and can result in lines disappearing as the resulting X component
can be tiny/approaching zero.
Change-Id: Icf3b7c10c627594600b517b8ff445f8df87c56f8
|
|
Change-Id: Iff1ae9806ee05654762b313ed00ada206e51337f
|
|
Change-Id: I5babcec50d48dc2a6288a01685db61fbb7058680
|
|
a new log section (sal.rtl.xub) is used to display alert in case of
suspicious len == 0xFFFF (aka STRING_LEN)
Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e
Reviewed-on: https://gerrit.libreoffice.org/7117
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
|
|
Change-Id: I7b53a8f18e1fb24b1ae0322bdf0980e431a0725f
|
|
Change-Id: I903d8e5629c578f292307bf3abdb2f58ef9dd92c
|
|
Change-Id: I4f861c7653c89d8f1ca73696e885f33f7bfc3b06
|
|
It seems I missed a few places in
21ec9beae29b19b8ec6f0a16fd0e708e4f210208, getting that straight
now hopefully.
Change-Id: I34fc8df2d1ee65bef0639b3de9487ff311bed89a
|
|
This reverts commit 639aa8e72639fd01e9004977f1cfaafc13b1e45f.
Change-Id: I0ac1a7ada530791e2d34d2f0802213c869ea48a1
|
|
Basically reverts the pieces of
21ec9beae29b19b8ec6f0a16fd0e708e4f210208 to make XSpriteCanvas a
XBitmapCanvas again
Otherwise PresenterHelper::loadBitmap is not an XBitmapCanvas
and so VclFactory::createBitmap cannot succeed
Change-Id: I197adf98e915102f383ee050a8ea16d1e41cecf2
|
|
Change-Id: I6043ee3c214f453afaef06125993c73be624c07e
|
|
Change-Id: Ic000edc60a9c5ae7d64fab9bf8b6c2a88bcec223
|
|
Change-Id: I25fa3ea9e0101de7b17c17ef44da6d7b26a46017
|
|
This finally makes the rendering of the custom line caps nice & complete.
Change-Id: If35ef1c44f34f5d5e6c50789c907105d03e96fca
|
|
Change-Id: Ic5e2e2d105fb006503b63e4e162d4dc09dab9e68
|
|
Change-Id: I3a5f79e22500f53c3c61c173e0827c250b2a8fd0
|
|
Change-Id: I584f8a1680c6aa7b51b948a00213c285387b77c3
|
|
Change-Id: I9eb21c0a8b5baa5b0080845f61b12fc65034d959
|
|
Change-Id: I7221311e5dee6384dc2d1c071bf6f1c61811895a
|
|
Convert code like:
aStr.equalsIgnoreAsciiCaseL(RTL_CONSTASCII_STRINGPARAM("XGRAD_SEQ_BEGIN"))
to:
aStr.equalsIgnoreAsciiCase("XGRAD_SEQ_BEGIN")
which compiles down to the same code.
Change-Id: Ia69289d853d292b2f27b68863cb6f6ecdbf1a71e
|
|
Convert code like this:
if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
if (aStr == "rem")
which compiles down to the same code.
Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
|
|
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.
I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
|
|
Convert code like:
if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
if (aByteStr.startsWith("rem"))
Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
|
|
Change-Id: I92c83ead449452679e539fad2316d391a1b59a62
|
|
Change code like this:
aStr = OUString("xxxx");
into this:
aStr = "xxxx";
Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
Change-Id: I4c688a4aeedcae56ed6404574bd1bb392d4190cb
Reviewed-on: https://gerrit.libreoffice.org/6311
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
|
|
Remove the implication that XCanvas IS-A XBitmapCanvas, i.e. one can
access underlying pixels. That's a preparation for display-list based
canvas implementations, and was a rather silly assumption in the first
place.
Also fixes up all client sites.
Change-Id: I7a3d6f68ef46fe94b23cce7759cc0b8b6ca4dae9
|
|
Change-Id: I12a219a50cc3a9b07c9852cc0d417f71797b9e15
|
|
Revert "EMF+: aBaseTransform is a hardcoded identity matrix, don't bother with it"
This reverts commit 2b700a710e44d2d09f45793f5f2448268e66d4fe.
Revert "Pass also the bounding box in device units to the EMF+ part"
This reverts commit f387c5da5a824df6cf2874155c13445a86804475.
|
|
Change-Id: I7f4d85f3e26ab8b19dae05c6907840b97a8af1d6
|