summaryrefslogtreecommitdiff
path: root/cppcanvas
AgeCommit message (Collapse)Author
2014-08-21vcl: convert push flags to type-safe enum-like classNoel Grandin
Change-Id: Ib49a0dd5ecee0225f51bea2ff1c0ab5326595a47
2014-08-20vcl: use enum for complex text layout constantsNoel Grandin
Since these constants are bitfield flags, we define some methods to make working with them reasonably type safe. Move the definitions to outdevstate.hxx, since we need the values there, and that appears to be the "root most" header file. Also dump TEXT_LAYOUT_BIDI_LTR constant, since it means the same thing as TEXT_LAYOUT_DEFAULT (ie. 0), and leaving it in causes people to write weird code thinking that it's a real flag. Change-Id: Iddab86cd6c78181ceb8caa48e77e1f5a8e526343 Reviewed-on: https://gerrit.libreoffice.org/10676 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-08Missing test dependenciesStephan Bergmann
Change-Id: I7ea8f2b02b66a15e86e20948536c34017d6a3999
2014-08-07coverity#1228877 Structurally dead codeCaolán McNamara
Change-Id: If3a3de8bae4c2d1b8e39d3255cd8ee7e985b4404
2014-07-29fdo#81799 we need cppuhelper here tooDavid Tardon
Change-Id: I719557813180c3f862ef4b00e24142fdbbb0daf0
2014-07-28Use better coordinates for unit test of fdo#77229Arnaud Versini
Change-Id: I5fae217687e12313451da5bf4b4e6f914551b628 Reviewed-on: https://gerrit.libreoffice.org/10447 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-07-20vcl consitent use of long for corrdinateNorbert Thiebaud
most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20emf+: recognise some more object typesTomaž Vajngerl
Change-Id: I33fec62e4bc38eeaf014eeb1210db2904af033f6
2014-07-20emf+: emulate hatch with color blendTomaž Vajngerl
Change-Id: I2ac8f790c79c269d4c1fa650e703c3645c567ca4
2014-07-20bnc#881024 Handle 0 font height just like outdev & drawinglayerTomaž Vajngerl
Change-Id: I80055e4101873e0ddd408ac1f0ee9c75cc3bf6b3
2014-07-20emf+: Log type name instead of the type numberTomaž Vajngerl
Change-Id: I5c4f7c5713a559815bd46328907673d114fee011
2014-07-01New loplugin:stringconcatStephan Bergmann
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-12Fix vclplug_* dependencies for gb_CppunitTest_use_vclStephan Bergmann
...and replace gb_CppunitTest_unset_headless with gb_CppunitTest_use_vcl_non_headless. Change-Id: Ibd859f98ed8df09988ca26ffcee26e06e25d8313
2014-06-12Lets assume gb_CppunitTest_unset_headless was cargo cult hereStephan Bergmann
Change-Id: I9d4255f0ddcaf375706556d0c0baf2a5a0762bbf
2014-06-04update_pch: add a bunch of pch filesThomas Arnhold
connectivity: 3m52s -> 2m47s cppcanvas: 28s -> 13s cppuhelper: 20s -> 14s dbaccess: 2m38s -> 2m01s hwpfilter: 16s -> 13s sot: 21s -> 16s Change-Id: I49286bfe6be73dd1b861be632b95e17a99e82f8a
2014-06-04DeInitVCL at end of testsStephan Bergmann
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-05-30Fix memory leak in test codeStephan Bergmann
Change-Id: I318878b3fa883eebbc081a6faf6a594dad2c6e26
2014-05-22cppcheck: Function parameter 'rStartPos' should be passed by referenceThomas Arnhold
Change-Id: Ie453e1a95b54de07463b6f5052a23d6632400b8d
2014-05-22cppcheck: Function parameter 'rLineInfo' should be passed by referenceThomas Arnhold
Change-Id: I5bd3f808a0ca61731c5ceb57100d1b30a3163e98
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-10Blind fix for red Tinderboxes, followingJulien Nabet
Change-Id: I590a682af7fc1879ae63cda3aea73063ba4c84f4
2014-05-09'!= false' is redundant, and confusing - kill it.Jan Holesovsky
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
2014-04-28coverity#738576 Uninitialized pointer fieldCaolán McNamara
Change-Id: Id945cf9549b7f633f7deb1f237a2bf6536f221c1
2014-04-28coverity#738575 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ib65f0e95ef2a837b6c5791d9e2dce5fe8025da33
2014-04-28coverity#738574 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia7cca6e2a2bc3240a32509697a999461491a2747
2014-04-28coverity#738573 Uninitialized scalar fieldCaolán McNamara
Change-Id: I8b112fa0095cc6ed15c9198a312a0b6fce3a8d28
2014-04-17remove executable bitAndras Timar
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
2014-04-10CppunitTest_cppcanvas_emfplus: disable this in case there is no display to useMiklos Vajna
This test is already disabled on non-Linux, but it fails in case there is no display to use. For now just disable it in that case. Change-Id: I29c52e803a1fca5f2bdeeb655c573ad8fef622e8
2014-04-10fdo#77229 testcaseMiklos Vajna
We didn't have EMF+ rendering testcases so far, let's see if it works out to render into a bitmap and then just assert pixel position colors there. It's better than nothing for missing shapes at least. Change-Id: I2d1c63fef1127f69af7156ed6c99553845f77c9f
2014-04-09fdo#77229 EMF+ rendering: improve EmfPlusSetClipPath's CombineModeExclude caseMiklos Vajna
This is still not perfect, but at least we now don't do the opposite of what was asked. Change-Id: I5e144c5ec2987902e65b2eb472259d9c39bbbd11
2014-04-09Clean up function declarationsStephan Bergmann
Change-Id: I54f8a16cd64375d1398b6582175b0941ba68696e
2014-04-07cppcanvas: sal_Bool->boolNoel Grandin
Change-Id: I3dc076f3593d4d083d5e25e41e007eadc97d2978
2014-04-07Replace SV_DECL/IMPL_REF macros with SvRef templateStephan Bergmann
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-25Remove visual noise from cppcanvasAlexander Wilms
Change-Id: I961e6a9e227962096b57569a8b8160841cacd950
2014-02-25Update little-to-big endian GetSwapFloat functionsDouglas Mencken
rSt >> pPtr[3] >> pPtr[2] >> pPtr[1] >> pPtr[0] results in error: no match for 'operator>>' in 'rSt >> *(pPtr + 3u)' Change-Id: I1820bac8c72f7633ab01a17bf5d073b988e1b58c Reviewed-on: https://gerrit.libreoffice.org/8207 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-24harmonize Tell() Seek() type.Norbert Thiebaud
Change-Id: I2e472aa0279d0763762d3c660207cd74da512626
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-17fix debug=2 buildCaolán McNamara
Change-Id: Id7c6db5c6cbefef427d9c2cc4bd210811b5a7991
2014-02-12remove SvStream::operator>> methodsNoel Grandin
in favour of ReadXXX methods. Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3 Reviewed-on: https://gerrit.libreoffice.org/7915 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-04convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin
as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-30EMF+: Only draw endcap outline if not filled, fix endcap scaling.Andrzej Hunt
Change-Id: I4520eea08e43ccd657c1db03b258ef84612da971 Reviewed-on: https://gerrit.libreoffice.org/7726 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-28Apparently broken bitmask operationStephan Bergmann
Change-Id: Id4dfa3d4676b50a86fd6044d501de15b122bb7f1
2014-01-23coverity#1158489 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ibe8600f8ad38859cd79d52528f970d99f0b8f536