Age | Commit message (Collapse) | Author |
|
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it. Cleaned up some, but something like
grep -FwL sal/log.hxx $(git grep -Elw \
'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)
shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.
Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
|
|
Change-Id: Ied1a4e7226de4ae1d1c24af90ae9397ba80f404a
|
|
found with
git grep -E '\* *\<reinterpret_cast\>[^>]+\<OUString\>'
Change-Id: I9306d4ad8e3b1664f54cb7df86f2d79bfd3c6cb9
|
|
Change-Id: I22ee2cbacad8b19bb55db234e816d401edcf4a35
|
|
Change-Id: I834eb4ecd0fa71caf6fa746901367fac8b538305
|
|
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
|
|
and we can include a few less headers
Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
|
|
Change-Id: I5dc00f7b03b51916b1331c4ba64064a5aa5930c9
|
|
Change-Id: I129f3dc1597035664e4ff284276cb0d49a560ab5
|
|
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
|
|
Change-Id: Iec1251648031afa9eddd7445135fb08dc74821bd
|
|
Change-Id: I1e166c7e3b58ed565aaf478fa0b6505d1f68b604
|
|
still leaks the handle of course, but c++izes the code and hides
the leak from coverity as a side-effect
Change-Id: Ieaab1545a98da1d699df93d020f0cb452ddf2516
|
|
Change-Id: Ie5253f9b32bb6ed1099eca75b442ba26528f2b32
|
|
Change-Id: Ib1ce66bf9ec71280409335c0a5022ecfe229f494
|
|
<http://msdn.microsoft.com/en-us/library/8fskxacy.aspx> "Importing into an
Application Using __declspec(dllimport)": "Using __declspec(dllimport) is
optional on function declarations, but the compiler produces more efficient code
if you use this keyword."
Change-Id: I149306049987b2406622d7a0dc5dde92d283a5b3
|
|
Change-Id: I8a1c520023b493c0494ac2ac650542d8ecc11c5d
|
|
Change-Id: Iaba8b9b3415c357990b795b6f23b98929ac5e00a
|
|
Change-Id: I185b29c185094176e0992fc84c9cc82ff93de9c2
|
|
Change-Id: Ia98b32bd8451051750fbf810958bdcfe584ea7be
|
|
Change-Id: I77d06a70f9c000f800b9b31d3b04aafe77754446
|
|
Stumbled across such redundant visibility re-specifications when looking at the
odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in
cppu/source/cppu/cppu_opt.cxx and used in inline code in
include/com/sun/star/uno/Reference.hxx with only a declaration lacking
CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows.
However, this plugin is probably not worth it being run all the time, so
committing it to compilerplugins/clang/store/.
Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
|
|
Change-Id: I82ce1030e69f8794c9fdbdc138541e5d7e0541d4
|
|
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
|
|
...superseded by CppunitTest_odk_checkapi
Change-Id: I5df89a1a12f496984deab153f0ba2734323c1293
|
|
Change-Id: Id1d763c83821b7af6c541cb28ff438765026ea4d
|
|
Change-Id: Ibb38d8b8395300501caa0fc040f03b06770fd42e
|
|
Change-Id: Id3aaae19d86b706fd5ddb5982340472d28a75610
|
|
Unfortunately iwyu gets quite confused by the weird cyclic dependencies
between various foo.h/foo.hxx and cppumaker generated headers, so it's
not obvious if any improvement here is realistic...
Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
|
|
Change-Id: I85bb3b8cb0ba25e5ebd0a0fff84bda51792cc743
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...which is dereferenced a few lines further down; this is in preparation for a
commit addressing cid#440589.
Change-Id: I3428216258d928473f85ecd4d025c352c8c83ea0
|
|
just throw up hands in despair via std::abort instead of std::runtime_error
Change-Id: I356932ed2d76558bb4febbd2ac0a7bb6ea27bd0f
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Change-Id: I3ccd6895a1ddbf46a441e60ceaaaceb945f682e4
|
|
This improves on b68640c44ecdb1df59d704cc6c2bae8bb412d7d0 "Prevent creation of
new ORequestThreads during shutdown," which added throwing the DisposedException
from ThreadAdmin::add. But ThreadAdmin::m_disposed can only become true via
uno_threadpool_destroy -> ThreadPool::joinWorkers -> ThreadAdmin::join, and
ThreadAdmin::add observing that can only happen via uno_threadpool_putJob ->
ThreadPool::addJob -> ThreadPool::createThread -> ORequestThread::launch ->
ThradAdmin::add, where the bridges should ensure that uno_threadpool_destroy
does not run in parallel with uno_threadpool_putJob. So demote this from a
DisposedException to a SAL_WARN.
Change-Id: I3912ea077b7fa35827c41e82dd0a8f962ba412b6
|
|
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
|
|
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
|
|
Change-Id: I6497303e1b2d8d5ffd962489657582387ab974b1
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I7099dcf15843a80c25c7fb508dd9c0e8df6447e0
|
|
Change-Id: I15acdaaa810b5ee209764a277d0da5a4d7773466
|
|
Change-Id: Ia6a1ee154254e7efc0d787ce92222e80fecfd04e
|
|
Change-Id: I16180cae5fcf8dc59614f4ccf33f8745db05e138
|
|
to avoid expensive function calls until the refcount reaches 0
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, slightly changing it to
add a uno_type_sequence_destroy to uno/sequence2.h instead of a
uno_type_destructSequence to uno/data.h.
Change-Id: I3bbff3294f2b515fc3c68c4c6c1cb16829f5cc44
|
|
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
it seems to have issues with a < token followed by a :: token.
Change-Id: I8cc6a5b6cf00a233182de273ab6aa8609326aca9
|
|
Add a macro in include/cppuhelper/implbase_ex.hxx
to make initialising the type_entry classes a little less verbose.
Change-Id: I0904b5b9db269c92bc89e7ce3d6c8b09350c9897
|