summaryrefslogtreecommitdiff
path: root/cui/source/customize/cfg.cxx
AgeCommit message (Collapse)Author
2024-06-06customization entry help never wants to search for parent widget helpCaolán McNamara
it's not a widget context help where help about the parent widget might help in the case of nothing available for the child widget, but help for the specific selected command/script see also: https://bugs.documentfoundation.org/show_bug.cgi?id=116494 Change-Id: Ib4b5650ca00c90b4b4b2a76ef0e3d8a438023327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168504 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-07loplugin:ostr in cuiNoel Grandin
Change-Id: I593eb3c02768423fc8cea8d93c112655860228d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167258 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-27Drop std::as_const from css::uno::Sequence iterationsMike Kaganski
Obsoleted by commit 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and commit fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code, 2021-11-05). Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-16cid#1545970 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545957 COPY_INSTEAD_OF_MOVE cid#1545944 COPY_INSTEAD_OF_MOVE cid#1545939 COPY_INSTEAD_OF_MOVE cid#1545931 COPY_INSTEAD_OF_MOVE cid#1545926 COPY_INSTEAD_OF_MOVE cid#1545909 COPY_INSTEAD_OF_MOVE cid#1545899 COPY_INSTEAD_OF_MOVE cid#1545896 COPY_INSTEAD_OF_MOVE cid#1545894 COPY_INSTEAD_OF_MOVE cid#1545858 COPY_INSTEAD_OF_MOVE cid#1545823 COPY_INSTEAD_OF_MOVE cid#1545820 COPY_INSTEAD_OF_MOVE cid#1545819 COPY_INSTEAD_OF_MOVE cid#1545772 COPY_INSTEAD_OF_MOVE cid#1545749 COPY_INSTEAD_OF_MOVE cid#1545743 COPY_INSTEAD_OF_MOVE cid#1545739 COPY_INSTEAD_OF_MOVE cid#1545635 COPY_INSTEAD_OF_MOVE cid#1545603 COPY_INSTEAD_OF_MOVE cid#1545602 COPY_INSTEAD_OF_MOVE cid#1545592 COPY_INSTEAD_OF_MOVE cid#1545544 COPY_INSTEAD_OF_MOVE cid#1545532 COPY_INSTEAD_OF_MOVE cid#1545520 COPY_INSTEAD_OF_MOVE cid#1545512 COPY_INSTEAD_OF_MOVE cid#1545490 COPY_INSTEAD_OF_MOVE cid#1545483 COPY_INSTEAD_OF_MOVE cid#1545467 COPY_INSTEAD_OF_MOVE cid#1545461 COPY_INSTEAD_OF_MOVE cid#1545458 COPY_INSTEAD_OF_MOVE cid#1545428 COPY_INSTEAD_OF_MOVE cid#1545394 COPY_INSTEAD_OF_MOVE cid#1545385 COPY_INSTEAD_OF_MOVE cid#1545383 COPY_INSTEAD_OF_MOVE cid#1545366 COPY_INSTEAD_OF_MOVE cid#1545357 COPY_INSTEAD_OF_MOVE Change-Id: I76224326977b4067b94ca3176cad1ca6de17930a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-16misc: check SfxViewFrame::Current()Caolán McNamara
SfxViewFrame::Current() is a festering wound, these ones look like they were safe anyway, so no need to backport. But with enough checked static analysis will kick in to flag new unchecked ones. Change-Id: I2925c4fa4e2d48c1e676ffe7951e65120192517e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144277 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10Related: tdf#152266 open 'event' page by default for SID_CONFIGEVENTCaolán McNamara
Change-Id: I7a3f6def8bda00588ef2846e5d3b5ed5d1da04de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10switch to the 'keyboard' tab if a SID_MACROINFO is setCaolán McNamara
Change-Id: Ie615ab2598309b0324daa11732e5345d1a927437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09make Notebookbar customize page match indent with the othersCaolán McNamara
remove intermediate grids with just one child, name the containers of the groups of widgets to be hidden and hide the container rather than the individual members so the container space doesn't push this page out of alignment with the others. Change-Id: Ie3fb291da49a6b43ca4516e5fe55b828543631e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-22loplugin:unusedfieldsNoel Grandin
Change-Id: I4487f1b3bb051e1eb48226eb52a6706b22493fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-23Related: tdf#35030 hide the "reset" button more reliablyCaolán McNamara
otherwise it won't end up hidden if the "keyboard" tab page is the initial page, this handler only happens when the user switches tabs. use the newly added virtual methods to manage this instead Change-Id: I3eef6b4d7d453a5ec16ec62b2ebb558bd4757caa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-20tdf#112237 Show tooltips for Assigned Commands in Customize dialogJim Raykowski
Change-Id: Iff1946d5d6ac7f2046d36df8fbd76e32edf371c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140142 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-03clang-tidy modernize-pass-by-value in cuiNoel Grandin
Change-Id: If3d2717c22e33412f813673a93ccc56d23ab2fa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135348 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-16Resolves tdf#35030 - Hide Reset button for keyboard customizationHeiko Tietze
Change-Id: Id69f2fd6ed5d33a622088886b25d1f61d7eb2516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131534 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-27no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemEntryInfo stuff in the pool) Change-Id: Ic7b5f2c3cc75a65bdf9c45f9522cc53954b4ba38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-13Recheck modules [a-c]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-21loplugin:flatten in canvas..cuiNoel Grandin
Change-Id: I208767eaa60d913fe2882403f1f9351eb08256f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-03don't use SVXSTR for translation ids that are in cui.moCaolán McNamara
use that just for the ones in svx.mo. This just changes the programmer-level #define and keeps the translator-level message context the same to avoid triggering any retranslations. Change-Id: I3ca90618e27c4d7abbc77de1096e67bafe49e7ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125832 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-27set png filter for import dialog in a more robust wayCaolán McNamara
Change-Id: Iec25e214b19e5a2ab8a7305aad307c3f03e67401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125913 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26tdf#145831: fix typo in PNGAndrea Gelmini
Change-Id: I206ac72d56409b3516f49798fb7f10b3a4c3d721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-23O[U]String::replaceAt overloads that take string_viewNoel Grandin
which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-02extract a ReorderingDropTarget for reuseCaolán McNamara
Change-Id: I0ae69bbf644e220e1bf3352d98eb4fd735167416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in cuiMike Kaganski
Change-Id: Ib359c029099cf86ccdebefd014d4a9bd91d57eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124356 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-15Remove non-const Sequence::begin()/end() in internal codeMike Kaganski
... to avoid hidden cost of multiple COW checks, because they call getArray() internally. This obsoletes [loplugin:sequenceloop]. Also rename toNonConstRange to asNonConstRange, to reflect that the result is a view of the sequence, not an independent object. TODO: also drop non-const operator[], but introduce operator[] in SequenceRange. Change-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123518 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-28gives names to all the Idles and TasksNoel Grandin
enforce it by making the constructor parameter non-default. Change-Id: I321543e4dcf15ea0a43ad8cce91d2f8dc22df6ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-12tdf#126665 Remember last used file picker directorySamuel Mehrbrodt
This introduces internal tracking of last used directories. Each caller of the file picker can pass a "context". The selected directory will then be saved & restored when opening the file picker with the same context again. After ffa636ba74b04b3258ec9a696bc4eac33581fa24 , the Windows file picker no longer tracks the last used directory itself. This is a replacement and an improvement at the same time, since there is not one global last used directory, but one per context. Change-Id: I10650cfb9359922690954fa65c89b4e47477e2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118597 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-06-02tdf#116491: Customize: Add indication for experimental commandsMuhammet Kara
Change-Id: Id485f86598aa89cbce6d742c0207c178e5208ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116014 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-05-26fix leak in SvxConfigPageNoel Grandin
Change-Id: I6b95d33cfbad455692c8047968a2581fe4610260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-18tdf#112369 allow to disable the add command button in menu customizebaltasarq
Instead of showing an alert dialog reporting that a command is already present in a given menu, enable or disable the add command button when needed. Change-Id: I52b9477896d4775ae2033c057fa1b5bfccb6a749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115057 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-23this Sequence can be a std::vectorNoel Grandin
Change-Id: I678db4ed598b3e1061857e942185b2307fbb9e88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25avoid some ref-countingNoel Grandin
can just return a pointer here, instead of VclPtr. Change-Id: I9ab8962cbbe84ed4dfcfd658a6d758112914cb89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11loplugin:stringviewNoel
Add new methods "subView" to O(U)String to return substring views of the underlying data. Add a clang plugin to warn when replacing existing calls to copy() would be better to use subView(). Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-03use more TOOLS_WARN_EXCEPTIONNoel
Change-Id: I8b5cde993c13e0b7c8c830b1ff698933a6b7cfd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-02loplugin:reducevarscope in cuiNoel
Change-Id: Iedfda307d149fe2a5a196c83d3ea02b618e7dd23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:simplifybool a little more aggressiveNoel Grandin
with expressions like !(a && b) Change-Id: Id2acec2a8d0eaaa8e5e37dbd2cae7281be36572e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-26Customize: Update description box on auto selectMuhammet Kara
When you open the dialog, select a category, or enter a search/filter term, the first entry on the functions list was selected automatically but the description box was not updated properly. Change-Id: I23737c540ab67af3e79694365b8c8c31c4f60ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97188 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-18distinguish active dnd-operation case from simple query caseCaolán McNamara
Change-Id: I1d8e95e46b45c71c0c83316ab4f19ba85eddcf75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96598 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-11fix my own mistakeTomoyuki Kubota
Change-Id: I01f3b405e91175ab0ef532505bf9f275073d2fc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-08rework treeview initial toggle button col to be like expander colCaolán McNamara
cause this assumption is baked into the vcl one making it hard to adapt remaining cases Change-Id: I75dd5264c65b1ffbf4d26c9a86f6d4d08b400d90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-04Upcoming loplugin:elidestringvar: cuiStephan Bergmann
Change-Id: I48c4f69a1fb2e4591eab81c2b0019d7d7d43947b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95395 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04make triangle largerCaolán McNamara
Change-Id: I7fce58507b039c080b5b6ffd423fb85f87ad077a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-28loplugin:simplifybool in canvas..cuiNoel Grandin
Change-Id: Ib7c3b381ce4456e3d48538ee6f762ceaf2784fe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94973 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-26followed the advice from Mike at https://gerrit.libreoffice.org/c/core/+/94687himajin100000
Change-Id: If961da88f3ecba03416394ab8e8093af1b20f664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94832 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-26cfg.cxx build fixhimajin100000
Change-Id: I7bab3dc64f0976b3d3e8711a05ea826243a6be67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94687 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-11 14:40:53 +0000