summaryrefslogtreecommitdiff
path: root/cui/source/customize
AgeCommit message (Collapse)Author
2021-03-17lok: fix the empty script node type container without "+" symbol expanderHenry Castro
According to description in https://bz.apache.org/ooo/show_bug.cgi?id=30923 "In this case I think it's an acceptable solution to display a '+' symbol for all library nodes, and if a library has no children and the user clicks on the '+' symbol, the '+' will disappear". Unfortunately this behaviour is not well driven for final users' client side, so they misinterpret as a bug. After tracing the method hasChildNodes(), the log result indicates that this method does not load the libraries, but it is necessary to iterate applying the method getChildNodes(), which will cause to load all libraries and determine if the child has a script CONTAINER node type to assign the '+' symbol. Also, I have traced the loading libraries when the Macro Selector dialog pops up and the result it load once, so I do not think it is a problem loading a small finite number of libraries today. Change-Id: I4ae5395b6afa7b7d6ff2b2ec692771e93c46c529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112636 Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-03-11Remove description from mobile macro selectorSzymon Kłos
Change-Id: I76d9a73c65d0c7759b56a3d7b69aadf5b58d7da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112327 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-11Remove unused code from Macro Selector dialogSzymon Kłos
Change-Id: I9930fd7eaf2410447f84aa4798478a10915ea738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112316 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-18lok: run async the Macro Selector DialogHenry Castro
Required to be called by the client side Change-Id: I9c9d22dd249839009bdc6a701553f3b9d776347a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107246 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109137 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-11-30rework treeview initial toggle button col to be like expander colCaolán McNamara
cause this assumption is baked into the vcl one making it hard to adapt remaining cases Change-Id: I75dd5264c65b1ffbf4d26c9a86f6d4d08b400d90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106874 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-12Resolves: tdf#133862 crash in customize toolbar in embedded mathCaolán McNamara
Change-Id: I2fc7f3620145e48516c3ca73c0a5d08dce11d78a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96035 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-05-20tdf#133036 notebookbar customize uses a special combobox idCaolán McNamara
in all other cases the m_xSaveInListBox id contains a SaveInData pointer but not the notebookbar case for some reason, we're already checking for this special id in one case, extend to check in the other too Change-Id: I460afa165ee2f6baa6deb1a15b0257df274a4c94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94269 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-03Fix crash with Tools > Customize... in Master DocumentMaxim Monastirsky
Need to compare by full module id here, as otherwise Master Document is detected as Writer, causing crash as the notebookbar tab isn't prepared to handle the Master Document variant. Change-Id: I872255c42517b4223fb31e2074e4d5d083c76e93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88344 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 0ad3558a0c84e97306dfd6d235680ed6e053711b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89775 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-07Resolves: tdf#130340 null deref when nothing selectedCaolán McNamara
Change-Id: Ie406006cbcca566ddd32fd86a7e88f0c754dd02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88048 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-12-01Resolves: tdf#129119 no SfxViewFrame in startcenterCaolán McNamara
Change-Id: I16d8207314146df3dd7f5b11182650066cc97fde Reviewed-on: https://gerrit.libreoffice.org/84149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-28tdf#126043 use another bulk_insert_for_eachCaolán McNamara
Change-Id: I05c3fc6e708d000ba955981dbd8d11371ea99da2 Reviewed-on: https://gerrit.libreoffice.org/83686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 05734503ed36cff64cfaac8afb7c6df5eced8873) Reviewed-on: https://gerrit.libreoffice.org/83983
2019-11-28tdf#126043 use bulk_insert_for_eachCaolán McNamara
Change-Id: I68b5a7805a2e0a76d1871448a011fdde7f7cdb1e Reviewed-on: https://gerrit.libreoffice.org/83685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9b6b134b3e605236e90aca089867f08d659a6076) Reviewed-on: https://gerrit.libreoffice.org/83967
2019-11-28tdf#126043 load the xml just onceCaolán McNamara
Change-Id: I98cfeeeddf2fb2d86259a11368bf3db752f5e556 Reviewed-on: https://gerrit.libreoffice.org/83656 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7c949066e6aae6ffe3b88d6500e70cdb7cc03b69) Reviewed-on: https://gerrit.libreoffice.org/83902
2019-11-27tdf#126043 don't bother converting to OUStringCaolán McNamara
Change-Id: I179354659e4ee118138b994c7848c1dda39317bb Reviewed-on: https://gerrit.libreoffice.org/83678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f54a8c6aafac53902b144f5125665644e9a50497) Reviewed-on: https://gerrit.libreoffice.org/83865
2019-11-27tdf#126043 module identifier already knownCaolán McNamara
Change-Id: I710180ed125bbea250694cfb5f7d12cb1b07f782 Reviewed-on: https://gerrit.libreoffice.org/83675 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 380b322b986720f155edac62b70b0d7aa40c16b7) Reviewed-on: https://gerrit.libreoffice.org/83866 Tested-by: Jenkins
2019-11-27tdf#126043 freeze/thaw around bulk insertCaolán McNamara
Change-Id: I2dd9aedc305a4fe1992fe8c52fee85ade8589a5b Reviewed-on: https://gerrit.libreoffice.org/83674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 300ffc649aaa555bba19a0475d74067c9574fc04) Reviewed-on: https://gerrit.libreoffice.org/83833
2019-11-27tdf#126043 identify the frame module just onceCaolán McNamara
Change-Id: I7f68cf67838bb08672975e7a38cf213022e39ed8 Reviewed-on: https://gerrit.libreoffice.org/83672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6e6233a5d0940e5bbdb346142091b0ae2e54e640) Reviewed-on: https://gerrit.libreoffice.org/83832
2019-11-27tdf#126043 drop intermediate OUStringCaolán McNamara
Change-Id: I96906737bfe0f40b8a4c0b2f88dde7cc40daeab0 Reviewed-on: https://gerrit.libreoffice.org/83677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit df701c92f3f8071d1dd6df70898c33d99e905e7e) Reviewed-on: https://gerrit.libreoffice.org/83834
2019-11-26use a better conversion to OUStringCaolán McNamara
Change-Id: I4a133c054700f72770380214cc794a691edac54e Reviewed-on: https://gerrit.libreoffice.org/83741 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 use CommandInfoProvider::GetModuleIdentifierCaolán McNamara
which probably already has a cached ModuleManager Change-Id: Id653e57ecf40061ace086881344a85d7413a5afc Reviewed-on: https://gerrit.libreoffice.org/83671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9426162a3b24732167e4fa7aa2fa6ee19d33e7e9) Reviewed-on: https://gerrit.libreoffice.org/83788
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/83763
2019-11-26tdf#126043 cache the appname and filenameCaolán McNamara
Change-Id: I10987f8a447785eb0d9887f94ee0ffb0da99649a Reviewed-on: https://gerrit.libreoffice.org/83716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25don't just truncate the unicode chars of the pathCaolán McNamara
instead convert to a systempath like we do for other uses of xmlParseFile drop the manual memory management Change-Id: I8c3329db4b47a2d212770297c96f066ccbe1ec77 Reviewed-on: https://gerrit.libreoffice.org/83692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25constifyCaolán McNamara
Change-Id: I912ec27312a65bf065887af26b42122b5276d69f Reviewed-on: https://gerrit.libreoffice.org/83652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25fix leakCaolán McNamara
Change-Id: I486fad57766c1314fde7c580fd06b2c5d225241a Reviewed-on: https://gerrit.libreoffice.org/83650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15Resolves: tdf#128802 manage dnd ourselfCaolán McNamara
instead of relying on the built-in dnd which is allowing toplevel entries to be dropped on other ones to become children of another entry, which is not what we want here. Change-Id: I8c5528d9b26e994b7eda9d2972af0b3783187f3e Reviewed-on: https://gerrit.libreoffice.org/82770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-09tdf#128010: Don't ask to enable JRE when populating available scriptsMike Kaganski
It was user's intention to not use JRE, so omitting the JRE-dependent scripts in dialogs is just consistent with user's configuration. Change-Id: Ic551f5dd1d797fbaa2dc6d7e443e23d46b0ac5d3 Reviewed-on: https://gerrit.libreoffice.org/82353 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-09tdf#80731: Only check closing parenthesis when in IDEMike Kaganski
This reinstates the fix by Pierre Lepage, which was reverted in 351dead74b4c213b13102f81b5ae9bb47ad8ca39, and makes sure it only has effect when the compilation is started from IDE. The idea is that the IDE is used primarily for development, and that's a good opportunity to detect any error in the code. When the code is compiled from outside of the IDE (like running an extension), the error is tolerated to allow users run the legacy code having this error. Hopefully this is enough for tdf#106529. This re-uses comphelper's NoEnableJavaInteractionContext class, which is converted into general-purpose SetFlagContext class to avoid code duplication. Change-Id: Ie290019cb190b8d1d590699ec13bd63eac478d09 Reviewed-on: https://gerrit.libreoffice.org/81616 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-08Fix tdf#128004: Customize: chosen category does not filter function listMuhammet Kara
Change-Id: I69b1defda33f22c38377aed559147c880b292ed8 Reviewed-on: https://gerrit.libreoffice.org/82319 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-03loplugin:stringaddNoel Grandin
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29weld fpicker clusterCaolán McNamara
Change-Id: I6566263809ff0032388a0b56571f0cf7428058d7 Reviewed-on: https://gerrit.libreoffice.org/81334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-22loplugin:constantparamNoel Grandin
Change-Id: Ibfe70492683ff3ec208cee95d8a11155ec54f690 Reviewed-on: https://gerrit.libreoffice.org/81314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16loplugin:bufferadd loosen some constraintsNoel Grandin
and extend O*StringView to have a constructor that takes a pointer and a length Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8 Reviewed-on: https://gerrit.libreoffice.org/80872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15new loplugin:bufferaddNoel Grandin
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08Resolves tdf#127903 - Allow customization with equal keyHeiko Tietze
Change-Id: Ie5e1fc23412d13a868e021addb0de47d9e84f80b Reviewed-on: https://gerrit.libreoffice.org/80436 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-06Related: tdf#127935 set default activate handler to toggle row expansionCaolán McNamara
Change-Id: I2bbfb1445b8d2e748f642cdf4723d41b7f072e2b Reviewed-on: https://gerrit.libreoffice.org/80305 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04drop unnecessary includesCaolán McNamara
Change-Id: I2d6828734cfdf795499d54e1b1e8ba9fc4b5a4d1 Reviewed-on: https://gerrit.libreoffice.org/80197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01loplugin:loopvartoosmall (clang-cl)Stephan Bergmann
Change-Id: I682fccecd94d1d1524fcb12e93f5d53b0c94ea03 Reviewed-on: https://gerrit.libreoffice.org/79935 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:stringadd in basctl..cuiNoel Grandin
Change-Id: I2fdeb7eb3ead3512ad6d3fe793305038ab3aa7ae Reviewed-on: https://gerrit.libreoffice.org/79886 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27Fix Typo SvxMenuConfigPage -> SvxConfigPageStephan Bergmann
...introduced with ccb2b0078f07194befa61f1e3fd88e53ff236871 "weld SvxMenuConfigPage/SvxToolbarConfigPage", causing -fsanitize=dynamic-type- mismatch during UITest_writer_demo: > include/tools/link.hxx:163:10: runtime error: downcast of address 0x613000204b40 which does not point to an object of type 'SvxMenuConfigPage' > 0x613000204b40: note: object is of type 'SvxConfigPage' > 83 01 00 4e b0 a1 bb 2e f6 7f 00 00 20 c4 56 00 e0 60 00 00 50 f8 a4 00 40 60 00 00 e8 49 38 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SvxConfigPage' > #0 in SvxMenuConfigPage* tools::detail::castTo<SvxMenuConfigPage*, SvxConfigPage*>(SvxConfigPage*) at include/tools/link.hxx:163:10 > #1 in SvxConfigPage::SvxConfigPage(weld::Container*, weld::DialogController*, SfxItemSet const&) at cui/source/customize/cfg.cxx:997:41 [...] Change-Id: Ie36ebabd3075cade590cc504fb06b5319b346dcf Reviewed-on: https://gerrit.libreoffice.org/79666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-26TODO rename to GetFrameWeldCaolán McNamara
Change-Id: I28527b6773075fe682682a4812cf86bb7ac13180 Reviewed-on: https://gerrit.libreoffice.org/79560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26now drop TabPageParent intermediateCaolán McNamara
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c Reviewed-on: https://gerrit.libreoffice.org/79469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara
Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23drop strange use of Help::ShowBalloonCaolán McNamara
Change-Id: I90406d02d31f1e89e31a5c9d938d42eeb112ee25 Reviewed-on: https://gerrit.libreoffice.org/79407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23set correct parentCaolán McNamara
Change-Id: I1fc03238a68bcc42e0e43f3305baeb4407791eca Reviewed-on: https://gerrit.libreoffice.org/79409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23replace LogicToPixel uses in SfxTabPagesCaolán McNamara
Change-Id: Ic2ea87bd5bcb8ccee58818b638e70a561fc8f95b Reviewed-on: https://gerrit.libreoffice.org/79410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17move GetStandardText to stdtext.hxxCaolán McNamara
Change-Id: Iaf9b5107cf88390f62d5ca94bf985c77bcb8b7ad Reviewed-on: https://gerrit.libreoffice.org/79048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-05loplugin:constmethod in cuiNoel Grandin
Change-Id: I06ffacbb02f3e9088e9c1a51e0e3e0d65d356f62 Reviewed-on: https://gerrit.libreoffice.org/78602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in basic..cuiNoel Grandin
Change-Id: I15d825de3201808d188b461415f78a4d81b64127 Reviewed-on: https://gerrit.libreoffice.org/77494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-08 16:33:16 +0000