summaryrefslogtreecommitdiff
path: root/cui/source/customize
AgeCommit message (Collapse)Author
2017-01-17tdf#105014: Disable related buttons when there is no menu to editMuhammet Kara
Clicking the "Add Separator" or the "Add Submenu" button, when there is no menu edit, causes LibreOffice to crash. So disable them properly. Change-Id: Ibf685145a87c9e4343d83e1bb5ef6f08136c8f31 Reviewed-on: https://gerrit.libreoffice.org/32987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-16Convert RID_MENU_NOTEBOOKBAR to xmlMaxim Monastirsky
Brings a lot of features (icons, keyboard shortcuts, customization, context menu interception etc.) Other changes: - Make SfxDispatcher::ExecutePopup take PopupMenuFlags arg, to be able to pass NoMouseUpClose, so that the menu won't close on mouse-up under anything != gtk3. - Make .uno:OpenFromWriter and .uno:OpenFromCalc async slots, to avoid crash under gtk3 when recycling the current frame. - Don't show the menu in customization dialog, if experimental mode disabled. Change-Id: Ieea2f73f6b48fbaf4bdfc4acf1a33d25422357cb Reviewed-on: https://gerrit.libreoffice.org/33101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-16SfxConfigGroupListBox leaks its resource containerCaolán McNamara
Change-Id: I02cf44bdc9032fdba9237083ef08da71b817e3af
2017-01-16unwind resourceCaolán McNamara
Change-Id: I7a951548204745035bd69e4311e5fa1fe91b2d32
2017-01-16drop unused defineCaolán McNamara
Change-Id: I2c3bd011f91e79d3aed43a78e54f149f19909cc3
2017-01-16b*, c*: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
2017-01-16new loplugin: useuniqueptr: cuiNoel Grandin
Change-Id: I9a72b0d3ca999e2f84c615515fafa90bc7f8f2b6 Reviewed-on: https://gerrit.libreoffice.org/33150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22unwind RID_SVXIMGLIST_FMEXPL ImageListCaolán McNamara
Change-Id: If9d733c5242e2f2b9947b251cfe832d1c10bd4bd Reviewed-on: https://gerrit.libreoffice.org/32350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-21convert VclButtonsType to scoped enumNoel Grandin
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-28loplugin:unnecessaryoverride (dtors) in cuiStephan Bergmann
Change-Id: Ibb78c2a16defbd523a079b651a27e9639d26953f
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-07loplugin:oncevar in cui..connectivityNoel Grandin
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17 Reviewed-on: https://gerrit.libreoffice.org/30653 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04customize dialog crashes, since...Caolán McNamara
commit 164d8e3b1aa660d65c1af9570e67b66520bd953a Date: Thu Nov 3 02:35:00 2016 +0200 tdf#91222 VclBuilder constructor cleanup so revert problematic bit of that. The impl is called SfxAccCfgTabListBox_Impl, but the widget name is SfxAccCfgTabListBox Change-Id: I8e800b376afa48090fde1074350c1c8ce39a27bf
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30511 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31Nonsensical OUString null checkStephan Bergmann
...ever since at least d32b3a714fe55892bdead03502c5a9b0e77fa61d "#i106421#: move svx/source/cui to cui". (That happened to redundantly check for non-empty url, too; maybe in the distant past GetScriptURL returned a pointer.) Change-Id: I6139db1d4b1fdcf5325895569de293dd89e36d9f
2016-10-30tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl
This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-25tdf#103160 Add 'Add Submenu' button in Customize dialogMuhammet Kara
And remove the 'Add Submenu' entry from Modify split button in Customize dialog Change-Id: I6ac940f5f1f41ac1f962f66f458c7e14d702b2be Reviewed-on: https://gerrit.libreoffice.org/30230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2016-10-12loplugin:unnecessaryoverride in connectivity/cuiNoel Grandin
Change-Id: I5ec4eb2f74036e42851333e3d669dbea58c2490a Reviewed-on: https://gerrit.libreoffice.org/29687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-06these other IMAGE_STDBTN_COLOR defines do nothingCaolán McNamara
Change-Id: If35bd52f973dc89b05afd283a4a89998c491b862
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-01Fix typosAndrea Gelmini
Change-Id: I8374d6d08f4eb4ae2821e213371c615b92d7e9ab Reviewed-on: https://gerrit.libreoffice.org/29432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15tdf#82840 Add radio buttons for toolbar stylesMuhammet Kara
Add 'Icons Only', 'Text Only', and 'Icons & Text' radio buttons to the 'Toolbar' tab of the 'Customize' dialog. And remove the corresponding items from the 'Toolbar' menu button. Also removed some unused literals and code pieces. This patch is towards achieving the design and functionality suggested in the related bug report. Change-Id: I072b05ae64817e93c0dbd5fb434126b525c2fd48 Reviewed-on: https://gerrit.libreoffice.org/28773 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-07tdf#82840 Add 'Add Separator' button to toolbar customizationMuhammet Kara
Add 'Add Separator' button to the 'Customize' dialog's 'Menus', 'Context Menus', and 'Toolbars' tabs. And remove the 'Add Separator' item from the 'Modify' menu. In the following commits, more widgets will be added and moved around to achieve the suggested appearance and functionality in the related bug report. Change-Id: I1961e2ebeb326eca69d8f967b2b636793200aba0 Reviewed-on: https://gerrit.libreoffice.org/28681 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-05tdf#82840 Add 'Reset' button to toolbar customizationMuhammet Kara
Add 'Reset' button to the toolbar customization dialog, and remove the 'Restore Default Settings' item from the 'Toolbar' menu. Note that this 'Reset' button does not only reset the selected item but also restores the selected top-level toolbar to default settings. Since there is no 'Restore Default Settings' option in the other tabs of the config dialog, the button is disabled and hidded in the parent class ctor, then made visible again in the child class ctor. In the following commits, more widgets will be added and moved around to achieve the suggested appearance and functionality in the related bug report. Change-Id: I028c082daf423761e3511101069a0dc842743e3b Reviewed-on: https://gerrit.libreoffice.org/28621 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-08-23tdf#82840 Add 'delete' button to toolbar customizationMuhammet Kara
Added 'delete' button for contents of Menus, Context Menus, and Toolbars pages of the 'Customize' dialog. And removed the 'delete' item from the 'Modify' menu in those pages. Change-Id: Ie59a32e0b92116f8058fe8efe288bfb215b522b0 Reviewed-on: https://gerrit.libreoffice.org/28323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-08-16new loplugin to check for static OUStringsNoel Grandin
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#100726: Improve readability of OUString concatenationnadith
module cui and dbaccess fixed Change-Id: Ief6fca46622fe4e0da804c9a874f7ec93a0fd7af Reviewed-on: https://gerrit.libreoffice.org/27770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-19improve unnecessaryoverride pluginNoel Grandin
to ignore ImplicitCastExpr when calling superclass method Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1 Reviewed-on: https://gerrit.libreoffice.org/27279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13Remove wrong, needless downcastStephan Bergmann
...from SaveInData (which has a virtual dtor) to MenuSaveInData, while the data could also be ContextMenuSaveInData (not derived from MenuSavaInData). Change-Id: I4928fa97ed7738516699f8e57f354ef0f334c4f1
2016-07-13no need to create temporary OUString for comparisonNoel Grandin
Change-Id: I0a321e8ffbe379588a288084ec2e74e1a8c296b2 Reviewed-on: https://gerrit.libreoffice.org/27171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-08loplugin:redundantcast: redundant static_casts in cuiStephan Bergmann
Change-Id: I97385a4fade4794f5aebd0b65eaf4c92ed06bd66
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I51957af512cae8ec838fd9b14bd576356edd2611
2016-06-27loplugin:singlevalfields in cuiNoel Grandin
Change-Id: Iead1e3130779566661eccf91556816724afcaa66 Reviewed-on: https://gerrit.libreoffice.org/26635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-26Resolves: tdf#100619 vclptr assert with menu set to menubuttonCaolán McNamara
Change-Id: I2e621567e3bbc01d6f52844014dba9e46fe79f41
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23Resolves: tdf#99981 make ScriptSelectorDialog modal for its parentCaolán McNamara
Change-Id: Ia522b36cd1f5d47d08afa74a22cec11de465f567
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-05SvxIconSelectorDialog was never destructedMaxim Monastirsky
Change-Id: I6cc9bd70f3e3f4266af0eddfff8be406021a1d66
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I263603fb81d368ebc8450b2d8cc01752fcd3f29d
2016-04-21clang-tidy modernize-loop-convert in c*Noel Grandin
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I0953cecd363dd75e6a4438d34d47035f53f334a6
generated by cgit (git 2.34.1) at 2025-02-14 16:45:15 +0000