summaryrefslogtreecommitdiff
path: root/cui/source/inc
AgeCommit message (Collapse)Author
2020-11-17tdf#137930 Apply button changes values to previous onesCaolán McNamara
Change-Id: I374b4f448715db9563f6073c433b82caf3482874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-16remove unused param in SvxHpLinkDlgNoel
ever since commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Author: Mathias Bauer <mba@openoffice.org> Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui Change-Id: I1c331cda3f756cc87344eac6c56cfaa8466286ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105914 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-13tdf#123936 Formatting files in module cui with clang-formatPhilipp Hofer
Change-Id: I473e2950bb9bd53043feeae31a27ae0c2fc7801d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105659 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-13Make Split Table Cell dialog asyncSzymon Kłos
Change-Id: I4efbb24f721aa50cc4dbbe78ae1e7e6087f8c876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103670 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105594 Tested-by: Jenkins
2020-11-06Related: tdf#138030 make 'except' page act like 'replace'Caolán McNamara
wrt pressing return to activate the entries Change-Id: If691caef70fb12f96e24441929ab325780304962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-06loplugin:unusedmethodsNoel
Change-Id: Ia6c0361cd793bb62905b0690f7e2ca554019e935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-06tdf#42949 Fix new IWYU warnings in directories c*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iac1e7802dbe1efa01c2befdd10406231788d4fc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105315 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-29have just the one handler for ok/apply optionsCaolán McNamara
'apply' is only really working the first time it is pressed in a page, I want to be able to apply to change e.g. notebookbar icon size and then change that again and apply and get the expected display size Change-Id: I7f051ad4063f0e99f822cc06fbe4a0ab49588fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-29call ExtPage::DeactivatePage for apply as well as okCaolán McNamara
I think the concerns at https://gerrit.libreoffice.org/c/core/+/54980/ are on balance overly conservative and its safer to make apply behave the same as ok wrt that call Change-Id: I889290c23dc9a7d4bb751769a509932142be5795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105019 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-28Use UCB instead of cURL to download https filesStephan Bergmann
Since 7dc6fc32eb618da6defb8a9f330978fa019677b8 "uitest: Check the more icons dialog opens" started to test the AdditionsDialog code, some ASan builds started to report use-after-poison from within SearchAndParseThread::execute -> curlGet -> curl_easy_perform -> ... -> https_connecting -> ... -> secmod_ModuleInit -> pemC_Initialize -> ..., see the comments starting at <https://gerrit.libreoffice.org/c/core/+/98226/ 10#message-2a55980ab2477e41dc7515e4aeabc7234afc2053> "tdf#133026: Tight integration of extensions - Adding thread structure". The exact cause for that ASan use-after-poison is not quite clear to me. First, I thought it was due to liberal use of curl_easy_init (without a central curl_global_init) in a multi-threaded process; see <https://curl.haxx.se/libcurl/c/curl_easy_init.html> for this being considered "lethal". But then, another issue could be that most of the nss libraries like instdir/program/libnss3.so (implementing the "... -> secmod_ModuleInit" part) come from LO's bundled --without-system-nss while /lib64/libnsspem.so (implementing the "pemC_Initialize -> ..." part) comes from the system, and there could be some mismatch when mixing these (esp. if the former are built with ASan). So whatever the actual cause, the right fix should be to use LO's UCB instead of directly calling into cURL anyway. That required a version of utl::UcbStreamHelper::CreateStream that uses a given XInteractionHandler (which may be null to indicate no interaction handling, instead reporting all interaction requests as exceptions) instead of internally creating an XInteractionHandler using the GUI, and which would cause deadlock in 7dc6fc32eb618da6defb8a9f330978fa019677b8's UITest_sw_options. (And introducing that additional utl::UcbStreamHelper::CreateStream overload required css::awt::XWindow to be a complete type now in vcl/source/graphic/GraphicLoader.cxx, for > include/com/sun/star/uno/Reference.h:277:18: note: in instantiation of variable template specialization 'std::is_base_of_v<com::sun::star::task::XInteractionHandler, com::sun::star::awt::XWindow>' requested here > std::is_base_of_v<interface_type, derived_type> > ^ ) (The removed code in cui/source/dialogs/AdditionsDialog.cxx should have been the last remaining use of curl in Library_cui. Apparently, e1e9e2aa16f08a8fd9e38db706d63e8eceeda8d1 "Kill Mozilla personas" had forgotten to remove it from cui/Library_cui.mk the last time Library_cui had become curl-free, before the introduction of the AdditionsDialog code.) (I did not remove the #undef ABSOLUTE FIXME from cui/source/dialogs/AdditionsDialog.cxx. c4bee547b02fbe3d07b1e9ee203c73e48f86e6bf "tdf#133026: Additions: Better Search Function" does not tell whether it had been added to mitigate a macro definition from the (now removed) #include <curl/curl.h>.) Change-Id: I1fec7488d36df81c3543d12d97da1291f77712fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-27Partially resolves: tdf#127279 Change "register-true" to "Page line-spacing"Seth Chaiklin
in Page and Paragraph For all places in UI where "register-true" appears, change to "Page line-spacing". -For Paragraph dialog, remove section heading and rename checkbox to "Activate page line-spacing" -For Page Style dialog, change label to: "Use page line-spacing" -Add tooltip and extended tooltip in Paragraph dialog; -Shorten tooltip in Page dialog, and add extended tooltip Bonus: -Add tooltip to "Automatic" in Paragraph dialog -Remove contraction in control label (in accordance with UI guidelines) Change-Id: I826ce35051b1d2c04f0e52d4e9fe4e6cfd1d7cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104331 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-26Fixes to TipOfTheDayHeiko Tietze
Callback removed Change-Id: I09eb95004151cf2ca068a0c23c02267d89b0ba20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104800 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-24Show animated GIFs in TotDHeiko Tietze
marchingants.gif added as an example Change-Id: I555aebc4a4e191b8afb4be06dfc1e5f3e6d1a911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104718 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-21use tools::Long in comphelper..cuiNoel
Change-Id: I65167999c6049038f8f5d530a0c5cb0552ab0e06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20Beautification of code and fix for on-/offline helpHeiko Tietze
Change-Id: I0c731f2c472ceb435f529956011a7fd5a00a27ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104358 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-18clang-format customize/SvxToolbarConfigPageMuhammet Kara
Change-Id: If9b3fcbaa8e900d73c8dd0e727b4059c3b30ac01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104485 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-18clang-format customize/SvxMenuConfigPageMuhammet Kara
Change-Id: I9ad8012d31c8e727fa4c8c840f15a93ca47541cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104483 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-18clang-format customize/SvxConfigPageHelperMuhammet Kara
Change-Id: Ia802bfc4a6cd8d970fbb3c37a55959729ea19257 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104481 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-18clang-format CommandCategoryListBoxMuhammet Kara
Change-Id: If7ae64a0b9be01b3fa73310a4d9834ae3c151c10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104479 Reviewed-by: Yusuf Keten <ketenyusuf@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Jenkins
2020-10-15This field only holds a compile-time constantMike Kaganski
Change-Id: I9796f97af5d45211b67070fc020547e2b63ef411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104348 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-12Resolves tdf#137187 - More dictionaries via extensions dialogHeiko Tietze
UNO command and linkbutton interaction replaced with the internal dialog DICT_REPO_URL removed, README adjusted Change-Id: I401737b538da229ac0d432007e7564105672ff40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103769 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-12Resolves tdf#135270 - Make the tight extensions dialog shinyHeiko Tietze
Information rearranged, empty icons instead of hidden, background and scaling of thumbnail Change-Id: Iae095134a717cb50670bf5d1786774c6424d283e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104079 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-07Resolves tdf#117463 - Dialog to show UI optionsHeiko Tietze
* New dialog to pick and apply one of the UI variants * Tip-of-the-Day enhanced to execute UNO commands in order to advertise the UI chooser on first start Change-Id: I5e5c4a8e0fb11d11bafc99cc37b7ec244a993781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99957 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-06loplugin:const* make some params and methods constNoel
Change-Id: Idec482c21c270912f9bcaeb980077c1616f67c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-04Fix format comment handling in number format dialogEike Rathke
Clicking any format in the Format list could had applied the default 'User-defined' comment to that format. Also an edited comment for an already existing format when clicking on another format applied the new comment to that other format. Sometimes 'User-defined' was displayed instead of a real comment. Change-Id: I452d41f2860affed2475737e3bc925db687d96c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103907 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-09-27Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I95f8fcdbfb2344624a2ec4cf0780b0af3bc7ba16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103498 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-23fix disable qrcodegen optionCaolán McNamara
Change-Id: Ic554f01125653022987c70d03c8c9d86fe3f547a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103271 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-21tdf#134331 - Added possibility to sort macros via context menuAndreas Heinisch
The user now has the possibility to sort the entries in various macro dialogs either alphabetically or in document order using a context menu. Change-Id: I064947daa9f9bca05cb28e4b2f65ff1c92689ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98783 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-09-18Resolves tdf#97918 - Individual UNO commands for distribution optionsHeiko Tietze
New UNO commands added, SID_DISTRIBUTE_DLG bend to dropdown, ui removed Menus and toolbars adjusted Change-Id: Ic0a3cc299f745a1a0cd18edead1f410ff57a1f1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102272 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-09-16Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uStringStephan Bergmann
...from which an OUString can cheaply be instantiated. This is the OUString equivalent of 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String". Most remarks about that commit apply here too (this commit is just substantially bigger and a bit more complicated because there were so much more uses of OUStringLiteral than of OStringLiteral): The one downside is that OUStringLiteral now needs to be a template abstracting over the string length. But any uses for which that is a problem (e.g., as the element type of a container that would no longer be homogeneous, or in the signature of a function that shall not be turned into a template for one reason or another) can be replaced with std::u16string_view, without loss of efficiency compared to the original OUStringLiteral, and without loss of expressivity. The new OUStringLiteral ctor code would probably not be very efficient if it were ever executed at runtime, but it is intended to be only executed at compile time. Where available, C++20 "consteval" is used to statically ensure that. The intended use of the new OUStringLiteral is in all cases where an object that shall itself not be an OUString (e.g., because it shall be a global static variable for which the OUString ctor/dtor would be detrimental at library load/unload) must be converted to an OUString instance in at least one place. Other string literal abstractions could use std::u16string_view (or just plain char16_t const[N]), but interestingly OUStringLiteral might be more efficient than constexpr std::u16string_view even for such cases, as it should not need any relocations at library load time. For now, no existing uses of OUStringLiteral have been changed to some other abstraction (unless technically necessary as discussed above), and no additional places that would benefit from OUStringLiteral have been changed to use it. Global constexpr OUStringLiteral variables defined in an included file would be somewhat suboptimal, as each translation unit that uses them would create its own, unshared instance. The envisioned solution is to turn them into static data members of some class (and there may be a loplugin coming to find and fix affected places). Another approach that has been taken here in a few cases where such variables were only used in one .cxx anyway is to move their definitions from the .hxx into that one .cxx (in turn causing some files to become empty and get removed completely)---which also silenced some GCC -Werror=unused-variable if a variable from a .hxx was not used in some .cxx including it. To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc. In a similar vein, comparison operators between OUString and std::u16string_view have been added to the existing plethora of comparison operator overloads. It would be nice to eventually consolidate them, esp. with the overloads taking OUStringLiteral and/or char16_t const[N] string literals, but that appears tricky to get right without introducing new ambiguities. Also, a handful of places across the code base use comparisons between OUString and OUStringNumber, which are now ambiguous (converting the OUStringNumber to either OUString or std::u16string_view). For simplicity, those few places have manually been fixed for now by adding explicit conversion to std::u16string_view. Also some compilerplugins code needed to be adapted, and some of the compilerplugins/test cases have become irrelevant (and have been removed), as the tested code would no longer compile in the first place. sal/qa/rtl/strings/test_oustring_concat.cxx documents a workaround for GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96878> "Failed class template argument deduction in unevaluated, parenthesized context". That place, as well as uses of OUStringLiteral in extensions/source/abpilot/fieldmappingimpl.cxx and i18npool/source/localedata/localedata.cxx, which have been replaced with OUString::Concat (and which is arguably a better choice, anyway), also caused failures with at least Clang 5.0.2 (but would not have caused failures with at least recent Clang 12 trunk, so appear to be bugs in Clang that have meanwhile been fixed). Change-Id: I34174462a28f2000cfeb2d219ffd533a767920b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102222 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-14rhbz#1878275 should use value_changed for spinbutton changesCaolán McNamara
Change-Id: I8d042eb9c288e9db69a49cb9e097b23cf765aae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-13tdf#124176 Use #pragma once in cuiGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Ia0099ecd621f008e497260f26e5754d55d0f09aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102549 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-09improve loplugin:unusedvarsglobalNoel Grandin
to find any global variable, was checking the wrong property of VarDecl Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-03Make ImpSvNumberformatScan::GetColor constMike Kaganski
Change-Id: Idbcce18029944ab884cdde03e21190cbb574a00f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102005 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-09-02drop some unused methodsCaolán McNamara
Change-Id: I4da391591d30db9e51c1dd543bcf128f2e8621c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101914 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28Change OUStringLiteral from char[] to char16_t[]Stephan Bergmann
This is a prerequisite for making conversion from OUStringLiteral to OUString more efficient at least for C++20 (by replacing its internals with a constexpr- generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount, conditionally for C++20 for now). For a configure-wise bare-bones build on Linux, size reported by `du -bs instdir` grew by 118792 bytes from 1155636636 to 1155755428. In most places just a u"..." string literal prefix had to be added. In some places char const a[] = "..."; variables have been changed to char16_t, and a few places required even further changes to code (which prompted the addition of include/o3tl/string_view.hxx helper function o3tl::equalsIgnoreAsciiCase and the additional OUString::createFromAscii overload). For all uses of macros expanding to string literals, the relevant uses have been rewritten as u"" MACRO instead of changing the macro definitions. It should be possible to change at least some of those macro definitions (and drop the u"" from their call sites) in follow-up commits. Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-26tdf#135275: Additions: Sorting of extensionsYusuf Keten
Change-Id: If10820786ebc1f97aef24a7cb71a9f8a67e4bb8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101097 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-25tdf#127802 support tristate for hidden/unhidden textCaolán McNamara
Change-Id: I9a8ad72ae3ee45ac2521e662b17d3d22d98aa055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#133026: Additions: Rating image implementationYusuf Keten
Change-Id: Id250f0e70490941743e0f3ca2b94897f69a9208f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101013 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-24tdf#133026: Additions: Install Extension FunctionYusuf Keten
Change-Id: Ifcad25a85533833c7d05e5be46ea763e1eeaa5d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100714 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-17inline some use-once typedefsNoel Grandin
Change-Id: I683175c1e788a2a4cfec9504dc8dc3ebfee7c5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16tdf133275: Additions: Sorting menu ui implementationYusuf Keten
Change-Id: I41b0887d0bc6bf4618bd1cf9afd06f4b1ddbabb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100778 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-13tdf#133026: Additions: Install Button HandlerYusuf Keten
Change-Id: If4e9b192557b6c9f56bd04ccf9f6a5a8273d7515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100340 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-12cleanup some unused leftoversCaolán McNamara
Change-Id: I5971ec431471c528c33b2f3a3f2353a3a825f286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-07tdf#133026: Additions: Disable install buttons of the existing extensionsYusuf Keten
If the extension exists, the install button will be disabled. Change-Id: Ide88faeabe86d9cdb6a3cb99257710d92e3b4769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99809 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-01Reliably set up controls of hyperlink dialog in constructorStephan Bergmann
The recently added test_insert_hyperlink in sw/qa/uitest/writer_tests3/hyperlinkdialog.py (UITest_writer_tests3) has often failed on slow builds like <https://ci.libreoffice.org/job/lo_ubsan/>, by hitting the assert in rtl_uString_newFromSubString as described at <https://lists.freedesktop.org/archives/libreoffice/2020-July/085594.html> "Race with SwEditWinUIObject::get_state during UITest_writer_tests3?" However, it turns out that the actual race is rather different from what was assumed there: The initial content of the dialog's controls like "target" and "indication" were only set during the first SvxHlinkCtrl::StateChanged(SID_HYERLINK_GETLINK), which is called from the SfxBindings machinery based on a timer. When that happens, any text that has already been typed into those controls by the user would be overwritten again. But in normal GUI operations, the timer fires so quickly that the user has not yet typed anything into those controls. On the other hand, for a typical (fast) execution of test_insert_hyperlink, the whole test has already been executed when the timer fires, so the overwriting is not noticed. But for a slow execution of the test, the timer may e.g. fire after the "indication" control's content ("link") has been typed in (which SvxHlinkCtrl::StateChanged will reset to the empty string) and before the dialog is closed (so instead of "link", the empty string will be added to the Writer document, and obtaining the text selection of length 4 will crash as described in the email). (Also, the two calls to wait_until_property_is_updated added with 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid any timing issue in test_insert_hyperlink" and 1cdda798def040fe778348061c0e18b28aa0e6bd "Further timing issues with test_insert_hyperlink" probably just address other symptoms caused by the same underlying issue, and should no longer be necessary with this fix. But cleaning that up is left for a follow-up commit.) The solution is to set up the controls' initial content already in the constructor, so when the SfxBindings timer fires for the first time, it no longer calls StateChanged because that state has already been recorded. However, that caused the focus no longer to be set to the "target" control when the dialog is opened, at least for the gen and svp VCL backends (which caused the .uno:HyperlinkDialog-related tests in desktop/qa/desktop_lib/test_desktop_lib.cxx, CppunitTest_desktop_lib, to fail because GetFocusControl returned null): The first call to SvxHlinkCtrl::StateChanged -> SvxHplinkDlg::SetPage now happens during the constructor, before the dialog is shown, so the request to grab the focus in SetInitFocus was ignored. The solution to that problem is to shift setting the initial focus to the first call of SvxHpLInkDlg::Activate, which is called whenever the dialog gains focus. Change-Id: Ib4d5e06dfc21014ccec546565426fa2d27e63ce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99903 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-31Resolves tdf#132066 - Localization of special text in about windowHeiko Tietze
Copy all version infos in English Follow-up to 56b2214c3aa40c2e2522eba5584063fb34e003ba Change-Id: Id093305261ec957137c56f61048c660e80e5c795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99773 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-28tdf#133026: Additions: Better Search FunctionYusuf Keten
Old search function was demo to test something. This function uses the JSON response to search, not the API call to search. Change-Id: I0f4163a55331667a73f15dd220302f58a27831c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99388 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-07-28Add spin button for shadow blur radius in area dialogA_GAN
Update shadow tab in area dialog with spin button to control blur radius of the shadow. Change-Id: I41f072ef10d280df4b118afae7a7c058eb975417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99557 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-25cid#1465509 Uninitialized pointer fieldCaolán McNamara
Change-Id: I0c5db5c3252a2d544a2f22327db6f89b1a26af39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-04 22:57:19 +0000